[02:24:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Timeless: Timeless WTE2017 preview has inconsistent styling - https://phabricator.wikimedia.org/T185284 (10Isarra) Possibly related, there's even some inconsistent styling in VE itself - thumbs seem to have monobook styles for some reason. [02:29:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Timeless, 10User-Ryasmeen: Slight conflict between 2017 WTE and Timeless top-bars - https://phabricator.wikimedia.org/T181167 (10Isarra) 05Open→03Resolved a:03Isarra Fixed with the other recent alignment things, as far as I can tell. In... [02:31:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Timeless: Timeless WTE2017 preview has inconsistent styling - https://phabricator.wikimedia.org/T185284 (10Izno) Why would VE be designed to duplicate the skin CSS? Questions that keep me awake at night. [10:26:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532350 (owner: 10L10n-bot) [12:36:57] 10Editing-team, 10MediaWiki-Comment-backend, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, and 2 others: The "Prompt me when entering a blank edit summary" wrongly triggers for undo edits - https://phabricator.wikimedia.org/T10912 (10mobrovac) [12:42:00] 10Cite, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): CX2: Highlight (and skip) references with a template that could not be adapted - https://phabricator.wikimedia.org/T203160 (10Jpita) 05Open→03Resolved [13:31:46] 10VisualEditor, 10MediaWiki-Change-tagging, 10MediaWiki-Page-editing, 10Wikimedia-Israel-Hackers, 10Patch-For-Review: Support tags from editing form - https://phabricator.wikimedia.org/T109032 (10Sophivorus) [15:16:41] (03PS4) 10Jforrester: Allow popular templates to be listed in the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510943 (https://phabricator.wikimedia.org/T55590) (owner: 10Esanders) [15:18:22] (03CR) 10Jforrester: [C: 04-1] Allow popular templates to be listed in the template dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510943 (https://phabricator.wikimedia.org/T55590) (owner: 10Esanders) [16:00:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics: Edit Cards v3: instrumentation post-deployment data checks - https://phabricator.wikimedia.org/T230367 (10Neil_P._Quinn_WMF) a:05Neil_P._Quinn_WMF→03MNeisler We can't do this until the instrumentation itself is decided on (T229841), so... [16:09:23] 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10VisualEditor (Current work): Check on VE as default A/B test results - https://phabricator.wikimedia.org/T229426 (10Neil_P._Quinn_WMF) [16:17:07] 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10VisualEditor (Current work): Check on VE as default A/B test results - https://phabricator.wikimedia.org/T229426 (10Neil_P._Quinn_WMF) p:05Triage→03Normal [16:59:52] 10VisualEditor: No edit pencil on edit cards when tapping on that node for the second time - https://phabricator.wikimedia.org/T231125 (10Ryasmeen) >>! In T231125#5436148, @Esanders wrote: > This looks like an iOS browser bug, although I can't reproduce it on my devices. @Esanders: Yeah, I think you are right,... [17:00:11] 10VisualEditor, 10User-Ryasmeen: No edit pencil on edit cards when tapping on that node for the second time - https://phabricator.wikimedia.org/T231125 (10Ryasmeen) 05Open→03Resolved a:03Ryasmeen [17:19:16] 10Citoid, 10Growth-Team (Current Sprint): Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10JTannerWMF) [17:20:13] 10Citoid, 10VisualEditor (Current work): Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10JTannerWMF) [17:43:24] (03CR) 10Bartosz Dziewoński: [C: 03+2] GeneratedContentNode: Re-apply model selection if DOM node count changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531945 (https://phabricator.wikimedia.org/T231094) (owner: 10Esanders) [17:44:38] 10VisualEditor-ContentEditable, 10Patch-For-Review, 10VisualEditor (Current work): Changing the number of child nodes in a template rendering moves the cursor - https://phabricator.wikimedia.org/T231094 (10matmarex) [17:45:53] (03Merged) 10jenkins-bot: GeneratedContentNode: Re-apply model selection if DOM node count changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531945 (https://phabricator.wikimedia.org/T231094) (owner: 10Esanders) [17:47:51] (03CR) 10jenkins-bot: GeneratedContentNode: Re-apply model selection if DOM node count changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531945 (https://phabricator.wikimedia.org/T231094) (owner: 10Esanders) [17:51:06] (03CR) 10Bartosz Dziewoński: [C: 03+2] ve.ce.Surface: Don't request offsets that are out of bounds [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531933 (https://phabricator.wikimedia.org/T231085) (owner: 10Esanders) [17:52:59] (03Merged) 10jenkins-bot: ve.ce.Surface: Don't request offsets that are out of bounds [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531933 (https://phabricator.wikimedia.org/T231085) (owner: 10Esanders) [17:54:46] (03CR) 10jenkins-bot: ve.ce.Surface: Don't request offsets that are out of bounds [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531933 (https://phabricator.wikimedia.org/T231085) (owner: 10Esanders) [18:02:46] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: On slower mobile devices, pressing 'next' in the VE toolbar doesn't visually respond immediately so users double tap which causes a publish - https://phabricator.wikimedia.org/T230816 (10Esanders) It appears just double tapping next will cause this. One option m... [18:10:02] (03CR) 10Esanders: [C: 04-1] "Need to check in with what WMDE's plans are around this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510943 (https://phabricator.wikimedia.org/T55590) (owner: 10Esanders) [18:12:31] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 10Performance-Team, 10Performance: Loading Formula dialog code for the first time in each session (delayed loading) is slow - https://phabricator.wikimedia.org/T145254 (10Ryasmeen) [18:24:00] (03PS1) 10Bartosz Dziewoński: DesktopArticleTarget.init: Improve handling of 'preloadparams' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532424 [18:29:19] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (3a669b323) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532425 (https://phabricator.wikimedia.org/T231085) [18:29:52] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (3a669b323) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532425 (https://phabricator.wikimedia.org/T231085) (owner: 10Bartosz Dziewoński) [18:43:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 10Performance-Team (Radar): Loading Formula dialog code for the first time in each session (delayed loading) is slow - https://phabricator.wikimedia.org/T145254 (10Krinkle) [18:43:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 10Performance-Team (Radar): Loading Formula dialog code for the first time in each session (delayed loading) is slow - https://phabricator.wikimedia.org/T145254 (10Krinkle) [18:46:43] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget.init: Improve handling of 'preloadparams' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532424 (owner: 10Bartosz Dziewoński) [18:48:31] 10Editing-team, 10Performance-Team (Radar): Avoid MagicWord/LCStore cost from WikiEditor in startup module (resourceLoaderGetConfigVars hook) - https://phabricator.wikimedia.org/T222828 (10Krinkle) p:05Triage→03High Confirmed via a recent flame graph that the performance issue is resolved; 10Editing-team, 10WikiEditor, 10patch-welcome: Make possible (or document how to) for a gadget to apply WikiEditor to a custom textarea - https://phabricator.wikimedia.org/T231244 (10Krinkle) [18:55:22] 10Editing-team, 10Performance-Team (Radar): Avoid MagicWord/LCStore cost from WikiEditor in startup module (resourceLoaderGetConfigVars hook) - https://phabricator.wikimedia.org/T222828 (10Krinkle) 05Open→03Resolved @Jack_who_built_the_house It should be possible to bind WikiEditor to any text area and ret... [18:55:53] 10Editing-team, 10WikiEditor, 10patch-welcome: Make possible (or document how to) for a gadget to apply WikiEditor to a custom textarea - https://phabricator.wikimedia.org/T231244 (10Krinkle) [18:56:05] 10Editing-team, 10WikiEditor, 10patch-welcome: Make possible (or document how to) for a gadget to apply WikiEditor to a custom textarea - https://phabricator.wikimedia.org/T231244 (10Krinkle) [19:00:52] (03PS1) 10Jforrester: build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532431 [19:01:45] 10VisualEditor: Search and replace leaves bogus text highlight at the end - https://phabricator.wikimedia.org/T231245 (10Catrope) [19:22:14] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532431 (owner: 10Jforrester) [19:24:41] (03Merged) 10jenkins-bot: build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532431 (owner: 10Jforrester) [19:29:32] 10VisualEditor: Search and replace leaves bogus text highlight at the end - https://phabricator.wikimedia.org/T231245 (10matmarex) Related? {T226604} [19:35:20] (03CR) 10DLynch: [C: 04-1] DesktopArticleTarget.init: Improve handling of 'preloadparams' (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532424 (owner: 10Bartosz Dziewoński) [20:06:29] (03PS1) 10Jforrester: build: Upgrade grunt from 1.0.3 to 1.0.4 and eslint-utils dependency from 1.3.1 to 1.4.2 for security issues [unicodejs] - 10https://gerrit.wikimedia.org/r/532445 [20:35:36] (03CR) 10jenkins-bot: build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532431 (owner: 10Jforrester) [21:35:47] (03PS1) 10Jforrester: Update VE core submodule to master (aec8d85c5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532468 [22:46:56] (03PS1) 10Esanders: Link inspector: Change "label" messages to "text" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532478 (https://phabricator.wikimedia.org/T230794) [23:01:17] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Showing the v2 toolbar with anon edit warning could be confusing - https://phabricator.wikimedia.org/T230806 (10Esanders) We may not want to just hide the toolbar completely, as this would also hide the close 'x' button. [23:03:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Fix link label ellipses on iOS - https://phabricator.wikimedia.org/T230493 (10Esanders) 05duplicate→03Open This is different to T230267, which is about link descriptions, not label text. [23:03:47] 10VisualEditor-MediaWiki, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Regression, 10VisualEditor (Current work): Long link descriptions abruptly truncated in link context - https://phabricator.wikimedia.org/T230267 (10Esanders) [23:04:10] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Fix link label ellipses on iOS - https://phabricator.wikimedia.org/T230493 (10Esanders) [23:04:12] 10VisualEditor-Mobile-UsabilityImprovements, 10VisualEditor (Current work): Implement Edit Cards v3 - https://phabricator.wikimedia.org/T229831 (10Esanders) [23:05:45] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Fix link label ellipses on iOS - https://phabricator.wikimedia.org/T230493 (10Esanders) I think this might have been an iOS rendering bug, similar to T231125 [23:20:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (3a669b323) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532425 (https://phabricator.wikimedia.org/T231085) (owner: 10Bartosz Dziewoński) [23:28:36] 10VisualEditor-Edit Cards , 10VisualEditor (Current work): Edit Cards: Configure thumbnail images and descriptions for link cards on prototype server - https://phabricator.wikimedia.org/T228232 (10Esanders) > First you need to set up Wikibase repo and client Those are big complex extensions that I have found... [23:51:29] (03CR) 10jenkins-bot: Update VE core submodule to master (3a669b323) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532425 (https://phabricator.wikimedia.org/T231085) (owner: 10Bartosz Dziewoński)