[03:47:30] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Verified, 10VisualEditor (Current work): v3: Implement form-based approach to editing a link's label - https://phabricator.wikimedia.org/T229431 (10ppelberg) 05Open→03Resolved [03:50:59] 10VisualEditor-DataModel, 10Skipped QA, 10VisualEditor (Current work): On a page with recovered autosaved changes, using Ctrl+Z to undo clears the DM selection (and CE selection is desync'd) - https://phabricator.wikimedia.org/T204197 (10ppelberg) 05Open→03Resolved [03:51:26] 10VisualEditor-ContentEditable, 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Patch-For-Review, 10VisualEditor (Current work): Fix VisualEditor unit test failures on Firefox headless - https://phabricator.wikimedia.org/T228767 (10ppelberg) 05Open→03Resolved [03:53:08] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10Browser-Support-Apple-Safari, 10Skipped QA, 10VisualEditor (Current work): Excessive white space at the end of article/section on iOS - https://phabricator.wikimedia.org/T217769 (10ppelberg) 05Open→03Resolved [04:00:57] 10VisualEditor-MediaWiki-Mobile, 10Design, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10VisualEditor (Current work): Improve loading progress appearance when loading MF, or switching from MF to VE - https://phabricator.wikimedia.org/T228159 (10ppelberg) Nice work, Bartosz. By the way: these in-line video... [04:25:32] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Skipped QA, 10VisualEditor (Current work): Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10ppelberg) 05Open→03Resolved [04:25:34] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing Design: [Epic] Mobile VE usability improvements - https://phabricator.wikimedia.org/T221328 (10ppelberg) [04:25:36] 10VisualEditor, 10Epic: Prepare visual editor to be a default mobile editor - https://phabricator.wikimedia.org/T221185 (10ppelberg) [04:27:00] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Design, 10Skipped QA, and 2 others: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10ppelberg) 05Open→03Resolved [04:27:02] 10VisualEditor-Mobile-UsabilityImprovements, 10Browser-Support-Apple-Safari, 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): iOS Safari: After inserting a link, the selection often ends up hidden by the keyboard - https://phabricator.wikimedia.org/T221723 (10ppelberg) [04:27:04] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing QA, and 2 others: Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome - https://phabricator.wikimedia.org/T136840 (10ppelberg) [04:27:37] 10VisualEditor-MediaWiki-Mobile, 10Verified, 10VisualEditor (Current work): Remove link label edit pencil from edit cards v3 - https://phabricator.wikimedia.org/T230214 (10ppelberg) 05Open→03Resolved [04:27:39] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Test edit cards v3 at Wikimania - https://phabricator.wikimedia.org/T230213 (10ppelberg) [07:19:44] 10VisualEditor, 10Growth-Team, 10Notifications, 10Regression: "TypeError: Cannot read property 'getRoot' of undefined" for Structured discussion mention in VE - https://phabricator.wikimedia.org/T231398 (10kostajh) Probably due to 9ef8379 [07:20:18] 10VisualEditor, 10Growth-Team, 10Notifications, 10Regression: "TypeError: Cannot read property 'getRoot' of undefined" for Structured discussion mention in VE - https://phabricator.wikimedia.org/T231398 (10kostajh) (See also T231094) [07:22:31] 10VisualEditor, 10Growth-Team, 10Notifications, 10Regression: "TypeError: Cannot read property 'getRoot' of undefined" for Structured discussion mention in VE - https://phabricator.wikimedia.org/T231398 (10kostajh) @Etonkovidova I can't reproduce this. [09:02:12] (03PS21) 10Divec: Split TreeModifier into a tree diff generator and tree diff applier [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 (https://phabricator.wikimedia.org/T215567) [09:03:09] (03PS2) 10Divec: WIP: POC: use ve.dm.TreeModifier to do the tree diffing in ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532724 [09:05:09] (03CR) 10jerkins-bot: [V: 04-1] WIP: POC: use ve.dm.TreeModifier to do the tree diffing in ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532724 (owner: 10Divec) [09:07:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532943 (owner: 10L10n-bot) [09:34:04] 10VisualEditor, 10Growth-Team, 10Notifications, 10Regression: "TypeError: Cannot read property 'getRoot' of undefined" for Structured discussion mention in VE - https://phabricator.wikimedia.org/T231398 (10matmarex) We noticed this error in VE too and it was already fixed: T231381. [09:34:16] 10VisualEditor, 10Growth-Team, 10Notifications, 10Regression: "TypeError: Cannot read property 'getRoot' of undefined" for Structured discussion mention in VE - https://phabricator.wikimedia.org/T231398 (10matmarex) [09:34:18] 10VisualEditor-ContentEditable, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10User-Ryasmeen, 10VisualEditor (Current work): [Regression wmf.20] Uncaught TypeError: Cannot read property 'getRoot' of undefined appears when adding new citation/chemical and math formu... - https://phabricator.wikimedia.org/T231381 [11:25:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing Design, 10User-Ryasmeen: [Epic] Mobile VE usability improvements - https://phabricator.wikimedia.org/T221328 (10matmarex) 05Open→03Resolved a:03matmarex I think we should close this, the work has... [11:25:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing Design, 10User-Ryasmeen: [Epic] Mobile VE usability improvements (FY18-19 Q4) - https://phabricator.wikimedia.org/T221328 (10matmarex) [12:18:37] (03CR) 10Esanders: [C: 03+2] ve.ui.DesktopContext: Reserve space above anchored inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528877 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński) [12:21:37] (03CR) 10Esanders: "If you have a document with a selection then run ve.init.target.surface.model.setNullSelection(), the native selection is not changed in a" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528197 (owner: 10Esanders) [12:21:43] (03Merged) 10jenkins-bot: ve.ui.DesktopContext: Reserve space above anchored inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528877 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński) [12:24:03] (03PS2) 10Esanders: Update (remove) native selection when model selection is null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528197 [12:33:45] (03PS1) 10Esanders: Use upstream pulsating dot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532997 (https://phabricator.wikimedia.org/T226719) [12:40:38] (03PS2) 10Esanders: Use upstream pulsating dot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532997 (https://phabricator.wikimedia.org/T226719) [13:07:56] (03CR) 10Esanders: [C: 03+2] DesktopArticleTarget.init: Improve handling of 'preloadparams' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532424 (https://phabricator.wikimedia.org/T231382) (owner: 10Bartosz Dziewoński) [13:08:34] (03CR) 10jenkins-bot: ve.ui.DesktopContext: Reserve space above anchored inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528877 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński) [13:08:50] (03CR) 10Esanders: [C: 03+2] ve.init.mw.ArticleTarget: Use errorformat=html when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526831 (https://phabricator.wikimedia.org/T229532) (owner: 10Bartosz Dziewoński) [13:16:19] (03CR) 10Esanders: [C: 04-1] Don't let double-clicking the save button trigger a save (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [13:37:57] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: Improve handling of 'preloadparams' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532424 (https://phabricator.wikimedia.org/T231382) (owner: 10Bartosz Dziewoński) [13:44:00] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTarget: Use errorformat=html when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526831 (https://phabricator.wikimedia.org/T229532) (owner: 10Bartosz Dziewoński) [13:50:44] (03CR) 10jenkins-bot: ve.init.mw.ArticleTarget: Use errorformat=html when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526831 (https://phabricator.wikimedia.org/T229532) (owner: 10Bartosz Dziewoński) [14:02:43] (03CR) 10jenkins-bot: DesktopArticleTarget.init: Improve handling of 'preloadparams' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532424 (https://phabricator.wikimedia.org/T231382) (owner: 10Bartosz Dziewoński) [14:26:01] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design: [EPIC] Mobile VE toolbar improvements - https://phabricator.wikimedia.org/T211255 (10iamjessklein) As our user testing at Wikimania Stockholm confirmed, this is working well. Has @Ryasmeen had a chance to do a QA review on it? [14:28:01] 10VisualEditor, 10Product-Analytics: Some EditAttemptStep events on existing pages do not have revision IDs - https://phabricator.wikimedia.org/T230133 (10Neil_P._Quinn_WMF) [15:29:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10iamjessklein) +1 [15:37:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10Esanders) Potential issues: * Putting the legal message below the diff could push it... [15:41:41] (03PS1) 10Esanders: Docs: Standardise "messages used" comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533044 [15:42:45] (03PS1) 10Esanders: Docs: Standardise "messages used" comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533046 [15:43:42] (03CR) 10Jforrester: [C: 03+2] Docs: Standardise "messages used" comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533046 (owner: 10Esanders) [15:44:18] (03CR) 10Jforrester: [C: 03+2] Docs: Standardise "messages used" comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533044 (owner: 10Esanders) [15:46:01] (03Merged) 10jenkins-bot: Docs: Standardise "messages used" comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533046 (owner: 10Esanders) [15:46:11] (03PS1) 10Jforrester: Update OOjs to v3.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 [15:51:39] (03CR) 10DLynch: Don't let double-clicking the save button trigger a save (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [15:53:37] (03CR) 10jerkins-bot: [V: 04-1] Update OOjs to v3.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 (owner: 10Jforrester) [15:55:14] (03CR) 10jenkins-bot: Docs: Standardise "messages used" comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533046 (owner: 10Esanders) [15:57:24] (03CR) 10Bartosz Dziewoński: [C: 03+2] Use upstream pulsating dot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532997 (https://phabricator.wikimedia.org/T226719) (owner: 10Esanders) [16:00:56] (03PS2) 10Jforrester: Update OOjs to v3.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 [16:00:58] (03PS1) 10Jforrester: jsduck: Stop listing OOjs in upstream, it's using JSDoc now [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533054 [16:03:12] (03CR) 10jerkins-bot: [V: 04-1] Update OOjs to v3.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 (owner: 10Jforrester) [16:03:23] (03CR) 10jerkins-bot: [V: 04-1] jsduck: Stop listing OOjs in upstream, it's using JSDoc now [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533054 (owner: 10Jforrester) [16:04:15] (03CR) 10Jforrester: "Meh." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533054 (owner: 10Jforrester) [16:12:27] (03PS1) 10DLynch: WindowAction: Expose a promise when opening a window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) [16:14:13] (03PS2) 10DLynch: Don't let double-clicking the save button trigger a save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) [16:54:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10Esanders) Example diffs for consideration when designing: Short visual diff, vertic... [16:57:11] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design: [EPIC] Mobile VE toolbar improvements - https://phabricator.wikimedia.org/T211255 (10iamjessklein) In usertesting we learned: 1. folks were confused about what “label” means - can/should this be changed to something else? 2. Text selection... [16:58:14] (03Merged) 10jenkins-bot: Docs: Standardise "messages used" comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533044 (owner: 10Esanders) [17:32:11] (03Merged) 10jenkins-bot: Use upstream pulsating dot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532997 (https://phabricator.wikimedia.org/T226719) (owner: 10Esanders) [18:54:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design: [EPIC] Mobile VE toolbar improvements - https://phabricator.wikimedia.org/T211255 (10matmarex) >>! In T211255#5446518, @iamjessklein wrote: > 1. folks were confused about what “label” means - can/should this be changed to something else? Co... [19:22:31] 10VisualEditor, 10Product-Analytics: Create a data dictionary for the VisualEditorFeatureUse data stream - https://phabricator.wikimedia.org/T229881 (10Neil_P._Quinn_WMF) [19:34:16] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), 10VisualEditor (Current work): Hide "options" bar under edit summary input when hidden - https://phabricator.wikimedia.org/T228165 (10iamjessklein) I'd mark this as done. [20:59:22] 10Citoid, 10User-Josve05a: Do not include "PMC" part of the PMC identifier - https://phabricator.wikimedia.org/T155887 (10Josve05a) [22:59:55] 10WikiEditor: Specific problems with account "User:Tulsi Bhagat" - https://phabricator.wikimedia.org/T231061 (10Krinkle) OK. So the invalid cookie statement is likely `mbNamespaces`. Looking [on ne.wikipedia.org](https://ne.wikipedia.org/w/index.php?sort=relevance&search=insource%3A%2FmbNamespaces%2F&title=Spec...