[00:44:26] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Instrument Edit Cards v3 - https://phabricator.wikimedia.org/T229841 (10ppelberg) Copying over @dlynch's responses from chat >>! In T229841#5443058, @ppelberg wrote: > Our remaining open questions are: > - [ ] 1) What tracking is live in Edit Ca... [00:50:58] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Instrument Edit Cards v3 - https://phabricator.wikimedia.org/T229841 (10ppelberg) Updating task description to include the "Additional instrumentation" [1] we would like to implement as a result of the changes we made in Edit Cards v3. See this ta... [00:51:21] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Instrument Edit Cards v3 - https://phabricator.wikimedia.org/T229841 (10ppelberg) [00:54:37] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Instrument Edit Cards v3 - https://phabricator.wikimedia.org/T229841 (10ppelberg) a:05Esanders→03None [08:57:37] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Wikimedia-Site-requests: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895 (10Elitre) a:05Whatamidoing-WMF→03None [08:58:08] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Wikimedia-Site-requests: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895 (10Elitre) AFAIK no progress has happened on this in a while, and we should avoid cookie-licking. [09:11:10] 10VisualEditor, 10Wikimedia-Site-requests: Deploy CollabPad to officewiki - https://phabricator.wikimedia.org/T196211 (10Elitre) @Esanders , see above? [10:17:23] 10Editing-team, 10Contributors-Team, 10Core Platform Team, 10MediaWiki-API, and 3 others: MovePage::move contention on cebwiki - https://phabricator.wikimedia.org/T221595 (10daniel) [12:05:05] (03PS1) 10Esanders: WIP Move diff to edit summary page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533199 (https://phabricator.wikimedia.org/T140451) [12:05:16] (03CR) 10jerkins-bot: [V: 04-1] WIP Move diff to edit summary page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533199 (https://phabricator.wikimedia.org/T140451) (owner: 10Esanders) [12:24:27] (03PS2) 10Esanders: WIP Move diff to edit summary page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533199 (https://phabricator.wikimedia.org/T140451) [12:51:25] (03CR) 10jerkins-bot: [V: 04-1] WIP Move diff to edit summary page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533199 (https://phabricator.wikimedia.org/T140451) (owner: 10Esanders) [13:00:10] 10VisualEditor: Failed to edit in VE - https://phabricator.wikimedia.org/T231550 (10MichaelSchoenitzer) [13:18:48] (03CR) 10Esanders: [C: 04-1] Don't let double-clicking the save button trigger a save (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [13:30:21] (03CR) 10Esanders: [C: 04-1] WindowAction: Expose a promise when opening a window (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [13:31:40] (03CR) 10Esanders: [C: 04-1] WindowAction: Expose a promise when opening a window (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [13:44:54] 10VisualEditor-MediaWiki, 10Editing Design, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10JTannerWMF) Looks like this... [13:45:49] 10VisualEditor-MediaWiki, 10Editing Design, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10JTannerWMF) @Esanders it lo... [13:50:09] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), 10VisualEditor (Current work): Hide "options" bar under edit summary input when hidden - https://phabricator.wikimedia.org/T228165 (10JTannerWMF) Hey @ppelberg we need you to close this out [13:51:53] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Conduct Edit Cards v3 usertesting.com test - https://phabricator.wikimedia.org/T229832 (10JTannerWMF) Hey @ppelberg this is ready to be closed. @DLynch and @esanders it looks like you're still commenting on this thread, should the conversation be... [14:07:10] (03CR) 10Esanders: "Is there any way to test this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529739 (https://phabricator.wikimedia.org/T230325) (owner: 10Divec) [14:07:46] 10VisualEditor-Edit Cards , 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Verified, 10VisualEditor (Current work): Edit Cards: Fix transition from link search dialog back to document/Edit Card after changing the target of an existing link. - https://phabricator.wikimedia.org/T228229 (10JTannerWMF) This ap... [14:10:14] 10VisualEditor, 10Editing Design: Find an easier way to put testing content on server(s) for testing purposes - https://phabricator.wikimedia.org/T227658 (10JTannerWMF) Hey @dchan what would be the level of effort to implement something like this? [14:12:16] 10VisualEditor-Edit Cards , 10OOUI, 10Design, 10VisualEditor (Current work): Evaluate mobile dialog transitions - https://phabricator.wikimedia.org/T224277 (10JTannerWMF) [14:20:05] 10VisualEditor-MediaWiki, 10Editing Design, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10JTannerWMF) a:03Esanders [15:27:57] (03PS11) 10Esanders: MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [15:34:48] (03CR) 10DLynch: Don't let double-clicking the save button trigger a save (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [15:41:19] (03CR) 10DLynch: WindowAction: Expose a promise when opening a window (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [15:44:55] (03PS2) 10DLynch: WindowAction: Expose a promise when opening a window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) [15:45:14] (03PS3) 10DLynch: Don't let double-clicking the save button trigger a save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) [16:43:44] (03PS2) 10Krinkle: jsduck: Stop listing OOjs in upstream, it's using JSDoc now [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533054 (owner: 10Jforrester) [16:44:08] (03PS3) 10Krinkle: Update OOjs to v3.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 (owner: 10Jforrester) [16:47:22] (03CR) 10jerkins-bot: [V: 04-1] Update OOjs to v3.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 (owner: 10Jforrester) [16:47:24] (03CR) 10jerkins-bot: [V: 04-1] jsduck: Stop listing OOjs in upstream, it's using JSDoc now [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533054 (owner: 10Jforrester) [16:48:23] (03PS3) 10Krinkle: jsduck: Stop listing OOjs in upstream, it's using JSDoc now [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533054 (owner: 10Jforrester) [16:48:43] (03PS4) 10Krinkle: jsduck: Stop listing OOjs in upstream, it's using JSDoc now [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533054 (owner: 10Jforrester) [16:50:12] (03PS4) 10Krinkle: Update OOjs to v3.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 (owner: 10Jforrester) [16:51:25] (03CR) 10jerkins-bot: [V: 04-1] jsduck: Stop listing OOjs in upstream, it's using JSDoc now [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533054 (owner: 10Jforrester) [16:51:58] (03CR) 10Krinkle: "Mostly passes now. The left-over issues are genuine, in so far that they are stuff that explicitly is trying to copy text from JSDuck inde" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 (owner: 10Jforrester) [16:52:12] (03CR) 10jerkins-bot: [V: 04-1] Update OOjs to v3.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 (owner: 10Jforrester) [16:52:36] (03CR) 10Krinkle: "Also, will need to apply in oojs-ui first before VE, as oojs-ui has a couple of @inheritdocs as well." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533048 (owner: 10Jforrester) [19:12:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533290 (owner: 10L10n-bot) [20:49:26] (03CR) 10Jforrester: "OOUI version: 798f4715761045eb5e283d56f6c7ec35c294a8ca" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533054 (owner: 10Jforrester) [21:58:33] (03CR) 10Bartosz Dziewoński: [C: 03+2] WindowAction: Expose a promise when opening a window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [22:01:05] (03Merged) 10jenkins-bot: WindowAction: Expose a promise when opening a window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [22:02:17] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (f3f6fae90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533346 (https://phabricator.wikimedia.org/T229900) [22:02:45] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (f3f6fae90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533346 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński) [22:02:50] (03PS4) 10Bartosz Dziewoński: Don't let double-clicking the save button trigger a save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [22:02:59] (03CR) 10Bartosz Dziewoński: [C: 03+2] Don't let double-clicking the save button trigger a save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [22:18:41] (03CR) 10jenkins-bot: WindowAction: Expose a promise when opening a window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [22:25:48] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (f3f6fae90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533346 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński) [22:25:50] (03CR) 10jerkins-bot: [V: 04-1] Don't let double-clicking the save button trigger a save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [22:27:20] (03PS1) 10DLynch: Update VE core submodule to master (f3f6fae90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533351 (https://phabricator.wikimedia.org/T229900) [22:27:30] Oops, doubled up. [22:28:12] (03Abandoned) 10DLynch: Update VE core submodule to master (f3f6fae90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533351 (https://phabricator.wikimedia.org/T229900) (owner: 10DLynch) [22:29:38] (03CR) 10jerkins-bot: [V: 04-1] Don't let double-clicking the save button trigger a save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [22:29:40] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (f3f6fae90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533346 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński) [22:30:51] (03CR) 10Bartosz Dziewoński: [C: 03+1] "This looks good to me. There were some questions about instrumentation from Peter, but I don't know what that was about and whether it was" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [22:33:55] (03CR) 10DLynch: "> Patch Set 11: Code-Review+1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [22:34:35] ugh, i think that's a real failure [22:36:15] (03PS1) 10Bartosz Dziewoński: ve.ui.DesktopContext: Check for null viewport first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533353 [22:36:22] Kemayo: if you're around, can you have a look? ^ [22:36:58] (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/533353" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528877 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński) [22:37:56] (03CR) 10DLynch: [C: 03+2] ve.ui.DesktopContext: Check for null viewport first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533353 (owner: 10Bartosz Dziewoński) [22:38:02] MatmaRex: There you go. [22:38:19] thanks [22:40:36] (03Merged) 10jenkins-bot: ve.ui.DesktopContext: Check for null viewport first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533353 (owner: 10Bartosz Dziewoński) [22:42:26] (03CR) 10Jforrester: [C: 03+1] Update (remove) native selection when model selection is null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528197 (owner: 10Esanders) [22:43:36] (03PS2) 10Bartosz Dziewoński: Update VE core submodule to master (4f3a331f6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533346 (https://phabricator.wikimedia.org/T229900) [22:43:55] (03PS5) 10Bartosz Dziewoński: Don't let double-clicking the save button trigger a save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [22:44:04] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (4f3a331f6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533346 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński) [23:17:07] (03Merged) 10jenkins-bot: Update VE core submodule to master (4f3a331f6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533346 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński) [23:18:21] (03CR) 10jenkins-bot: ve.ui.DesktopContext: Check for null viewport first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533353 (owner: 10Bartosz Dziewoński) [23:21:42] (03Merged) 10jenkins-bot: Don't let double-clicking the save button trigger a save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [23:41:16] (03CR) 10jenkins-bot: Don't let double-clicking the save button trigger a save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/532737 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [23:41:50] (03CR) 10jenkins-bot: Update VE core submodule to master (4f3a331f6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533346 (https://phabricator.wikimedia.org/T229900) (owner: 10Bartosz Dziewoński)