[01:07:08] (03PS1) 10DLynch: MWLinkAnnotationInspector: check icon for done on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533366 (https://phabricator.wikimedia.org/T228230) [01:38:41] (03CR) 10Jforrester: [C: 03+1] "Still subject to product/design discussion so let's not merge just yet?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533366 (https://phabricator.wikimedia.org/T228230) (owner: 10DLynch) [04:05:26] (03CR) 10DLynch: "> Patch Set 1: Code-Review+1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533366 (https://phabricator.wikimedia.org/T228230) (owner: 10DLynch) [08:39:07] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533468 (owner: 10L10n-bot) [11:52:36] (03CR) 10Esanders: WindowAction: Expose a promise when opening a window (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [11:55:11] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10VisualEditor (Current work): Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown - https://phabricator.wikimedia.org/T230816 (10Esanders) [12:03:01] (03PS7) 10Esanders: Support for defined template context items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478246 (https://phabricator.wikimedia.org/T211243) [12:10:40] 10VisualEditor-MediaWiki, 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Add a useful call-to-action in the context for citation needed templates - https://phabricator.wikimedia.org/T211243 (10Esanders) 1) It appears I already had the same though and switched the colours in the patch,... [14:12:54] 10VisualEditor, 10Editing Design: Edit card user interface tweaks - https://phabricator.wikimedia.org/T231649 (10iamjessklein) [14:13:36] 10VisualEditor, 10Editing Design: Edit Cards: deploy v4 to all wikis - https://phabricator.wikimedia.org/T231342 (10iamjessklein) [14:14:09] 10VisualEditor, 10Editing Design: Edit Cards: deploy v4 to all wikis - https://phabricator.wikimedia.org/T231342 (10iamjessklein) I updated the description with the edit card ui design sub-task ticket T231649 [14:17:06] 10VisualEditor, 10Editing Design: Edit Cards: deploy v4 to all wikis - https://phabricator.wikimedia.org/T231342 (10iamjessklein) [14:17:24] 10VisualEditor, 10Editing Design: Edit Cards: deploy v4 to all wikis - https://phabricator.wikimedia.org/T231342 (10iamjessklein) [14:38:39] 10VisualEditor, 10VisualEditor-Edit Cards , 10Editing Design, 10Patch-For-Review: Add "✔️" into link modal - https://phabricator.wikimedia.org/T228230 (10iamjessklein) I agree and think this should be at a minimum in all the mobile dialogs (I'm less sure about desktop but can loop back and check). To make... [15:22:34] (03CR) 10DLynch: WindowAction: Expose a promise when opening a window (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533059 (https://phabricator.wikimedia.org/T230816) (owner: 10DLynch) [15:24:56] (03PS1) 10DLynch: WindowAction: fix documentation reference to Promise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533541 [15:33:07] (03CR) 10Esanders: [C: 03+2] MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [15:33:48] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): v1 toolbar shows disabled edit tools on first load, then never again - https://phabricator.wikimedia.org/T230807 (10Esanders) [15:34:05] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Showing the v1 toolbar with anon edit warning could be confusing - https://phabricator.wikimedia.org/T230806 (10Esanders) [15:38:21] 10VisualEditor, 10VisualEditor-Edit Cards , 10Editing Design, 10Patch-For-Review: Add "✔️" into link modal - https://phabricator.wikimedia.org/T228230 (10Esanders) +1, we should treat the link inspector differently. Should be at least all mobile inspectors and dialogs (except publish/save dialog). [15:41:07] 10VisualEditor, 10I18n, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): In the Georgian Wikipedia, adding links in VisualEditor is broken because of incorrect capitalization - https://phabricator.wikimedia.org/T230559 (10ovasileva) p:05Triage→03High [15:48:31] (03CR) 10Esanders: [C: 03+2] WindowAction: fix documentation reference to Promise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533541 (owner: 10DLynch) [15:51:08] (03Merged) 10jenkins-bot: WindowAction: fix documentation reference to Promise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533541 (owner: 10DLynch) [15:52:56] 10VisualEditor, 10Editing Design, 10MinervaNeue, 10MobileFrontend, and 3 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10ovasileva) 05Open→03Resolved Discussed with @alexhollender and we're... [15:53:15] 10VisualEditor, 10Editing Design, 10MinervaNeue, 10MobileFrontend, and 3 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10ovasileva) [15:57:33] (03CR) 10jenkins-bot: WindowAction: fix documentation reference to Promise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533541 (owner: 10DLynch) [16:11:13] 10VisualEditor, 10Editing Design: Edit card user interface tweaks - https://phabricator.wikimedia.org/T231649 (10iamjessklein) [[ https://wikimedia.invisionapp.com/freehand/document/s1duRw6io | Here's ]]my first round of tweaks, would love to hear some feedback @cmadeo Please provide high level comments her... [16:20:17] (03CR) 10Jforrester: [C: 03+2] "TranslateWiki change is I7e4865dea0aeab0748e1ebbf4c515e922a780182" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478246 (https://phabricator.wikimedia.org/T211243) (owner: 10Esanders) [16:20:59] 10VisualEditor, 10VisualEditor-MediaWiki: Add handler for [[Template:Citation needed span]] - https://phabricator.wikimedia.org/T211447 (10Jdforrester-WMF) [16:21:04] 10VisualEditor-MediaWiki, 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Add a useful call-to-action in the context for citation needed templates - https://phabricator.wikimedia.org/T211243 (10Jdforrester-WMF) [16:21:12] 10VisualEditor, 10VisualEditor-MediaWiki: Add handler for [[Template:Citation needed span]] - https://phabricator.wikimedia.org/T211447 (10Jdforrester-WMF) [16:21:15] 10VisualEditor-MediaWiki, 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Add a useful call-to-action in the context for citation needed templates - https://phabricator.wikimedia.org/T211243 (10Jdforrester-WMF) [16:51:35] 10VisualEditor, 10VisualEditor-Edit Cards , 10Editing Design, 10Patch-For-Review: Add "✔️" into link modal - https://phabricator.wikimedia.org/T228230 (10ppelberg) @iamjessklein + @Esanders: great. So to summarize the conclusion... >>! In T228230#5453194, @ppelberg wrote: >two questions for you courtesy... [16:53:36] 10VisualEditor, 10Editing Design: Edit Cards: deploy v4 to all wikis - https://phabricator.wikimedia.org/T231342 (10ppelberg) [16:54:45] 10VisualEditor, 10Editing Design: Edit Cards: deploy v4 to all wikis - https://phabricator.wikimedia.org/T231342 (10ppelberg) Update to task description: - Adding an another change that should be implemented in our next release: {T229841} [16:59:58] 10VisualEditor, 10User-Ryasmeen, 10good first bug: Add icon(s) for audiovisual media (music / movie) to the cite tool css classes - https://phabricator.wikimedia.org/T220009 (10Esanders) 05Open→03Resolved a:03Esanders I set it to use the play icon from OOUI: https://gl.wikipedia.org/w/index.php?title=M... [17:08:23] 10VisualEditor, 10VisualEditor-Edit Cards , 10Editing Design, 10Patch-For-Review: Add "✔️" into link modal - https://phabricator.wikimedia.org/T228230 (10Esanders) In technical terms this would be anything that uses `ve.ui.FragmentWindow` [17:44:00] (03Merged) 10jenkins-bot: MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [17:44:26] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Deploy toolbar v1 to all wikis - https://phabricator.wikimedia.org/T231622 (10Esanders) Patch is merged, see T211789 [17:57:43] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Verified, 10VisualEditor (Current work): Link dialog: change "Label" field title to "Text" - https://phabricator.wikimedia.org/T230794 (10Ryasmeen) [18:04:04] (03CR) 10jenkins-bot: MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [18:31:37] 10WikiEditor: "|" used in Wikidata query not parsed correctly in WikiEditor SPARQL2 template - https://phabricator.wikimedia.org/T231676 (10wassan.anmol117) [18:34:58] (03CR) 10D3r1ck01: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533468 (owner: 10L10n-bot) [18:50:14] (03CR) 10Krinkle: "Trying this out seems fine by me." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521575 (https://phabricator.wikimedia.org/T213214) (owner: 10Bartosz Dziewoński) [18:50:29] (03Merged) 10jenkins-bot: Support for defined template context items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478246 (https://phabricator.wikimedia.org/T211243) (owner: 10Esanders) [18:59:27] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimania-Hackathon-2019, and 2 others: Provide a Lua method mw.templatedata.load() - https://phabricator.wikimedia.org/T107119 (10jeblad) The repo for my work on this is at [[ https://github.com/jeblad/TemplateData | Github: jeblad/TemplateData ]... [19:10:50] (03CR) 10jenkins-bot: Support for defined template context items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478246 (https://phabricator.wikimedia.org/T211243) (owner: 10Esanders) [19:34:24] (03CR) 10D3r1ck01: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533468 (owner: 10L10n-bot) [20:33:58] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update (remove) native selection when model selection is null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528197 (owner: 10Esanders) [20:35:47] (03CR) 10Bartosz Dziewoński: "I'm glad we're all in agreement but one of you needs to click the button. :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521575 (https://phabricator.wikimedia.org/T213214) (owner: 10Bartosz Dziewoński) [20:36:28] (03Merged) 10jenkins-bot: Update (remove) native selection when model selection is null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528197 (owner: 10Esanders) [20:43:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533468 (owner: 10L10n-bot) [20:44:44] (03CR) 10jenkins-bot: Update (remove) native selection when model selection is null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528197 (owner: 10Esanders) [21:07:19] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533604 [21:38:02] (03CR) 10jerkins-bot: [V: 04-1] ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533604 (owner: 10Bartosz Dziewoński) [21:40:45] (03PS2) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533604 [21:45:55] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Verified, 10VisualEditor (Current work): Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown - https://phabricator.wikimedia.org/T230816 (10Ryasm... [21:50:32] (03CR) 10Jforrester: [C: 03+2] "It's Gordian Knot time." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521575 (https://phabricator.wikimedia.org/T213214) (owner: 10Bartosz Dziewoński) [22:25:18] (03Merged) 10jenkins-bot: Break up our massive load.php request to work around network issues [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521575 (https://phabricator.wikimedia.org/T213214) (owner: 10Bartosz Dziewoński) [22:29:44] (03CR) 10jenkins-bot: Break up our massive load.php request to work around network issues [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521575 (https://phabricator.wikimedia.org/T213214) (owner: 10Bartosz Dziewoński) [22:31:46] 10VisualEditor, 10MobileFrontend, 10Design (RW-Design-Debt), 10Readers-Web-Backlog (Tracking): AbuseFilter warnings and errors are handled badly by the editor - https://phabricator.wikimedia.org/T202460 (10Jdlrobson) This is very broken. Came across this again while documenting the mobile site's UI compone... [22:34:37] (03PS1) 10DLynch: ui.FragmentWindow: override action widget config on mobile for done actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533612 (https://phabricator.wikimedia.org/T228230) [22:35:15] (03Abandoned) 10DLynch: MWLinkAnnotationInspector: check icon for done on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533366 (https://phabricator.wikimedia.org/T228230) (owner: 10DLynch) [22:40:57] (03CR) 10DLynch: ui.FragmentWindow: override action widget config on mobile for done actions (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/533612 (https://phabricator.wikimedia.org/T228230) (owner: 10DLynch) [23:03:55] (03CR) 10Jforrester: [C: 03+2] ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533604 (owner: 10Bartosz Dziewoński) [23:27:15] (03Merged) 10jenkins-bot: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533604 (owner: 10Bartosz Dziewoński) [23:28:56] (03CR) 10jenkins-bot: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533604 (owner: 10Bartosz Dziewoński) [23:29:11] (03CR) 10Jdlrobson: "Please follow https://gerrit.wikimedia.org/r/531558 and https://gerrit.wikimedia.org/r/533360 - unifying OOUI and mobile's icons has been " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533604 (owner: 10Bartosz Dziewoński) [23:59:58] (03CR) 10Jforrester: "> Patch Set 2:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/533604 (owner: 10Bartosz Dziewoński)