[03:20:55] (03CR) 10DLynch: [C: 03+2] ApiVisualEditorEdit: Remove special handling for SpamBlacklist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526817 (https://phabricator.wikimedia.org/T211443) (owner: 10Bartosz Dziewoński) [03:42:36] (03Merged) 10jenkins-bot: ApiVisualEditorEdit: Remove special handling for SpamBlacklist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526817 (https://phabricator.wikimedia.org/T211443) (owner: 10Bartosz Dziewoński) [03:44:18] (03CR) 10jenkins-bot: ApiVisualEditorEdit: Remove special handling for SpamBlacklist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526817 (https://phabricator.wikimedia.org/T211443) (owner: 10Bartosz Dziewoński) [08:48:19] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#cannot_save_edits_404_error [08:48:25] TypeError: Illegal invocation [11:36:48] 10WikiEditor, 10MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), 10Regression: WikiEditor insert file dialog broken (due to gadgets that override the open function of file dialog) - https://phabricator.wikimedia.org/T230078 (10Aklapper) [13:13:12] 10WikiEditor, 10Graphs, 10Growth-Team, 10MassMessage, and 18 others: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Woolvia) >>! In T213426#4869452, @Esanders wrote: > ` > $ mwgrep $.throttle > enwiki MediaWiki:Gadget-ptoc... [13:13:57] 10WikiEditor, 10Graphs, 10Growth-Team, 10MassMessage, and 18 others: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Woolvia) >>! In T213426#4869452, @Esanders wrote: > ` > $ mwgrep $.throttle > enwiki MediaWiki:Gadget-ptoc... [13:58:27] (03CR) 10Esanders: [C: 03+2] Add new EditAttemptStep stage: firstChange [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/535320 (https://phabricator.wikimedia.org/T229079) (owner: 10DLynch) [13:59:02] (03CR) 10Esanders: [C: 03+2] Implement firstChange logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/535612 (https://phabricator.wikimedia.org/T229079) (owner: 10DLynch) [14:08:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/536189 (owner: 10L10n-bot) [15:10:40] 10Editing-team, 10Analytics, 10Cleanup: Deletion of limn-edit-data repository - https://phabricator.wikimedia.org/T228982 (10TheSandDoctor) This appears to be a duplicate of T228981 but pinging different users...? [15:17:47] 10Editing-team, 10Analytics, 10Cleanup: Deletion of limn-edit-data repository - https://phabricator.wikimedia.org/T228982 (10fdans) @TheSandDoctor nope. This task is regarding the deletion of https://github.com/wikimedia/analytics-limn-edit-data The task you mention is for the deletion of https://github.com... [15:19:47] (03Merged) 10jenkins-bot: Add new EditAttemptStep stage: firstChange [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/535320 (https://phabricator.wikimedia.org/T229079) (owner: 10DLynch) [15:20:16] (03CR) 10jerkins-bot: [V: 04-1] Implement firstChange logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/535612 (https://phabricator.wikimedia.org/T229079) (owner: 10DLynch) [15:22:59] (03CR) 10jenkins-bot: Add new EditAttemptStep stage: firstChange [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/535320 (https://phabricator.wikimedia.org/T229079) (owner: 10DLynch) [15:26:48] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Mangling of non existing media links by VisualEditor - https://phabricator.wikimedia.org/T232754 (10ti_infotrad) [15:36:05] (03CR) 10Esanders: [C: 03+2] ve.init.mw.MobileArticleTarget: Really deactivate the surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/535254 (owner: 10Bartosz Dziewoński) [15:37:43] (03CR) 10Esanders: [C: 03+2] ve.ce.Surface: Actually default to showAsActivated=true in #deactivate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/535252 (owner: 10Bartosz Dziewoński) [15:40:06] (03Merged) 10jenkins-bot: ve.ce.Surface: Actually default to showAsActivated=true in #deactivate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/535252 (owner: 10Bartosz Dziewoński) [15:44:05] (03PS1) 10DLynch: ArticleTargetEvents: clean up some duplication [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/536223 [15:45:06] (03PS2) 10DLynch: ArticleTargetEvents: clean up some duplication [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/536223 [15:54:29] (03CR) 10jenkins-bot: ve.ce.Surface: Actually default to showAsActivated=true in #deactivate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/535252 (owner: 10Bartosz Dziewoński) [16:43:07] (03Merged) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Really deactivate the surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/535254 (owner: 10Bartosz Dziewoński) [17:00:49] 10VisualEditor-MediaWiki, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10Technical-Debt, 10VisualEditor (Current work): Remove SpamBlacklist error handling from ApiVisualEditorEdit.php - https://phabricator.wikimedia.org/T211443 (10matmarex) (QA is cove... [17:01:02] 10VisualEditor-MediaWiki, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10Skipped QA, and 2 others: Remove SpamBlacklist error handling from ApiVisualEditorEdit.php - https://phabricator.wikimedia.org/T211443 (10matmarex) [17:12:09] (03CR) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Really deactivate the surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/535254 (owner: 10Bartosz Dziewoński) [17:18:07] (03CR) 10Bartosz Dziewoński: [C: 03+2] "This is the failure:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/535612 (https://phabricator.wikimedia.org/T229079) (owner: 10DLynch) [18:08:28] (03Merged) 10jenkins-bot: Implement firstChange logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/535612 (https://phabricator.wikimedia.org/T229079) (owner: 10DLynch) [18:54:00] 10Citoid: Use open access URL via oaDOI in citoid response - https://phabricator.wikimedia.org/T174540 (10Nemo_bis) >>! In T174540#4695196, @Mvolz wrote: > New changes to citoid are frozen until we complete T197242 - sorry about that! Looks like that's fixed now! [19:01:15] 10Citoid: In cite journal, do not add URL expanded from existing identifier like DOI - https://phabricator.wikimedia.org/T232771 (10Nemo_bis) [19:01:26] 10Citoid: In cite journal, do not add URL expanded from existing identifier like DOI - https://phabricator.wikimedia.org/T232771 (10Nemo_bis) p:05Triage→03Normal [19:06:35] 10Citoid, 10Patch-For-Review: In cite journal, do not add URL expanded from existing identifier like DOI - https://phabricator.wikimedia.org/T232771 (10Nemo_bis) I've added a patch I wrote some time ago (not tested). At the time I was not sure what method to use as I couldn't see an easy way to track the prove... [19:38:06] 10VisualEditor, 10MediaWiki-General, 10MediaWiki-Page-editing, 10MediaWiki-Templates: After typing {{, no dialog for calling a template comes, and writing does not work anymore - https://phabricator.wikimedia.org/T142937 (10neilpquinn) I can't reproduce in Safari 12.1.12 on macOS 10.14.6; however, the desc... [19:46:24] 10VisualEditor: Clicking between a bullet circle and the associated text doesn't move the cursor - https://phabricator.wikimedia.org/T145893 (10neilpquinn) 05Stalled→03Open p:05Triage→03Low I //can// reproduce this on Firefox 70.0b5 on macOS 10.14.6 (but not on Chrome 77.0.3865.75). I imagine the priorit... [20:01:54] (03CR) 10Esanders: [C: 03+2] "Merging now for testing time, but 'XXX' comments should all be cleaned up." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 (https://phabricator.wikimedia.org/T215567) (owner: 10Divec) [20:04:05] (03Merged) 10jenkins-bot: Split TreeModifier into a tree diff generator and tree diff applier [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 (https://phabricator.wikimedia.org/T215567) (owner: 10Divec) [20:05:04] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): Split TreeModifier into a tree diff generator and tree diff applier - https://phabricator.wikimedia.org/T215567 (10marcella) [20:09:00] (03CR) 10jenkins-bot: Split TreeModifier into a tree diff generator and tree diff applier [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 (https://phabricator.wikimedia.org/T215567) (owner: 10Divec) [20:43:05] 10VisualEditor, 10MonoBook, 10Timeless, 10Vector: VE dialog overlay results in scrollbar disappearing (all layouts) and non-fixed header being positioned incorrectly (desktop-small) - https://phabricator.wikimedia.org/T231138 (10Isarra) The scrollbar thing also looks quite strange in MonoBook and Vector, j... [22:07:21] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): When creating a "New section", the text for the body is not properly aligned with the rest of the page - https://phabricator.wikimedia.org/T222217 (10matmarex) I looked at it again and had a new idea. Turns out I can reproduce this aft... [22:19:35] (03PS1) 10Krinkle: Merge 'ext.templateDataGenerator.ui' into 'ext.templateDataGenerator.editTemplatePage' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/536363 [22:22:49] 10VisualEditor: Verify editing flow events are firing properly - https://phabricator.wikimedia.org/T232790 (10ppelberg) [22:23:10] 10VisualEditor: Verify editing flow events are firing properly - https://phabricator.wikimedia.org/T232790 (10ppelberg) [22:23:14] 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10Patch-For-Review, 10VisualEditor (Current work): Instrument each step of mobile VE edit flow - https://phabricator.wikimedia.org/T229079 (10ppelberg) [22:44:29] (03PS1) 10Bartosz Dziewoński: Fix Vector wikitext surface padding overrides when using custom browser font-size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/536371 (https://phabricator.wikimedia.org/T222217) [22:48:27] (03CR) 10Jforrester: [C: 03+2] Merge 'ext.templateDataGenerator.ui' into 'ext.templateDataGenerator.editTemplatePage' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/536363 (owner: 10Krinkle) [23:03:53] 10WikiEditor, 10VisualEditor (Current work): Update WikiEditor for changes in AbuseFilter and SpamBlacklist API error responses - https://phabricator.wikimedia.org/T232687 (10matmarex) a:03matmarex [23:10:22] (03Merged) 10jenkins-bot: Merge 'ext.templateDataGenerator.ui' into 'ext.templateDataGenerator.editTemplatePage' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/536363 (owner: 10Krinkle) [23:14:52] (03CR) 10jenkins-bot: Merge 'ext.templateDataGenerator.ui' into 'ext.templateDataGenerator.editTemplatePage' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/536363 (owner: 10Krinkle) [23:15:03] (03CR) 10DLynch: [C: 03+2] Update SpamBlacklist error logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/536375 (https://phabricator.wikimedia.org/T232687) (owner: 10Bartosz Dziewoński) [23:37:51] (03Merged) 10jenkins-bot: Update SpamBlacklist error logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/536375 (https://phabricator.wikimedia.org/T232687) (owner: 10Bartosz Dziewoński) [23:40:30] 10VisualEditor, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Regression: Regression: ICONS: Loading label is visible when clicking edit icon - https://phabricator.wikimedia.org/T232799 (10Jdlrobson) [23:53:11] 10VisualEditor, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Regression: Regression: ICONS: Loading label is visible when clicking edit icon - https://phabricator.wikimedia.org/T232799 (10Jdlrobson)