[03:02:15] (03PS1) 10Divec: Make test names clearer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544567 [03:02:17] (03PS1) 10Divec: TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544568 (https://phabricator.wikimedia.org/T235959) [03:11:07] 10VisualEditor, 10Patch-For-Review: Visual Editor: deleting selected text not working - https://phabricator.wikimedia.org/T235959 (10dchan) Thanks @Kerry_Raymond ! Technical details for triage: this is triggered if a transaction contains a removal starting in the interior of a text node, crosses an inline ele... [05:49:02] 10VisualEditor, 10Patch-For-Review: Visual Editor: deleting selected text not working - https://phabricator.wikimedia.org/T235959 (10Kerry_Raymond) The template does indeed seem to be the trouble maker. I just had the same problem on [https://en.wikipedia.org/w/index.php?title=Kia_Ora,_Queensland&oldid=9222917... [07:39:12] 10VisualEditor-DataModel, 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10VisualEditor (Current work): VE not successfully loading on certain page of fr.wikiversity: "TypeError: href is null" from ve.dm.MWInternalLinkAnnotation.js:141:2 - https://phabricator.wikimedia.org/T235707 (10Lionel_Scheepmans) >>! In T... [09:34:03] (03PS9) 10Mvolz: Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) [09:57:20] (03CR) 10Jforrester: [C: 03+2] Make test names clearer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544567 (owner: 10Divec) [10:09:13] (03PS10) 10Mvolz: Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) [10:12:53] 10VisualEditor, 10Patch-For-Review: Visual Editor: deleting selected text not working - https://phabricator.wikimedia.org/T235959 (10dchan) Yes that looks like the same pattern – thanks for the additional info! [10:13:46] (03CR) 10Jforrester: [C: 03+2] build: Bump mediawiki-phan-config to 0.8.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544382 (owner: 10Daimona Eaytoy) [10:18:33] (03Merged) 10jenkins-bot: Make test names clearer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544567 (owner: 10Divec) [10:19:00] (03CR) 10jerkins-bot: [V: 04-1] build: Bump mediawiki-phan-config to 0.8.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544382 (owner: 10Daimona Eaytoy) [10:19:53] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544382 (owner: 10Daimona Eaytoy) [10:20:01] (03CR) 10jerkins-bot: [V: 04-1] build: Bump mediawiki-phan-config to 0.8.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544382 (owner: 10Daimona Eaytoy) [10:20:25] (03CR) 10Hashar: [C: 03+2] "Failure is unrelated. That is due to CI :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544382 (owner: 10Daimona Eaytoy) [10:31:51] (03Merged) 10jenkins-bot: build: Bump mediawiki-phan-config to 0.8.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544382 (owner: 10Daimona Eaytoy) [10:54:42] (03CR) 10Esanders: [C: 03+2] TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544568 (https://phabricator.wikimedia.org/T235959) (owner: 10Divec) [10:56:29] (03Merged) 10jenkins-bot: TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544568 (https://phabricator.wikimedia.org/T235959) (owner: 10Divec) [11:07:12] (03PS2) 10Jforrester: Update VE core submodule to master (b2939de73) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/543685 (https://phabricator.wikimedia.org/T234108) [11:08:44] (03PS2) 10Esanders: TargetWidget: Use surface view focus/blur events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/543912 [11:08:46] (03PS2) 10Esanders: Separate utilities required for DOM parsing into separate file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544246 [11:08:49] (03PS4) 10Esanders: [BREAKING CHANGE] ve.ui.TargetWidget: Construct a real target inside the widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/541825 [11:11:13] (03CR) 10jerkins-bot: [V: 04-1] Separate utilities required for DOM parsing into separate file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544246 (owner: 10Esanders) [11:12:07] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] ve.ui.TargetWidget: Construct a real target inside the widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/541825 (owner: 10Esanders) [11:28:22] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (b2939de73) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/543685 (https://phabricator.wikimedia.org/T234108) (owner: 10Jforrester) [11:32:06] (03PS1) 10Esanders: Grammar fix in doc [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544868 [11:37:00] (03PS3) 10Esanders: Use plugin to ensure all message keys are documented [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/543146 (https://phabricator.wikimedia.org/T235502) [11:37:33] (03CR) 10jerkins-bot: [V: 04-1] Use plugin to ensure all message keys are documented [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/543146 (https://phabricator.wikimedia.org/T235502) (owner: 10Esanders) [11:37:57] (03CR) 10Jforrester: [C: 03+2] Grammar fix in doc [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544868 (owner: 10Esanders) [11:39:46] (03Merged) 10jenkins-bot: Grammar fix in doc [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/544868 (owner: 10Esanders) [11:47:36] (03Merged) 10jenkins-bot: Update VE core submodule to master (b2939de73) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/543685 (https://phabricator.wikimedia.org/T234108) (owner: 10Jforrester) [11:55:00] 10VisualEditor, 10Anti-Harassment, 10MediaWiki-User-management, 10Stewards-and-global-tools, 10Mobile: Mobile block notice not showing block reason or block log entry for global blocks - https://phabricator.wikimedia.org/T233996 (10Niharika) [12:22:17] (03PS4) 10Esanders: Use plugin to ensure all message keys are documented [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/543146 (https://phabricator.wikimedia.org/T235502) [12:32:29] (03CR) 10Jforrester: [C: 03+2] Use plugin to ensure all message keys are documented [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/543146 (https://phabricator.wikimedia.org/T235502) (owner: 10Esanders) [12:34:44] (03Merged) 10jenkins-bot: Use plugin to ensure all message keys are documented [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/543146 (https://phabricator.wikimedia.org/T235502) (owner: 10Esanders) [13:08:12] (03PS1) 10Bartosz Dziewoński: TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/544901 (https://phabricator.wikimedia.org/T235959) [13:09:16] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to d3e22619d7 [extensions/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/544902 (https://phabricator.wikimedia.org/T235959) [13:09:31] (03CR) 10Bartosz Dziewoński: [C: 03+2] TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/544901 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [13:09:58] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to d3e22619d7 [extensions/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/544902 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [13:11:31] (03Merged) 10jenkins-bot: TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/544901 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [13:16:40] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to d3e22619d7 [extensions/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/544902 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [13:22:41] (03Merged) 10jenkins-bot: Update VE core submodule to d3e22619d7 [extensions/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/544902 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [13:36:29] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: Create mockups - https://phabricator.wikimedia.org/T235592 (10Esanders) Looks correct. [13:42:44] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): Visual Editor: deleting selected text not working - https://phabricator.wikimedia.org/T235959 (10matmarex) [13:44:02] (03PS1) 10Bartosz Dziewoński: TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544915 (https://phabricator.wikimedia.org/T235959) [13:45:18] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to a98c346bb2 [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544916 (https://phabricator.wikimedia.org/T235959) [13:46:09] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to a98c346bb2 [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544916 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [13:46:33] (03PS1) 10Bartosz Dziewoński: TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544917 (https://phabricator.wikimedia.org/T235959) [13:47:03] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to a4ab456dc0 [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544918 (https://phabricator.wikimedia.org/T235959) [13:48:47] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to a4ab456dc0 [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544918 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [14:28:03] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This doesn't seem to have any effect (testing with VE-MW media dialog). Can you explain what is supposed to change?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/543912 (owner: 10Esanders) [14:31:40] (03PS1) 10Bartosz Dziewoński: ApiVisualEditor: Always return 'etag' with 'content' [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544934 (https://phabricator.wikimedia.org/T233320) [14:34:30] (03PS2) 10Bartosz Dziewoński: ApiVisualEditor: Always return 'etag' with 'content' [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544934 (https://phabricator.wikimedia.org/T233320) [14:35:05] (03PS1) 10Bartosz Dziewoński: Detect mangled etags from RESTBase and retry via MediaWiki API [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544935 (https://phabricator.wikimedia.org/T233320) [14:35:27] (03CR) 10jerkins-bot: [V: 04-1] ApiVisualEditor: Always return 'etag' with 'content' [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544934 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [14:36:08] (03CR) 10jerkins-bot: [V: 04-1] Detect mangled etags from RESTBase and retry via MediaWiki API [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544935 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [14:36:24] (03PS1) 10Bartosz Dziewoński: ApiVisualEditor: Always return 'etag' with 'content' [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544938 (https://phabricator.wikimedia.org/T233320) [14:36:26] (03PS1) 10Bartosz Dziewoński: Detect mangled etags from RESTBase and retry via MediaWiki API [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544939 (https://phabricator.wikimedia.org/T233320) [14:37:21] (03CR) 10jerkins-bot: [V: 04-1] ApiVisualEditor: Always return 'etag' with 'content' [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544938 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [14:37:24] (03CR) 10jerkins-bot: [V: 04-1] Detect mangled etags from RESTBase and retry via MediaWiki API [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544939 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [14:44:36] (03PS1) 10Bartosz Dziewoński: Try using structured logging again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544941 (https://phabricator.wikimedia.org/T234564) [14:56:40] (03CR) 10jerkins-bot: [V: 04-1] Try using structured logging again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544941 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [15:04:33] (03PS2) 10Bartosz Dziewoński: Try using structured logging again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544941 (https://phabricator.wikimedia.org/T234564) [15:20:03] (03CR) 10jerkins-bot: [V: 04-1] Try using structured logging again [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544957 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [15:20:19] (03CR) 10jerkins-bot: [V: 04-1] Try using structured logging again [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544958 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [15:32:19] (03CR) 10Jforrester: [C: 03+2] TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544917 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [15:32:21] (03CR) 10Jforrester: [C: 03+2] TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544915 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [15:34:13] (03Merged) 10jenkins-bot: TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544917 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [15:34:57] (03Merged) 10jenkins-bot: TreeModifier: Ignore removed nodes properly when normalizing from a text node [VisualEditor/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544915 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [15:35:31] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544916 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [15:35:48] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544918 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [15:56:30] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544934 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [15:56:33] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544935 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [15:56:35] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544957 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [15:56:43] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544938 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [15:56:51] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544939 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [15:56:55] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544958 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [16:10:35] MatmaRex: Given that wmf.1 isn't deployed anywhere, I'll just merge the lot there now and sync it. [16:10:59] (03CR) 10Jforrester: [C: 03+2] Update VE core submodule to a98c346bb2 [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544916 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [16:11:04] (03CR) 10Jforrester: [C: 03+2] ApiVisualEditor: Always return 'etag' with 'content' [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544934 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [16:11:07] (03CR) 10Jforrester: [C: 03+2] Detect mangled etags from RESTBase and retry via MediaWiki API [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544935 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [16:11:43] James_F: oh, that's news to me [16:11:57] it definitely was at least on en.wp when i started making those backports [16:11:58] Except https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/544957/ seems unhappy in phan? [16:12:08] It was, yes; the train was rolled out an hour ago. [16:12:14] Happy times. [16:13:39] James_F: hmm, in the change on master, i got the opposite error [16:13:54] James_F: are we running different versions of phan on master and on wmf branches or something? [16:14:07] Well, we're running different versions of MW core. [16:14:19] And that is running different versions of phan-related fixes. [16:15:00] okay, that makes sense [16:18:48] (03PS2) 10Bartosz Dziewoński: Try using structured logging again [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544957 (https://phabricator.wikimedia.org/T234564) [16:19:29] (03PS2) 10Bartosz Dziewoński: Try using structured logging again [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544958 (https://phabricator.wikimedia.org/T234564) [16:20:18] (03CR) 10Bartosz Dziewoński: "Turns out this is using a different version of Phan than master, so I had to restore suppression of a false positive that I removed in the" [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544957 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [16:20:21] (03CR) 10Bartosz Dziewoński: "Turns out this is using a different version of Phan than master, so I had to restore suppression of a false positive that I removed in the" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544958 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [16:25:41] (03Merged) 10jenkins-bot: Update VE core submodule to a98c346bb2 [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544916 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [16:25:46] (03Merged) 10jenkins-bot: ApiVisualEditor: Always return 'etag' with 'content' [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544934 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [16:25:50] (03Merged) 10jenkins-bot: Detect mangled etags from RESTBase and retry via MediaWiki API [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544935 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [16:51:37] (03CR) 10Jforrester: [C: 03+2] Try using structured logging again [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544957 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [17:03:19] (03Merged) 10jenkins-bot: Try using structured logging again [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/544957 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [17:07:48] 10VisualEditor, 10VisualEditor-Edit Cards , 10Product-Analytics (Kanban): Analyze impact of edit cards in the mobile visual editor - https://phabricator.wikimedia.org/T221728 (10LGoto) p:05Triage→03Normal [17:28:25] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), 10User-Ryasmeen, 10VisualEditor (Current work): When creating a "New section", the text for the body is not properly aligned with the rest of the page - https://phabricator.wikimedia.org/T222217 (10Whatamidoing-WMF) 0... [17:51:02] (03CR) 10Lucas Werkmeister (WMDE): "This change is ready for review." (035 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) (owner: 10Mvolz) [18:04:45] 10WikiEditor, 10Editing Design, 10Patch-For-Review, 10User-Zoranzoki21, and 2 others: Change "Media" to "Photos and media" in the visual editor toolbar - https://phabricator.wikimedia.org/T223775 (10iamjessklein) +1 to "images and media" - the language is a bit more humane [18:09:17] (03CR) 10Urbanecm: [C: 03+2] "SWAT" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544918 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [18:10:53] (03CR) 10Urbanecm: [C: 03+2] "SWAT" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544938 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [18:10:59] (03CR) 10Urbanecm: [C: 03+2] "SWAT" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544939 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [18:11:04] (03CR) 10Urbanecm: [C: 03+2] "SWAT" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544958 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [18:11:14] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10Regression, 10VisualEditor (Current work): Transition of MF expand icons when opening VE is wrong after icon updates - https://phabricator.wikimedia.org/T235692 (10Ryasmeen) >>! In T235692#5588325, @Esanders... [18:19:04] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: Create mockups - https://phabricator.wikimedia.org/T235592 (10ppelberg) >>! In T235592#5584688, @iamjessklein wrote: > To start off this work. I made a [[ https://wikimedia.invisionapp.com/freehand/document/AmJCcpPmd | userflow ]] of the existing wo... [18:21:19] 10VisualEditor-Tables, 10Editing QA, 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), 10VisualEditor (Current work): Can't add cells in tables - https://phabricator.wikimedia.org/T234108 (10Ryasmeen) >>! In T234108#5585009, @matmarex wrote: > @Ryasmeen In your video, the site is in a weird mix of Italian and En... [18:22:11] (03Merged) 10jenkins-bot: Update VE core submodule to a4ab456dc0 [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544918 (https://phabricator.wikimedia.org/T235959) (owner: 10Bartosz Dziewoński) [18:22:15] (03Merged) 10jenkins-bot: ApiVisualEditor: Always return 'etag' with 'content' [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544938 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [18:22:18] (03Merged) 10jenkins-bot: Detect mangled etags from RESTBase and retry via MediaWiki API [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544939 (https://phabricator.wikimedia.org/T233320) (owner: 10Bartosz Dziewoński) [18:22:24] (03Merged) 10jenkins-bot: Try using structured logging again [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/544958 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [18:34:25] 10WikiEditor, 10Editing Design, 10Patch-For-Review, 10User-Zoranzoki21, and 2 others: Change "Media" to "Photos and media" in the visual editor toolbar - https://phabricator.wikimedia.org/T223775 (10Trizek-WMF) We have a consensus for "images and media". Go! :) [18:36:27] (03PS1) 10Urbanecm: Revert "Try using structured logging again" [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/545000 [18:36:34] (03PS1) 10Urbanecm: Revert "Try using structured logging again" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/545001 [18:36:53] (03CR) 10Urbanecm: [C: 03+2] "SWAT" [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/545000 (owner: 10Urbanecm) [18:36:57] (03CR) 10Urbanecm: [C: 03+2] "SWAT" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/545001 (owner: 10Urbanecm) [18:37:55] (03Abandoned) 10Urbanecm: Revert "Try using structured logging again" [extensions/VisualEditor] (wmf/1.35.0-wmf.1) - 10https://gerrit.wikimedia.org/r/545000 (owner: 10Urbanecm) [18:39:08] (03CR) 10Urbanecm: [V: 03+2 C: 03+2] Revert "Try using structured logging again" [extensions/VisualEditor] (wmf/1.35.0-wmf.2) - 10https://gerrit.wikimedia.org/r/545001 (owner: 10Urbanecm) [18:43:02] 10VisualEditor, 10Deployments, 10Release-Engineering-Team, 10Wikimedia-Logstash, and 3 others: Logstash discards messages from MediaWiki if they contain uncommon keys in the $context array - https://phabricator.wikimedia.org/T234564 (10Urbanecm) >>! In T234564#5592733, @gerritbot wrote: > Change 544958 **m... [18:46:47] (03Abandoned) 10Bartosz Dziewoński: Try using structured logging again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544941 (https://phabricator.wikimedia.org/T234564) (owner: 10Bartosz Dziewoński) [18:47:58] 10VisualEditor, 10Deployments, 10Release-Engineering-Team, 10Wikimedia-Logstash, and 3 others: Logstash discards messages from MediaWiki if they contain uncommon keys in the $context array - https://phabricator.wikimedia.org/T234564 (10matmarex) I tested that on mwdebug1001, triggered the case that should... [18:55:54] (03PS1) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Remove error handling hacks for MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/545007 [18:59:23] 10VisualEditor-Tables, 10Editing QA, 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), 10VisualEditor (Current work): Can't add cells in tables - https://phabricator.wikimedia.org/T234108 (10matmarex) Yes (it'll go out to production wikis next week). [19:02:20] 10VisualEditor-DataModel, 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10Patch-For-Review, 10VisualEditor (Current work): Visual Editor: deleting selected text not working - https://phabricator.wikimedia.org/T235959 (10matmarex) This should be resolved on all Wikimedia wikis now. [19:21:29] (03PS1) 10Bartosz Dziewoński: Don't retry when etag is undefined because the page doesn't exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/545015 [19:22:02] (03PS2) 10Bartosz Dziewoński: Don't retry when etag is undefined because the page doesn't exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/545015 (https://phabricator.wikimedia.org/T233320) [19:31:03] 10WikiEditor, 10Editing Design, 10Patch-For-Review, 10User-Zoranzoki21, and 2 others: Change "Media" to "Photos and media" in the visual editor toolbar - https://phabricator.wikimedia.org/T223775 (10Zoranzoki21) Excellent, so you can merge patch? [19:33:49] (03PS5) 10Zoranzoki21: Fix visualeditor-dialogbutton-media-tooltip message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/536766 (https://phabricator.wikimedia.org/T223775) [19:34:15] (03CR) 10Zoranzoki21: "Merge conflict fixed :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/536766 (https://phabricator.wikimedia.org/T223775) (owner: 10Zoranzoki21) [19:35:34] 10VisualEditor: Visual editor not loading - https://phabricator.wikimedia.org/T236099 (10Zoranzoki21) [20:31:16] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Consider creating a way for contributors to navigate between sections, while still in edit mode - https://phabricator.wikimedia.org/T228109 (10kostajh) > This task involves the work with investigating whether it would be valuable to create a way for contributors... [20:35:04] 10VisualEditor: Visual editor not loading - https://phabricator.wikimedia.org/T236099 (10matmarex) You're in the right place, thank you for reporting this! It's a bug in VisualEditor that is triggered by the audio file "thumbnails" on that page. We've already fixed it, and the fix will go live later this week,... [20:35:06] 10VisualEditor: Visual editor not loading - https://phabricator.wikimedia.org/T236099 (10matmarex) [20:35:08] 10VisualEditor-DataModel, 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10VisualEditor (Current work): VE not successfully loading on pages with video or audio embeds: "TypeError: href is null" from ve.dm.MWInternalLinkAnnotation.js:141:2 - https://phabricator.wikimedia.org/T235707 (10matmarex) [20:35:10] 10VisualEditor-DataModel, 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10VisualEditor (Current work): VE not successfully loading on pages with video or audio embeds: "TypeError: href is null" from ve.dm.MWInternalLinkAnnotation.js:141:2 - https://phabricator.wikimedia.org/T235707 (10matmarex) [20:50:13] 10VisualEditor-MediaWiki-Links, 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10Verified, 10VisualEditor (Current work): Relative links to subpages are treated as links to the mainspace that start with / until after saving - https://phabricator.wikimedia.org/T110413 (10Ryasmeen)