[00:50:52] (03PS1) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Improve toolbar scrolling behavior on iOS 13 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547365 [00:51:12] (03PS2) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Improve toolbar scrolling behavior on iOS 13 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547365 (https://phabricator.wikimedia.org/T233470) [00:56:43] 10VisualEditor-ContentEditable, 10Patch-For-Review, 10VisualEditor (Current work): Collapsible elements are not visible in VisualEditor - https://phabricator.wikimedia.org/T236247 (10ti_infotrad) It seems to work nicely. One question, though: was the change designed to show the inactive [Expand] toggle? [01:03:35] (03PS2) 10Jforrester: Update VE core submodule to master (8f850a718) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/546732 (https://phabricator.wikimedia.org/T226604) [01:09:41] 10VisualEditor, 10VisualEditor-Links, 10Growth-Team, 10Parsoid, 10StructuredDiscussions: 'Wikidata:' namespace prefix removed when creating a link on Wikidata, making the link a 404 - https://phabricator.wikimedia.org/T228616 (10matmarex) [01:10:04] 10VisualEditor, 10VisualEditor-Links, 10Growth-Team, 10Parsoid, 10StructuredDiscussions: 'Wikidata:' namespace prefix removed when creating a link on Wikidata, making the link a 404 - https://phabricator.wikimedia.org/T228616 (10matmarex) [01:10:08] 10VisualEditor, 10Wikidata: Visual Editor on Wikidata drops Wikidata: namespace prefix - https://phabricator.wikimedia.org/T236959 (10matmarex) [01:16:47] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (8f850a718) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/546732 (https://phabricator.wikimedia.org/T226604) (owner: 10Jforrester) [01:27:20] (03Merged) 10jenkins-bot: Update VE core submodule to master (8f850a718) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/546732 (https://phabricator.wikimedia.org/T226604) (owner: 10Jforrester) [01:58:56] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: Create mockups - https://phabricator.wikimedia.org/T235592 (10iamjessklein) [02:01:25] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: Create mockups - https://phabricator.wikimedia.org/T235592 (10iamjessklein) I've updated the ticket description with the mockups and final links. I'm moving this over to pm review. [02:04:04] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: Create mockups - https://phabricator.wikimedia.org/T235592 (10iamjessklein) [02:20:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "* Toggle is not greyed out" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547207 (https://phabricator.wikimedia.org/T236247) (owner: 10Esanders) [02:21:01] (03PS2) 10Bartosz Dziewoński: Expand collapsible blocks in editor, like we do with collapsible tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547207 (https://phabricator.wikimedia.org/T236247) (owner: 10Esanders) [02:21:21] (03CR) 10Bartosz Dziewoński: [C: 03+1] "PS2 fixes these issues, please +2 if you agree with the changes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547207 (https://phabricator.wikimedia.org/T236247) (owner: 10Esanders) [02:23:20] 10VisualEditor-ContentEditable, 10Patch-For-Review, 10VisualEditor (Current work): Collapsible elements are not visible in VisualEditor - https://phabricator.wikimedia.org/T236247 (10matmarex) >>! In T236247#5622009, @ti_infotrad wrote: > It seems to work nicely. One question, though: was the change designed... [02:27:29] (03CR) 10Bartosz Dziewoński: [C: 03+2] Replace deprecated easy-deflate.deflate with mediawiki.deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547284 (owner: 10Esanders) [02:40:30] (03Merged) 10jenkins-bot: Replace deprecated easy-deflate.deflate with mediawiki.deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547284 (owner: 10Esanders) [04:39:00] (03CR) 10Bartosz Dziewoński: [C: 04-1] Factor out save logic into ArticleTargetSaver (0310 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544265 (owner: 10Esanders) [06:55:09] 10VisualEditor, 10VisualEditor-Links, 10Growth-Team, 10Parsoid, and 2 others: 'Wikidata:' namespace prefix removed when creating a link on Wikidata, making the link a 404 - https://phabricator.wikimedia.org/T228616 (10Lydia_Pintscher) [07:59:31] 10Cite, 10Book-Referencing, 10TCB-Team, 10WMDE-QWERTY-Sprint-2019-10-23: Find a good name for new attribute in ref tag - https://phabricator.wikimedia.org/T171581 (10thiemowmde) It's a draft at the moment. We are going to make it public after the meeting happened. [15:21:02] (03CR) 10Esanders: Factor out save logic into ArticleTargetSaver (039 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544265 (owner: 10Esanders) [15:22:26] (03PS7) 10Esanders: Factor out save logic into ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544265 [15:56:20] (03PS3) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Improve toolbar scrolling behavior on iOS 13 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547365 (https://phabricator.wikimedia.org/T233470) [16:15:15] (03CR) 10Esanders: [C: 03+1] ve.init.mw.MobileArticleTarget: Improve toolbar scrolling behavior on iOS 13 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547365 (https://phabricator.wikimedia.org/T233470) (owner: 10Bartosz Dziewoński) [16:15:21] (03CR) 10Jforrester: [C: 03+2] Expand collapsible blocks in editor, like we do with collapsible tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547207 (https://phabricator.wikimedia.org/T236247) (owner: 10Esanders) [16:27:48] (03Merged) 10jenkins-bot: Expand collapsible blocks in editor, like we do with collapsible tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547207 (https://phabricator.wikimedia.org/T236247) (owner: 10Esanders) [17:41:07] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): Collapsible elements are not visible in VisualEditor - https://phabricator.wikimedia.org/T236247 (10ti_infotrad) Still running into issues, collision with collapsible table option in VE. I will try and post an example. [17:58:02] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): Collapsible elements are not visible in VisualEditor - https://phabricator.wikimedia.org/T236247 (10ti_infotrad) Here is a sample code where the client is experiencing an issue: ` {| width="100%" cellspacing="3" cellpadding="3" border="0" | colsp... [18:06:52] 10Editing-team, 10OWC2020: [Epic] Affordance: Replying to specific comments - https://phabricator.wikimedia.org/T233443 (10ppelberg) [18:08:08] 10Editing-team, 10OWC2020: [Epic] Affordance: Replying to specific comments - https://phabricator.wikimedia.org/T233443 (10ppelberg) [18:08:38] 10Editing-team, 10OWC2020: [Epic] Affordance: Replying to specific comments - https://phabricator.wikimedia.org/T233443 (10ppelberg) Updated the task description to include: - Versions - Project rationale [18:09:13] 10Editing-team, 10OWC2020: Write spec for replying to specific comments - https://phabricator.wikimedia.org/T234824 (10ppelberg) 05Open→03Resolved > - [x] The "Components" listed above are posted to the task description of T233443 See: https://phabricator.wikimedia.org/T233443#5624272 [18:09:17] 10Editing-team, 10OWC2020: [Epic] Affordance: Replying to specific comments - https://phabricator.wikimedia.org/T233443 (10ppelberg) [18:13:28] 10Editing-team, 10DiscussionTools, 10OWC2020: Replies v1.0: release replying to specific comments - https://phabricator.wikimedia.org/T235923 (10ppelberg) During the team's 30-October planning meeting, we identified questions that still need to be answered. Those questions are listed below. They have also be... [18:13:57] 10Editing-team, 10DiscussionTools, 10OWC2020: Replies v1.0: release replying to specific comments - https://phabricator.wikimedia.org/T235923 (10ppelberg) [18:20:50] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): Collapsible elements are not visible in VisualEditor - https://phabricator.wikimedia.org/T236247 (10ti_infotrad) Commenting out following section in `resources\src\jquery\jquery.makeCollapsible.styles.less` fixes the issue ` .mw-collapsed:not( @{e... [18:35:14] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): Collapsible elements are not visible in VisualEditor - https://phabricator.wikimedia.org/T236247 (10ti_infotrad) To be more specific, the line that causes the issue described above is ` tr:not( :first-child ), ` [18:58:43] 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics (Kanban), 10VisualEditor (Current work): Analyze mobile VE edit completion rate for "Quarter in Review" - https://phabricator.wikimedia.org/T236860 (10MNeisler) @ppelberg Here are the initial results. There was a drop in the overall mobile VE edit comp... [19:25:40] 10VisualEditor, 10Parsoid: Visual editor changing automatically something in text while saving - https://phabricator.wikimedia.org/T237040 (10matmarex) [19:50:57] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: conduct usability testing - https://phabricator.wikimedia.org/T236921 (10ppelberg) @iamjessklein I wonder if this moderated user test might from 2014 [1] might be helpful as we think about the design of the user test we will be conducting for this in... [19:57:00] 10VisualEditor, 10MediaWiki-General, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rely on the target system - https://phabricator.wikimedia.org/T236944 (1... [20:06:14] 10VisualEditor, 10Parsoid: Visual editor changing automatically something in text while saving - https://phabricator.wikimedia.org/T237040 (10matmarex) This is a bug, visual editor is not supposed to make any "cleanup" changes not intended by the user. [20:11:20] 10VisualEditor, 10Parsoid: Visual editor changing automatically something in text while saving - https://phabricator.wikimedia.org/T237040 (10matmarex) I made a smaller test case at , where I can reproduce the problem reliably. (In the "Review your chan... [20:12:53] 10VisualEditor, 10Parsoid: Visual editor changing automatically something in text while saving - https://phabricator.wikimedia.org/T237040 (10matmarex) This may be caused by my change {da9b6fffbdba9007cfe893b1eafd1ccb42dbb537} in VE, which was made to fix {T193253}. [20:15:30] 10VisualEditor, 10Parsoid: Visual editor changing automatically something in text while saving - https://phabricator.wikimedia.org/T237040 (10Arlolra) Might be similar to T214649 [20:31:12] 10Editing-team, 10DiscussionTools, 10OWC2020: Replies v1.0: release replying to specific comments - https://phabricator.wikimedia.org/T235923 (10ppelberg) [21:03:22] 10VisualEditor, 10User-RhinosF1: Don't show VE help/welcome messages to users if seen before - https://phabricator.wikimedia.org/T231763 (10RhinosF1) > I believe this issue is to do with our frequent downtime/slow loading. >Based on what i found, VisualEditor saves using the API so that it remembers not to sh... [21:14:45] 10VisualEditor, 10User-RhinosF1: Don't show VE help/welcome messages to users if seen before - https://phabricator.wikimedia.org/T231763 (10matmarex) To be clear, I already identified the issue on your side in my comment T231763#5596140. On your test wiki, the action=options API does not actually save our user... [21:15:46] 10VisualEditor, 10User-RhinosF1: Don't show VE help/welcome messages to users if seen before - https://phabricator.wikimedia.org/T231763 (10RhinosF1) >>! In T231763#5624791, @matmarex wrote: > To be clear, I already identified the issue on your side in my comment T231763#5596140. On your test wiki, the action=... [21:18:41] 10VisualEditor, 10MediaWiki-General, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rely on the target system - https://phabricator.wikimedia.org/T236944 (1... [21:18:52] 10VisualEditor, 10Desktop Improvements, 10MediaWiki-General, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rel... - https://phabricator.wikimedia.org/T236944 [21:22:38] 10VisualEditor, 10Desktop Improvements, 10MediaWiki-General, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rel... - https://phabricator.wikimedia.org/T236944 [21:38:50] 10VisualEditor, 10Parsoid: Visual editor changing automatically something in text while saving - https://phabricator.wikimedia.org/T237040 (10matmarex) p:05Triage→03Unbreak! This isn't quite data loss, but dirty diffs are annoying, so we should fix this as soon as possible. I was able to reproduce on my l... [21:41:15] (03PS1) 10Bartosz Dziewoński: Revert "Parse relative hrefs on image nodes like on regular links" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547660 (https://phabricator.wikimedia.org/T237040) [21:44:23] 10VisualEditor, 10Parsoid, 10Patch-For-Review: Visual editor changing automatically something in text while saving - https://phabricator.wikimedia.org/T237040 (10matmarex) The buggy patch was in version 1.35.0-wmf.2, which was deployed to Wikimedia wikis in the week of 15-17 October. [21:48:52] (03CR) 10DLynch: [C: 03+2] Revert "Parse relative hrefs on image nodes like on regular links" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547660 (https://phabricator.wikimedia.org/T237040) (owner: 10Bartosz Dziewoński) [21:58:47] (03Merged) 10jenkins-bot: Revert "Parse relative hrefs on image nodes like on regular links" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/547660 (https://phabricator.wikimedia.org/T237040) (owner: 10Bartosz Dziewoński) [22:01:49] (03PS1) 10Jforrester: Revert "Parse relative hrefs on image nodes like on regular links" [extensions/VisualEditor] (wmf/1.35.0-wmf.4) - 10https://gerrit.wikimedia.org/r/547667 (https://phabricator.wikimedia.org/T237040) [22:03:29] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix visualeditor-dialogbutton-media-tooltip message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/536766 (https://phabricator.wikimedia.org/T223775) (owner: 10Zoranzoki21) [22:13:38] (03Merged) 10jenkins-bot: Fix visualeditor-dialogbutton-media-tooltip message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/536766 (https://phabricator.wikimedia.org/T223775) (owner: 10Zoranzoki21) [22:14:08] (03PS1) 10Bartosz Dziewoński: Adjust file/image button tooltip to match VisualEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/547670 (https://phabricator.wikimedia.org/T223775) [22:15:18] (03CR) 10DLynch: [C: 03+2] Adjust file/image button tooltip to match VisualEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/547670 (https://phabricator.wikimedia.org/T223775) (owner: 10Bartosz Dziewoński) [22:24:45] (03Merged) 10jenkins-bot: Adjust file/image button tooltip to match VisualEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/547670 (https://phabricator.wikimedia.org/T223775) (owner: 10Bartosz Dziewoński) [22:53:31] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Just typos, looks good otherwise" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544265 (owner: 10Esanders) [23:05:55] (03CR) 10Urbanecm: [C: 03+2] Revert "Parse relative hrefs on image nodes like on regular links" [extensions/VisualEditor] (wmf/1.35.0-wmf.4) - 10https://gerrit.wikimedia.org/r/547667 (https://phabricator.wikimedia.org/T237040) (owner: 10Jforrester) [23:16:15] (03Merged) 10jenkins-bot: Revert "Parse relative hrefs on image nodes like on regular links" [extensions/VisualEditor] (wmf/1.35.0-wmf.4) - 10https://gerrit.wikimedia.org/r/547667 (https://phabricator.wikimedia.org/T237040) (owner: 10Jforrester)