[04:05:04] 10VisualEditor, 10Core Platform Team, 10Parsoid-PHP: Preparing VisualEditor for Parsoid-PHP switch - https://phabricator.wikimedia.org/T229074 (10ssastry) p:05Triage→03High @JTannerWMF, @Esanders, we would ideally like to switch over all services to Parsoid-PHP the week before Thanksgiving and appreciate... [10:55:03] 10Editing-team, 10Advanced Mobile Contributions, 10Desktop Improvements, 10Discovery, and 2 others: Add redlink experience to empty search results on Mobile (JS version) - https://phabricator.wikimedia.org/T211006 (10Trizek-WMF) Have you considered to add a link to an help page that would provide best prac... [11:15:10] 10Editing-team, 10Advanced Mobile Contributions, 10Desktop Improvements, 10Discovery, and 2 others: Add redlink experience to empty search results on Mobile (JS version) - https://phabricator.wikimedia.org/T211006 (10Masumrezarock100) @Trizek-WMF I am pretty sure the content of that help page would vary pe... [11:16:23] 10Cite, 10Book-Referencing, 10WMDE-QWERTY-Sprint-2019-10-23: Implement baseline and/or fallback for non-indented sub-references - https://phabricator.wikimedia.org/T237241 (10thiemowmde) [11:16:34] 10Cite, 10Book-Referencing, 10WMDE-QWERTY-Sprint-2019-10-23: Implement baseline and/or fallback for non-indented sub-references - https://phabricator.wikimedia.org/T237241 (10thiemowmde) [12:18:28] (03PS1) 10Esanders: Remove jQuery from ve.dm.MWLanguageVariantNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548237 [12:18:30] (03PS1) 10Esanders: Avoid use of $.parseHTML in model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548238 [12:18:32] (03PS1) 10Esanders: Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 [13:14:19] (03CR) 10Divec: [C: 03+2] Remove jQuery from ve.dm.MWLanguageVariantNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548237 (owner: 10Esanders) [13:23:20] (03PS2) 10Divec: Avoid use of $.parseHTML in model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548238 (owner: 10Esanders) [13:23:41] (03Merged) 10jenkins-bot: Remove jQuery from ve.dm.MWLanguageVariantNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548237 (owner: 10Esanders) [13:50:43] (03CR) 10Divec: [C: 03+2] Avoid use of $.parseHTML in model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548238 (owner: 10Esanders) [14:03:04] (03Merged) 10jenkins-bot: Avoid use of $.parseHTML in model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548238 (owner: 10Esanders) [14:04:42] (03CR) 10Divec: [C: 03+2] Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 (owner: 10Esanders) [14:04:51] (03PS2) 10Divec: Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 (owner: 10Esanders) [14:04:59] (03CR) 10Divec: [V: 03+2 C: 03+2] Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 (owner: 10Esanders) [14:05:21] (03CR) 10Divec: [V: 03+2] Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 (owner: 10Esanders) [14:05:24] (03CR) 10Divec: [V: 03+2 C: 03+2] Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 (owner: 10Esanders) [14:06:02] (03CR) 10Divec: Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 (owner: 10Esanders) [14:07:11] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: conduct usability testing - https://phabricator.wikimedia.org/T236921 (10iamjessklein) I started to [[ https://docs.google.com/document/d/12zaCdZDnlgwmzi93rRC8xu9DQJEG_0kfgfDWVhzBySQ/edit?usp=sharing | draft ]] out the test protocol. On Friday @ppe... [14:07:18] (03PS3) 10Divec: Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 (owner: 10Esanders) [14:14:26] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Consider removing toolbar borders - https://phabricator.wikimedia.org/T231815 (10iamjessklein) Let's move forward with the proposal that @Volker_E has put forth. It's clean and achieves our goa... [14:20:09] 10VisualEditor-Edit Cards , 10Editing Design, 10I18n, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), and 2 others: Add "✔️" into link modal - https://phabricator.wikimedia.org/T228230 (10iamjessklein) re localization: @Esanders is it possible to have the check icon by default and then tweak for outliers? [14:22:21] (03CR) 10Divec: [C: 03+2] Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 (owner: 10Esanders) [14:31:53] 10TemplateData, 10VisualEditor, 10MediaWiki-API: Templatedata API includes parameters that only exist within comments (for templates mising templatedata) - https://phabricator.wikimedia.org/T237195 (10Anomie) [14:39:11] 10VisualEditor-Edit Cards , 10Editing Design, 10I18n, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), and 2 others: Add "✔️" into link modal - https://phabricator.wikimedia.org/T228230 (10Esanders) Yes, OOUI icons are localisable. However if the checkmark is deemed to not be universal it should be fixed upstr... [14:42:28] (03Merged) 10jenkins-bot: Replace $.when with ve.promiseAll [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548239 (owner: 10Esanders) [15:01:12] 10VisualEditor, 10Wikimedia-Site-requests, 10Bengali-Sites: Enable VisualEditor Extension on bn.wikibooks at রন্ধনপ্রণালী (cookbook) Namespace - https://phabricator.wikimedia.org/T236840 (10Majavah) p:05Triage→03Normal I believe VE should be enabled on all `wgContentNamespaces`, so this would be solved b... [15:36:55] 10VisualEditor-MediaWiki, 10Editing Design, 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10Verified, 10VisualEditor (Current work): Add a useful call-to-action in the context for citation needed templates - https://phabricator.wikimedia.org/T211243 (10Esanders) If I get around to updating this, we many n... [15:46:16] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design, 10Epic, 10Patch-For-Review: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325 (10Jdlrobson) @ppelberg should this task be closed? Pretty old school. [15:53:01] (03PS1) 10Esanders: Move more code to ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 [15:53:25] hi ! [15:53:35] anyone from the visualeditor team on ? [15:53:40] i wanted to share an idea [15:53:56] for some years now i've been developing the proveit gadget (https://commons.wikimedia.org/wiki/Help:Gadget-ProveIt) [15:54:36] it's basically a reference manager [15:55:46] it provides a GUI for adding or editing references in wikitext [15:56:27] it's quite advanced and recently i got a grant to make it work with the new wikitext editor [15:57:10] which i completed a few days ago: https://meta.wikimedia.org/wiki/Grants:Project/Rapid/Enhance_the_ProveIt_gadget,_part_2/Report [15:57:37] the GUI is quite neat and clean but im now thinking on translating it to OOUI [15:57:44] anyway, the point of all this is [15:57:48] (03CR) 10Esanders: "Don't merge until after next release (2019-11-05)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [15:58:09] that maybe with some further improvements [15:58:28] this gadget could be merged with the new wikitext editor to provide a default reference manger in wikitext mode [15:59:34] i consulted with Matthew Flaschen, original developer of the gadget and former WMF developer, and he suggested i drop the idea here [16:00:29] so anyway, let me know your thoughts ! [16:07:07] +v ^ [16:21:19] (03PS1) 10Esanders: Add missing dependency for parsing utils [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548303 [16:22:35] (03PS2) 10Esanders: Remove toolbar borders from mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/534466 (https://phabricator.wikimedia.org/T231815) [16:23:24] (03CR) 10Esanders: "Ready for review" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/534466 (https://phabricator.wikimedia.org/T231815) (owner: 10Esanders) [16:24:45] (03PS2) 10Jforrester: Reduce size of PopupToolGroup indicators on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/534627 (owner: 10Esanders) [17:19:05] (03CR) 10Bartosz Dziewoński: [C: 03+1] Factor out save logic into ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/544265 (owner: 10Esanders) [17:47:21] 10Editing-team, 10VisualEditor, 10Growth-Team: EventLogging validation errors for EditAttemptStep - https://phabricator.wikimedia.org/T237063 (10DLynch) It's not just `loaded_timing`, there's also `ready_timing`. I think getting a null there would have to mean loaded is firing before init, because of this c... [17:51:07] 10VisualEditor, 10Desktop Improvements, 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), and 2 others: The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rely on t... - https://phabricator.wikimedia.org/T236944 [17:59:46] 10VisualEditor, 10VisualEditor-Links: Vertical alignment regressions in desktop link contexts - https://phabricator.wikimedia.org/T237289 (10Esanders) [18:30:47] 10VisualEditor, 10VisualEditor-Links: Vertical alignment regressions in desktop link contexts - https://phabricator.wikimedia.org/T237289 (10Esanders) Bisect unsurprisingly blames an OOUI update. v0.35.1 :) [18:34:50] 10VisualEditor, 10VisualEditor-Links: Vertical alignment regressions in desktop link contexts - https://phabricator.wikimedia.org/T237289 (10Esanders) cc @Volker_E @matmarex [19:23:50] hi ! anyone on from the visualeditor team ? [19:37:48] (03PS1) 10Esanders: Fix alignment of frameless button in desktop context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548467 (https://phabricator.wikimedia.org/T237289) [19:38:12] 10VisualEditor-Links, 10Patch-For-Review, 10VisualEditor (Current work): Vertical alignment regressions in desktop link contexts - https://phabricator.wikimedia.org/T237289 (10Esanders) [19:40:08] (03PS1) 10VolkerE: Fix vertical alignment in LinkContextItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548469 (https://phabricator.wikimedia.org/T237289) [19:40:43] 10VisualEditor-Links, 10Patch-For-Review, 10VisualEditor (Current work): Vertical alignment regressions in desktop link contexts - https://phabricator.wikimedia.org/T237289 (10matmarex) Seems to be caused by the addition of min-height in https://gerrit.wikimedia.org/r/c/oojs/ui/+/514970/19/src/themes/wikimed... [19:47:48] 10VisualEditor-Links, 10Patch-For-Review, 10VisualEditor (Current work): Vertical alignment regressions in desktop link contexts - https://phabricator.wikimedia.org/T237289 (10Esanders) It does, but the height addition is useful in increasing the click target, so I added negative margin instead. [19:50:47] (03CR) 10VolkerE: Fix alignment of frameless button in desktop context (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548467 (https://phabricator.wikimedia.org/T237289) (owner: 10Esanders) [19:51:25] 10VisualEditor-Links, 10Patch-For-Review, 10VisualEditor (Current work): Vertical alignment regressions in desktop link contexts - https://phabricator.wikimedia.org/T237289 (10Volker_E) This ^! [19:51:43] (03Abandoned) 10VolkerE: Fix vertical alignment in LinkContextItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548469 (https://phabricator.wikimedia.org/T237289) (owner: 10VolkerE) [19:53:21] (03PS1) 10VolkerE: Replace color with WikimediaUI color palette one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548473 [19:57:45] hi, i've installed the visual editor and parsoid properly (i think), but when i press edit, the page reloads and then nothing happens. [19:59:06] i'm not too sure how to get logs but my web console prints this: https://gist.github.com/benclarkk/d39ac07d895bc206e5bb71e9b7210401 [20:09:06] (03CR) 10Bartosz Dziewoński: [C: 03+2] "The button and the labels on the left are still slightly misaligned for me. I'll submit a followup on the task." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548467 (https://phabricator.wikimedia.org/T237289) (owner: 10Esanders) [20:12:21] (03Merged) 10jenkins-bot: Fix alignment of frameless button in desktop context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548467 (https://phabricator.wikimedia.org/T237289) (owner: 10Esanders) [20:13:41] (03PS1) 10Jforrester: Update VE core submodule to master (5f0d866a0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548484 (https://phabricator.wikimedia.org/T237289) [20:15:16] (03PS1) 10Bartosz Dziewoński: Tweak alignment of frameless button in desktop context further [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548485 (https://phabricator.wikimedia.org/T237289) [20:44:45] oh by the way, all the urls in the console logs exist [20:44:50] so i'm confused [21:10:51] (03PS1) 10Esanders: Follow-up I59a4d1a4: Fix padding/height in desktop context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548520 [21:28:35] (03CR) 10Esanders: [C: 04-1] Tweak alignment of frameless button in desktop context further (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548485 (https://phabricator.wikimedia.org/T237289) (owner: 10Bartosz Dziewoński) [21:28:56] (03Abandoned) 10Esanders: Follow-up I59a4d1a4: Fix padding/height in desktop context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548520 (owner: 10Esanders) [21:29:17] 10VisualEditor-Edit Cards , 10Editing Design, 10I18n, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), and 2 others: Add "✔️" into link modal - https://phabricator.wikimedia.org/T228230 (10Volker_E) For me the question remains, if the context for using the 'check' icon is sufficient as metaphor for Publish in... [22:06:26] (03CR) 10Bartosz Dziewoński: Tweak alignment of frameless button in desktop context further (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548485 (https://phabricator.wikimedia.org/T237289) (owner: 10Bartosz Dziewoński) [22:06:33] (03PS2) 10Bartosz Dziewoński: Tweak alignment of frameless button in desktop context further [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548485 (https://phabricator.wikimedia.org/T237289) [22:14:02] (03PS2) 10Bartosz Dziewoński: Replace color with WikimediaUI color palette one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548473 (owner: 10VolkerE) [22:14:08] (03CR) 10Bartosz Dziewoński: [C: 03+2] Replace color with WikimediaUI color palette one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548473 (owner: 10VolkerE) [22:14:27] (03PS3) 10Bartosz Dziewoński: Tweak alignment of frameless button in desktop context further [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548485 (https://phabricator.wikimedia.org/T237289) [22:15:28] (03CR) 10Bartosz Dziewoński: [C: 03+2] Add missing dependency for parsing utils [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548303 (owner: 10Esanders) [22:16:03] (03Merged) 10jenkins-bot: Replace color with WikimediaUI color palette one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/548473 (owner: 10VolkerE) [22:21:36] (03CR) 10Bartosz Dziewoński: Move more code to ArticleTargetSaver (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [22:28:04] (03Merged) 10jenkins-bot: Add missing dependency for parsing utils [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548303 (owner: 10Esanders) [22:33:21] (03PS2) 10Esanders: Move more code to ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 [23:10:58] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: Create mockups - https://phabricator.wikimedia.org/T235592 (10Jc86035) I think it's possible that the inline "reply" button might not be visible enough, since it just looks like a normal link enclosed in parentheses. Perhaps it could be given differe... [23:13:13] 10Editing-team, 10OWC2020, 10VisualEditor (Current work): Create a VE-based text input for replying - https://phabricator.wikimedia.org/T234403 (10Jc86035) While I am a Flow user and have it enabled on my Wikidata talk page, I do have some reservations about using VE directly without any alternative. I think...