[00:00:42] (03Merged) 10jenkins-bot: Config value for X-Parsoid-Variant [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548784 (https://phabricator.wikimedia.org/T229074) (owner: 10DLynch) [00:24:34] 10TemplateData, 10VisualEditor, 10ApiFeatureUsage, 10BetaFeatures, and 22 others: All API help links should use `Special:MyLanguage` - https://phabricator.wikimedia.org/T231269 (10Niharika) [00:36:52] (03PS1) 10Bartosz Dziewoński: ve.init.mw.ArticleTarget: Fix error handling in #prepareCacheKey [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549236 [01:25:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] Move more code to ArticleTargetSaver (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [01:42:30] 10VisualEditor: Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10matmarex) [01:42:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10matmarex) I took a closer look. The reproduction steps are even simpler – just open the editor at 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10matmarex) (I think we should prioritize this, at least until someones assures me that this problem can't ha... [01:51:47] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Chinese-Sites, 10VisualEditor (Current work): Chinese IME issue in 2017 WTE - https://phabricator.wikimedia.org/T222894 (10matmarex) [04:59:05] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10ssastry) @matmarex, look at Example 2 and the discussion on https://www.mediawiki.org/wiki/Parsing/Notes/Se... [06:47:04] 10Citoid, 10Services, 10Toolforge, 10cloud-services-team (Kanban): DNS lookups for nih.gov hosts failing from Cloud VPS/Toolforge, services (citoid) - https://phabricator.wikimedia.org/T226088 (10Elenadonne68) [url=https://r-roku.com/link]roku.com/link[/url] this is simplest way to stream entertainment to... [06:47:39] 10Citoid, 10Services, 10Toolforge, 10cloud-services-team (Kanban): DNS lookups for nih.gov hosts failing from Cloud VPS/Toolforge, services (citoid) - https://phabricator.wikimedia.org/T226088 (10Elenadonne68) https://r-roku.com/link this is simplest way to stream entertainment to your TV. On your terms.... [08:59:18] 10Editing-team, 10Advanced Mobile Contributions, 10Desktop Improvements, 10Discovery, and 2 others: Add redlink experience to empty search results on Mobile (JS version) - https://phabricator.wikimedia.org/T211006 (10Trizek-WMF) >>! In T211006#5635331, @ovasileva wrote: > @Trizek-WMF - just to make sure, y... [09:12:04] 10VisualEditor, 10ContentTranslation, 10Design, 10Language-Team (Language-2019-October-December): CX2: Support for references added by name when the details are inside a template - https://phabricator.wikimedia.org/T209266 (10Pginer-WMF) Until the root cause (T52896) is solved, the scope of this ticket is... [10:15:38] 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), 10VisualEditor (Current work): NWE: Copying tab/newline characters using mouse only (on unixoid systems) doesn't work as expected - https://phabricator.wikimedia.org/T157956 (10Schnark) This o... [10:19:34] 10Editing-team, 10Advanced Mobile Contributions, 10Desktop Improvements, 10Discovery, and 2 others: Add redlink experience to empty search results on Mobile (JS version) - https://phabricator.wikimedia.org/T211006 (10ovasileva) >>! In T211006#5636346, @Jdlrobson wrote: > And to clarify are we talking about... [12:00:20] 10Cite, 10Book-Referencing, 10Documentation: Improve on-wiki documentation for Cite features - https://phabricator.wikimedia.org/T237631 (10awight) [13:01:00] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): 2017WTE loses focus after making a link - https://phabricator.wikimedia.org/T222249 (10Esanders) This was probably a regression around link inspector refactoring, but appears to have been fixed. Can you confirm @Whatamidoing-WMF ? [13:57:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Keyboard shortcut puts � into the page, instead of opening the correct dialog - https://phabricator.wikimedia.org/T233972 (10Esanders) I can't reproduce this is Safari 11 or 13. Is this still happening for you @Whatamidoing-WMF or was it just a Safar... [14:04:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Using Undo after inserting formatted element resets cursor - https://phabricator.wikimedia.org/T191566 (10Esanders) I can't reproduce this. [14:50:53] (03PS1) 10Esanders: Follow-up I83b98e41: Always sanitize when using plain text paste in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549469 (https://phabricator.wikimedia.org/T201561) [14:58:14] (03CR) 10Esanders: "As I said on the original patch "We should have tests for these, but current we have no test rigging for source mode." :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549469 (https://phabricator.wikimedia.org/T201561) (owner: 10Esanders) [15:17:46] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/549471 (owner: 10L10n-bot) [15:46:02] (03CR) 10Jforrester: "Yeah, these would need escaping (and this content is wrong anyway)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/549471 (owner: 10L10n-bot) [15:47:52] (03Abandoned) 10Jforrester: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/549471 (owner: 10L10n-bot) [15:50:56] (03CR) 10DLynch: [C: 03+2] ve.init.mw.ArticleTarget: Fix error handling in #prepareCacheKey [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549236 (owner: 10Bartosz Dziewoński) [15:54:49] (03CR) 10Lucas Werkmeister (WMDE): Add support for items (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) (owner: 10Mvolz) [15:58:22] (03CR) 10Lucas Werkmeister (WMDE): Add support for items (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) (owner: 10Mvolz) [16:00:54] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTarget: Fix error handling in #prepareCacheKey [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549236 (owner: 10Bartosz Dziewoński) [16:06:37] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10cscott) Seems like the bug is in VE's section-stripping code? It should probably not strip the section tag... [16:30:58] 10TemplateData, 10VisualEditor, 10ApiFeatureUsage, 10BetaFeatures, and 22 others: All API help links should use `Special:MyLanguage` - https://phabricator.wikimedia.org/T231269 (10DannyS712) [16:53:26] (03PS1) 10Catrope: ve.init.mw.ArticleTarget: Fix error handling in #prepareCacheKey [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/549570 [16:54:56] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10ssastry) @cscott, but, as I noted in my previous comment, we explicitly provide support for VE and clients... [16:56:19] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: conduct usability testing - https://phabricator.wikimedia.org/T236921 (10ppelberg) >>! In T236921#5631418, @iamjessklein wrote: > I started to [[ https://docs.google.com/document/d/12zaCdZDnlgwmzi93rRC8xu9DQJEG_0kfgfDWVhzBySQ/edit?usp=sharing | draft... [16:59:46] 10Citoid: Keep anchor when generating reference from URL - https://phabricator.wikimedia.org/T212608 (10Tkarcher) This issue (Citoid replacing given URLs with the ones found in meta data) does not only cause problems with anchors, but also with sites using short urls in their meta data: As reported in https://d... [18:04:41] 10Editing-team, 10Advanced Mobile Contributions, 10Desktop Improvements, 10Discovery, and 2 others: Add redlink experience to empty search results on Mobile (JS version) - https://phabricator.wikimedia.org/T211006 (10alexhollender) >>! In T211006#5630616, @Trizek-WMF wrote: > Have you considered to add a l... [18:05:47] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10cscott) @subbu -- the data-mw attribute necessary to round-trip the template is only occuring on the 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10ssastry) No, we update data-mw appropriately to be valid for both locations. ` [subbu@earth:~/work/wmf/pars... [18:26:01] (03CR) 10Jforrester: [C: 03+1] Follow-up I83b98e41: Always sanitize when using plain text paste in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549469 (https://phabricator.wikimedia.org/T201561) (owner: 10Esanders) [18:45:21] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10cscott) You're right, I didn't notice it in the example, and i missed it in @matmarex's screenshot, because... [18:54:27] (03CR) 10Bartosz Dziewoński: [C: 03+2] "No idea what this really does." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549469 (https://phabricator.wikimedia.org/T201561) (owner: 10Esanders) [19:04:12] (03Merged) 10jenkins-bot: Follow-up I83b98e41: Always sanitize when using plain text paste in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549469 (https://phabricator.wikimedia.org/T201561) (owner: 10Esanders) [19:05:30] (03CR) 10Catrope: [C: 03+2] ve.init.mw.ArticleTarget: Fix error handling in #prepareCacheKey [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/549570 (owner: 10Catrope) [19:15:49] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTarget: Fix error handling in #prepareCacheKey [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/549570 (owner: 10Catrope) [19:24:32] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10ssastry) >>! In T234280#5645308, @cscott wrote: > You're right, I didn't notice it in the example, and i mi... [19:37:29] 10VisualEditor, 10Contributors-Team, 10MobileFrontend: Allow mobile web edits to be marked as minor - https://phabricator.wikimedia.org/T123694 (10Pelagic) Agree with Sdkb. This and also the ability to edit or at least see the /* section */ part of the edit summary. There's a separate Phab task for that so... [20:50:09] 10VisualEditor-Edit Cards , 10Verified, 10VisualEditor (Current work): [Pre-deployment bug] While trying to change label for a link in Edit card V2 the page scrolls up making the link go out of view on iOS 11 - https://phabricator.wikimedia.org/T227627 (10Ryasmeen) [20:52:04] (03PS1) 10Bartosz Dziewoński: Ensure all requests in one edit session use the same X-Parsoid-Variant [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549629 (https://phabricator.wikimedia.org/T229074) [21:10:40] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10matmarex) Thanks, that is reassuring :) That's clever, I didn't know it worked that way. [21:13:18] 10Editing-team, 10MediaWiki-extensions-Graph, 10Wikimedia-production-error: Fatal from ApiGraph->getGraphSpec: "Call to a member function getExtensionData() on boolean" - https://phabricator.wikimedia.org/T235356 (10DLynch) I don't actually know anything about the Graph extension, but a quick glance at the c... [21:23:15] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10matmarex) I think I see the exact problem here. In the Parsoid HTML (https://www.mediawiki.org/api/rest_v1/... [21:24:55] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10ssastry) >>! In T234280#5645999, @matmarex wrote: > I think I see the exact problem here. In the Parsoid HT... [21:25:02] 10VisualEditor-MediaWiki, 10Parsoid, 10VisualEditor (Current work): Edits made via VE on a translatable page removes untouched content in tags - https://phabricator.wikimedia.org/T234280 (10matmarex) I think this is actually a bug in Parsoid. The second element should have `about="#mwt39"` – ther... [22:11:39] (03PS1) 10Jforrester: Update VE core submodule to master (a6ef2cc7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549651 (https://phabricator.wikimedia.org/T237289) [22:12:50] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (a6ef2cc7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549651 (https://phabricator.wikimedia.org/T237289) (owner: 10Jforrester) [22:27:56] (03Merged) 10jenkins-bot: Update VE core submodule to master (a6ef2cc7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549651 (https://phabricator.wikimedia.org/T237289) (owner: 10Jforrester) [22:42:50] (03CR) 10Esanders: Move more code to ArticleTargetSaver (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [22:42:55] (03PS3) 10Esanders: Move more code to ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 [22:43:11] (03CR) 10Esanders: Move more code to ArticleTargetSaver (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [22:44:17] (03PS4) 10Esanders: Move more code to ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 [23:52:56] 10VisualEditor, 10User-Ryasmeen: Determine Android device for QA - https://phabricator.wikimedia.org/T233370 (10ppelberg) 05Open→03Resolved @Ryasmeen, let's use a Samsung Galaxy S8 as the Android device we use for testing. It appears to be relatively popular in the countries where many contributors to the...