[00:21:14] (03PS1) 10Esanders: tests: Put FragmentInspector test runner in shared util [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550382 [00:22:01] (03PS4) 10Esanders: Support wikitext link editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550359 [00:24:19] 10Editing-team, 10OWC2020: Consult communities about participating as "target wikis" - https://phabricator.wikimedia.org/T233761 (10ppelberg) [00:25:09] 10Editing-team, 10OWC2020: Consult communities about participating as "target wikis" - https://phabricator.wikimedia.org/T233761 (10ppelberg) [00:27:07] (03PS5) 10Esanders: Support wikitext link editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550359 [00:29:11] (03CR) 10jerkins-bot: [V: 04-1] Support wikitext link editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550359 (owner: 10Esanders) [01:30:15] 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics (Kanban), 10VisualEditor (Current work): Investigate drop in mobile VE edit completion rate among unregistered users - https://phabricator.wikimedia.org/T237075 (10ppelberg) One potential explanation for the drop in edit completion rate among unregistered... [10:44:29] 10Cite, 10Book-Referencing, 10TCB-Team: Implement "extends"-attribute for ref-tag - https://phabricator.wikimedia.org/T151301 (10jeblad) Anyone working on this, or is it dead in the water? [10:53:45] 10Cite, 10Book-Referencing, 10TCB-Team: Implement "extends"-attribute for ref-tag - https://phabricator.wikimedia.org/T151301 (10thiemowmde) Yes: #wmde-qwerty-sprint-2019-11-06. [11:03:44] 10Cite, 10Book-Referencing, 10TCB-Team, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), and 3 others: Find a good name for new attribute in ref tag - https://phabricator.wikimedia.org/T171581 (10JStrodt_WMDE) [11:03:59] 10Cite, 10Book-Referencing, 10TCB-Team: Implement "extends"-attribute for ref-tag - https://phabricator.wikimedia.org/T151301 (10JStrodt_WMDE) [11:04:02] 10Cite, 10Book-Referencing, 10TCB-Team, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), and 3 others: Find a good name for new attribute in ref tag - https://phabricator.wikimedia.org/T171581 (10JStrodt_WMDE) 05Open→03Resolved [12:22:40] 10Cite, 10Book-Referencing, 10Spike: Spike: Bookreferencing implementation in cite extension - https://phabricator.wikimedia.org/T228997 (10awight) 05Open→03Resolved a:03awight [12:22:46] 10Cite, 10Book-Referencing, 10Community-Wishlist-Survey-2015, 10German-Community-Wishlist-Main-Wishes, 10TCB-Team (Oct2016-March2017): Efficient way to refer to different pages of the same work when adding references to an article (#17) - https://phabricator.wikimedia.org/T100645 (10awight) [12:29:57] 10VisualEditor, 10ContentTranslation, 10Language-Team (Language-2019-October-December): CX2: Support for references added by name when the details are inside a template - https://phabricator.wikimedia.org/T209266 (10Pginer-WMF) [12:30:57] 10VisualEditor, 10ContentTranslation, 10Language-Team (Language-2019-October-December): CX2: Support for references added by name when the details are inside a template - https://phabricator.wikimedia.org/T209266 (10Pginer-WMF) >>! In T209266#5643388, @Pginer-WMF wrote: > I'll update the description with a p... [12:48:46] 10Cite, 10Book-Referencing, 10Spike: Spike: Bookreferencing implementation in cite extension - https://phabricator.wikimedia.org/T228997 (10awight) [12:49:59] 10Cite, 10Book-Referencing, 10TCB-Team, 10WMDE-Design, 10Design: Error handling for "extends" parameter - https://phabricator.wikimedia.org/T151305 (10awight) [12:55:57] 10Cite, 10Book-Referencing, 10WMDE-QWERTY-Sprint-2019-10-23, 10WMDE-QWERTY-Sprint-2019-11-06: Implement basic book referencing - https://phabricator.wikimedia.org/T237241 (10awight) [12:57:44] 10Cite, 10Book-Referencing, 10WMDE-QWERTY-Sprint-2019-10-23, 10WMDE-QWERTY-Sprint-2019-11-06: Implement basic book referencing - https://phabricator.wikimedia.org/T237241 (10awight) Indentation could be split out into its own patches, if that makes the implementation easier. [13:08:32] 10Citoid, 10Wikimedia-Logstash: Citoid logs fields explosion - https://phabricator.wikimedia.org/T238083 (10fgiunchedi) [13:12:23] 10Citoid, 10Wikimedia-Logstash: Citoid logs fields explosion - https://phabricator.wikimedia.org/T238083 (10fgiunchedi) [13:20:20] 10VisualEditor, 10Uncyclomedia, 10I18n: VisualEditor should use its own message for the "Edit" tab - https://phabricator.wikimedia.org/T219056 (10Aklapper) [13:43:11] (03PS6) 10Esanders: Support wikitext link editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550359 [13:53:29] (03CR) 10jerkins-bot: [V: 04-1] Support wikitext link editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550359 (owner: 10Esanders) [13:54:18] (03PS6) 10Esanders: Generate internal links locally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550351 (https://phabricator.wikimedia.org/T147230) [13:54:22] (03PS7) 10Esanders: Support wikitext link editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550359 [13:54:24] (03PS1) 10Esanders: Add missing FragmentInspector tests to MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550469 [14:05:43] (03CR) 10jerkins-bot: [V: 04-1] Support wikitext link editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550359 (owner: 10Esanders) [15:15:17] (03CR) 10Jforrester: [C: 03+2] tests: Have MWDummyTarget create the correct surface type [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550361 (owner: 10Esanders) [15:15:19] (03CR) 10Jforrester: [C: 03+2] Add missing FragmentInspector tests to MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550469 (owner: 10Esanders) [15:19:03] (03CR) 10Jforrester: [C: 03+1] Generate internal links locally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550351 (https://phabricator.wikimedia.org/T147230) (owner: 10Esanders) [15:20:59] (03CR) 10Jforrester: [C: 03+1] Allow config to be passed to mock surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550360 (owner: 10Esanders) [15:21:47] (03CR) 10Jforrester: [C: 03+1] tests: Put FragmentInspector test runner in shared util [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550382 (owner: 10Esanders) [15:26:43] (03Merged) 10jenkins-bot: tests: Have MWDummyTarget create the correct surface type [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550361 (owner: 10Esanders) [15:27:40] (03Merged) 10jenkins-bot: Add missing FragmentInspector tests to MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550469 (owner: 10Esanders) [16:24:11] (due to the holiday, parsoid team meeting and engineering enclave conflict again this week) [18:49:33] 10VisualEditor-Links, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), 10Verified, 10VisualEditor (Current work): Vertical alignment regressions in desktop link contexts - https://phabricator.wikimedia.org/T237289 (10Ryasmeen) [18:50:51] 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10VisualEditor (Current work): Read-mode references pasted into VE via a third-party editor are not stripped - https://phabricator.wikimedia.org/T232461 (10Ryasmeen) [19:28:18] 10VisualEditor: Copied picture's description is split into two parts on some occasions - https://phabricator.wikimedia.org/T237812 (10matmarex) Link for reference: https://cs.wikipedia.org/wiki/Praha#Druhá_světová_válka I can reproduce this, note that you have to paste at the beginning of a paragraph that alrea... [19:28:31] 10VisualEditor: Copied picture's description is split into two parts on some occasions - https://phabricator.wikimedia.org/T237812 (10matmarex) [19:36:58] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10Regression, 10VisualEditor (Current work): Transition of MF expand icons when opening VE is wrong after icon updates - https://phabricator.wikimedia.org/T235692 (10Ryasmeen) [19:51:18] (03CR) 10Bartosz Dziewoński: [C: 03+2] tests: Put FragmentInspector test runner in shared util [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550382 (owner: 10Esanders) [19:51:21] (03CR) 10Bartosz Dziewoński: [C: 03+2] Allow config to be passed to mock surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550360 (owner: 10Esanders) [19:53:20] (03Merged) 10jenkins-bot: Allow config to be passed to mock surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550360 (owner: 10Esanders) [19:53:22] (03Merged) 10jenkins-bot: tests: Put FragmentInspector test runner in shared util [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550382 (owner: 10Esanders) [20:05:56] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Consider removing toolbar borders - https://phabricator.wikimedia.org/T231815 (10Ryasmeen) Checked the change using iPhone 5s and iPhone 6s. Looks good. [20:28:30] 10VisualEditor-EditingTools, 10Verified, 10VisualEditor (Current work): After replacing last match, still one match shown - https://phabricator.wikimedia.org/T226604 (10Ryasmeen) [20:35:38] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (12422dc27) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550541 [20:36:01] (03PS7) 10Bartosz Dziewoński: Generate internal links locally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550351 (https://phabricator.wikimedia.org/T147230) (owner: 10Esanders) [20:36:09] (03PS8) 10Bartosz Dziewoński: Support wikitext link editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550359 (owner: 10Esanders) [20:48:37] (03CR) 10Jforrester: [C: 03+1] "Good to go if you're happy with it; not C+2ing to avoid breaking your testing." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550541 (owner: 10Bartosz Dziewoński) [20:55:27] (03CR) 10Bartosz Dziewoński: [C: 03+2] Generate internal links locally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550351 (https://phabricator.wikimedia.org/T147230) (owner: 10Esanders) [20:55:31] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (12422dc27) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550541 (owner: 10Bartosz Dziewoński) [21:05:42] (03Merged) 10jenkins-bot: Update VE core submodule to master (12422dc27) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550541 (owner: 10Bartosz Dziewoński) [21:07:06] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: badtoken error on preview in new wikitext editor when you wait a few minutes - https://phabricator.wikimedia.org/T187747 (10matmarex) 05Open→03Resolved I can't reproduce this. Admittedly, instead of waiting a few minutes, I jus... [21:08:19] (03Merged) 10jenkins-bot: Generate internal links locally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550351 (https://phabricator.wikimedia.org/T147230) (owner: 10Esanders) [21:18:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Parser, 10Parsoid, 10User-Ryasmeen: [[?oldid=851713451]] is a valid link in the new preview, but not when the page is saved - https://phabricator.wikimedia.org/T201072 (10matmarex) 05Open→03Resolved I can't reproduce this proble... [22:14:38] 10VisualEditor: Error "Uncaught TypeError: Cannot read property 'getView' of null" appears while switching from one image to another inside Gallery dialog in VE - https://phabricator.wikimedia.org/T238159 (10Ryasmeen) [22:17:34] 10VisualEditor, 10Anti-Harassment, 10MediaWiki-User-management, 10Stewards-and-global-tools, and 2 others: Mobile block notice not showing block reason or block log entry for global blocks - https://phabricator.wikimedia.org/T233996 (10Niharika) @Tchanders Should we poke more people for code review on this? [22:21:43] 10VisualEditor: [Regression pre-wmf.6] Cannot create a new page on Beta cluster shows error "Error contacting the Parsoid/RESTBase server (HTTP 500)" - https://phabricator.wikimedia.org/T238161 (10Ryasmeen) [22:39:59] (03CR) 10Bartosz Dziewoński: Move more code to ArticleTargetSaver (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [22:49:09] 10VisualEditor, 10Math: Allow the VE dialog for math elements to be movable and resizable - https://phabricator.wikimedia.org/T59437 (10John_Broughton) https://ux.stackexchange.com/questions/81134/should-modal-dialogs-be-movable seems to show a (rough) consensus that when a proposed solution to a dialog is to... [22:52:51] (03CR) 10Bartosz Dziewoński: Move more code to ArticleTargetSaver (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [22:54:53] 10VisualEditor: [Regression pre-wmf.6] Cannot create a new page on Beta cluster shows error "Error contacting the Parsoid/RESTBase server (HTTP 500)" - https://phabricator.wikimedia.org/T238161 (10matmarex) Looks like {T237666}, but this page title doesn't have a slash. [22:55:22] 10VisualEditor: [Regression pre-wmf.6] Cannot create a new page on Beta cluster shows error "Error contacting the Parsoid/RESTBase server (HTTP 500)" - https://phabricator.wikimedia.org/T238161 (10matmarex) [22:56:20] 10VisualEditor: Error "Uncaught TypeError: Cannot read property 'getView' of null" appears while switching from one image to another inside Gallery dialog in VE - https://phabricator.wikimedia.org/T238159 (10matmarex) Seems to be the same error as T236949 [22:56:28] 10VisualEditor: Error "Uncaught TypeError: Cannot read property 'getView' of null" appears while switching from one image to another inside Gallery dialog in VE - https://phabricator.wikimedia.org/T238159 (10matmarex) [22:56:30] 10VisualEditor: Closing the Media/Gallery/Basic Reference dialog without closing the inspector inside it, throws error "Uncaught TypeError: Cannot read property 'getView' of nul" - https://phabricator.wikimedia.org/T236949 (10matmarex) [22:58:35] (03CR) 10Bartosz Dziewoński: [C: 04-1] Move more code to ArticleTargetSaver (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [22:59:26] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Otherwise, I think this is good to go, the changes look reasonable and I haven't found a case where anything blows up (although I'm sure w" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [23:10:48] (03PS1) 10Bartosz Dziewoński: ve.ui.TargetWidget: Avoid exception when destroying widgets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550573 (https://phabricator.wikimedia.org/T236949) [23:37:54] 10Editing-team, 10DiscussionTools, 10OWC2020: Replies v1.0: release replying to specific comments - https://phabricator.wikimedia.org/T235923 (10matmarex) >>! In T235923#5639667, @Jc86035 wrote: > I feel like it should be obvious that ideally a wikitext table should just work like it normally would? It //is/...