[00:56:13] (03PS10) 10Esanders: Move more code to ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 [00:56:15] (03CR) 10Esanders: Move more code to ArticleTargetSaver (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [00:56:54] (03Abandoned) 10Esanders: Remove never-used error code param from save request promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/549843 (owner: 10Esanders) [03:01:30] (03CR) 10Bartosz Dziewoński: "Thoughts on the method signatures?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [07:17:37] Hi everyone, any idea why would visual editor insert a link to an image from commons? The parameter looks like `link=https://cs.wikipedia.org...`. One example is https://cs.wikipedia.org/w/index.php?title=Findlater%C5%AFv_obelisk&oldid=17803382. Thanks! [10:05:27] (03PS14) 10Mvolz: Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) [10:05:49] (03PS15) 10Mvolz: Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) [10:06:53] (03CR) 10jerkins-bot: [V: 04-1] Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) (owner: 10Mvolz) [10:14:57] (03PS16) 10Mvolz: Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) [10:16:43] (03CR) 10Mvolz: Add support for items (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) (owner: 10Mvolz) [10:19:09] (03CR) 10jerkins-bot: [V: 04-1] Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) (owner: 10Mvolz) [10:21:28] (03PS17) 10Mvolz: Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) [10:25:45] (03CR) 10jerkins-bot: [V: 04-1] Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) (owner: 10Mvolz) [10:31:09] (03PS18) 10Mvolz: Add support for items [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) [10:48:19] 10Citoid: Citoid unable to parse ISO dates with punctuation missing in date and/or time - https://phabricator.wikimedia.org/T178586 (10Mvolz) a:05Mvolz→03None [11:01:42] (03PS1) 10Mvolz: Refractor zoteroProperties to nonEntityProperties [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/550821 [11:02:17] (03PS2) 10Mvolz: Refractor zoteroProperties to nonEntityProperties [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/550821 [11:45:54] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Months missing leading 0 (e.g. "2018-7") from citoid - https://phabricator.wikimedia.org/T234420 (10mobrovac) [12:04:22] 10Cite, 10Editing-team, 10Book-Referencing, 10MediaWiki-API, 10WMDE-QWERTY-Team: Check ApiQueryReferences compatibility with extended references - https://phabricator.wikimedia.org/T238195 (10thiemowmde) Wow, that's an incredibly helpful response. Thanks a lot! I tested the API locally. This is how the... [13:14:49] (03CR) 10Kosta Harlan: [C: 03+1] "Looks good but haven't had a chance to manually test it." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/550746 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope) [13:15:31] (03CR) 10Kosta Harlan: [C: 03+1] EditAttemptStep: Allow session ID override from query string or mw.config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550745 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope) [14:28:59] (03CR) 10Esanders: "I suppose we could throw a deprecation warning if a callback is passed.." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [14:35:24] (03PS11) 10Esanders: Move more code to ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 [14:39:06] 10TemplateData, 10VisualEditor, 10I18n, 10RTL: In TemplateData editor, set the direction of the template and parameter descriptions according to the selected language - https://phabricator.wikimedia.org/T238329 (10Amire80) [14:43:45] 10TemplateData, 10VisualEditor, 10I18n: In TemplateData editor, show a source language when writing template and parameter descriptions in a new language - https://phabricator.wikimedia.org/T238330 (10Amire80) [14:55:46] 10VisualEditor, 10Regression: Retried-load results in document showing twice - https://phabricator.wikimedia.org/T238332 (10Esanders) [14:55:53] (03CR) 10Lucas Werkmeister (WMDE): Add support for items (037 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/525082 (https://phabricator.wikimedia.org/T235788) (owner: 10Mvolz) [14:57:01] 10VisualEditor, 10Regression: Retried-load results in document showing twice - https://phabricator.wikimedia.org/T238332 (10Esanders) Looks like the `ve-active` class isn't added to the body. This is the one that hides the read article. [14:59:40] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] "I think this makes sense, since entityIdentifyingProperties (from If409b0cbe2, “Add support for items”) also has Zotero properties in the " [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/550821 (owner: 10Mvolz) [15:08:37] 10VisualEditor, 10Regression: Retried-load results in document showing twice - https://phabricator.wikimedia.org/T238332 (10Esanders) [15:18:32] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-MediaWiki: VE still explicitely blacklists Opera < 12 - https://phabricator.wikimedia.org/T225600 (10Esanders) JS appears to still be running in Opera 12, and even 11, so either our matrix is wrong or the feature check is wrong. CC @Krinkle {F31... [15:20:17] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: Pages protected against creation show a wrong message about loading the editor - https://phabricator.wikimedia.org/T184786 (10Esanders) 05Open→03Resolved a:03Esanders The editor now loads corr... [15:24:02] (03PS1) 10Esanders: Don't reject activatingDeferred on loadFail [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550858 (https://phabricator.wikimedia.org/T238332) [15:56:26] 10VisualEditor, 10VisualEditor-Initialisation: VE plugins from user scripts not always loaded - https://phabricator.wikimedia.org/T157113 (10Esanders) I'm not sure it would be a good idea to run plugins that are loaded after target init. Plugins is designed to run before target init, and some plugins may depen... [16:35:46] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: Pasting formatted code at the end of a paragraph breaks cursor positioning - https://phabricator.wikimedia.org/T158170 (10Esanders) 05Stalled→03Resolved a:03Esanders We removed a bunch of annotatio... [16:38:29] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): 2017WTE loses focus after making a link - https://phabricator.wikimedia.org/T222249 (10Esanders) 05Open→03Resolved a:03Esanders Please re-open if you can reproduce. [16:44:15] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-MediaWiki-Links, 10MediaWiki-General: Percent-encoding stops link from working - https://phabricator.wikimedia.org/T180511 (10Esanders) The link `[[Stadskanaal#/maplink/1]]` does take me to the correct page. Can you still reproduce... [16:49:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: Using Undo after inserting formatted element resets cursor - https://phabricator.wikimedia.org/T191566 (10Esanders) 05Open→03Resolved a:03Esanders Assume this was fixed in the last two years. Please reopen if you can reproduce. [17:03:56] 10Editing-team, 10Editing Design, 10OWC2020: Determine target wiki selection criteria - https://phabricator.wikimedia.org/T233760 (10ppelberg) 05Open→03Resolved >>! In T233760#5627894, @ppelberg wrote: > @MNeisler, I'm going to leave this task open until you've given your final sign-off...I'm wanting to... [17:03:59] 10Editing-team, 10OWC2020, 10VisualEditor (Current work): Determine target wikis for project - https://phabricator.wikimedia.org/T233627 (10ppelberg) [17:04:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: Issues with 2017 editor and Grammarly - https://phabricator.wikimedia.org/T167019 (10Esanders) 05Stalled→03Resolved a:03Esanders Grammarly should be disabled on VE surfaces (at least wikitext mode) [17:05:00] 10Editing-team, 10Editing Design, 10OWC2020: Determine target wiki selection criteria - https://phabricator.wikimedia.org/T233760 (10ppelberg) [17:12:06] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Internet-Explorer: In 2017 WikiEditor, dragging and dropping and/or performing IE11's "Undo" action lead to weird results - https://phabricator.wikimedia.org/T190686 (10matmarex) I can reproduce this, this may be a similar problem... [17:23:23] 10Editing-team, 10OWC2020: Consult communities about participating as "target wikis" - https://phabricator.wikimedia.org/T233761 (10ppelberg) a:05ppelberg→03Whatamidoing-WMF [17:40:58] 10VisualEditor, 10MediaWiki-Page-editing, 10MinervaNeue, 10Mobile, 10Readers-Web-Backlog (Tracking): Transcluded section edit links are broken in Minerva - https://phabricator.wikimedia.org/T198011 (10ppelberg) Talked with @ovasileva. We agreed this is not a priority for either of our teams. We'll keep b... [17:41:46] 10VisualEditor: ve.ce.TableEnterKeyDownHandler unit test failing on Mac - https://phabricator.wikimedia.org/T238351 (10marcella) [17:58:19] 10VisualEditor, 10MediaWiki-Page-editing, 10MinervaNeue, 10Mobile, 10Readers-Web-Backlog (Tracking): Transcluded section edit links are broken in Minerva - https://phabricator.wikimedia.org/T198011 (10Masumrezarock100) [17:59:34] (03PS2) 10DLynch: [WIP] Completion framework [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/540436 (https://phabricator.wikimedia.org/T232601) [18:03:16] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Completion framework [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/540436 (https://phabricator.wikimedia.org/T232601) (owner: 10DLynch) [18:03:40] (03PS2) 10DLynch: Completion framework [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/540437 (https://phabricator.wikimedia.org/T232601) [18:03:42] (03PS1) 10DLynch: [WIP] Username completion action, split out [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550897 (https://phabricator.wikimedia.org/T232601) [18:05:46] (03PS3) 10DLynch: [WIP] Completion framework [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/540436 (https://phabricator.wikimedia.org/T232601) [18:05:52] (03CR) 10jerkins-bot: [V: 04-1] Completion framework [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/540437 (https://phabricator.wikimedia.org/T232601) (owner: 10DLynch) [18:05:54] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Username completion action, split out [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550897 (https://phabricator.wikimedia.org/T232601) (owner: 10DLynch) [18:31:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: Issues with template parameters - https://phabricator.wikimedia.org/T156507 (10matmarex) 05Stalled→03Resolved Maybe it was T156498, maybe T154382, impossible to tell from the video. It definitely looks fixed. [18:33:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design: Consider using colour/etc. to denote that tabs displayed as arrows / newlines as returns are not the raw Unicode character - https://phabricator.wikimedia.org/T153434 (10matmarex) >>! In T153434#2991146, @Whata... [18:46:12] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: New wikitext editor should not display uneditable page content - https://phabricator.wikimedia.org/T188186 (10matmarex) 05Open→03Resolved a:03matmarex This was fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Vi... [18:58:56] (03PS1) 10Marcella L. Florence: ve.ce.TableEnterKeyDownHandler: unit test failing on Mac [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550908 (https://phabricator.wikimedia.org/T238351) [18:58:58] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550908 (https://phabricator.wikimedia.org/T238351) (owner: 10Marcella L. Florence) [19:00:40] (03CR) 10jerkins-bot: [V: 04-1] ve.ce.TableEnterKeyDownHandler: unit test failing on Mac [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550908 (https://phabricator.wikimedia.org/T238351) (owner: 10Marcella L. Florence) [19:07:12] 10VisualEditor, 10VisualEditor-ContentEditable: VE: Firefox doesn't break lines after arrow indicating linebreak - https://phabricator.wikimedia.org/T155619 (10matmarex) This is still a problem (and it affects all browsers). That page changed, so you have to test with this old revision: https://de.wikipedia.or... [19:10:39] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Make page title selectable - https://phabricator.wikimedia.org/T156047 (10matmarex) a:03matmarex This was filed again as T214790 and implemented! We haven't notice that this task already existed. I'll close it as a duplicate. [19:10:48] 10VisualEditor-MediaWiki, 10Verified, 10VisualEditor (Current work): Allow selection of the page title in Visual Editor - https://phabricator.wikimedia.org/T214790 (10matmarex) [19:10:51] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Make page title selectable - https://phabricator.wikimedia.org/T156047 (10matmarex) [19:11:07] (03PS3) 10Catrope: EditAttemptStep: Allow session ID to be overridden through query string [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/550746 (https://phabricator.wikimedia.org/T238249) [19:11:47] 10VisualEditor, 10VisualEditor-MediaWiki: Clicking the page's title h1 should give feedback as to why it is not editable - https://phabricator.wikimedia.org/T89811 (10matmarex) >>! In T89811#3129871, @Jdforrester-WMF wrote: > At most one of this task, {T156047}, and {T159914} can feasibly be done. Which? T156... [19:12:53] (03CR) 10Tchanders: ve.ce.TableEnterKeyDownHandler: unit test failing on Mac (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550908 (https://phabricator.wikimedia.org/T238351) (owner: 10Marcella L. Florence) [19:13:00] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Clicking on the page title should reactivate the Visual editor - https://phabricator.wikimedia.org/T159914 (10matmarex) >>! In T159914#3129869, @Jdforrester-WMF wrote: > At most one of this task, {T156047}, and {T89811} can feasibly be done. Which? T1560... [19:52:21] (03CR) 10Esanders: "Inside the test runner ve.test.utils.runSurfaceHandleSpecialKeyTest (defined in ve.ce.Surface.test.js) we build a fake event objection bas" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550908 (https://phabricator.wikimedia.org/T238351) (owner: 10Marcella L. Florence) [19:52:34] (03CR) 10Esanders: [C: 04-1] ve.ce.TableEnterKeyDownHandler: unit test failing on Mac [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550908 (https://phabricator.wikimedia.org/T238351) (owner: 10Marcella L. Florence) [20:10:24] 10Cite, 10Book-Referencing: Nicer error handling for broken Cite references - https://phabricator.wikimedia.org/T238061 (10Aklapper) @awight: Assuming this task is about #Cite, hence adding project tag so others can find this task when searching for tasks under that project or looking at that project workboard... [20:52:35] 10Editing-team, 10OWC2020, 10VisualEditor (Current work): Determine target wikis for project - https://phabricator.wikimedia.org/T233627 (10ppelberg) [21:05:59] 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics (Kanban), 10VisualEditor (Current work): Analyze mobile VE edit completion rate for "Quarter in Review" - https://phabricator.wikimedia.org/T236860 (10ppelberg) 05Open→03Resolved Resolving this task as this analysis is what we needed for the, "Product... [21:13:45] (03CR) 10Bartosz Dziewoński: [C: 03+2] Move more code to ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [21:26:26] (03Merged) 10jenkins-bot: Move more code to ArticleTargetSaver [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/548296 (owner: 10Esanders) [21:58:01] (03PS1) 10Esanders: Disable whitespace replacement in source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/550952 (https://phabricator.wikimedia.org/T153434) [21:58:28] (03CR) 10Catrope: EditAttemptStep: Allow session ID to be overridden through query string (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/550746 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope) [22:29:47] (03CR) 10Kosta Harlan: [C: 03+1] EditAttemptStep: Allow session ID to be overridden through query string [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/550746 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope) [22:35:58] (03PS1) 10Esanders: Set tab-size to 4 in TempWikitextEditorWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550962 [22:36:25] (03PS2) 10Esanders: Set tab-size to 4 in TempWikitextEditorWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550962