[01:18:54] <wikibugs>	 (03PS3) 10Catrope: EditAttemptStep: Allow session ID override from query string or mw.config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550745 (https://phabricator.wikimedia.org/T238249)
[01:24:40] <wikibugs>	 (03PS1) 10Catrope: Unbreak instrumentation of init events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551696
[01:44:31] <wikibugs>	 10Cite, 10Contributors-Team, 10Growth-Team, 10MediaWiki-Configuration, and 5 others: Support listing modules in extension.json that are registered if another extension is installed - https://phabricator.wikimedia.org/T128012 (10Florian) Getting this again out of the history again :D How would such a functi...
[02:12:35] <wikibugs>	 (03CR) 10Bartosz Dziewoński: [C: 03+2] Unbreak instrumentation of init events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551696 (owner: 10Catrope)
[02:24:59] <wikibugs>	 (03Merged) 10jenkins-bot: Unbreak instrumentation of init events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551696 (owner: 10Catrope)
[06:27:48] <wikibugs>	 (03PS1) 10Catrope: Unbreak instrumentation of init events [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551726
[08:43:07] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Merged already on master." [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551726 (owner: 10Catrope)
[09:36:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Wikimedia-User-Group-Basque, 10Design, and 2 others: VisualEditor: Provide some kind of template suggestion in the transclusion editor - https://phabricator.wikimedia.org/T55590 (10Theklan) Any clue on this?
[12:45:09] <wikibugs>	 (03CR) 10Kosta Harlan: [C: 03+1] EditAttemptStep: Allow session ID override from query string or mw.config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550745 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope)
[13:01:08] <wikibugs>	 10Editing-team, 10DiscussionTools, 10OWC2020: Replies v1.0: release replying to specific comments - https://phabricator.wikimedia.org/T235923 (10ppelberg)
[13:02:35] <wikibugs>	 10Editing-team, 10DiscussionTools, 10OWC2020: Replies v1.0: release replying to specific comments - https://phabricator.wikimedia.org/T235923 (10ppelberg) **Updating task description** - Adding questions that surfaced in T235592 (thank you @Alsee for the input you shared, specifically [these](https://en.wiki...
[14:06:54] <wikibugs>	 (03CR) 10DLynch: [C: 03+2] EditAttemptStep: Allow session ID override from query string or mw.config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550745 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope)
[14:19:46] <wikibugs>	 (03Merged) 10jenkins-bot: EditAttemptStep: Allow session ID override from query string or mw.config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550745 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope)
[15:55:08] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry)
[15:56:31] <wikibugs>	 (03CR) 10Esanders: [C: 03+2] Remove unused message 'visualeditor-loaderror-title' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551647 (owner: 10Bartosz Dziewoński)
[15:57:52] <wikibugs>	 (03CR) 10Esanders: [C: 03+2] ApiVisualEditorEdit: Simplify diff handling a bit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551648 (owner: 10Bartosz Dziewoński)
[15:58:50] <wikibugs>	 (03CR) 10Esanders: [C: 04-1] ArticleTargetSaver: Fix handling for `data.result !== 'success'` (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551649 (owner: 10Bartosz Dziewoński)
[16:00:12] <wikibugs>	 (03CR) 10Esanders: [C: 04-1] ArticleTargetSaver: Fix handling for `data.result !== 'success'` (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551649 (owner: 10Bartosz Dziewoński)
[16:09:13] <wikibugs>	 (03Merged) 10jenkins-bot: Remove unused message 'visualeditor-loaderror-title' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551647 (owner: 10Bartosz Dziewoński)
[16:09:17] <wikibugs>	 (03Merged) 10jenkins-bot: ApiVisualEditorEdit: Simplify diff handling a bit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551648 (owner: 10Bartosz Dziewoński)
[18:03:38] <wikibugs>	 (03CR) 10Catrope: [C: 03+2] Unbreak instrumentation of init events [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551726 (owner: 10Catrope)
[18:15:25] <wikibugs>	 (03Merged) 10jenkins-bot: Unbreak instrumentation of init events [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551726 (owner: 10Catrope)
[18:24:04] <wikibugs>	 (03PS2) 10Bartosz Dziewoński: ArticleTargetSaver: Fix handling for `data.result !== 'success'` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551649
[18:56:23] <wikibugs>	 10Editing-team, 10serviceops, 10Beta-Cluster-reproducible, 10Core Platform Team Legacy (Watching / External), 10Services (next): Zotero container: Production is running candidate version, last production version is broken due to lack of ca-certificates package - https://phabricator.wikimedia.org/T223345 (...
[19:15:06] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry)
[19:24:08] <wikibugs>	 (03PS3) 10Bartosz Dziewoński: ArticleTargetSaver: Fix handling for `data.result !== 'success'` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551649
[19:24:36] <wikibugs>	 (03CR) 10Bartosz Dziewoński: ArticleTargetSaver: Fix handling for `data.result !== 'success'` (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551649 (owner: 10Bartosz Dziewoński)
[19:24:51] <wikibugs>	 (03PS2) 10Bartosz Dziewoński: Localize some hardcoded English error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551650 (https://phabricator.wikimedia.org/T227325)
[19:26:34] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Localize some hardcoded English error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551650 (https://phabricator.wikimedia.org/T227325) (owner: 10Bartosz Dziewoński)
[19:53:47] <wikibugs>	 10VisualEditor, 10SyntaxHighlight: Syntax highlighting moves cursor out from the actual writing place when using New Wikitext Mode at euwiki - https://phabricator.wikimedia.org/T238678 (10Theklan)
[19:56:30] <wikibugs>	 (03PS3) 10Bartosz Dziewoński: Localize some hardcoded English error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551650 (https://phabricator.wikimedia.org/T227325)
[19:56:32] <wikibugs>	 (03PS1) 10Bartosz Dziewoński: MWSaveDialog: Fix error handling for diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551912
[19:56:34] <wikibugs>	 (03PS1) 10Bartosz Dziewoński: ApiVisualEditorEdit: Simplify diff handling a bit more! [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551913
[20:07:49] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Localize some hardcoded English error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551650 (https://phabricator.wikimedia.org/T227325) (owner: 10Bartosz Dziewoński)
[20:09:56] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] ApiVisualEditorEdit: Simplify diff handling a bit more! [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551913 (owner: 10Bartosz Dziewoński)
[20:10:03] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] MWSaveDialog: Fix error handling for diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551912 (owner: 10Bartosz Dziewoński)
[20:24:06] <wikibugs>	 (03PS4) 10Bartosz Dziewoński: Localize some hardcoded English error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551650 (https://phabricator.wikimedia.org/T227325)
[20:24:18] <wikibugs>	 (03PS2) 10Bartosz Dziewoński: MWSaveDialog: Fix error handling for diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551912
[20:24:27] <wikibugs>	 (03PS2) 10Bartosz Dziewoński: ApiVisualEditorEdit: Simplify diff handling a bit more! [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551913
[20:25:48] <wikibugs>	 (03PS3) 10Bartosz Dziewoński: MWSaveDialog: Fix error handling for diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551912
[20:25:56] <wikibugs>	 (03PS3) 10Bartosz Dziewoński: ApiVisualEditorEdit: Simplify diff handling a bit more! [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551913
[20:56:57] <wikibugs>	 (03CR) 10Esanders: [C: 03+2] ArticleTargetSaver: Fix handling for `data.result !== 'success'` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551649 (owner: 10Bartosz Dziewoński)
[21:00:54] <wikibugs>	 (03CR) 10Esanders: [C: 03+2] Localize some hardcoded English error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551650 (https://phabricator.wikimedia.org/T227325) (owner: 10Bartosz Dziewoński)
[21:09:23] <wikibugs>	 (03CR) 10Esanders: [C: 04-1] MWSaveDialog: Fix error handling for diffs (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551912 (owner: 10Bartosz Dziewoński)
[21:12:22] <wikibugs>	 (03CR) 10Esanders: [C: 03+2] ApiVisualEditorEdit: Simplify diff handling a bit more! [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551913 (owner: 10Bartosz Dziewoński)
[21:18:02] <wikibugs>	 (03Merged) 10jenkins-bot: ArticleTargetSaver: Fix handling for `data.result !== 'success'` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551649 (owner: 10Bartosz Dziewoński)
[21:18:05] <wikibugs>	 (03Merged) 10jenkins-bot: Localize some hardcoded English error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551650 (https://phabricator.wikimedia.org/T227325) (owner: 10Bartosz Dziewoński)
[21:19:37] <wikibugs>	 (03PS1) 10Catrope: EditAttemptStep: Allow session ID override from query string or mw.config [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551925 (https://phabricator.wikimedia.org/T238249)
[21:20:08] <wikibugs>	 (03PS1) 10Catrope: EditAttemptStep: Allow session ID to be overridden through query string [extensions/WikiEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551927 (https://phabricator.wikimedia.org/T238249)
[21:46:46] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) Okay, looks like this is readily reproducible with [[https://test.wikipedia.org/wiki/User:SSastry_(WMF)/sandbox|a simple wikitext string]] which is `<font face="Gotic" size="3">foo</font>`....
[22:02:28] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) Here isa dump of Parsoid generated HTML from those 2 wikis with the <head> stripped. For test.wikipedia.org, I fetch from Parsoid/PHP. For en.wikipedia.org, I fetch from Parsoid/JS. As you se...
[22:17:52] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) Here is a dump of Parsoid-generated HML as fetched by RESTBase for these two pages. I've stripped out the header from both. They are identical as before. And, the `<font>` attributes are in t...
[22:21:35] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) And, now here is the dump of HTML that VE loads. (Obained by following instructions @ https://www.mediawiki.org/wiki/Parsoid/Debugging#Dumping_HTML_DOM_in_VE ) From en.wikipedia.org: ` <body...
[22:38:08] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) This transcript below simulates the effect of VE's reordering. And, mysteriously enough, Parsoid/JS hides the reordering whereas Parsoid/PHP does not. Okay, now to figure out whether this is...
[22:38:23] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) a:03ssastry
[22:39:51] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) @Esanders @matmarex @DLynch why does VE reorder attributes on the `<font>` tag? Or is this a more general thing that is happening with VE when it loads the Parsoid DOM? Is this accidental and...
[22:48:14] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) >>! In T238665#5676688, @ssastry wrote: > @Esanders @matmarex @DLynch why does VE reorder attributes on the `<font>` tag? Or is this a more general thing that is happening with VE when it loa...
[22:56:05] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) So, indeed, Parsoid/JS disregards the ordering differences between the two whereas Parsoid/PHP doesn't. See DOM diff output below. So, this does indeed turn out to be a dom-diffing issue as s...
[23:07:00] <wikibugs>	 (03CR) 10Catrope: [C: 03+2] EditAttemptStep: Allow session ID to be overridden through query string [extensions/WikiEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551927 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope)
[23:07:02] <wikibugs>	 (03CR) 10Catrope: [C: 03+2] EditAttemptStep: Allow session ID override from query string or mw.config [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551925 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope)
[23:09:14] <wikibugs>	 10VisualEditor, 10Parsoid-PHP: Dirty diff on test.wikipedia.org - https://phabricator.wikimedia.org/T238665 (10ssastry) Looks like we have had code to ignore attribute order during DOM diffing since April 2013 ( first introduced in [[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Parsoid/+/59151/4/js/li...
[23:19:38] <wikibugs>	 (03Merged) 10jenkins-bot: EditAttemptStep: Allow session ID to be overridden through query string [extensions/WikiEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551927 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope)
[23:19:56] <wikibugs>	 (03Merged) 10jenkins-bot: EditAttemptStep: Allow session ID override from query string or mw.config [extensions/VisualEditor] (wmf/1.35.0-wmf.5) - 10https://gerrit.wikimedia.org/r/551925 (https://phabricator.wikimedia.org/T238249) (owner: 10Catrope)