[00:11:34] 10VisualEditor, 10VisualEditor-Tables: Enhance the VisualEditor table editor to allow sorting and saving sorted content - https://phabricator.wikimedia.org/T240114 (10Timeshifter) Related help, info, and discussions: *https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Initial_table_sort *https:/... [00:13:07] 10VisualEditor, 10VisualEditor-Tables: Enhance the VisualEditor table editor to allow sorting and saving sorted content - https://phabricator.wikimedia.org/T240114 (10Xaosflux) See also https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=929902219#Initial_table_sort [08:26:39] 10Cite: New references group is not immediately available in VisualEditor - https://phabricator.wikimedia.org/T240184 (10awight) [08:38:26] 10Cite, 10Book-Referencing, 10Epic: Don't break Cite VisualEditor integration - https://phabricator.wikimedia.org/T240186 (10awight) [08:44:49] 10Cite, 10Book-Referencing, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10WMDE-QWERTY-Sprint-2019-11-20: Implement basic book referencing - https://phabricator.wikimedia.org/T237241 (10awight) We've hit a lot of numbering issues already, I'll just do this here rather than create a new task. On current `m... [09:00:04] 10Cite, 10Book-Referencing, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10Patch-For-Review, 10WMDE-QWERTY-Sprint-2019-11-20: Implement basic book referencing - https://phabricator.wikimedia.org/T237241 (10awight) >>! In T237241#5722632, @awight wrote: > We've hit a lot of numbering issues already, I'll... [09:14:38] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Browser-Support-Firefox, and 3 others: Reference numbers wrong in Firefox when following a list - https://phabricator.wikimedia.org/T229307 (10thiemowmde) [09:28:47] 10Cite, 10Book-Referencing, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10Patch-For-Review, 10WMDE-QWERTY-Sprint-2019-11-20: Implement basic book referencing - https://phabricator.wikimedia.org/T237241 (10awight) [10:02:48] 10Cite, 10Book-Referencing, 10Documentation, 10WMDE-QWERTY-Sprint-2019-11-20: Improve on-wiki documentation for Cite features - https://phabricator.wikimedia.org/T237631 (10awight) a:03awight [10:04:11] 10Cite, 10Book-Referencing, 10TCB-Team, 10WMDE-Design, and 4 others: Error handling for "extends" parameter - https://phabricator.wikimedia.org/T151305 (10awight) a:03thiemowmde [10:06:03] 10Cite, 10Book-Referencing, 10WMDE-Design, 10Design, 10WMDE-QWERTY-Sprint-2019-11-20: [Design] How should book references appear when reused? - https://phabricator.wikimedia.org/T239329 (10awight) We did this, which might be good enough for now: {F31463587} [10:44:16] 10Citoid, 10Core Platform Team Workboards (Clinic Duty Team): Citoid is logging all request / response headers as separate fields - https://phabricator.wikimedia.org/T239713 (10mobrovac) [12:11:20] 10Cite, 10Book-Referencing, 10WMDE-Design, 10Design, 10WMDE-QWERTY-Sprint-2019-11-20: [Design] How should book references appear when reused? - https://phabricator.wikimedia.org/T239329 (10WMDE-Fisch) I might totally ignore discussions that happened about this, that I am not aware of atm, but in the orig... [12:14:20] 10Cite, 10Book-Referencing, 10WMDE-Design, 10Design, 10WMDE-QWERTY-Sprint-2019-11-20: [Design] How should book references appear when reused? - https://phabricator.wikimedia.org/T239329 (10JStrodt_WMDE) Is it specific per wiki whether they use numbers or letters? [12:41:10] 10Cite, 10Book-Referencing, 10TCB-Team, 10WMDE-Design, and 4 others: Error handling for "extends" parameter - https://phabricator.wikimedia.org/T151305 (10awight) Merged patch should have been tagged here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cite/+/555901/ [12:42:18] 10Cite, 10Book-Referencing, 10TCB-Team, 10WMDE-Design, and 4 others: Error handling for "extends" parameter - https://phabricator.wikimedia.org/T151305 (10awight) I think we should forbid `extends` inside the references tag. * On a technical level, see parser test "Extends defined in ca... [12:42:40] 10Cite, 10Book-Referencing, 10TCB-Team, 10WMDE-Design, and 4 others: More edge case handling for "extends" parameter - https://phabricator.wikimedia.org/T151305 (10awight) [13:28:35] 10VisualEditor, 10VisualEditor-EditingTools, 10Accessibility, 10User-Ryasmeen: VisualEditor: Template editor is missing accessibility features - https://phabricator.wikimedia.org/T67474 (10Aklapper) [14:06:14] 10Cite, 10Book-Referencing, 10WMDE-Design, 10Design, 10WMDE-QWERTY-Sprint-2019-11-20: [Design] How should book references appear when reused? - https://phabricator.wikimedia.org/T239329 (10awight) >>! In T239329#5723183, @JStrodt_WMDE wrote: > Is it specific per wiki whether they use numbers or letters?... [14:12:58] 10Cite, 10Book-Referencing, 10Documentation, 10WMDE-QWERTY-Sprint-2019-11-20: Improve on-wiki documentation for Cite features - https://phabricator.wikimedia.org/T237631 (10awight) [14:24:16] 10VisualEditor, 10DiscussionTools, 10OWC2020: [Pre-deployment testing] Clicking on edit on "Talk:Reply test" page, gives error "Uncaught TypeError: Cannot read property 'range' of undefined" - https://phabricator.wikimedia.org/T239873 (10Esanders) We need to avoid running the code on edit pages. [14:51:33] 10Editing-team, 10Editing Design, 10OWC2020: Conduct a control test of as-is reply workflow - https://phabricator.wikimedia.org/T239175 (10iamjessklein) I ran the second test on usertesting.com on November 28, 2019 - [CT 6-10] This is a control test. We tested a discussion page on beta. In contrast to the f... [14:52:03] (03CR) 10Esanders: "You should not be surprised. Only +1?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/554128 (owner: 10Esanders) [14:52:28] 10Editing-team, 10Editing Design, 10OWC2020: Conduct a control test of as-is reply workflow - https://phabricator.wikimedia.org/T239175 (10iamjessklein) [14:54:03] 10Editing-team, 10Editing Design, 10OWC2020: Conduct a control test of as-is reply workflow - https://phabricator.wikimedia.org/T239175 (10iamjessklein) a:05iamjessklein→03ppelberg @ppelberg these two control tests are concluded. I am reassigning this ticket over to you - to make sure that the findings... [14:55:03] (03PS3) 10Esanders: WIP: NWE: Always paste rich text as plain, and show context item to convert [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 [15:04:59] 10Cite, 10Book-Referencing: Remove almost all uses of recursiveTagParse from Cite - https://phabricator.wikimedia.org/T239572 (10awight) @Lucas_Werkmeister_WMDE helped find this tool to review overridden error messages. We can use fine-tuned regexes to quickly check for specific content. {P9838} [15:12:29] 10Cite, 10Book-Referencing, 10WMDE-Design, 10Design, 10WMDE-QWERTY-Sprint-2019-11-20: [Design] How should book references appear when reused? - https://phabricator.wikimedia.org/T239329 (10thiemowmde) Yea, this is per-wiki configuration. For most wikis we get "a", "b", and so on. There is not much we nee... [17:21:38] 10VisualEditor, 10DiscussionTools, 10OWC2020: [Pre-deployment testing] Retaining draft comments/replies - https://phabricator.wikimedia.org/T239966 (10Esanders) Given the page can be reloaded we would need to implement LocalStorage/SessionStorage based auto-save to support that. [17:21:42] 10Cite, 10Book-Referencing: Remove almost all uses of recursiveTagParse from Cite - https://phabricator.wikimedia.org/T239572 (10awight) Here's a WIP patch once we verify that the error messages can be parsed more simply? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cite/+/552019/ [17:31:39] (03PS2) 10Esanders: mediasurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/552149 (owner: 10Bartosz Dziewoński) [17:33:04] (03PS2) 10Esanders: mediasurface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/552150 (owner: 10Bartosz Dziewoński) [17:43:44] (03CR) 10jerkins-bot: [V: 04-1] mediasurface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/552150 (owner: 10Bartosz Dziewoński) [17:51:44] (03CR) 10Esanders: [C: 04-1] "The issue here is you are only sharing the DM doc, which is just a state snapshot. The DM surface is the document+transactions." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/552150 (owner: 10Bartosz Dziewoński) [18:10:18] 10Cite, 10Wikimedia-production-error: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php - https://phabricator.wikimedia.org/T240248 (10brennen) [18:10:32] 10Cite, 10Wikimedia-production-error: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php - https://phabricator.wikimedia.org/T240248 (10brennen) p:05Triage→03Unbreak! [18:10:51] 10Cite, 10Wikimedia-production-error: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php - https://phabricator.wikimedia.org/T240248 (10brennen) [18:11:31] 10Cite, 10Wikimedia-production-error: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php - https://phabricator.wikimedia.org/T240248 (10brennen) [18:12:52] 10Cite, 10Wikimedia-production-error: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php - https://phabricator.wikimedia.org/T240248 (10brennen) [18:20:53] (03PS1) 10SD0001: Make getRawParams() ignore parameters in comments and nowiki tags [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/556011 (https://phabricator.wikimedia.org/T237195) [18:20:55] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/556011 (https://phabricator.wikimedia.org/T237195) (owner: 10SD0001) [18:23:09] 10Cite, 10Wikimedia-production-error: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php - https://phabricator.wikimedia.org/T240248 (10Jdforrester-WMF) https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Cite/+/wmf/1.35.0-wmf.8/src/Cite.php#635 for the code that... [18:30:15] 10Cite, 10WMDE-QWERTY-Sprint-2019-11-20, 10Wikimedia-production-error: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php - https://phabricator.wikimedia.org/T240248 (10awight) [18:33:40] 10TemplateData, 10VisualEditor, 10MediaWiki-API, 10Patch-For-Review: Templatedata API includes parameters that only exist within comments (for templates mising templatedata) - https://phabricator.wikimedia.org/T237195 (10SD0001) @JTannerWMF I have written a patch for this. It is fairly simple. Could you r... [19:26:50] 10VisualEditor, 10Product-Analytics (Kanban): VE mobile default: analyze A/B test results - https://phabricator.wikimedia.org/T221198 (10MNeisler) Moving to blocked pending completion of AB test rerun. [19:46:29] 10Editing-team, 10OWC2020, 10VisualEditor (Current work): [Spike] How do we have a test instance that supports a relatively larger number of people testing prototypes? - https://phabricator.wikimedia.org/T240063 (10ppelberg) [19:58:38] 10VisualEditor, 10DiscussionTools, 10OWC2020: [Pre-deployment testing] Retaining draft comments/replies - https://phabricator.wikimedia.org/T239966 (10ppelberg) Great spot, @Ryasmeen. I think it's reasonable to expect drafted comments to remain "intact" even after a comment has been posted. To Ed's point... [19:59:46] 10VisualEditor, 10DiscussionTools, 10OWC2020: QA Replying v1.0 on prototype server - https://phabricator.wikimedia.org/T239961 (10ppelberg) [19:59:48] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: conduct usability testing - https://phabricator.wikimedia.org/T236921 (10ppelberg) [20:05:19] 10Editing-team, 10DiscussionTools, 10OWC2020: Build auto-save - https://phabricator.wikimedia.org/T240257 (10ppelberg) [20:07:28] 10Editing-team, 10DiscussionTools, 10OWC2020: Build auto-save - https://phabricator.wikimedia.org/T240257 (10ppelberg) [20:08:30] 10Editing-team, 10Project-Admins, 10Developer-Advocacy (Oct-Dec 2019), 10PM: Sort out #Editing-Team vs #VisualEditor Phabricator project tags - https://phabricator.wikimedia.org/T234648 (10Aklapper) [20:11:46] 10Editing-team, 10OWC2020, 10VisualEditor (Current work): Implement `unload handlers` for compose - https://phabricator.wikimedia.org/T240259 (10ppelberg) [20:22:48] 10VisualEditor, 10DiscussionTools, 10OWC2020: QA Replying v1.0 on prototype server - https://phabricator.wikimedia.org/T239961 (10ppelberg) [21:04:18] 10Editing-team, 10OWC2020, 10VisualEditor (Current work): Implement `unload handlers` for compose - https://phabricator.wikimedia.org/T240259 (10Esanders) [21:15:47] 10VisualEditor, 10Regression: Inspector vertical alignment regressions in Apex/Monobook - https://phabricator.wikimedia.org/T240268 (10Esanders) [21:23:24] 10Citoid, 10Knowledge-Integrity, 10Research, 10WMF-Legal, and 3 others: [2.11] Integrate Citoid in Wikidata - https://phabricator.wikimedia.org/T199197 (10leila) [21:27:38] 10Editing-team, 10Editing Design, 10OWC2020: Warn contributors before they discard a draft - https://phabricator.wikimedia.org/T240271 (10ppelberg) [21:27:52] 10Editing-team, 10Editing Design, 10OWC2020: Warn contributors before they discard a draft - https://phabricator.wikimedia.org/T240271 (10ppelberg) a:05iamjessklein→03None [21:28:06] 10Editing-team, 10OWC2020, 10VisualEditor (Current work): Warn contributors before they discard a draft - https://phabricator.wikimedia.org/T240271 (10ppelberg) [21:29:13] 10Citoid, 10Knowledge-Integrity, 10Research, 10Wikidata, and 4 others: Add wikibase/wikidata export format to citoid service - https://phabricator.wikimedia.org/T208213 (10leila) [21:36:38] 10Cite, 10WMDE-QWERTY-Sprint-2019-11-20, 10Wikimedia-production-error: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php - https://phabricator.wikimedia.org/T240248 (10awight) a:03awight There are evidently illegal array accesses coming from several places in the code on pro... [21:49:11] 10Cite, 10WMDE-QWERTY-Sprint-2019-11-20, 10Wikimedia-production-error: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php - https://phabricator.wikimedia.org/T240248 (10Jdforrester-WMF) (wmf.5, not wmf.7; this is the first train for a month.) [22:11:05] 10VisualEditor, 10Parsoid: Parsoid removes all newlines from the page when editing a table inside a list item `:{|` - https://phabricator.wikimedia.org/T240280 (10matmarex) [22:12:26] 10VisualEditor, 10Parsoid: Parsoid removes all newlines from the page when editing a table inside a list item `:{|` - https://phabricator.wikimedia.org/T240280 (10matmarex) [22:16:14] 10VisualEditor, 10Parsoid: Parsoid removes all newlines from the page when editing a table inside a list item `:{|` - https://phabricator.wikimedia.org/T240280 (10matmarex) [23:28:14] 10Editing-team, 10OWC2020: [SPIKE] What talk-related events are being tracked? - https://phabricator.wikimedia.org/T239328 (10ppelberg) Thank you for this, David – before responding to the findings you shared, I first want to document answers to the questions you posed [1] **1. Is edit_count local or global?... [23:32:05] (03CR) 10Bartosz Dziewoński: [C: 03+1] "I read the code but haven't tested it :D" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/554128 (owner: 10Esanders) [23:32:30] (03CR) 10Bartosz Dziewoński: [C: 03+1] "(and this depends on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/550359 anyway)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/554128 (owner: 10Esanders) [23:36:38] 10VisualEditor, 10Parsoid: Parsoid removes all newlines from the page when editing a table inside a list item `:{|` - https://phabricator.wikimedia.org/T240280 (10Arlolra) All the content in the table in your example is found in a fosterable position. If your table looked like, ` :{| | ` Parsoid probably wo... [23:42:39] (03CR) 10Bartosz Dziewoński: [C: 04-1] "My main concern here is that when you're looking at an inspector like this: https://i.imgur.com/tIpmASr.png it's not really clear whether " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/550359 (owner: 10Esanders)