[09:54:19] (03PS1) 10Esanders: ArticleTargetLoader: Check apiXhr exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/557840 [09:56:15] (03CR) 10Jforrester: [C: 03+1] ArticleTargetLoader: Check apiXhr exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/557840 (owner: 10Esanders) [10:12:04] (03PS5) 10Jforrester: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/557420 (owner: 10Libraryupgrader) [10:13:23] 10WikiEditor: Selection of text misses starting character(s) for complex scripts like Telugu - https://phabricator.wikimedia.org/T228611 (10Aklapper) 05Stalled→03Declined Unfortunately closing this Phabricator task as no further information has been provided and as nobody else can reproduce the problem. I s... [10:19:24] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/557420 (owner: 10Libraryupgrader) [10:37:22] (03PS1) 10Fomafix: Use document.body instead of 'body' as jQuery selector [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/557866 [10:54:15] (03CR) 10Jforrester: [C: 03+2] "…" [VisualEditor/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/556295 (https://phabricator.wikimedia.org/T239209) (owner: 10Jforrester) [10:55:45] (03CR) 10Jforrester: "Does this mean we can turn no-global-selector back on in the eslint rules?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/557866 (owner: 10Fomafix) [11:01:00] (03Merged) 10jenkins-bot: Sanitize HTML on paste [VisualEditor/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/556295 (https://phabricator.wikimedia.org/T239209) (owner: 10Jforrester) [11:08:53] (03PS1) 10Jforrester: Update VE core submodule to REL1_34 HEAD (a00498275) [extensions/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/557882 (https://phabricator.wikimedia.org/T239209) [11:14:57] (03CR) 10Jforrester: [C: 03+2] Update VE core submodule to REL1_34 HEAD (a00498275) [extensions/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/557882 (https://phabricator.wikimedia.org/T239209) (owner: 10Jforrester) [11:19:57] (03Merged) 10jenkins-bot: Update VE core submodule to REL1_34 HEAD (a00498275) [extensions/VisualEditor] (REL1_34) - 10https://gerrit.wikimedia.org/r/557882 (https://phabricator.wikimedia.org/T239209) (owner: 10Jforrester) [11:23:00] 10VisualEditor-CopyPaste, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), 10Patch-For-Review, and 4 others: XSS in Visual Editor via Copy&Paste (CVE-2019-19708) - https://phabricator.wikimedia.org/T239209 (10Jdforrester-WMF) OK, we've managed back-ports for REL1_33 and REL1_34; this is as good... [13:50:46] 10Cite, 10Book-Referencing, 10Technical-Debt, 10WMDE-QWERTY-Sprint-2019-12-11: Clean up implementation for "follow" cases - https://phabricator.wikimedia.org/T240858 (10awight) [14:16:25] 10Editing-team, 10Editing Design, 10OWC2020: Replies v1.0: conduct usability testing - https://phabricator.wikimedia.org/T236921 (10iamjessklein) I ran a test on usertesting.com on December 11, 2019 - [PT 1-5] The test recruited 5 random, technically - advanced web users. Participants were directed to an ar... [15:12:42] (03PS1) 10Esanders: build: Update linters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/558077 [15:26:04] (03CR) 10jerkins-bot: [V: 04-1] build: Update linters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/558077 (owner: 10Esanders) [15:31:03] (03PS1) 10Esanders: rebaser: Update dependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558095 [15:32:16] (03CR) 10jerkins-bot: [V: 04-1] rebaser: Update dependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558095 (owner: 10Esanders) [16:12:42] 10VisualEditor-CopyPaste, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), 10Patch-For-Review, and 4 others: XSS in Visual Editor via Copy&Paste (CVE-2019-19708) - https://phabricator.wikimedia.org/T239209 (10sbassett) >>! In T239209#5744008, @Jdforrester-WMF wrote: > OK, we've managed back-por... [16:17:09] 10VisualEditor, 10Regression: VE's gallery representation differs enough so that selser is never applied? - https://phabricator.wikimedia.org/T214649 (10Arlolra) >>! In T214649#5741618, @Raymond wrote: > Adding the regression tag as the bug happens now on every edit with a gallery tag since December 4th 2019,... [16:24:55] 10VisualEditor, 10Regression: VE's gallery representation differs enough so that selser is never applied? - https://phabricator.wikimedia.org/T214649 (10Raymond) >>! In T214649#5744845, @Arlolra wrote: >>>! In T214649#5741618, @Raymond wrote: >> Adding the regression tag as the bug happens now on every edit wi... [16:39:50] (03PS6) 10DLynch: Completion framework [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/540436 (https://phabricator.wikimedia.org/T232601) [17:03:49] 10Cite, 10I18n, 10affects-translatewiki.net: Discuss: should we move Cite keys to use "-" rather than "_"? - https://phabricator.wikimedia.org/T240874 (10awight) [17:07:36] 10VisualEditor, 10Regression: VE's gallery representation differs enough so that selser is never applied? - https://phabricator.wikimedia.org/T214649 (10Arlolra) > Sorry but that is not correct. Ah, I think you're right. It seems that `nativeGallery` is now enabled everywhere by default. https://github.com/... [17:07:38] 10Cite, 10I18n, 10affects-translatewiki.net: Discuss: should we move Cite keys to use "-" rather than "_"? - https://phabricator.wikimedia.org/T240874 (10awight) [17:07:48] 10Cite, 10I18n, 10affects-translatewiki.net: Discuss: should we move Cite keys to use "-" rather than "_"? - https://phabricator.wikimedia.org/T240874 (10awight) [17:33:54] 10Cite, 10translatewiki.net, 10I18n: Discuss: should we move Cite keys to use "-" rather than "_"? - https://phabricator.wikimedia.org/T240874 (10Nikerabbit) We (translatewiki.net) have tooling for renames now, so it's easy from out side. But from our side non-consecutive underscores/spaces are okay. [17:46:34] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (c0fbb063a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/557636 (https://phabricator.wikimedia.org/T126027) (owner: 10Jforrester) [17:58:49] (03Merged) 10jenkins-bot: Update VE core submodule to master (c0fbb063a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/557636 (https://phabricator.wikimedia.org/T126027) (owner: 10Jforrester) [18:06:06] 10Editing-team, 10VisualEditor, 10OWC2020, 10Product-Analytics: Analyze the number of distinct contributors using DiscussionTools - https://phabricator.wikimedia.org/T240704 (10mpopov) Howdy! o/ Product Analytics team will review and prioritize the request during our next board review meeting (today, 2019-... [18:15:14] 10VisualEditor, 10Product-Analytics: Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10mpopov) Howdy! o/ Product Analytics team will review and prioritize the request during our next board review meeting (today, 2019-12-16). >>! In T240697#5741164, @DLynch wrote:... [19:07:47] 10Editing-team, 10VisualEditor, 10OWC2020, 10Product-Analytics: Analyze the number of distinct contributors using DiscussionTools - https://phabricator.wikimedia.org/T240704 (10kzimmerman) p:05Triage→03Normal [19:09:11] 10VisualEditor, 10Product-Analytics: Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10kaldari) "Edits done" means edits completed. [19:11:42] 10VisualEditor, 10Product-Analytics: Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10kaldari) >We may also want to repeat File:Analysis of Wikipedia Portal Traffic and JavaScript Support.pdf but other page(s)? @mpopov - Yes, that would be super helpful for the oth... [19:11:47] 10VisualEditor, 10Product-Analytics: Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10LGoto) p:05Triage→03Normal [19:17:10] 10VisualEditor, 10Product-Analytics: Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10kzimmerman) @kaldari @JKatzWMF moving to backlog right now because we don't have bandwidth and this looks like it will be an extensive task. Please let me know if it's high priori... [19:27:31] 10VisualEditor, 10MinervaNeue, 10Readers-Web-Backlog (Tracking): Visual Editor in Desktop Minerva: Text and icon overlaid - https://phabricator.wikimedia.org/T240757 (10Jdlrobson) This looks like a visual editor specific problem. Leaving to that team to triage. [20:41:22] (03CR) 10Bartosz Dziewoński: [C: 03+2] ArticleTargetLoader: Check apiXhr exists (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/557840 (owner: 10Esanders) [20:41:48] (03CR) 10Bartosz Dziewoński: "(Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/557840)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/554107 (owner: 10Esanders) [20:46:37] 10Cite, 10Book-Referencing, 10Patch-For-Review, 10Technical-Debt, 10WMDE-QWERTY-Sprint-2019-12-11: Clean up implementation for "follow" cases - https://phabricator.wikimedia.org/T240858 (10awight) [20:48:48] 10Cite, 10Book-Referencing, 10Patch-For-Review, 10Technical-Debt, 10WMDE-QWERTY-Sprint-2019-12-11: Clean up implementation for "follow" cases - https://phabricator.wikimedia.org/T240858 (10awight) [20:52:20] (03Merged) 10jenkins-bot: ArticleTargetLoader: Check apiXhr exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/557840 (owner: 10Esanders) [21:03:46] 10Editing-team, 10DiscussionTools, 10Performance-Team: Performance review for the DiscussionTools extension - https://phabricator.wikimedia.org/T240474 (10Gilles) a:03Gilles Body of the template coming later in the quarter, I assume? [21:40:31] 10VisualEditor, 10Product-Analytics: Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10kaldari) @kzimmerman - Thanks for looking into it. @DLynch - Is there any chance this could be done by the engineers on the Editing team without the help of Product Analytics (sa... [22:24:42] 10VisualEditor, 10Product-Analytics: Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10DLynch) > Server-side PHP sends EditAttemptStep events, right? And those are limited to action='init' & action='saveSuccess'? @mpopov Yeah, that's my logic. It does also do `saveA... [22:26:41] 10Cite, 10Book-Referencing, 10Epic: Don't break Cite VisualEditor integration - https://phabricator.wikimedia.org/T240186 (10awight) @Jdforrester-WMF we don't currently have a product manager—we expect a new hire to start in January. But in the meantime, perhaps our engineering manager @Tobi_WMDE_SW can coo... [23:28:35] 10VisualEditor, 10Patch-For-Review, 10Regression: VE's gallery representation differs enough so that selser is never applied? - https://phabricator.wikimedia.org/T214649 (10Arlolra) With that deploy, `nativeGallery` is now re-disabled. That should returns things to how they've been the past year, where only...