[00:14:56] (03CR) 10Zoranzoki21: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/559176 (owner: 10Libraryupgrader) [03:03:05] (03PS2) 10Divec: ve.dm.Transaction: Don't translate annotate-like operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [03:04:33] (03CR) 10jerkins-bot: [V: 04-1] ve.dm.Transaction: Don't translate annotate-like operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [03:04:48] (03CR) 10Divec: [C: 04-1] "The offset doesn't get translated correctly if a 'true' replacement happens after the annotation replacement. I'll fix." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [03:15:14] (03PS3) 10Divec: ve.dm.Transaction: Don't translate offsets inside annotate-only replacements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [03:17:55] (03CR) 10Divec: [C: 03+1] "+2 to the parts I didn't write" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [03:18:53] (03CR) 10Divec: [C: 04-1] "Whoops no, sorry, I duplicated something" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [03:19:35] (03PS4) 10Divec: ve.dm.Transaction: Don't translate offsets inside annotate-only replacements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [03:22:01] (03CR) 10Divec: [C: 03+1] "Ok, fixed now ... +2 to the parts I didn't write" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [03:48:07] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/559176 (owner: 10Libraryupgrader) [09:19:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Wikimedia-production-error: VisualEditor throwing "PHP Notice: Undefined index: etag" on officewiki as of wmf.11 - https://phabricator.wikimedia.org/T240961 (10matmarex) This probably only affected officewiki and other... [09:19:15] (03CR) 10Bartosz Dziewoński: "(I commented on the task responding to the questions)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/558863 (https://phabricator.wikimedia.org/T240961) (owner: 10Thiemo Kreuz (WMDE)) [09:19:20] (03CR) 10Bartosz Dziewoński: [C: 03+1] Fix unchecked array access in ApiVisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/558863 (https://phabricator.wikimedia.org/T240961) (owner: 10Thiemo Kreuz (WMDE)) [10:41:00] 10Cite, 10Book-Referencing, 10WMDE-QWERTY-Team, 10WMDE-QWERTY-Sprint-2019-12-11, 10Wikimedia-Incident: Retrospective and learnings from the Parser/Cite clone incident - https://phabricator.wikimedia.org/T240671 (10awight) Adding a random story point estimate. The incident report looks complete, I'll tic... [10:41:15] 10Cite, 10Book-Referencing, 10WMDE-QWERTY-Team, 10WMDE-QWERTY-Sprint-2019-12-11, 10Wikimedia-Incident: Retrospective and learnings from the Parser/Cite clone incident - https://phabricator.wikimedia.org/T240671 (10awight) [10:43:47] 10Cite, 10Book-Referencing, 10WMDE-Design, 10Design, and 2 others: [Design] How should book references appear when reused? - https://phabricator.wikimedia.org/T239329 (10awight) [10:44:13] 10Cite, 10Book-Referencing, 10Patch-For-Review, 10Technical-Debt, 10WMDE-QWERTY-Sprint-2019-12-11: Clean up implementation for "follow" cases - https://phabricator.wikimedia.org/T240858 (10awight) [10:44:48] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Browser-Support-Firefox, and 4 others: Reference numbers wrong in Firefox when following a list - https://phabricator.wikimedia.org/T229307 (10awight) Assigning random story points, please revise as needed. [10:45:17] 10Cite, 10Book-Referencing, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10WMDE-QWERTY-Sprint-2019-11-20, 10WMDE-QWERTY-Sprint-2019-12-11: CSS counters are messing up list numbering in Firefox - https://phabricator.wikimedia.org/T239787 (10awight) Assigning random story points, please revise... [10:46:07] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Browser-Support-Firefox, and 4 others: Reference numbers wrong in Firefox when following a list - https://phabricator.wikimedia.org/T229307 (10awight) [12:07:07] (03CR) 10Esanders: [C: 03+2] ve.dm.Transaction: Don't translate offsets inside annotate-only replacements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [12:10:37] (03Merged) 10jenkins-bot: ve.dm.Transaction: Don't translate offsets inside annotate-only replacements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558733 (owner: 10Esanders) [12:22:38] (03PS4) 10Jforrester: FragmentWindow: Replace previousSelection with initialFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558630 (owner: 10Esanders) [12:22:45] (03PS4) 10Jforrester: DesktopContext: Remove onModelSelect event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558631 (owner: 10Esanders) [12:27:09] (03PS1) 10Esanders: Pause synchronizer while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 [12:28:09] (03PS5) 10Esanders: DesktopContext: Remove onModelSelect event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558631 [12:28:11] (03PS2) 10Esanders: Pause synchronizer while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 [12:33:35] (03PS3) 10Esanders: Pause synchronizer while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 [12:33:43] (03CR) 10jerkins-bot: [V: 04-1] Pause synchronizer while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 (owner: 10Esanders) [12:34:21] (03CR) 10jerkins-bot: [V: 04-1] DesktopContext: Remove onModelSelect event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558631 (owner: 10Esanders) [12:38:59] (03CR) 10jerkins-bot: [V: 04-1] Pause synchronizer while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 (owner: 10Esanders) [12:45:54] (03PS1) 10Esanders: Evalutate fragment selection after staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559452 [12:50:03] (03CR) 10jerkins-bot: [V: 04-1] Evalutate fragment selection after staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559452 (owner: 10Esanders) [13:14:00] (03CR) 10Esanders: "v-1 isn't real. FF headless timing out." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558631 (owner: 10Esanders) [13:14:15] (03CR) 10Esanders: "v-1 isn't real. FF headless timing out." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 (owner: 10Esanders) [13:14:29] (03CR) 10Esanders: "v-1 isn't real. FF headless timing out." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559452 (owner: 10Esanders) [13:24:32] (03PS1) 10Esanders: CI: Double Firefox test timeouts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559461 [13:31:45] (03CR) 10jerkins-bot: [V: 04-1] CI: Double Firefox test timeouts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559461 (owner: 10Esanders) [13:50:14] (03CR) 10Esanders: [C: 04-1] "Didn't work :/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559461 (owner: 10Esanders) [14:48:50] (03CR) 10Divec: [C: 03+2] FragmentWindow: Replace previousSelection with initialFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558630 (owner: 10Esanders) [14:50:55] (03PS6) 10Divec: DesktopContext: Remove onModelSelect event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558631 (owner: 10Esanders) [14:51:30] (03Merged) 10jenkins-bot: FragmentWindow: Replace previousSelection with initialFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558630 (owner: 10Esanders) [15:49:13] (03PS1) 10Esanders: Use ve.dm.example.imgSrc everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559518 [15:50:07] (03PS1) 10Esanders: Remove CE HTML from DM html test fixture [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559519 [15:51:37] (03CR) 10Esanders: Remove CE HTML from DM html test fixture (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559519 (owner: 10Esanders) [15:57:11] (03CR) 10jerkins-bot: [V: 04-1] Remove CE HTML from DM html test fixture [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559519 (owner: 10Esanders) [16:19:25] (03PS1) 10Esanders: ve.ce.Document test: Add src to test image [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559530 [16:19:57] 10VisualEditor, 10Continuous-Integration-Config: Firefox CI tests keep failing in VE - https://phabricator.wikimedia.org/T240955 (10Esanders) p:05Triage→03High This is failing quite regularly now. [16:21:24] cscott: we didn't have the meeting this week as the Editing team are doing a side-project week [16:21:45] as discussed in "Talk Pages Engine Room" chat [16:22:06] should be back to normal schedule after xmas though [16:24:03] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General, 10MediaWiki-Interface, and 11 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784 (10Jdlrobson) [16:24:28] (03CR) 10jerkins-bot: [V: 04-1] ve.ce.Document test: Add src to test image [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559530 (owner: 10Esanders) [16:26:46] (03CR) 10Jforrester: [C: 03+2] Use ve.dm.example.imgSrc everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559518 (owner: 10Esanders) [16:30:16] (03CR) 10jerkins-bot: [V: 04-1] Use ve.dm.example.imgSrc everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559518 (owner: 10Esanders) [16:34:47] (03PS1) 10Jforrester: Update VE core submodule to master (eadee0343) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/559534 [16:38:44] 10VisualEditor, 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (201912): Firefox CI tests keep failing in VE - https://phabricator.wikimedia.org/T240955 (10Jdforrester-WMF) [16:55:33] (03CR) 10Jforrester: [C: 03+2] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559518 (owner: 10Esanders) [16:58:02] (03Merged) 10jenkins-bot: Use ve.dm.example.imgSrc everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559518 (owner: 10Esanders) [16:59:02] (03PS7) 10Jforrester: DesktopContext: Remove onModelSelect event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558631 (owner: 10Esanders) [16:59:08] (03PS4) 10Jforrester: Pause synchronizer while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 (owner: 10Esanders) [16:59:20] (03PS2) 10Jforrester: Evalutate fragment selection after staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559452 (owner: 10Esanders) [16:59:31] (03PS2) 10Jforrester: Remove CE HTML from DM html test fixture [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559519 (owner: 10Esanders) [16:59:50] (03CR) 10Divec: [C: 03+2] Remove CE HTML from DM html test fixture [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559519 (owner: 10Esanders) [17:00:36] (03CR) 10Divec: [C: 03+2] ve.ce.Document test: Add src to test image [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559530 (owner: 10Esanders) [17:00:42] (03PS2) 10Jforrester: ve.ce.Document test: Add src to test image [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559530 (owner: 10Esanders) [17:04:01] (03PS1) 10Divec: Temporarily disable karma:firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559544 [17:05:52] (03Abandoned) 10Jforrester: Temporarily disable karma:firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559544 (owner: 10Divec) [17:05:59] (03Abandoned) 10Jforrester: CI: Double Firefox test timeouts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559461 (owner: 10Esanders) [17:09:41] 10VisualEditor, 10Continuous-Integration-Config, 10Patch-For-Review, 10Release-Engineering-Team-TODO (201912): Firefox CI tests keep failing in VE - https://phabricator.wikimedia.org/T240955 (10Jdforrester-WMF) OK, I've bumped the jobs back down to the old image (which has Firefox 60 not 68), and all seems... [17:14:31] 10VisualEditor, 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (201912): Firefox CI tests keep failing in VE - https://phabricator.wikimedia.org/T240955 (10dchan) Ooh, thanks! [17:15:02] (03CR) 10Divec: [C: 03+2] DesktopContext: Remove onModelSelect event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558631 (owner: 10Esanders) [17:16:56] (03Merged) 10jenkins-bot: DesktopContext: Remove onModelSelect event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/558631 (owner: 10Esanders) [17:21:02] (03PS1) 10Jforrester: git-build: Fix name of grunt.log.error [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559555 [17:26:47] (03PS2) 10Jforrester: Update VE core submodule to master (d1dceab31) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/559534 [17:49:23] (03PS5) 10Divec: Pause synchronizer while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 (owner: 10Esanders) [18:05:51] (03CR) 10Divec: [C: 03+1] "+2 to the parts I didn't write" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 (owner: 10Esanders) [18:20:11] (03PS1) 10Esanders: Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 [18:21:05] (03CR) 10Esanders: [C: 03+2] Pause synchronizer while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 (owner: 10Esanders) [18:22:00] (03CR) 10jerkins-bot: [V: 04-1] Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [18:22:02] (03CR) 10Divec: [C: 03+2] Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [18:23:50] (03Merged) 10jenkins-bot: Pause synchronizer while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559447 (owner: 10Esanders) [18:24:03] (03CR) 10jerkins-bot: [V: 04-1] Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [18:56:01] 10Cite, 10Parsoid: Implement and add html/parsoid sections for new citeParserTests - https://phabricator.wikimedia.org/T241164 (10Arlolra) [18:57:13] (03PS2) 10Esanders: Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 [19:03:02] (03PS3) 10Esanders: Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 [19:12:56] (03PS4) 10Divec: Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [19:18:03] (03CR) 10Esanders: [C: 03+1] Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [19:26:19] (03PS5) 10Divec: Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [19:30:38] (03CR) 10Divec: [C: 03+2] Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [19:32:54] (03CR) 10Divec: [C: 03+2] Evalutate fragment selection after staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559452 (owner: 10Esanders) [19:35:46] 10VisualEditor, 10Contributors-Team: Disable VE on translated pages - https://phabricator.wikimedia.org/T140703 (10Quiddity) 05Declined→03Open >>! In T140703#2693831, @Esanders wrote: > How about a dialog that says "VE is not supported on this page, switch to source editing: [OK] | [No, I want to try VE an... [19:41:15] (03PS6) 10Divec: Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [19:45:00] (03CR) 10Divec: [C: 03+1] Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [19:45:05] (03CR) 10Divec: [C: 03+2] Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [19:47:02] (03Merged) 10jenkins-bot: Catch various out-of-bounds exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559564 (owner: 10Esanders) [20:05:51] (03PS3) 10Divec: Evalutate fragment selection after staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559452 (owner: 10Esanders) [20:06:14] (03CR) 10Esanders: [C: 03+2] Remove CE HTML from DM html test fixture [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559519 (owner: 10Esanders) [20:08:26] (03Merged) 10jenkins-bot: Remove CE HTML from DM html test fixture [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559519 (owner: 10Esanders) [20:08:34] (03Merged) 10jenkins-bot: ve.ce.Document test: Add src to test image [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559530 (owner: 10Esanders) [20:22:03] (03CR) 10Divec: [C: 03+1] Evalutate fragment selection after staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559452 (owner: 10Esanders) [20:22:06] (03CR) 10Divec: [C: 03+2] Evalutate fragment selection after staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559452 (owner: 10Esanders) [20:24:00] (03Merged) 10jenkins-bot: Evalutate fragment selection after staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/559452 (owner: 10Esanders) [20:42:27] 10Cite, 10MediaWiki-HTML-Templating, 10MediaWiki-extensions-Html2Wiki: cite error: A tag is missing the closing in Citizenship_(Amendment)_Act,_2019 Page - https://phabricator.wikimedia.org/T241173 (10Smruti_SRanjan) [22:07:34] 10Editing-team, 10MassMessage, 10Patch-For-Review, 10User-DannyS712: MassMessage: add a hook before posting a message - https://phabricator.wikimedia.org/T231607 (10Legoktm) >>! In T231607#5459670, @DannyS712 wrote: >>>! In T231607#5459551, @Legoktm wrote: >> What's the use case for this? I don't really wa... [22:10:49] 10Editing-team, 10MassMessage, 10Patch-For-Review, 10User-DannyS712: MassMessage: add a hook before posting a message - https://phabricator.wikimedia.org/T231607 (10DannyS712) >>! In T231607#5755478, @Legoktm wrote: >>>! In T231607#5459670, @DannyS712 wrote: >>>>! In T231607#5459551, @Legoktm wrote: >>> Wh... [22:11:35] 10Editing-team, 10MassMessage, 10Patch-For-Review, 10User-DannyS712: MassMessage: add a hook before posting a message - https://phabricator.wikimedia.org/T231607 (10Legoktm) I mean a setting to prevent blocked users from receiving messages. I still don't see the point of having a hook. [22:12:24] 10Editing-team, 10MassMessage, 10Patch-For-Review, 10User-DannyS712: MassMessage: add a hook before posting a message - https://phabricator.wikimedia.org/T231607 (10DannyS712) >>! In T231607#5755485, @Legoktm wrote: > I mean a setting to prevent blocked users from receiving messages. I still don't see the...