[00:29:35] (03PS1) 10Bartosz Dziewoński: Allow switching in welcome dialog on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568148 [00:29:37] (03PS1) 10Bartosz Dziewoński: Disallow switching in NWE welcome dialog if VE should be unavailable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568149 [00:29:39] (03PS1) 10Bartosz Dziewoński: Fix tab initialization if NWE is enabled but VE is disabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568150 (https://phabricator.wikimedia.org/T178976) [00:29:41] (03PS1) 10Bartosz Dziewoński: Don't offer switching to VE if it's disabled in preferences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568151 (https://phabricator.wikimedia.org/T243723) [00:31:37] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Wikitext editor toolbar and welcome dialog give the option to switch to visual editor even if it's disabled in user preferences (or not enabled, on opt-in wikis) - https://phabricator.wikimedia.org/T243723 (10matmarex) [00:32:09] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Wikitext editor toolbar and welcome dialog give the option to switch to visual editor even if it's disabled in user preferences (or not enabled, on opt-in wikis) - https://phabricator.wikimedia.org/T243723 (10matmarex) (I need to as... [00:33:07] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): When VE is disabled but NWE is enabled and wiki is in multi-tab mode, initialization code for the "Edit" tab doesn't run - https://phabricator.wikimedia.org/T178976 (10matmarex) I was i... [02:08:03] (03CR) 10jerkins-bot: [V: 04-1] build: Updating composer dependencies [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/568209 (owner: 10Libraryupgrader) [02:57:46] 10VisualEditor, 10User-RhinosF1, 10User-Ryasmeen: Visual Editor not taking image size into account - https://phabricator.wikimedia.org/T165880 (10Hispano76) 05Open→03Resolved that was solved at the time: https://phabricator.miraheze.org/T1404 [08:20:40] (03PS2) 10Thiemo Kreuz (WMDE): build: Updating composer dependencies [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/568209 (owner: 10Libraryupgrader) [10:06:32] 10Citoid: Switch to new pubmed website - https://phabricator.wikimedia.org/T243882 (10Mvolz) [12:35:04] 10Cite, 10Patch-For-Review: Cite: Add namespace detection for automatically generated reference list - https://phabricator.wikimedia.org/T70324 (10thiemowmde) [17:27:10] 10TemplateData, 10VisualEditor, 10MediaWiki-Parser, 10Parsoid, 10Technical-Debt: Evaluate how to structure internal calls to TemplateData in PHP - https://phabricator.wikimedia.org/T243854 (10Anomie) Note that while the code currently lives in a Parsoid "extension", that's intended as a temporary measure... [18:42:43] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor ignores autogenerated parameter info for templates without TemplateData - https://phabricator.wikimedia.org/T243868 (10matmarex) Sounds good to me. [18:55:08] (03CR) 10Umherirrender: [C: 03+1] build: Updating composer dependencies (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/568209 (owner: 10Libraryupgrader) [18:58:33] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Mobile, 10Readers-Web-Backlog (Tracking): HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack) - https://phabricator.wikimedia.org/T242351 (10matmarex) >>! In T242351#5790208, @Masumrezarock100 wrote: > VisualDiff feature doesn't work... [19:08:21] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] build: Updating composer dependencies [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/568209 (owner: 10Libraryupgrader) [19:15:35] (03PS1) 10Bartosz Dziewoński: ArticleTargetLoader: Fix loading visual diffs when no RESTBase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568555 [19:15:37] (03PS1) 10Bartosz Dziewoński: Enable visual diff code on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568556 (https://phabricator.wikimedia.org/T242351) [19:16:14] 10VisualEditor-VisualDiffs, 10Mobile, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack) - https://phabricator.wikimedia.org/T242351 (10matmarex) [19:43:10] 10VisualEditor: Browser spellchecking broken in VE for words with special characters - https://phabricator.wikimedia.org/T240327 (10matmarex) @Schnark The Firefox bug was marked fixed, is this resolved now? [19:44:10] 10VisualEditor: Não estou conseguindo gravar as minhas edições - https://phabricator.wikimedia.org/T233139 (10matmarex) 05Stalled→03Invalid [19:48:36] 10VisualEditor, 10Technical-Debt: hasMatchingAncestor is the wrong check for list tools - https://phabricator.wikimedia.org/T210505 (10matmarex) [19:48:41] 10VisualEditor: Indented list items lose formatting when switching between bulleted & numbered list styles - https://phabricator.wikimedia.org/T217618 (10matmarex) [19:50:11] 10VisualEditor: Indented list items lose formatting when switching between bulleted & numbered list styles - https://phabricator.wikimedia.org/T217618 (10matmarex) From the other task, which describes the same problem at a "lower level": > **hasMatchingAncestor is the wrong check for list tools** > We currently... [19:52:29] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: Multiline list items rendering differently in ContentEditable than the resulting wikitext - https://phabricator.wikimedia.org/T57746 (10matmarex) [19:52:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Tables can be created inside list items, even though that is invalid wikitext - https://phabricator.wikimedia.org/T164016 (10matmarex) [19:52:35] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables: It's possible to insert a table inside a definition list, which breaks the formatting in edit mode and is incorrectly serialized by Parsoid - https://phabricator.wikimedia.org/T147348 (10matmarex) [20:05:35] (03PS1) 10Esanders: eslint: Use /mediawiki ruleset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/568572 [20:09:58] (03PS1) 10Esanders: Use ve.promiseAll [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/568575 [20:13:53] (03CR) 10Divec: [C: 03+2] ArticleTargetLoader: Fix loading visual diffs when no RESTBase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568555 (owner: 10Bartosz Dziewoński) [20:19:36] (03CR) 10Divec: [C: 03+2] Enable visual diff code on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568556 (https://phabricator.wikimedia.org/T242351) (owner: 10Bartosz Dziewoński) [20:20:50] (03CR) 10Jforrester: [C: 03+2] Use ve.promiseAll [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/568575 (owner: 10Esanders) [20:21:13] (03CR) 10Jforrester: [C: 03+2] eslint: Use /mediawiki ruleset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/568572 (owner: 10Esanders) [20:23:39] (03Merged) 10jenkins-bot: eslint: Use /mediawiki ruleset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/568572 (owner: 10Esanders) [20:29:31] (03Merged) 10jenkins-bot: ArticleTargetLoader: Fix loading visual diffs when no RESTBase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568555 (owner: 10Bartosz Dziewoński) [20:32:49] (03Merged) 10jenkins-bot: Enable visual diff code on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568556 (https://phabricator.wikimedia.org/T242351) (owner: 10Bartosz Dziewoński) [20:35:49] (03Merged) 10jenkins-bot: Use ve.promiseAll [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/568575 (owner: 10Esanders) [20:55:40] 10VisualEditor-VisualDiffs, 10Mobile, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack) - https://phabricator.wikimedia.org/T242351 (10Masumrezarock100) >>! In T242351#5838862, @matmarex wro... [21:05:21] 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Mobile, 10Patch-For-Review, and 2 others: HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack) - https://phabricator.wikimedia.org/T242351 (10Masumrezarock100) This visual diff design looks bad on mobile.... [21:14:35] (03CR) 10Tchanders: [C: 03+2] Display log entry underneath 'titleprotectedwarning' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/565409 (owner: 10Bartosz Dziewoński) [21:17:38] 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Mobile, 10Patch-For-Review, and 2 others: HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack) - https://phabricator.wikimedia.org/T242351 (10matmarex) >>! In T242351#5838967, @Masumrezarock100 wrote: > Th... [21:18:05] 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Mobile, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack) - https://phabricator.wikimedia.org/T242351 (10matmarex) [21:25:05] 10VisualEditor-ContentEditable, 10Editing QA, 10VisualEditor (Current work): Clicking on a slug while the selection is inside a table causes an exception - https://phabricator.wikimedia.org/T243860 (10matmarex) [21:25:11] 10Editing-team, 10Editing QA, 10OWC2020, 10VisualEditor (Current work): Remove max height on reply-widget-plain - https://phabricator.wikimedia.org/T243346 (10matmarex) [21:25:14] 10Editing-team, 10DiscussionTools, 10Editing QA, 10OWC2020, 10VisualEditor (Current work): Unable to respond to specific comments - https://phabricator.wikimedia.org/T241391 (10matmarex) [21:30:12] (03Merged) 10jenkins-bot: Display log entry underneath 'titleprotectedwarning' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/565409 (owner: 10Bartosz Dziewoński) [21:31:38] (03CR) 10Tchanders: [C: 03+2] Pass the "count" parameter to 'cascadeprotectedwarning' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/565410 (owner: 10Bartosz Dziewoński) [21:31:41] (03CR) 10Tchanders: [C: 03+2] ApiVisualEditor: Refactor edit notice code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/565411 (owner: 10Bartosz Dziewoński) [21:38:43] 10VisualEditor-MediaWiki, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10MinervaNeue (Tracking), 10Patch-For-Review, and 2 others: Mobile VE no longer restores section hash fragment after section editing - https://phabricator.wikimedia.org/T234868 (10polishdeveloper) a:05pmiazga→03Edtadros [21:39:15] 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Mobile, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack) - https://phabricator.wikimedia.org/T242351 (10Masumrezarock100) The switched... [21:40:13] (03CR) 10Esanders: "I think we should update callers to explicitly pass the visualeditor(-wikitext) tags, so we don't have to depend on these defaults. Those " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/567122 (https://phabricator.wikimedia.org/T242184) (owner: 10DLynch) [21:41:44] (03CR) 10DLynch: "> I think we should update callers to explicitly pass the" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/567122 (https://phabricator.wikimedia.org/T242184) (owner: 10DLynch) [21:45:36] (03Merged) 10jenkins-bot: Pass the "count" parameter to 'cascadeprotectedwarning' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/565410 (owner: 10Bartosz Dziewoński) [21:46:01] (03Merged) 10jenkins-bot: ApiVisualEditor: Refactor edit notice code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/565411 (owner: 10Bartosz Dziewoński) [21:50:53] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10MobileFrontend (MobileFrontend Special Pages), and 2 others: Regression: issues with MobileDiff - https://phabricator.wikimedia.org/T242310 (10Masumrezarock100) @Jdlrobson I am afraid the 2nd problem's OA steps are o... [22:08:41] 10VisualEditor-MediaWiki, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10MinervaNeue (Tracking), 10Patch-For-Review, and 2 others: Mobile VE no longer restores section hash fragment after section editing - https://phabricator.wikimedia.org/T234868 (10matmarex) Thank you all for the reviews! [22:52:50] (03CR) 10Tchanders: Don't display duplicate protection notices when user can't edit (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/565412 (owner: 10Bartosz Dziewoński) [23:01:00] (03PS5) 10Divec: WIP: POC: use ve.dm.TreeModifier to do the tree diffing in ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532724 [23:02:55] (03CR) 10jerkins-bot: [V: 04-1] WIP: POC: use ve.dm.TreeModifier to do the tree diffing in ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532724 (owner: 10Divec) [23:06:53] (03CR) 10Bartosz Dziewoński: [C: 03+1] "I think this is correct but I'd like to hear what Ed thinks about it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/567483 (https://phabricator.wikimedia.org/T243606) (owner: 10TK-999) [23:18:21] 10WikiEditor, 10Browser-Support-Google-Chrome, 10Browser-Support-Internet-Explorer, 10Patch-For-Review, and 3 others: WikiEditor dialogs kill the undo buffer - https://phabricator.wikimedia.org/T33780 (10TheDJ) a:05TheDJ→03None [23:23:08] (03PS2) 10DLynch: Tag VE edits from the client-side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/567122 (https://phabricator.wikimedia.org/T242184) [23:24:46] (03CR) 10DLynch: "Okay, implemented it that way!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/567122 (https://phabricator.wikimedia.org/T242184) (owner: 10DLynch) [23:40:09] (03PS6) 10Divec: WIP: POC: use ve.dm.TreeModifier to do the tree diffing in ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532724 [23:41:30] (03CR) 10jerkins-bot: [V: 04-1] WIP: POC: use ve.dm.TreeModifier to do the tree diffing in ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/532724 (owner: 10Divec) [23:51:21] 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Mobile, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack) - https://phabricator.wikimedia.org/T242351 (10Jdlrobson) Given its a beta fe... [23:55:30] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10MobileFrontend (MobileFrontend Special Pages), and 2 others: Regression: issues with MobileDiff - https://phabricator.wikimedia.org/T242310 (10Jdlrobson)