[01:47:55] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10MobileFrontend (MobileFrontend Special Pages), and 2 others: Regression: issues with MobileDiff - https://phabricator.wikimedia.org/T242310 (10Edtadros) a:05Edtadros→03Jdlrobson @Jdlrobson if I'm reading this cor... [02:28:27] (03PS1) 10Tchanders: ApiVisualEditor: Replace calls to deprecated Title methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568735 [02:39:12] (03CR) 10jerkins-bot: [V: 04-1] ApiVisualEditor: Replace calls to deprecated Title methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568735 (owner: 10Tchanders) [04:58:48] (03PS2) 10Tchanders: ApiVisualEditor: Replace calls to deprecated Title methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568735 [05:46:53] (03CR) 10Esanders: [C: 04-1] "looks good. theoretical nitpick" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/567122 (https://phabricator.wikimedia.org/T242184) (owner: 10DLynch) [05:55:23] (03PS3) 10DLynch: Tag VE edits from the client-side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/567122 (https://phabricator.wikimedia.org/T242184) [05:57:14] (03CR) 10Bartosz Dziewoński: "When this gets deplayed, any edits in-progress will not get tagged. Is it worth to try to split this into two patches and put them on sepa" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/567122 (https://phabricator.wikimedia.org/T242184) (owner: 10DLynch) [07:42:26] (03CR) 10jerkins-bot: [V: 04-1] build: Updating composer dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/568865 (owner: 10Libraryupgrader) [07:51:52] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10MobileFrontend (MobileFrontend Special Pages), and 2 others: Regression: issues with MobileDiff - https://phabricator.wikimedia.org/T242310 (10Masumrezarock100) >>! In T242310#5839382, @Edtadros wrote: > @Jdlrobson i... [07:56:32] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10MobileFrontend (MobileFrontend Special Pages), and 2 others: Regression: issues with MobileDiff - https://phabricator.wikimedia.org/T242310 (10Masumrezarock100) a:05Jdlrobson→03Edtadros [10:15:41] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects: Support 'maps' parameter in TemplateData Editor (GUI) - https://phabricator.wikimedia.org/T208305 (10Mvolz) [10:27:29] 10Cite, 10Wikisource, 10Patch-For-Review, 10Technical-Debt: list item must not wrap the text in - https://phabricator.wikimedia.org/T49544 (10Billinghurst) >>! In T49544#2264126, @Jdforrester-WMF wrote: > Not allowing block elements in references is absolutely intentional; I'm Declinin... [10:32:05] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects: Support 'maps' parameter in TemplateData Editor (GUI) - https://phabricator.wikimedia.org/T208305 (10Mvolz) [10:33:15] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects: Support 'maps' parameter in TemplateData Editor (GUI) - https://phabricator.wikimedia.org/T208305 (10Mvolz) [11:00:05] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects: Support 'maps' parameter in TemplateData Editor (GUI) - https://phabricator.wikimedia.org/T208305 (10Mvolz) [11:06:33] 10Citoid, 10Operations: Request took down both zotero and citoid (exceeding memory) - https://phabricator.wikimedia.org/T243444 (10Mvolz) >>! In T243444#5829834, @akosiaris wrote: >>>! In T243444#5829606, @Mvolz wrote: >>>>! In T243444#5826816, @akosiaris wrote: >>>> Thanks. That's working now, but I've downlo... [12:25:51] (03PS2) 10Thiemo Kreuz (WMDE): build: Updating composer dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/568865 (owner: 10Libraryupgrader) [12:33:33] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects: Support 'maps' parameter in TemplateData Editor (GUI) - https://phabricator.wikimedia.org/T208305 (10Prondubuisi) Hello @Mvolz thanks for the additional description! I am interested in working on this project, Please when you say add some templa... [12:45:59] (03CR) 10Daimona Eaytoy: [C: 04-1] "I suggest suppressing the issue inline, pointing to T240141 in the comment. There are many [1] issues suppressed for the same reason; by s" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/568865 (owner: 10Libraryupgrader) [12:52:06] (03CR) 10Thiemo Kreuz (WMDE): "I hate these suppressions. What they effectively do is documenting a bug in Phan. But this documentation is not in Phan, it's in all *othe" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/568865 (owner: 10Libraryupgrader) [13:13:08] (03CR) 10Daimona Eaytoy: [C: 04-1] "> I hate these suppressions. What they effectively do is documenting" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/568865 (owner: 10Libraryupgrader) [13:27:03] (03CR) 10Thiemo Kreuz (WMDE): "But this exception is not dead code. The moment there is a bug in dieWithError() method, the line of code will be reached." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/568865 (owner: 10Libraryupgrader) [13:33:00] (03CR) 10Daimona Eaytoy: [C: 04-1] "> The moment there is a bug in" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/568865 (owner: 10Libraryupgrader) [16:30:16] (03CR) 10Thiemo Kreuz (WMDE): "Sure, "if it breaks, all kinds of breakage may happen around". Or may not. We don't know, and can't guarantee this. Also, if stuff breaks " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/568865 (owner: 10Libraryupgrader) [18:41:58] (03CR) 10Jforrester: [C: 03+2] ApiVisualEditor: Replace calls to deprecated Title methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568735 (owner: 10Tchanders) [18:57:37] (03Merged) 10jenkins-bot: ApiVisualEditor: Replace calls to deprecated Title methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/568735 (owner: 10Tchanders) [19:30:04] (03CR) 10Bartosz Dziewoński: Don't display duplicate protection notices when user can't edit (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/565412 (owner: 10Bartosz Dziewoński) [19:30:14] (03PS2) 10Bartosz Dziewoński: Don't display duplicate protection notices when user can't edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/565412 [20:37:48] (03CR) 10Esanders: "I think our test coverage is good, so I'm not too concerned, but this method is also used in MWWikitextSurface by $textbox.textSelection( " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/567483 (https://phabricator.wikimedia.org/T243606) (owner: 10TK-999) [21:41:53] (03CR) 10Bartosz Dziewoński: [C: 03+1] "I don't think the behavior of that will actually change here… you need a selection that ends between {/type:paragraph} and {type:paragraph" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/567483 (https://phabricator.wikimedia.org/T243606) (owner: 10TK-999) [21:43:35] (03CR) 10Bartosz Dziewoński: [C: 03+2] ve.dm.SourceConverter: Add a trailing newline to each full paragraph [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/567483 (https://phabricator.wikimedia.org/T243606) (owner: 10TK-999) [21:44:17] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Patch-For-Review, 10VisualEditor (Current work): Inserting a table breaks CodeMirror highlighting in NWE - https://phabricator.wikimedia.org/T243606 (10matmarex) [21:45:30] (03Merged) 10jenkins-bot: ve.dm.SourceConverter: Add a trailing newline to each full paragraph [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/567483 (https://phabricator.wikimedia.org/T243606) (owner: 10TK-999) [22:01:18] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10VisualEditor (Current work): Inserting a table breaks CodeMirror highlighting in NWE - https://phabricator.wikimedia.org/T243606 (10matmarex)