[00:02:51] 10Editing-team, 10VisualEditor, 10OWC2020 (OWC2020 Replying 1.0): Changes to EditAttemptStep schema for Discussion Tools Replying V1.0 - https://phabricator.wikimedia.org/T243467 (10Mayakp.wiki) [00:03:05] 10Editing-team, 10VisualEditor, 10OWC2020 (OWC2020 Replying 1.0): Changes to EditAttemptStep schema for Discussion Tools Replying V1.0 - https://phabricator.wikimedia.org/T243467 (10Mayakp.wiki) >>! In T243467#5867062, @DLynch wrote: > But Maya and I have spoken about it, and we know what needs to happen. A... [00:03:12] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (Tracking), 10Mobile, 10Readers-Web-Backlog (Tracking): VisualDiff feature on mobile has an inconsistent style/layout - https://phabricator.wikimedia.org/T244673 (10Masumrezarock100) [00:05:07] 10VisualEditor, 10DiscussionTools, 10MediaWiki-General, 10Editing-team (Q3 2019-2020 Kanban Board), and 2 others: Upstream API error handling from VisualEditor to MediaWiki, use it in DiscussionTools - https://phabricator.wikimedia.org/T240519 (10Ryasmeen) [00:06:45] 10VisualEditor, 10DiscussionTools, 10MediaWiki-General, 10Editing-team (Q3 2019-2020 Kanban Board), and 2 others: Upstream API error handling from VisualEditor to MediaWiki, use it in DiscussionTools - https://phabricator.wikimedia.org/T240519 (10Ryasmeen) Please mention what I need to test here and the st... [00:06:58] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (Tracking), 10Mobile, 10Readers-Web-Backlog (Tracking): VisualDiff feature on mobile has an inconsistent style/layout - https://phabricator.wikimedia.org/T244673 (10Masumrezarock100) >>! In T244673#5870517, @Jdlrobson wrote: > @JTannerWMF I don't... [00:15:24] 10WikiEditor: The number passed to the dialog is not localized - https://phabricator.wikimedia.org/T244812 (10Huji) [01:04:28] (03PS3) 10Edward Chernenko: Add "width" and "alignment" fields to the Table dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/567510 (https://phabricator.wikimedia.org/T244818) [17:46:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), and 3 others: [Regression] Single tapping on a link is enabling the label editing mode - https://phabricator.wikimedia.org/T232172 (10marcella) 05Open→03Resolved [17:59:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), 10User-notice: On non-SET wikis (two edit tabs), links to new pages (red links) should open the user's preferred editor (last used) - https://phabricator.wikimedia.org/T223793 (... [18:01:44] (03CR) 10Jforrester: [C: 03+2] "> Patch Set 2: Code-Review-1" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/568865 (owner: 10Libraryupgrader) [18:04:29] 10VisualEditor, 10Product-Analytics, 10Editing-team (Q3 2019-2020 Kanban Board): Some EditAttemptStep events on existing pages do not have revision IDs - https://phabricator.wikimedia.org/T230133 (10matmarex) I think I just realized what is causing this – when you open the old wikitext edit page, `mw.config.... [18:04:36] 10VisualEditor, 10MobileFrontend, 10Design (RW-Design-Debt), 10Readers-Web-Backlog (Tracking), 10User-Ryasmeen: AbuseFilter warnings and errors are handled badly by the editor - https://phabricator.wikimedia.org/T202460 (10marcella) [18:04:38] 10VisualEditor, 10MobileFrontend, 10SpamBlacklist, 10User-Ryasmeen: Spam links trigger unknown error on mobile - https://phabricator.wikimedia.org/T167078 (10marcella) [18:07:05] 10VisualEditor, 10MobileFrontend, 10Editing-team (Q3 2019-2020 Kanban Board), 10Regression, and 2 others: [Regression] Disabling the ability to edit the whole article can make it impossible to edit on mobile in a specific scenario - https://phabricator.wikimedia.org/T232170 (10marcella) 05Open→03Resolved [18:08:01] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Parsoid, 10Editing-team (Q3 2019-2020 Kanban Board), and 3 others: Mangling of non existing media links by VisualEditor - https://phabricator.wikimedia.org/T232754 (10marcella) 05Open→03Resolved [18:09:20] 10VisualEditor, 10VisualEditor-DataModel, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), and 2 others: VE not successfully loading on pages with video or audio embeds: "TypeError: href is null" from ve.dm.MWInternalLinkAnnot... - https://phabricator.wikimedia.org/T235707 [18:16:55] 10Editing-team: Add a button to reply to user to mentorship questions - https://phabricator.wikimedia.org/T244651 (10Patriccck) @MMiller_WMF Yes, of course, I can answer follow-up questions try out prototypes :-). [18:38:29] (03PS1) 10Bartosz Dziewoński: Fix EditAttemptStep events logged with revision_id=0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/571555 (https://phabricator.wikimedia.org/T230133) [19:02:06] (03PS1) 10Jforrester: Update VE core submodule to master (792df1cd0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/571561 [19:07:16] (03CR) 10Jforrester: "How would this not be set? It comes from OutputPage::getJSVars(); is setRevisionId() not guaranteed to be called?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/571555 (https://phabricator.wikimedia.org/T230133) (owner: 10Bartosz Dziewoński) [19:13:25] (03CR) 10Bartosz Dziewoński: "Yeah. I apparently investigated that… a couple years ago, huh: https://phabricator.wikimedia.org/T62548#650251" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/571555 (https://phabricator.wikimedia.org/T230133) (owner: 10Bartosz Dziewoński) [19:13:57] (03CR) 10Jforrester: [C: 03+1] Fix EditAttemptStep events logged with revision_id=0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/571555 (https://phabricator.wikimedia.org/T230133) (owner: 10Bartosz Dziewoński) [19:25:10] 10VisualEditor, 10Community-Tech (Kanban-Q3-2019-20): Spike: Investigate Named References in VE [8 hours] - https://phabricator.wikimedia.org/T243300 (10Mooeypoo) Thank you for the analysis, @HMonroy, this is super helpful! As you've mentioned, working with citations within VisualEditor is a super complex pie... [19:57:13] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (Tracking), 10Mobile, 10Readers-Web-Backlog (Tracking): VisualDiff feature on mobile has an inconsistent style/layout - https://phabricator.wikimedia.org/T244673 (10matmarex) I think the scope of this is unclear… If this task is about consolidat... [20:37:15] (03CR) 10DLynch: [C: 03+2] "This seems sensible as a fallback -- are there any cases where it'll be initialized without a revisionid but also without the edit page fo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/571555 (https://phabricator.wikimedia.org/T230133) (owner: 10Bartosz Dziewoński) [20:44:50] (03PS1) 10Bartosz Dziewoński: Add .mw-parser-output to historical visual diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/571571 (https://phabricator.wikimedia.org/T244673) [20:49:53] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (Tracking), 10Mobile, and 2 others: VisualDiff feature on mobile has an inconsistent style/layout - https://phabricator.wikimedia.org/T244673 (10matmarex) I believe these patches result in an acceptable state. Example diff: | Before (mobile) | Af... [20:51:26] (03Merged) 10jenkins-bot: Fix EditAttemptStep events logged with revision_id=0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/571555 (https://phabricator.wikimedia.org/T230133) (owner: 10Bartosz Dziewoński) [21:06:55] (03CR) 10Bartosz Dziewoński: "This is less bad, but still seems a bit pointless. I worry that this change is still going to be considered unnecessary and antagonize our" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/509882 (https://phabricator.wikimedia.org/T223155) (owner: 10Esanders) [21:20:31] (03CR) 10VolkerE: [C: 03+1] Use WikimediaUI toolbar styling in Vector [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/509882 (https://phabricator.wikimedia.org/T223155) (owner: 10Esanders) [21:26:59] (03CR) 10VolkerE: [C: 03+1] "There's a lil more maintenance burden, it's 87 lines and it's actually coming much closer to our default styling, which means we can more " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/509882 (https://phabricator.wikimedia.org/T223155) (owner: 10Esanders) [21:29:22] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (Q3 2019-2020 Kanban Board), 10Mobile, and 2 others: VisualDiff feature on mobile has an inconsistent style/layout - https://phabricator.wikimedia.org/T244673 (10matmarex) [21:32:02] (03CR) 10Bartosz Dziewoński: "> This seems sensible as a fallback -- are there any cases where it'll be initialized without a revisionid but also without the edit page " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/571555 (https://phabricator.wikimedia.org/T230133) (owner: 10Bartosz Dziewoński) [21:33:40] (03CR) 10VolkerE: [C: 03+2] Use WikimediaUI toolbar styling in Vector [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/509882 (https://phabricator.wikimedia.org/T223155) (owner: 10Esanders) [21:35:05] 10VisualEditor, 10Product-Analytics, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18): Some EditAttemptStep events on existing pages do not have revision IDs - https://phabricator.wikimedia.org/T230133 (10matmarex) That should fix this. We should check if this is stil... [21:45:14] 10WikiEditor, 10CodeEditor, 10UI-Standardization, 10CSS, 10Design: Fix several design features of WikiEditor and CodeEditor to match the general style - https://phabricator.wikimedia.org/T174119 (10Volker_E) [21:45:17] 10WikiEditor, 10UI-Standardization, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), 10Patch-For-Review: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style - https://phabricator.wikimedia.org/T223155 (10Volker_E) 05Open→03Resolved a:03Esanders [21:45:28] 10WikiEditor, 10UI-Standardization, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11): WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style - https://phabricator.wikimedia.org/T223155 (10Volker_E) [21:49:27] (03Merged) 10jenkins-bot: Use WikimediaUI toolbar styling in Vector [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/509882 (https://phabricator.wikimedia.org/T223155) (owner: 10Esanders) [23:22:51] 10Cite, 10Mobile: cite button is generating incorrect isbn data for isbn 978-3-443-01063-8 - https://phabricator.wikimedia.org/T244890 (10Reedy) [23:59:33] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), 10Product-Analytics (Kanban): QA Revision IDs of EditAttemptStep schema - https://phabricator.wikimedia.org/T244939 (10Mayakp.wiki)