[03:07:04] 10VisualEditor, 10WikiEditor, 10I18n: Save button on Japanese Wikipedia is unnecessarily long - https://phabricator.wikimedia.org/T244595 (10Rxy) a:03RStallman-legalteam To: @RStallman-legalteam , CC: @jrbs Could you please ask for your supervisor to consulting to lawyer having knowledge to the Laws of Jap... [09:10:45] 10Cite: Reflist with embedded refs no longer shown in section preview - https://phabricator.wikimedia.org/T245376 (10Aklapper) Hi @DavidEppstein, thanks for taking the time to report this! Do you have a link handy to an example article where this issue can be seen? [12:39:52] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10VisualEditor-Tables: VE can't edit tables nested inside a transcluded table (example: row number single-column table from {{Rank}} on English Wikipedia) - https://phabricator.wikimedia.org/T245277 (10Timeshifter) >>! In T245277#5888288, @Aklapper wrote: >... [14:38:11] 10Cite, 10Book-Referencing, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), 10Patch-For-Review, and 3 others: Clean up implementation for "follow" cases - https://phabricator.wikimedia.org/T240858 (10thiemowmde) a:05thiemowmde→03None @awight, I believe you will find https://gerrit.wikimedia.org/r/570376 q... [14:42:05] 10VisualEditor, 10Operations, 10Parsoid, 10wikitech.wikimedia.org: VisualEditor was removed from Wikitech because Parsoid/PHP isn't yet compatible with how Wikitech is set up - https://phabricator.wikimedia.org/T241961 (10ayounsi) Any ETA on when it will be fixed? [14:45:14] I thought I might ask here before going too deep into the code: Is there a way to purge VisualEditor's cached, unsaved changes at the end of a workflow? I found that the new conflict resolution workflow sends the user back to "Resume your edit?" after a successful merge, which is wrong. [14:45:51] I'd like to leave the local, unsaved changes intact until the workflow completes, and then delete them. [14:51:55] 10VisualEditor, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-QWERTY-Sprint-2020-02-04: Bad interaction between VisualEditor and TwoColConflict - https://phabricator.wikimedia.org/T245119 (10awight) Found one clue, in `ve.init.mw.ArticleTargetLoader.js` we test that `response.oldid` != `wgCurRevisio... [14:52:23] ^ I think that's the issue, so I'm pretty close to solving it. [17:10:50] 10Cite, 10Analytics, 10Reference Previews, 10CPT Initiatives (Modern Event Platform (TEC2)): Remove or simplify tracking metrics - https://phabricator.wikimedia.org/T242127 (10Nuria) >The correct approach would be to simply emit StatsD metrics which can be directly consumed from Grafana to give all the sam... [17:29:12] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0), 10Product-Analytics (Kanban): Changes to EditAttemptStep schema for Discussion Tools Replying V1.0 - https://phabricator.wikimedia.org/T243467 (10Mayakp.wiki) [17:40:50] 10Cite: Reflist with embedded refs no longer shown in section preview - https://phabricator.wikimedia.org/T245376 (10DavidEppstein) Sure — go to https://en.wikipedia.org/wiki/A_Guide_to_the_Classification_Theorem_for_Compact_Surfaces, edit the references section using the source editor, and preview. I don't thin... [19:13:48] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor by default for all users of the Dutch Wikipedia - https://phabricator.wikimedia.org/T161365 (10ppelberg) [19:15:02] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor by default for all users of the Dutch Wikipedia - https://phabricator.wikimedia.org/T161365 (10ppelberg) [19:18:24] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor by default for all users of the Dutch Wikipedia - https://phabricator.wikimedia.org/T161365 (10ppelberg) >>! In T161365#5849523, @Whatamidoing-WMF wrote: > There isn't an "Edit mode" dropdown because it's not a https://www.mediawiki.org/wiki/Visual... [19:18:36] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor by default for all users of the Dutch Wikipedia - https://phabricator.wikimedia.org/T161365 (10ppelberg) a:03Whatamidoing-WMF [19:19:28] 10VisualEditor, 10Wikimedia-Site-requests, 10Editing-team (Q3 2019-2020 Kanban Board): Enable VisualEditor by default for all users of the Dutch Wikipedia - https://phabricator.wikimedia.org/T161365 (10ppelberg) [19:31:37] 10Editing-team, 10Editing Design, 10OWC2020 (New Discussion 1.0): Conduct a control test of as-is new discussion workflow - https://phabricator.wikimedia.org/T243251 (10iamjessklein) Thanks for the input @Jc86035 @ppelberg and @Whatamidoing-WMF Please provide your feedback on the [[ https://docs.google.com/... [20:06:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Thanks, good idea. There are a few more shim images defined elsewhere, they should get the same treatment:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/572364 (https://phabricator.wikimedia.org/T245319) (owner: 10Akinwale-microsoft) [20:09:09] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix: Add aria-label to comment inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/572361 (https://phabricator.wikimedia.org/T245315) (owner: 10Akinwale-microsoft) [20:11:25] (03Merged) 10jenkins-bot: Fix: Add aria-label to comment inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/572361 (https://phabricator.wikimedia.org/T245315) (owner: 10Akinwale-microsoft) [20:21:26] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think it would be better to directly use the localisation message in MWExternalLinkAnnotationWidget.js and ve.ui.MWInternalLinkAnnotatio" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572310 (https://phabricator.wikimedia.org/T245294) (owner: 10Akinwale-microsoft) [20:39:11] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (a5f81e9fb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572743 (https://phabricator.wikimedia.org/T245074) [20:40:18] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (a5f81e9fb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572743 (https://phabricator.wikimedia.org/T245074) (owner: 10Bartosz Dziewoński) [20:44:57] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Visual Editor Image node has wrong control type - https://phabricator.wikimedia.org/T245319 (10matmarex) [20:45:03] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Insert_comment is missing name(aria-label) - https://phabricator.wikimedia.org/T245315 (10matmarex) [20:45:07] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Ensures elements have alternate text or a role of none or presentation. - https://phabricator.wikimedia.org/T245307 (10matmarex) [20:45:11] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Internal and External Link annotation widget - https://phabricator.wikimedia.org/T245294 (10matmarex) [20:45:15] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board): Visual Editor accessibility bugs - https://phabricator.wikimedia.org/T242357 (10matmarex) [20:45:19] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: [VisualEditor] Fix missing name(aria-label) in Page Options - Find and Replace - https://phabricator.wikimedia.org/T245074 (10matmarex) [20:50:15] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board): Visual Editor accessibility bugs - https://phabricator.wikimedia.org/T242357 (10matmarex) @Akinwale-microsoft I assume all of the patches you've been submitting are based on this report? Thank you for working on this! [20:52:25] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (a5f81e9fb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572743 (https://phabricator.wikimedia.org/T245074) (owner: 10Bartosz Dziewoński) [20:53:51] (03Merged) 10jenkins-bot: Update VE core submodule to master (a5f81e9fb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572743 (https://phabricator.wikimedia.org/T245074) (owner: 10Bartosz Dziewoński) [21:57:30] (03CR) 10Akinwale-microsoft: "> Patch Set 2: Code-Review-1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572310 (https://phabricator.wikimedia.org/T245294) (owner: 10Akinwale-microsoft) [22:20:54] 10VisualEditor, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-QWERTY-Sprint-2020-02-04: Bad interaction between VisualEditor and TwoColConflict - https://phabricator.wikimedia.org/T245119 (10matmarex) I can reproduce, this is a VE bug. VE needs to clear its autosave state when switching to the old... [22:24:46] 10VisualEditor, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-QWERTY-Sprint-2020-02-04: Bad interaction between VisualEditor and TwoColConflict - https://phabricator.wikimedia.org/T245119 (10matmarex) (Feel free to submit a patch, otherwise I'll write one in a few days) [22:31:22] 10VisualEditor, 10Accessibility: Screen reader not announcement (Link "8c9c37e") in Version label is not descriptive - https://phabricator.wikimedia.org/T245470 (10Akinwale-microsoft)