[00:28:06] 10VisualEditor, 10Accessibility: Ensures elements have alternate text or a role of none or presentation. - https://phabricator.wikimedia.org/T246184 (10Akinwale-microsoft) [01:25:07] (03PS3) 10Akinwale-microsoft: Fix: Insert -> gallery dialog now contain label for screen readers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/574581 (https://phabricator.wikimedia.org/T245899) [01:25:42] (03CR) 10Akinwale-microsoft: "> Patch Set 2:" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/574581 (https://phabricator.wikimedia.org/T245899) (owner: 10Akinwale-microsoft) [01:28:17] 10Citoid, 10Editing-team, 10VisualEditor, 10VisualEditor-Mobile-UsabilityImprovements: citoid convert button hidden on mobile - https://phabricator.wikimedia.org/T246115 (10jeremyb-phone) to clarify none of this is on mdot. it's all desktop site just switching local user agent between default and desktop m... [02:22:16] 10VisualEditor, 10DiscussionTools, 10MediaWiki-General, 10Editing-team (Q3 2019-2020 Kanban Board), and 2 others: Upstream API error handling from VisualEditor to MediaWiki, use it in DiscussionTools - https://phabricator.wikimedia.org/T240519 (10Whatamidoing-WMF) I think that the report from @thiemowmde a... [02:38:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Page-editing, 10Accessibility: Visual Editor accesskey conflicts with Show Changes accesskey in edit page - https://phabricator.wikimedia.org/T156141 (10Whatamidoing-WMF) @AhmadF.Cheema reports problems wit... [02:38:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing: Alt+Shift+V access key in the wikitext editor switches to the visual one, so conflicts with 'show changes' which no longer works in Chrome, focus splits in Firefox - https://phabricator.wikimedia.org/T54701 (10Whatamidoing-WMF... [03:38:25] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-2017WikitextEditor: Add shortcut to insert nowiki text - https://phabricator.wikimedia.org/T245939 (10BrandonXLF) Yes, that would be correct. I guess the option can just be greyed out in visual mode similar to how the "Clear styling" optio... [03:39:09] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-2017WikitextEditor: Add shortcut to insert nowiki text - https://phabricator.wikimedia.org/T245939 (10BrandonXLF) >>! In T245939#5917270, @matmarex wrote: > I assume this is about the new wikitext editor – in visual mode, there's no need f... [03:40:10] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10User-Ryasmeen: Screen reader not announcement (Link "8c9c37e") in Version label is not descriptive - https://phabricator.wikimedia.org/T245470 (10ppelberg) 05Open→03Resolved We appreciate your work on this, @Akinwale-microsoft [03:40:49] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10User-Ryasmeen: Visual Editor Image node has wrong control type - https://phabricator.wikimedia.org/T245319 (10ppelberg) 05Open→03Resolved [03:41:33] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25): Internal and External Link annotation widget - https://phabricator.wikimedia.org/T245294 (10ppelberg) We appreciate your clear task descriptions (and the patches as well, of course). [03:43:59] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), 10User-Ryasmeen: Internal and External Link annotation widget - https://phabricator.wikimedia.org/T245294 (10ppelberg) 05Open→03Resolved [03:45:27] 10VisualEditor, 10VisualEditor-EditingTools: Use pre tag for preformatted text - https://phabricator.wikimedia.org/T245938 (10BrandonXLF) That makes sense. Maybe then an option to insert "Preformatted block" can be added under the "Insert" dropdown or when editing text is preformatted with a spart at the start... [08:40:48] 10WikiEditor, 10MediaWiki-extensions-Page_Forms: WikiEditor not show up in PageForms Section Textarea - https://phabricator.wikimedia.org/T246199 (10Tinganwiki) [10:15:50] 10WikiEditor, 10MediaWiki-extensions-Page_Forms: WikiEditor not show up in PageForms Section Textarea - https://phabricator.wikimedia.org/T246199 (10Tombolano) Hi, this works for me, what version of Page Forms are you using? I think this is related to this bug: https://phabricator.wikimedia.org/T239023, which... [11:35:37] 10WikiEditor, 10MediaWiki-extensions-Page_Forms: WikiEditor not show up in PageForms Section Textarea - https://phabricator.wikimedia.org/T246199 (10Tinganwiki) hi, I am using PageForms 0.5.2 and mediawiki1.34. The solution you sent me not work. but I fixed by my own solution. [12:05:39] 10WikiEditor, 10MediaWiki-extensions-Page_Forms: WikiEditor not show up in PageForms Section Textarea - https://phabricator.wikimedia.org/T246199 (10Tinganwiki) my solution works for me, but didn't consider downward compatibility issue, https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageForms/+/575006... [13:03:12] (03PS1) 10TheDJ: Fix dimensions of WE2017 switch to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/575010 (https://phabricator.wikimedia.org/T223155) [14:22:55] 10WikiEditor, 10MediaWiki-extensions-Page_Forms: WikiEditor not show up in PageForms Section Textarea - https://phabricator.wikimedia.org/T246199 (10Yaron_Koren) What version of Page Forms are you running? I assume it's not 0.5.2. [15:32:24] (03CR) 10DLynch: "The OOUI patch is +2'd, so I think this can be abandoned?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/573042 (https://phabricator.wikimedia.org/T245576) (owner: 10Akinwale-microsoft) [15:38:25] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing-team (Q3 2019-2020 Kanban Board), and 3 others: Mobile table editing should default to cell contents - https://phabricator.wikimedia.org/T211240 (10DLynch) @iamjessklein do you mean that in the sense tha... [16:31:36] (03PS15) 10DLynch: Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [16:31:41] (03PS3) 10VolkerE: Add `aria-label` to list of tool groups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/573686 (https://phabricator.wikimedia.org/T245776) (owner: 10Akinwale-microsoft) [16:39:38] (03CR) 10DLynch: "So, I rebased this and fixed merge conflicts that had accrued over the last year. It might be good to make sure that I didn't break anythi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [16:45:44] (03CR) 10jerkins-bot: [V: 04-1] Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [16:50:11] (03PS16) 10DLynch: Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [16:51:49] (03CR) 10DLynch: "I missed a few linting changes relating to promises while rebasing." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [16:56:10] 10VisualEditor: Please centralize enwiki's feedback for VisualEditor - https://phabricator.wikimedia.org/T224851 (10Whatamidoing-WMF) I think the simplest way to solve this problem is to reverse the "uninstall" part of {T148611}. [17:05:00] (03CR) 10jerkins-bot: [V: 04-1] Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [17:09:27] (03PS17) 10DLynch: Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [17:34:48] 10VisualEditor, 10Editing Design, 10Editing-team (Tracking): Draft requirements for sub-reference support in VE - https://phabricator.wikimedia.org/T245299 (10ppelberg) [17:36:44] 10VisualEditor, 10Editing Design, 10Editing-team (Tracking): Draft requirements for sub-reference support in VE - https://phabricator.wikimedia.org/T245299 (10ppelberg) Adding #editing_design so @iamjessklein can review ahead of tomorrow's meeting. [17:37:00] 10VisualEditor, 10Editing Design, 10Editing-team (Tracking): Draft requirements for sub-reference support in VE - https://phabricator.wikimedia.org/T245299 (10ppelberg) a:03iamjessklein [17:50:54] (03CR) 10Esanders: [C: 04-1] "It's rendering as 34px for me. When I delete the switch widget from the DOM the height of the toolbar doesn't change. What we do need to c" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/575010 (https://phabricator.wikimedia.org/T223155) (owner: 10TheDJ) [17:57:38] 10VisualEditor, 10Accessibility: Ensures every accesskey attribute value is unique (#wpDiff) - https://phabricator.wikimedia.org/T246247 (10Akinwale-microsoft) [18:08:40] 10VisualEditor, 10Commons, 10Multimedia, 10UploadWizard, 10good first task: Automatic upload comments by Upload Wizard are unhelpful, make them more informative - https://phabricator.wikimedia.org/T234192 (10Soda) a:03Soda @kaldari Should I hard code the text or should I throw them on the messages API?... [20:03:03] 10Cite, 10MediaWiki-Core-Testing, 10MediaWiki-Parser, 10Tidy: Upgrade parserTests in cite to v2 - https://phabricator.wikimedia.org/T246285 (10cscott) [20:06:23] 10VisualEditor, 10WikiEditor, 10I18n: Save button on Japanese Wikipedia is unnecessarily long - https://phabricator.wikimedia.org/T244595 (10Rxy) @Jrogers-WMF I sent an e-mail to your team [20:07:18] 10Cite, 10MediaWiki-Core-Testing, 10MediaWiki-Parser, 10Tidy, 10Patch-For-Review: Upgrade parserTests in cite to v2 - https://phabricator.wikimedia.org/T246285 (10cscott) [20:21:58] 10Editing-team, 10VisualEditor, 10VisualEditor-MediaWiki, 10OWC2020: "Remember my last editor" should probably not change preference if only one editor was available in 2017WTE - https://phabricator.wikimedia.org/T246259 (10Esanders) [20:23:48] (03PS1) 10Esanders: NWE: Don't change editor preference if visual mode not available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/575078 (https://phabricator.wikimedia.org/T246259) [20:33:22] 10Cite, 10Book-Referencing, 10WMDE-QWERTY-Team, 10Patch-For-Review, 10Technical-Debt: Cleanup and document code dealing with incomplete follow - https://phabricator.wikimedia.org/T245549 (10beleg_tal) > I have seen some continuing footnoes that are quite complex If anyone wants examples of a "follow" re... [20:44:46] (03CR) 10TheDJ: "@esanders.. Thats strange, for me it absolutely does.. both Safari and Chrome and logged in and anonymous..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/575010 (https://phabricator.wikimedia.org/T223155) (owner: 10TheDJ) [20:50:45] (03CR) 10TheDJ: "screen recording: https://phabricator.wikimedia.org/F31632550" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/575010 (https://phabricator.wikimedia.org/T223155) (owner: 10TheDJ) [20:54:12] (03CR) 10Esanders: "oooh, I didn't realise my WMUI patch had merged (that's bold :)) - my local copy was not up to date :/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/575010 (https://phabricator.wikimedia.org/T223155) (owner: 10TheDJ) [20:57:48] (03CR) 10Jforrester: [C: 03+1] NWE: Don't change editor preference if visual mode not available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/575078 (https://phabricator.wikimedia.org/T246259) (owner: 10Esanders) [20:57:55] (03CR) 10Esanders: [C: 03+2] Fix dimensions of WE2017 switch to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/575010 (https://phabricator.wikimedia.org/T223155) (owner: 10TheDJ) [21:11:15] (03Merged) 10jenkins-bot: Fix dimensions of WE2017 switch to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/575010 (https://phabricator.wikimedia.org/T223155) (owner: 10TheDJ) [21:50:09] 10VisualEditor, 10OOUI, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Toggle buttons in table properties do have names missing label - https://phabricator.wikimedia.org/T245576 (10matmarex) (waiting for next OOUI release) [22:03:23] (03CR) 10Bartosz Dziewoński: "Instead of this, I think we might be able to specify `label: ..., invisibleLabel: true` in the definitions of the toolbar buttons, e.g. ve" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/573686 (https://phabricator.wikimedia.org/T245776) (owner: 10Akinwale-microsoft) [22:05:22] 10VisualEditor: accesskey "v" is already used for "show changes" - https://phabricator.wikimedia.org/T54969 (10matmarex) [22:05:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing: Alt+Shift+V access key in the wikitext editor switches to the visual one, so conflicts with 'show changes' which no longer works in Chrome, focus splits in Firefox - https://phabricator.wikimedia.org/T54701 (10matmarex) [22:09:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10Accessibility: Visual Editor accesskey conflicts with Show Changes accesskey in edit page - https://phabricator.wikimedia.org/T156141 (10matmarex) [22:10:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing: Alt+Shift+V access key in the wikitext editor switches to the visual one, so conflicts with 'show changes' which no longer works in Chrome, focus splits in Firefox - https://phabricator.wikimedia.org/T54701 (10matmarex) [22:10:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10Accessibility: Visual Editor accesskey conflicts with Show Changes accesskey in edit page - https://phabricator.wikimedia.org/T156141 (10matmarex) [22:10:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10Accessibility: Alt+Shift+V access key in the wikitext editor switches to the visual one, so conflicts with 'show changes' which no longer works in Chrome, focus splits in Firefox - https://phabricator.wikimedia.org/T54701 (10matmarex) [22:13:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10Accessibility: Alt+Shift+V access key in the wikitext editor switches to the visual one, so conflicts with 'show changes' which no longer works in Chrome, focus splits in Firefox - https://phabricator.wikimedia.org/T54701 (10matmarex) [22:13:56] 10VisualEditor, 10Accessibility: Ensures every accesskey attribute value is unique (#wpDiff) - https://phabricator.wikimedia.org/T246247 (10matmarex) [23:19:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: "Remember my last editor" should probably not change preference if only one editor was available in 2017WTE - https://phabricator.wikimedia.org/T246259 (10matmarex) [23:38:36] 10VisualEditor, 10Editing Design, 10Editing-team (Tracking): Draft requirements for sub-reference support in VE - https://phabricator.wikimedia.org/T245299 (10ppelberg)