[11:12:01] (03CR) 10Esanders: [C: 03+2] Use built-in mw.Api 'badtoken' handling, also 'assert'/'assertuser' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572375 (https://phabricator.wikimedia.org/T245327) (owner: 10Bartosz Dziewoński) [11:13:11] (03CR) 10Esanders: [C: 03+2] Clean up code related to token and bad token handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572388 (owner: 10Bartosz Dziewoński) [11:25:48] (03Merged) 10jenkins-bot: Use built-in mw.Api 'badtoken' handling, also 'assert'/'assertuser' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572375 (https://phabricator.wikimedia.org/T245327) (owner: 10Bartosz Dziewoński) [11:25:59] (03Merged) 10jenkins-bot: Clean up code related to token and bad token handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/572388 (owner: 10Bartosz Dziewoński) [12:11:56] (03CR) 10Esanders: "Vector contains lots of legacy design patterns. WMUI is the current standard so that should be fixed in the other direction." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575690 (owner: 10Esanders) [12:42:55] (03CR) 10Fomafix: [C: 04-1] "The pinable pull down menu should have any UI indicator. Currently it is just an up arrow when pinned. But without an UI indicator it is n" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575690 (owner: 10Esanders) [13:03:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New Wikitext Editor: Previews should use the article-view rendering engine - https://phabricator.wikimedia.org/T154844 (10Tkarcher) To add a current example to the discussion: The table header in https://de.wikipedia.org/wiki/Vorlage:Charteintrag/Be... [13:14:17] (03CR) 10Bartosz Dziewoński: "We have used an up/down indicator in some more recent interfaces too… for example, the "Other review rools" collapsible box on https://en." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575690 (owner: 10Esanders) [14:30:13] 10Citoid, 10Wikidata: Remember user's last tab preference - https://phabricator.wikimedia.org/T246990 (10Samwalton9) [14:30:23] 10Citoid, 10Wikidata: Remember user's last tab preference - https://phabricator.wikimedia.org/T246990 (10Samwalton9) p:05Triage→03High [14:42:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New Wikitext Editor: Previews should use the article-view rendering engine - https://phabricator.wikimedia.org/T154844 (10TheDJ) @Tkarcher that would be {T212085}, not this issue. [14:57:32] 10Citoid, 10Wikidata: Remember user's last tab preference - https://phabricator.wikimedia.org/T246990 (10Lucas_Werkmeister_WMDE) > Users will find it frustrating to need to keep clicking the 'Manual' tab if they don't want to use Citoid's Automatic tab. Is 'Manual' not going to remain the default? [15:00:26] 10Citoid, 10Wikidata: Remember user's last tab preference - https://phabricator.wikimedia.org/T246990 (10Lydia_Pintscher) The plan was to have the automatic be the default in the long run. [15:01:59] (03PS1) 10Bartosz Dziewoński: Add some accessibility labels to buttons on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/577253 [15:02:14] (03PS1) 10Bartosz Dziewoński: Add some accessibility labels to buttons on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/577254 [15:15:29] (03CR) 10jerkins-bot: [V: 04-1] Add some accessibility labels to buttons on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/577254 (owner: 10Bartosz Dziewoński) [15:31:57] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (1240e4ead) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/576993 (owner: 10Jforrester) [15:35:23] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10TemplateStyles: TemplateStyles not loaded in NWE preview - https://phabricator.wikimedia.org/T212085 (10matmarex) This is the same as T197563. That task fixed the rendering of templates in visual mode, we need to apply the same fix to preview in... [15:40:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New Wikitext Editor: Previews should use the article-view rendering engine - https://phabricator.wikimedia.org/T154844 (10Tkarcher) Ah, thanks - I didn't know about that one. But wouldn't a change of the rendering engine also fix T212085? [15:46:18] (03Merged) 10jenkins-bot: Update VE core submodule to master (1240e4ead) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/576993 (owner: 10Jforrester) [15:50:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New Wikitext Editor: Previews should use the article-view rendering engine - https://phabricator.wikimedia.org/T154844 (10matmarex) In this case, it actually wouldn't… We have code that specifically removes `style` tags after rendering the preview (a... [15:52:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New Wikitext Editor: Previews should use the article-view rendering engine - https://phabricator.wikimedia.org/T154844 (10Jc86035) > But wouldn't a change of the rendering engine also fix T212085? It might well, but this task has been largely dormant... [15:58:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10TemplateStyles, 10Editing-team (Q3 2019-2020 Kanban Board): TemplateStyles not loaded in NWE preview - https://phabricator.wikimedia.org/T212085 (10matmarex) a:03matmarex [15:58:42] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Remove meta element filtering from wikitext preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/577275 (https://phabricator.wikimedia.org/T212085) [16:10:23] (03CR) 10Bartosz Dziewoński: "(depends on https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/577253)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/577254 (owner: 10Bartosz Dziewoński) [16:22:29] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Use stem-less back arrow in overlays to match WMUI - https://phabricator.wikimedia.org/T246658 (10matmarex) [16:23:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New Wikitext Editor: Previews should use the article-view rendering engine - https://phabricator.wikimedia.org/T154844 (10DLynch) @Tkarcher alas, no -- that's about how dependencies bundled with the preview markup are applied. Which parser is used ma... [16:40:21] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog, 10Editing-team (Q3 2019-2020 Kanban Board), 10Skipped QA: Use stem-less back arrow in overlays to match WMUI - https://phabricator.wikimedia.org/T246658 (10matmarex) [16:42:06] 10VisualEditor: Visual editor breaks labeled sections, invisibly removes line breaks - https://phabricator.wikimedia.org/T247001 (10Writ_Keeper) [17:05:47] (03CR) 10DLynch: "If we're leaving the link/meta elements in, should we also switch to proactively empty $previewViewer whenever the preview pane is swapped" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/577275 (https://phabricator.wikimedia.org/T212085) (owner: 10Bartosz Dziewoński) [17:11:30] (03CR) 10DLynch: "I have verified this: viewing the preview and closing the dialog leaves the preview output in the DOM, so the styles would presumably pers" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/577275 (https://phabricator.wikimedia.org/T212085) (owner: 10Bartosz Dziewoński) [19:30:48] 10VisualEditor, 10MediaWiki-Page-editing, 10MinervaNeue (Desktop): On the desktop site, editing the lead section of a page under MinervaNeue skin directs a user to one of desktop WikiEditors - https://phabricator.wikimedia.org/T190989 (10Jdlrobson) Per T190989#5924922 @matmarex can this be resolved? I'm not... [21:20:00] 10VisualEditor: Visual editor breaks labeled sections, invisibly removes line breaks - https://phabricator.wikimedia.org/T247001 (10matmarex) Looks like `
` tags are incorrectly treated as "meta" nodes, instead of "alien extension" nodes. For reference: * Meta nodes are those for which it doesn't matter... [21:36:47] (03PS1) 10Bartosz Dziewoński: ve.dm.MWAlienMetaItem: Never match mw:Extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/577350 (https://phabricator.wikimedia.org/T247001) [21:43:49] 10VisualEditor, 10Patch-For-Review: Visual editor breaks labeled sections, invisibly removes line breaks - https://phabricator.wikimedia.org/T247001 (10matmarex) This patch would fix this issue, but I'm not sure if it might have any bad consequences elsewhere. We might need to think about this a bit more. The... [22:18:48] 10VisualEditor, 10Parsoid, 10Parsoid-Serializer, 10RESTBase, and 2 others: Detect when a page save is likely to be a corruption - https://phabricator.wikimedia.org/T182740 (10ssastry) [22:19:16] 10VisualEditor, 10Parsoid, 10Parsoid-Serializer, 10RESTBase, and 2 others: Detect when a page save is likely to be a corruption - https://phabricator.wikimedia.org/T182740 (10ssastry) p:05Medium→03Low [22:59:38] 10VisualEditor, 10Patch-For-Review: Visual editor breaks labeled sections, invisibly removes line breaks - https://phabricator.wikimedia.org/T247001 (10Jdforrester-WMF) >>! In T247001#5946511, @matmarex wrote: > I would suggest never using `
` tags and instead putting the data that must be reused betwe... [23:21:06] 10VisualEditor, 10Patch-For-Review: Visual editor breaks labeled sections, invisibly removes line breaks - https://phabricator.wikimedia.org/T247001 (10Writ_Keeper) I'm far from an expert at the intricacies of magic word/template/whatever parsing here, but the enwiki help page suggests that such a template isn...