[00:29:01] (03CR) 10Ppchelko: [C: 03+2] Remove use of WikiPage::getRevision [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587373 (https://phabricator.wikimedia.org/T249393) (owner: 10DannyS712) [00:50:11] 10VisualEditor, 10StructuredDataOnCommons, 10WikibaseMediaInfo, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: When inserting an image using Visual Editor, show media description in the language of the wiki - https://phabricator.wikimedia.org/T249442 (10Jdforrester-WMF) >>! In T249442#60... [00:52:08] 10VisualEditor, 10StructuredDataOnCommons, 10WikibaseMediaInfo, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: When inserting an image using Visual Editor, show CommonsMetadata content in the language of the wiki - https://phabricator.wikimedia.org/T249442 (10Jdforrester-WMF) [00:53:14] (03Merged) 10jenkins-bot: Remove use of WikiPage::getRevision [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587373 (https://phabricator.wikimedia.org/T249393) (owner: 10DannyS712) [01:04:29] (03CR) 10Jforrester: [C: 03+2] "Huh. Indeed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587323 (owner: 10Krinkle) [01:29:11] (03Merged) 10jenkins-bot: jquery.wikiEditor: change autoIcon() to no longer append version string [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587323 (owner: 10Krinkle) [08:10:21] (03CR) 10DannyS712: Tag WikiEditor edits with a hidden tag (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587228 (https://phabricator.wikimedia.org/T249038) (owner: 10Esanders) [12:51:42] (03PS2) 10Esanders: Match entity encoding in HTML comments to Parsoid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/587363 (https://phabricator.wikimedia.org/T144708) (owner: 10Bartosz Dziewoński) [12:54:05] (03CR) 10Esanders: [C: 04-1] "Isn't our behaviour more sensible? Shouldn't Parsoid be fixed?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/587363 (https://phabricator.wikimedia.org/T144708) (owner: 10Bartosz Dziewoński) [12:55:28] 10Cite, 10VisualEditor, 10Parsoid, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Unexpected DOM diff on a node after an edit - https://phabricator.wikimedia.org/T144708 (10Esanders) It seems like the VE approach avoids encoding '-' in comments, which I imagine is quite common, and... [12:59:06] (03CR) 10Esanders: [C: 04-1] build: Upgrade eslint- and stylelint-config-wikimedia (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/585623 (owner: 10Jforrester) [14:36:57] (03CR) 10Divec: [C: 04-1] build: Upgrade eslint- and stylelint-config-wikimedia (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/585623 (owner: 10Jforrester) [14:39:11] (03PS1) 10Divec: Fix initialization typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/587532 [14:40:37] (03PS4) 10Divec: build: Upgrade eslint- and stylelint-config-wikimedia [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/585623 (owner: 10Jforrester) [14:43:50] (03CR) 10Divec: [C: 03+1] "Ok, rebased onto a fix of that typo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/585623 (owner: 10Jforrester) [14:45:13] (03CR) 10Esanders: [C: 03+2] Fix initialization typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/587532 (owner: 10Divec) [14:45:28] (03CR) 10Esanders: [C: 03+2] build: Upgrade eslint- and stylelint-config-wikimedia [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/585623 (owner: 10Jforrester) [14:47:17] (03Merged) 10jenkins-bot: Fix initialization typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/587532 (owner: 10Divec) [14:47:29] (03Merged) 10jenkins-bot: build: Upgrade eslint- and stylelint-config-wikimedia [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/585623 (owner: 10Jforrester) [16:21:38] 10Cite, 10VisualEditor, 10Parsoid, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Unexpected DOM diff on a node after an edit - https://phabricator.wikimedia.org/T144708 (10cscott) I wrote the encoding code, and it was originally carefully the same in Parsoid and VE. The encoding... [16:29:38] 10VisualEditor, 10MediaWiki-Page-rename: Provide assistance for renaming an article - https://phabricator.wikimedia.org/T244092 (10DannyS712) [16:32:57] 10Cite, 10VisualEditor, 10Parsoid, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Unexpected DOM diff on a node after an edit - https://phabricator.wikimedia.org/T144708 (10ssastry) >>! In T144708#6039620, @Esanders wrote: > It seems like the VE approach avoids encoding '-' in comm... [16:42:55] (03CR) 10C. Scott Ananian: "> Isn't our behaviour more sensible? Shouldn't Parsoid be fixed?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/587363 (https://phabricator.wikimedia.org/T144708) (owner: 10Bartosz Dziewoński) [16:47:41] (03PS1) 10Krinkle: Remove redundant dependency on 'mediawiki.notify' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587558 (https://phabricator.wikimedia.org/T233676) [16:52:26] (03PS2) 10Esanders: Tag WikiEditor edits with a hidden tag [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587228 (https://phabricator.wikimedia.org/T249038) [17:04:54] (03CR) 10Jforrester: [C: 03+2] Remove redundant dependency on 'mediawiki.notify' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587558 (https://phabricator.wikimedia.org/T233676) (owner: 10Krinkle) [17:05:30] (03CR) 10jerkins-bot: [V: 04-1] Tag WikiEditor edits with a hidden tag [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587228 (https://phabricator.wikimedia.org/T249038) (owner: 10Esanders) [17:18:08] (03Merged) 10jenkins-bot: Remove redundant dependency on 'mediawiki.notify' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587558 (https://phabricator.wikimedia.org/T233676) (owner: 10Krinkle) [17:29:46] (03PS3) 10Jforrester: Tag WikiEditor edits with a hidden tag [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587228 (https://phabricator.wikimedia.org/T249038) (owner: 10Esanders) [17:31:35] (03PS1) 10C. Scott Ananian: Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587563 (https://phabricator.wikimedia.org/T236809) [17:33:07] (03CR) 10Reedy: [C: 03+2] Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587563 (https://phabricator.wikimedia.org/T236809) (owner: 10C. Scott Ananian) [17:35:25] (03PS1) 10Reedy: Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.27) - 10https://gerrit.wikimedia.org/r/587565 (https://phabricator.wikimedia.org/T236809) [17:35:30] (03CR) 10Reedy: [C: 03+2] Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.27) - 10https://gerrit.wikimedia.org/r/587565 (https://phabricator.wikimedia.org/T236809) (owner: 10Reedy) [17:35:38] (03PS1) 10Reedy: Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.26) - 10https://gerrit.wikimedia.org/r/587566 (https://phabricator.wikimedia.org/T236809) [17:35:45] (03CR) 10Reedy: [C: 03+2] Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.26) - 10https://gerrit.wikimedia.org/r/587566 (https://phabricator.wikimedia.org/T236809) (owner: 10Reedy) [17:41:11] (03CR) 10jerkins-bot: [V: 04-1] Tag WikiEditor edits with a hidden tag [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587228 (https://phabricator.wikimedia.org/T249038) (owner: 10Esanders) [17:44:11] (03CR) 10jerkins-bot: [V: 04-1] Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587563 (https://phabricator.wikimedia.org/T236809) (owner: 10C. Scott Ananian) [17:44:35] (03CR) 10Jforrester: "https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/59604/artifact/log/Page-should-be-undoable.png" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587228 (https://phabricator.wikimedia.org/T249038) (owner: 10Esanders) [17:47:14] (03PS2) 10C. Scott Ananian: Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587563 (https://phabricator.wikimedia.org/T236809) [17:47:21] (03CR) 10jerkins-bot: [V: 04-1] Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.27) - 10https://gerrit.wikimedia.org/r/587565 (https://phabricator.wikimedia.org/T236809) (owner: 10Reedy) [17:47:23] (03CR) 10Jforrester: [C: 04-1] Tag WikiEditor edits with a hidden tag [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587228 (https://phabricator.wikimedia.org/T249038) (owner: 10Esanders) [17:48:14] (03CR) 10jerkins-bot: [V: 04-1] Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.26) - 10https://gerrit.wikimedia.org/r/587566 (https://phabricator.wikimedia.org/T236809) (owner: 10Reedy) [17:50:06] (03PS2) 10Reedy: Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.26) - 10https://gerrit.wikimedia.org/r/587566 (https://phabricator.wikimedia.org/T236809) [17:50:13] (03PS2) 10Reedy: Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.27) - 10https://gerrit.wikimedia.org/r/587565 (https://phabricator.wikimedia.org/T236809) [17:51:03] (03CR) 10Reedy: [C: 03+2] Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.27) - 10https://gerrit.wikimedia.org/r/587565 (https://phabricator.wikimedia.org/T236809) (owner: 10Reedy) [17:51:08] (03CR) 10Reedy: [C: 03+2] Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.26) - 10https://gerrit.wikimedia.org/r/587566 (https://phabricator.wikimedia.org/T236809) (owner: 10Reedy) [17:51:13] (03CR) 10Reedy: [C: 03+2] Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587563 (https://phabricator.wikimedia.org/T236809) (owner: 10C. Scott Ananian) [18:03:58] (03Merged) 10jenkins-bot: Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.27) - 10https://gerrit.wikimedia.org/r/587565 (https://phabricator.wikimedia.org/T236809) (owner: 10Reedy) [18:05:07] (03Merged) 10jenkins-bot: Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] (wmf/1.35.0-wmf.26) - 10https://gerrit.wikimedia.org/r/587566 (https://phabricator.wikimedia.org/T236809) (owner: 10Reedy) [18:05:12] (03Merged) 10jenkins-bot: Don't use deprecated Parser::enableOOUI() hook [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587563 (https://phabricator.wikimedia.org/T236809) (owner: 10C. Scott Ananian) [18:08:43] (03CR) 10Esanders: "I've not done tagging stuff before. What is a better way? I'd rather we kept some code in the client to verify that the user did run the W" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/587228 (https://phabricator.wikimedia.org/T249038) (owner: 10Esanders) [20:12:09] (03PS1) 10C. Scott Ananian: Remove deprecated Parser::enableOOUI(), take 2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587591 [20:21:59] (03CR) 10Jforrester: [C: 03+2] Remove deprecated Parser::enableOOUI(), take 2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587591 (owner: 10C. Scott Ananian) [20:36:18] (03Merged) 10jenkins-bot: Remove deprecated Parser::enableOOUI(), take 2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587591 (owner: 10C. Scott Ananian) [20:46:08] (03PS1) 10Jforrester: Remove deprecated Parser::enableOOUI(), take 2 [extensions/TemplateData] (wmf/1.35.0-wmf.27) - 10https://gerrit.wikimedia.org/r/587595 [20:46:13] (03CR) 10Jforrester: [C: 03+2] Remove deprecated Parser::enableOOUI(), take 2 [extensions/TemplateData] (wmf/1.35.0-wmf.27) - 10https://gerrit.wikimedia.org/r/587595 (owner: 10Jforrester) [20:46:25] (03PS1) 10Jforrester: Remove deprecated Parser::enableOOUI(), take 2 [extensions/TemplateData] (wmf/1.35.0-wmf.26) - 10https://gerrit.wikimedia.org/r/587596 [20:46:29] (03CR) 10Jforrester: [C: 03+2] Remove deprecated Parser::enableOOUI(), take 2 [extensions/TemplateData] (wmf/1.35.0-wmf.26) - 10https://gerrit.wikimedia.org/r/587596 (owner: 10Jforrester) [20:46:50] (03CR) 10C. Scott Ananian: "This is a follow up to Ib75f530506bfc9692137b0538f66eb5b511637f0 (which is itself a follow up to I71be19c1d735fef5b781c68ef7ba47cafc37595d" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587591 (owner: 10C. Scott Ananian) [20:49:14] (03PS1) 10C. Scott Ananian: Improve directionality settings for TemplateDataBlob rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587597 [20:49:45] (03CR) 10C. Scott Ananian: "For discussion; especially in regard to T101666." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/587597 (owner: 10C. Scott Ananian) [20:59:03] (03Merged) 10jenkins-bot: Remove deprecated Parser::enableOOUI(), take 2 [extensions/TemplateData] (wmf/1.35.0-wmf.27) - 10https://gerrit.wikimedia.org/r/587595 (owner: 10Jforrester) [20:59:27] (03Merged) 10jenkins-bot: Remove deprecated Parser::enableOOUI(), take 2 [extensions/TemplateData] (wmf/1.35.0-wmf.26) - 10https://gerrit.wikimedia.org/r/587596 (owner: 10Jforrester)