[00:24:44] (03PS2) 10Esanders: Build: Update linters and fix errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 [00:24:57] (03CR) 10jerkins-bot: [V: 04-1] Build: Update linters and fix errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 (owner: 10Esanders) [00:28:23] (03PS1) 10Esanders: eslintrc: Cleanup rule overrides [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/589453 [01:48:17] (03CR) 10Jforrester: [C: 03+2] eslintrc: Cleanup rule overrides [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/589453 (owner: 10Esanders) [01:50:57] (03Merged) 10jenkins-bot: eslintrc: Cleanup rule overrides [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/589453 (owner: 10Esanders) [01:54:24] (03PS3) 10Jforrester: eslint: Enable the `mediawiki/class-doc` rule and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 (owner: 10Esanders) [01:54:58] (03CR) 10Jforrester: [C: 03+2] eslint: Enable the `mediawiki/class-doc` rule and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 (owner: 10Esanders) [02:05:57] (03CR) 10jerkins-bot: [V: 04-1] eslint: Enable the `mediawiki/class-doc` rule and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 (owner: 10Esanders) [04:42:11] 10VisualEditor, 10Growth-Team, 10MediaWiki-extensions-GuidedTour, 10Patch-For-Review: Allow hiding VE onboarding experience programmatically to avoid sidetracking users using a different onboarding experience - https://phabricator.wikimedia.org/T122623 (10Catrope) [04:42:14] 10Editing-team, 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: suppress editor popups for guidance - https://phabricator.wikimedia.org/T235566 (10Catrope) [04:42:27] 10VisualEditor, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): vehidebetadialog doesn't work for page views, gets erased when user clicks edit - https://phabricator.wikimedia.org/T249957 (10Catrope) [04:42:30] 10Editing-team, 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: suppress editor popups for guidance - https://phabricator.wikimedia.org/T235566 (10Catrope) [04:43:18] 10Editing-team, 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: suppress editor popups for guidance - https://phabricator.wikimedia.org/T235566 (10Catrope) I'm an idiot, this was actually very simple, and I didn't need the refactoring that I was doing in VE at all.... [05:19:31] 10Editing-team, 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: suppress editor popups for guidance - https://phabricator.wikimedia.org/T235566 (10Catrope) >>! In T235566#6060441, @MMiller_WMF wrote: > @Catrope @matmarex -- thanks for checking. What are some exampl... [06:55:06] 10VisualEditor: Changing active namespaces of VisualEditor on VEC Wikipedia - https://phabricator.wikimedia.org/T250419 (10QEDK) @Vajotwo link to community discussions please. [06:56:03] 10VisualEditor, 10Wikimedia-Site-requests, 10User-QEDK: Changing active namespaces of VisualEditor on VEC Wikipedia - https://phabricator.wikimedia.org/T250419 (10QEDK) [07:46:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Maps (Kartographer): Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor - https://phabricator.wikimedia.org/T250463 (10Daylen) [07:57:16] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Preview template on page doesn't appear on the 2017 wikitext editor - https://phabricator.wikimedia.org/T250464 (10Daylen) [08:04:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Maps (Kartographer): Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor - https://phabricator.wikimedia.org/T250463 (10TheDJ) a:03TheDJ [08:18:13] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Preview template on page doesn't appear on the 2017 wikitext editor - https://phabricator.wikimedia.org/T250464 (10Dvorapa) [08:18:20] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-TemplateSandbox, 10Patch-For-Review: Support "Preview page with this template" (TemplateSandbox) in the new wikitext editor - https://phabricator.wikimedia.org/T153367 (10Dvorapa) [12:01:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Maps (Kartographer): Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor - https://phabricator.wikimedia.org/T250463 (10TheDJ) 05Open→03Invalid 1. That's not a Kartographer map on that... [12:24:02] 10Editing-team, 10MediaWiki-Page-editing, 10Regression: Watch star is not updated when page is saved with "Watch this page" selected - https://phabricator.wikimedia.org/T201271 (10Ammarpad) 05Open→03Invalid Not reproducible on English Wikipedia [13:16:59] 10Editing-team, 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: suppress editor popups for guidance - https://phabricator.wikimedia.org/T235566 (10Esanders) > ...such trivial things as "please write in British English... Shhh, @Jdforrester-WMF might hear you! [13:33:12] (03PS4) 10Esanders: eslint: Enable the `mediawiki/class-doc` rule and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 [13:35:56] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing Design, 10MediaWiki-User-preferences, 10Design: Re-design the Editing preferences to make it easier to pick the editing environment that you want to use - https://phabricator.wikimedia.org/T202921 (10Pelagic) Thanks for raising this t... [13:45:51] 10VisualEditor, 10ConfirmEdit (CAPTCHA extension): ReCaptchaNoCaptcha not working in VisualEditor - https://phabricator.wikimedia.org/T250488 (10Florian) [14:37:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing Design, 10MediaWiki-User-preferences, 10Design: Re-design the Editing preferences to make it easier to pick the editing environment that you want to use - https://phabricator.wikimedia.org/T202921 (10Pelagic) Minor observation: on en-... [15:54:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing Design, 10MediaWiki-User-preferences, 10Design: Re-design the Editing preferences to make it easier to pick the editing environment that you want to use - https://phabricator.wikimedia.org/T202921 (10Pelagic) Anyway, sorry for the dig... [16:08:01] 10VisualEditor, 10Parsoid: VE leaves around inline data-parsoid on edited content - https://phabricator.wikimedia.org/T239875 (10LGoto) p:05Triage→03Medium [16:09:10] 10VisualEditor, 10Parsoid: VE leaves around inline data-parsoid on edited content - https://phabricator.wikimedia.org/T239875 (10cscott) Seems like either: 1) VE should strip inline `data-parsoid` to be consistent in the RESTBase and non-RESTBase scenarios, or 2) We need to rethink how we handle the non-RESTBa... [16:26:24] 10VisualEditor, 10Parsoid: Previewing a page on Wikidata freezes VisualEditor - https://phabricator.wikimedia.org/T223797 (10LGoto) p:05Triage→03Low [16:26:45] 10Editing-team, 10Editing Design, 10OWC2020: Create "journey map" for "Talk pages project" - https://phabricator.wikimedia.org/T247763 (10ppelberg) **Journey map details** Below are the people, their goals and the components of these goals @iamjessklein and I have come to think the journey map(s) ought to re... [16:28:41] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: VE should respect/preserve original block formatting in block template (comments between template parameters) - https://phabricator.wikimedia.org/T225349 (10LGoto) p:05Triage→03Medium [17:19:44] 10VisualEditor, 10Wikimedia-Site-requests, 10User-QEDK: Changing active namespaces of VisualEditor on VEC Wikipedia - https://phabricator.wikimedia.org/T250419 (10QEDK) p:05Triage→03Low a:03QEDK [17:25:25] 10Editing-team, 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: suppress editor popups for guidance - https://phabricator.wikimedia.org/T235566 (10MMiller_WMF) @Catrope -- okay, I understand now about the edit notices. We can refrain from suppressing them, and when... [17:31:50] (03PS5) 10Sohom Datta: Treat links to diffs and history pages as external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/583616 (https://phabricator.wikimedia.org/T248076) [18:04:10] 10WikiEditor, 10I18n: Thanks, but it's not working properly to input Korean character. - https://phabricator.wikimedia.org/T250468 (10Aklapper) 05Stalled→03Open [18:04:32] 10WikiEditor, 10I18n: Korean character input unexpectedly moves lines in WikiEditor - https://phabricator.wikimedia.org/T250468 (10Aklapper) [18:05:06] 10WikiEditor, 10I18n: Korean character input unexpectedly moves lines in WikiEditor - https://phabricator.wikimedia.org/T250468 (10revi) T250468#6066466 is reproducible on kowiki. Also seen on Windows 10 Education (10.0.18363.778) Chrome C81. [18:05:59] 10WikiEditor, 10I18n: Korean character input unexpectedly moves lines in WikiEditor - https://phabricator.wikimedia.org/T250468 (10revi) >>! In T250468#6066499, @revi wrote: > T250468#6066466 is reproducible on kowiki. Also seen on Windows 10 Education (10.0.18363.778) Chrome C81. Windows one's IME: MS defaul... [18:16:26] 10WikiEditor, 10I18n: Korean character input unexpectedly moves lines in WikiEditor - https://phabricator.wikimedia.org/T250468 (10Sayme) I think the image description is a bit confusing. Rather, when you click the space bar, the Hangul characters you just entered disappears. Now it turns out that the Enter k... [18:23:00] 10WikiEditor, 10I18n: Korean character input unexpectedly moves lines in WikiEditor - https://phabricator.wikimedia.org/T250468 (10revi) 선생님 안녕하세요~ 크롬 쓰신다고 하셨는데, 주소창에 `chrome://version`` 치고 들어가셔서 맨 윗줄에 `Chrome: (뭐시기)`에 뭐라고 쓰여 있는지 확인해 주실 수 있으실까요? 더불어 윈도우 버전이랑 (10이면) 설정 앱 > 시간 � [18:23:47] 10WikiEditor, 10I18n: Korean character input unexpectedly moves lines in WikiEditor - https://phabricator.wikimedia.org/T250468 (10revi) >>! In T250468#6066549, @revi wrote: > 선생님 안녕하세요~ 크롬 쓰신다고 하셨는데, 주소창에 `chrome://version` 치고 들어가셔서 맨 윗줄에 `Chrome: (뭐시기)`에 뭐라고 쓰여 있는지 확인해 주실 수 있으실까요? > > 더불어 윈도우 버� [18:28:50] (03CR) 10Sohom Datta: Treat links to diffs and history pages as external links (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/583616 (https://phabricator.wikimedia.org/T248076) (owner: 10Sohom Datta) [18:30:00] 10WikiEditor, 10I18n: Korean character input unexpectedly moves lines in WikiEditor - https://phabricator.wikimedia.org/T250468 (10Sayme) 안녕하세요. 크롬 버전은 아래와 같습니다. Chrome 80.0.3987.163 (공식 빌드) (64비트) (cohort: Stable) 개정 e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037} OS Windows 10 OS Ve... [18:31:34] 10WikiEditor, 10I18n: Korean character input unexpectedly moves lines in WikiEditor - https://phabricator.wikimedia.org/T250468 (10revi) 감사합니다~ Andre: Sayme's config: * Chrome Version 80.0.3987.163 (Official build) (64 bit) * Revision e7fbe071abe9328cdce4ffedac9822435fbd3656 * OS: Windows 10 OS Version 1909... [18:49:55] 10WikiEditor, 10I18n: Korean character input unexpectedly moves lines in WikiEditor - https://phabricator.wikimedia.org/T250468 (10JJMC89) Based on the screenshots, it looks like #CodeMirror is enabled in #WikiEditor. [18:58:12] 10VisualEditor, 10ConfirmEdit (CAPTCHA extension), 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: ReCaptchaNoCaptcha not working in VisualEditor - https://phabricator.wikimedia.org/T250488 (10matmarex) [19:09:03] 10VisualEditor, 10ConfirmEdit (CAPTCHA extension), 10Editing-team (Q3 2019-2020 Kanban Board), 10Skipped QA: ReCaptchaNoCaptcha not working in VisualEditor - https://phabricator.wikimedia.org/T250488 (10matmarex) (Note that we don't use ReCaptcha on Wikimedia wikis, so we don't have a convenient way for QA... [19:11:32] (03CR) 10Bartosz Dziewoński: "(dependency is merged)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/588994 (owner: 10Bartosz Dziewoński) [19:44:52] (03CR) 10Jforrester: [C: 03+2] Remove some hardcoded CAPTCHA support code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/588994 (owner: 10Bartosz Dziewoński) [19:56:59] (03Merged) 10jenkins-bot: Remove some hardcoded CAPTCHA support code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/588994 (owner: 10Bartosz Dziewoński) [20:04:07] 10WikiEditor, 10MediaWiki-extensions-CodeMirror, 10I18n: Korean character input unexpectedly moves lines or last letter disappears on Microsoft Windows - https://phabricator.wikimedia.org/T250468 (10Aklapper) [20:40:50] 10Editing-team, 10Editing Design, 10OWC2020 (New Discussion 1.0): Re-run control test of as-is new discussion workflow - https://phabricator.wikimedia.org/T247485 (10iamjessklein) I've finished three rounds of testing on the article talk page for the new discussion flow. In order to run a test on the signe... [20:58:34] 10Editing-team, 10Editing Design, 10OWC2020 (New Discussion 1.0): Re-run control test of as-is new discussion workflow - https://phabricator.wikimedia.org/T247485 (10iamjessklein) # Findings from usability test on article talk page: We ran a test on usertesting.com on April 16, 2020 - The test recruited 5 r... [21:54:17] (03CR) 10Esanders: [C: 03+2] eslint: Enable the `mediawiki/class-doc` rule and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 (owner: 10Esanders) [21:59:21] (03PS5) 10Esanders: eslint: Enable the `mediawiki/class-doc` rule and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 [21:59:23] (03PS1) 10Esanders: Separate out client code from screenshots runners [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/589718 [22:11:44] (03CR) 10Jforrester: [C: 03+2] eslint: Enable the `mediawiki/class-doc` rule and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 (owner: 10Esanders) [22:26:34] (03Merged) 10jenkins-bot: eslint: Enable the `mediawiki/class-doc` rule and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/587738 (owner: 10Esanders) [22:46:32] (03PS1) 10Catrope: ArticleTarget: Clean up WelcomeDialog show/hide handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/589733 [22:46:34] (03PS1) 10Catrope: ArticleTarget: Move shouldShowWelcomeDialog() into DesktopArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/589734 [22:46:36] (03PS1) 10Catrope: DesktopArticleTarget: Move shouldShowWelcomeDialog() to init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/589735 (https://phabricator.wikimedia.org/T249954) [22:46:38] (03PS1) 10Catrope: DesktopArticleTarget.init: Add mw.libs.ve.disableWelcomeDialog() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/589736 (https://phabricator.wikimedia.org/T235566) [22:54:20] (03PS1) 10Jforrester: Gemfile: Push rake to 12.3.3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/589739 [23:00:35] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget: Move shouldShowWelcomeDialog() to init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/589735 (https://phabricator.wikimedia.org/T249954) (owner: 10Catrope) [23:00:46] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget.init: Add mw.libs.ve.disableWelcomeDialog() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/589736 (https://phabricator.wikimedia.org/T235566) (owner: 10Catrope) [23:06:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Maps (Kartographer): Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor - https://phabricator.wikimedia.org/T250463 (10Daylen) 05Invalid→03Open [23:07:19] (03CR) 10jerkins-bot: [V: 04-1] Gemfile: Push rake to 12.3.3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/589739 (owner: 10Jforrester) [23:10:12] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Maps (Kartographer): Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor - https://phabricator.wikimedia.org/T250463 (10Daylen) @TheDJ It is correct that the page currently uses a simple i...