[01:03:09] 10Editing-team, 10Editing Design, 10OWC2020: Redesign empty state for talk pages that have not been created - https://phabricator.wikimedia.org/T252902 (10ppelberg) [07:54:19] 10Cite: Feature request: support for complex list-defined notes used in conjuction with list-defined references - https://phabricator.wikimedia.org/T253596 (10Aklapper) [07:56:20] 10VisualEditor, 10Accessibility, 10Patch-For-Review: Edit section gets cropped at 400% page zoom - https://phabricator.wikimedia.org/T253601 (10Aklapper) [08:58:57] 10Editing-team, 10DiscussionTools, 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable DiscussionTools on zhwiki - https://phabricator.wikimedia.org/T251075 (10MarcoAurelio) [13:14:21] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review, 10covid-19: Noinclude with the VisualEditor - https://phabricator.wikimedia.org/T250937 (10Esanders) Instead of <>noinclude with the icon, why not just `` in monospace? [15:03:51] (03CR) 10Esanders: [C: 04-1] Handle etc. as nodes rather than metaitems (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/595052 (https://phabricator.wikimedia.org/T250937) (owner: 10Bartosz Dziewoński) [15:07:14] (03CR) 10Esanders: [C: 04-1] "We only need to make these visible when they are inline. When they are block level their position we be preserved in the same way other me" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/577350 (https://phabricator.wikimedia.org/T247001) (owner: 10Bartosz Dziewoński) [15:37:19] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review, 10covid-19: Noinclude with the VisualEditor - https://phabricator.wikimedia.org/T250937 (10matmarex) Because we have used the `<>` icon followed by tag name for other tags, e.g. the aforementioned , which will display lik... [15:57:19] 10Editing-team, 10Editing Design, 10OWC2020 (New Discussion 1.0): New discussion v1.0: create mockups - https://phabricator.wikimedia.org/T243248 (10ppelberg) >>! In T243248#6136844, @iamjessklein wrote: > Yesterday, @ppelberg and I discussed a design strategy for this work that would allow us to make improv... [16:01:35] 10Editing-team, 10DiscussionTools, 10Editing QA: Strikethrough in Reply tool adds tags with href attribute - https://phabricator.wikimedia.org/T253584 (10Esanders) The moving of attributes to the wrong element looks like a Parsoid issue. [17:16:12] 10VisualEditor, 10Accessibility: No focus visualization in parameter result widget - https://phabricator.wikimedia.org/T253665 (10Bkudiess-msft) [17:18:16] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10Product-Analytics (Kanban), 10Readers-Web-Backlog (Tracking): Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10Mayakp.wiki) [17:22:49] (03PS1) 10Jforrester: Update VE core submodule to master (549239957) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598805 [17:23:36] (03PS1) 10Bkudiess-msft: Adds focus visualization to parameter result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598806 [17:25:52] 10Editing-team, 10DiscussionTools, 10Editing QA: Strikethrough in Reply tool adds tags with href attribute - https://phabricator.wikimedia.org/T253584 (10Krenair) I also ran into this in: * https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Dogs&diff=424245&oldid=424088&diffmode=source * https:... [18:20:16] (03CR) 10Jforrester: [C: 03+2] Parse messages in string context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598240 (owner: 10Umherirrender) [18:22:03] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0): Problem with template transclusion and switching editors - https://phabricator.wikimedia.org/T253150 (10Esanders) Looks like we are messing up the Parsoid HTML for templates during the de-indentation process of switching from source to visu... [18:22:50] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (549239957) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598805 (owner: 10Jforrester) [18:37:53] (03Merged) 10jenkins-bot: Parse messages in string context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598240 (owner: 10Umherirrender) [18:41:24] (03Merged) 10jenkins-bot: Update VE core submodule to master (549239957) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598805 (owner: 10Jforrester) [19:15:52] (03PS1) 10Jforrester: build: Upgrade mediawiki-codesniffer from v3.0.0 to v31.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598829 [19:16:08] (03PS2) 10Jforrester: build: Upgrade mediawiki-codesniffer from v30.0.0 to v31.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598829 [19:20:47] (03PS2) 10Bartosz Dziewoński: Adds role to Document Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [19:21:02] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Thanks!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [19:21:16] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review, 10covid-19: Noinclude with the VisualEditor - https://phabricator.wikimedia.org/T250937 (10Esanders) I think given that these are start & end markers, unlike extension blocks, `<>noinclude` and `<>/noinclude` are needlessly co... [19:22:54] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Edit box has wrong control type - https://phabricator.wikimedia.org/T253592 (10matmarex) [19:23:09] (03CR) 10jerkins-bot: [V: 04-1] Adds role to Document Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [19:27:15] (03PS1) 10Bartosz Dziewoński: build: Unbreak language lists, adding 'ti' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598835 [19:28:02] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Oops, sorry about the failing tests. I'm fixing that in https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/598835 ." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [19:28:08] (03PS3) 10Bartosz Dziewoński: Adds role to Document Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [19:28:13] (03CR) 10jerkins-bot: [V: 04-1] Adds role to Document Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [19:29:25] (03PS3) 10Bartosz Dziewoński: ve.ui.LinearContextItem: Make items with no actions have normal padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598548 [19:30:00] (03CR) 10jerkins-bot: [V: 04-1] build: Unbreak language lists, adding 'ti' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598835 (owner: 10Bartosz Dziewoński) [19:30:12] (03CR) 10jerkins-bot: [V: 04-1] Adds role to Document Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [19:31:29] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.LinearContextItem: Make items with no actions have normal padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598548 (owner: 10Bartosz Dziewoński) [19:32:16] (03CR) 10Esanders: [C: 03+2] build: Upgrade mediawiki-codesniffer from v30.0.0 to v31.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598829 (owner: 10Jforrester) [19:32:17] 10Editing-team, 10Editing Design, 10OWC2020 (OWC2020 Replying 2.0): Reply v2.0: conduct usability tests (usertesting.com) - https://phabricator.wikimedia.org/T246190 (10ppelberg) **Updates** //These are notes notes from this morning's standup and the chat Jess and I had in Slack on Friday:// - Each test par... [19:36:10] 10Editing-team, 10Editing Design, 10OWC2020 (OWC2020 Replying 2.0): Reply v2.0: conduct usability tests (usertesting.com) - https://phabricator.wikimedia.org/T246190 (10ppelberg) [19:43:02] (03CR) 10Bartosz Dziewoński: "I agree with the idea but the effect of this change is worse than I expected." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598546 (owner: 10Bkudiess-msft) [19:43:07] (03CR) 10Bartosz Dziewoński: [C: 04-1] Fixes edit section being cropped on page with zoom [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598546 (owner: 10Bkudiess-msft) [19:43:36] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Edit section gets cropped at 400% page zoom - https://phabricator.wikimedia.org/T253601 (10matmarex) [19:48:15] 10VisualEditor, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), 10OWC2020 (OWC2020 Replying 2.0): Keep '@' prefix in username auto-complete output - https://phabricator.wikimedia.org/T252460 (10Esanders) >>! In T252460#6127013, @Dyolf77_WMF wrote: >... [19:48:49] 10VisualEditor, 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Explore enabling wikis to customize what syntax is used for @ mentions - https://phabricator.wikimedia.org/T250332 (10Esanders) >>! In T252460#6127013, @Dyolf77_WMF wrote: > For RTL wikis, is it possible to use the symbol `◀` instea... [19:49:38] (03PS2) 10Jforrester: build: Unbreak language lists, adding 'ti' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598835 (owner: 10Bartosz Dziewoński) [19:50:26] (03CR) 10Jforrester: [C: 03+2] build: Unbreak language lists, adding 'ti' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598835 (owner: 10Bartosz Dziewoński) [19:50:38] (03PS4) 10Jforrester: Adds role to Document Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [19:50:43] (03Merged) 10jenkins-bot: build: Upgrade mediawiki-codesniffer from v30.0.0 to v31.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598829 (owner: 10Jforrester) [19:50:50] (03PS4) 10Jforrester: ve.ui.LinearContextItem: Make items with no actions have normal padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598548 (owner: 10Bartosz Dziewoński) [19:51:44] (03PS3) 10Bartosz Dziewoński: build: Unbreak language lists, adding 'ti' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598835 [19:55:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10OWC2020: Provide a keyboard shortcut for adding signature - https://phabricator.wikimedia.org/T166494 (10Esanders) With OWC we are building tools specifically for posting comments on talk pages, including using a VE interface. If the project is successful this task... [20:00:01] (03PS1) 10Bartosz Dziewoński: Avoid listing languages twice in availableLanguages [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598839 [20:01:11] (03CR) 10Jforrester: [C: 03+2] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598835 (owner: 10Bartosz Dziewoński) [20:01:40] (03CR) 10Jforrester: [C: 03+2] Avoid listing languages twice in availableLanguages [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598839 (owner: 10Bartosz Dziewoński) [20:03:13] (03Merged) 10jenkins-bot: build: Unbreak language lists, adding 'ti' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598835 (owner: 10Bartosz Dziewoński) [20:03:43] (03Merged) 10jenkins-bot: Avoid listing languages twice in availableLanguages [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598839 (owner: 10Bartosz Dziewoński) [20:30:49] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0): Problem with template transclusion and switching editors - https://phabricator.wikimedia.org/T253150 (10Esanders) This particular template is multi-line because it has a linebreak after the [[File:]] which will cause it to fail even in the... [20:37:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: Save dialog too small after switching to diff and back again - https://phabricator.wikimedia.org/T161880 (10matmarex) 05Open→03Resolved a:03matmarex This was probably accidentally fixed by {11673b21add4bd9a30395199836df6efdd559d02}. [20:38:27] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0): Problem with template transclusion and switching editors - https://phabricator.wikimedia.org/T253150 (10Esanders) @cscott @ssastry is it correct that in ` :{{test}} ` (where test is https://en.wikipedia.beta.wmflabs.org/wiki/Template:Test)... [20:39:34] 10VisualEditor: When switching from source mode to visual mode all content is gone for new articles - https://phabricator.wikimedia.org/T253467 (10matmarex) This appears to have been broken for a long time, at least as far back as 8ae492567674b3bd9a12c772d454cf1fd0a82b1d. [20:44:24] 10VisualEditor: When switching from source mode to visual mode all content is gone for new articles - https://phabricator.wikimedia.org/T253467 (10matmarex) Actually, I can't reproduce this on Wikipedia, only on wikis using non-RESTBase mode. [20:49:11] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0), 10Patch-For-Review: Problem with template transclusion and switching editors - https://phabricator.wikimedia.org/T253150 (10Esanders) The above patch avoids unwrapping templated lists. This means the template isn't destroyed anymore, but... [20:56:23] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0), 10Patch-For-Review: Problem with template transclusion and switching editors - https://phabricator.wikimedia.org/T253150 (10ssastry) This below conflrms the behavior ` [subbu@earth:~/work/wmf/parsoid] echo -e ":{{1x|[[File:Placeholder.png... [21:08:30] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0), 10Patch-For-Review: Problem with template transclusion and switching editors - https://phabricator.wikimedia.org/T253150 (10ssastry) Ideal solution would be to trim trailing newlines (after expansion and *after* processing include directi... [21:09:50] (03PS5) 10Bartosz Dziewoński: ve.ui.LinearContextItem: Make items with no actions have normal padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598548 [21:10:04] (03PS5) 10Bartosz Dziewoński: Adds role to Document Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [21:10:10] (03CR) 10Bartosz Dziewoński: [C: 03+2] Adds role to Document Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [21:12:41] (03Merged) 10jenkins-bot: Adds role to Document Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/598539 (https://phabricator.wikimedia.org/T253592) (owner: 10Bkudiess-msft) [21:15:19] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0), 10Patch-For-Review: Problem with template transclusion and switching editors - https://phabricator.wikimedia.org/T253150 (10ssastry) Wikitext and whitespace have a complicated relationship. :) [21:17:53] 10VisualEditor, 10Editing QA, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board): Edit box has wrong control type - https://phabricator.wikimedia.org/T253592 (10matmarex) [21:19:41] 10VisualEditor, 10Accessibility, 10Editing-team (Q3 2019-2020 Kanban Board), 10Skipped QA: Edit box has wrong control type - https://phabricator.wikimedia.org/T253592 (10matmarex) I think Rummana said at some point that she can't verify screenreader accessibility, I tested it and it works as expected. [21:30:48] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0), 10Patch-For-Review: Problem with template transclusion and switching editors - https://phabricator.wikimedia.org/T253150 (10Esanders) Thanks @ssastry. Confirmed on beta that this isn't a problem with well-formed templates. `{{infobox}}` f... [21:39:12] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), 10OWC2020 (OWC2020 Replying 2.0), 10Verified: Keep '@' prefix in username auto-complete output - https://phabricator.wikimedia.org/T252460 (10Ryasmeen) [22:08:05] 10VisualEditor: Contents of the save dialog (summary and checkboxes) should be stored together with the document - https://phabricator.wikimedia.org/T253696 (10matmarex) [22:16:41] 10VisualEditor, 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Explore enabling wikis to customize what syntax is used for @ mentions - https://phabricator.wikimedia.org/T250332 (10Dyolf77_WMF) Thanks @Esanders, that is Okay. [22:31:57] (03PS1) 10Bartosz Dziewoński: When switching from wikitext to visual, preserve the edit checkboxes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598873 (https://phabricator.wikimedia.org/T250388) [22:32:49] 10VisualEditor, 10Scoring-platform-team, 10edittypes-modeling, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Change from source code editing to visual editing: minor edit property not kept - https://phabricator.wikimedia.org/T250388 (10matmarex) a:03matmarex Let's keep this one simple... [22:49:40] (03CR) 10Bartosz Dziewoński: "> We only need to make these visible when they are inline. When they are block level their position we be preserved in the same way other " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/577350 (https://phabricator.wikimedia.org/T247001) (owner: 10Bartosz Dziewoński) [22:58:27] (03CR) 10Bkudiess-msft: "> Patch Set 1:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598546 (owner: 10Bkudiess-msft) [23:00:39] (03PS2) 10Bkudiess-msft: Fixes edit section being cropped on page with zoom [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598546 [23:15:49] (03PS5) 10Bartosz Dziewoński: Handle etc. as nodes rather than metaitems [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/595052 (https://phabricator.wikimedia.org/T250937) [23:16:25] (03CR) 10Bartosz Dziewoński: "Done, although I think it looks awful. Please amend if you find a way to make it look better." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/595052 (https://phabricator.wikimedia.org/T250937) (owner: 10Bartosz Dziewoński) [23:19:06] (03CR) 10jerkins-bot: [V: 04-1] Fixes edit section being cropped on page with zoom [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598546 (owner: 10Bkudiess-msft) [23:19:48] 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review, 10covid-19: Noinclude with the VisualEditor - https://phabricator.wikimedia.org/T250937 (10matmarex)