[00:09:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10Expiring-Watchlist-Items, 10Community-Tech (Kanban-2020-21-Q1): Watchlist Expiry: Fix interface bug in VisualEditor [[MEDIUM]] - https://phabricator.wikimedia.org/T259546 (10ifried) [01:00:14] 10VisualEditor, 10Talk Pages: NWE: Scroll to new section after publishing - https://phabricator.wikimedia.org/T259862 (10ppelberg) [02:50:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10Expiring-Watchlist-Items, 10Community-Tech (Kanban-2020-21-Q1): Watchlist Expiry: Fix interface bug in VisualEditor [[MEDIUM]] - https://phabricator.wikimedia.org/T259546 (10Samwilson) a:03Samwilson [05:14:50] (03PS1) 10Samwilson: Ignore non-checkbox fields for page saving dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/618880 (https://phabricator.wikimedia.org/T259546) [05:18:48] (03PS2) 10Samwilson: Ignore non-checkbox fields for page saving dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/618880 (https://phabricator.wikimedia.org/T259546) [05:19:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10Expiring-Watchlist-Items, 10Community-Tech (Kanban-2020-21-Q1), 10Patch-For-Review: Watchlist Expiry: Fix interface bug in VisualEditor [[MEDIUM]] - https://phabricator.wikimedia.org/T259546 (10Samwilson) Thanks @matmarex, that's super helpful. I've made a litt... [05:35:04] 10Editing-team, 10DiscussionTools, 10Parsoid, 10User-brennen, 10Wikimedia-production-error: ThreadItem: PHP Notice: Undefined index: href - https://phabricator.wikimedia.org/T259856 (10matmarex) We enabled DiscussionTools on kowiki in a config deploy, the reports probably started then. Any impact should... [05:38:17] 10VisualEditor, 10Parsoid, 10MW-1.35-release: Setting up VisualEditor following Parsoid/PHP instruction result in HTTP 500 Restbase error - https://phabricator.wikimedia.org/T259693 (10VulpesVulpes825) @Legoktm @cscott I have retried with both the latest master branch as well as REL_1.35 branch of MediaWiki... [06:26:21] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/618911 (owner: 10L10n-bot) [06:34:34] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/618911 (owner: 10L10n-bot) [07:32:46] 10VisualEditor, 10Parsoid, 10MW-1.35-release: Setting up VisualEditor following Parsoid/PHP instruction result in HTTP 500 Restbase error - https://phabricator.wikimedia.org/T259693 (10KeybladeSpyMaster) Just set up MW 1.35.0-rc.0 with the bundled extensions, getting the same error. When switching from Sourc... [09:59:23] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Investigation: Dependent parameters - https://phabricator.wikimedia.org/T258193 (10ECohen_WMDE) This is a great overview! I have a couple questions, particularly about the sets featur... [10:25:29] 10Citoid, 10Operations, 10serviceops, 10Patch-For-Review: citoid /api LVS check reports HTTP 200 instead of HTTP 404 - https://phabricator.wikimedia.org/T259469 (10akosiaris) 05Open→03Resolved a:03akosiaris Thanks @mvolz. Problem resolved. [11:24:24] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Investigation: Dependent parameters - https://phabricator.wikimedia.org/T258193 (10awight) >>! In T258193#6367994, @ECohen_WMDE wrote: > @awight Can we look the through the TemplateDa... [11:55:26] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Investigation: Dependent parameters - https://phabricator.wikimedia.org/T258193 (10ECohen_WMDE) Great! Thanks @awight. I see it in the code but not in the results? Maybe I'm just miss... [12:06:47] 10VisualEditor, 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Reply widget's white background is inconsistent between source and visual mode - https://phabricator.wikimedia.org/T259811 (10Esanders) I filed and fixed this in T259828 [12:09:00] (03CR) 10Esanders: "Duplicate of I55a8dce728ff30d6c5bf61e03a2a3bf9a4d8f86e" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618778 (https://phabricator.wikimedia.org/T259811) (owner: 10Bartosz Dziewoński) [12:10:08] (03CR) 10Esanders: "is the :not required? could you just use background-color instead?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618778 (https://phabricator.wikimedia.org/T259811) (owner: 10Bartosz Dziewoński) [12:46:01] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Investigation: Dependent parameters - https://phabricator.wikimedia.org/T258193 (10awight) >>! In T258193#6368208, @ECohen_WMDE wrote: > I see it in the code but not in the results?... [13:31:18] (03CR) 10Esanders: [C: 03+2] TargetWidget: Use a white background, not transparent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618778 (https://phabricator.wikimedia.org/T259811) (owner: 10Bartosz Dziewoński) [13:32:17] (03Abandoned) 10Esanders: Give TargetWidget a white background [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618826 (https://phabricator.wikimedia.org/T259828) (owner: 10Esanders) [13:32:58] 10VisualEditor, 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Reply widget's white background is inconsistent between source and visual mode - https://phabricator.wikimedia.org/T259811 (10Esanders) [13:35:41] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Investigation: Dependent parameters - https://phabricator.wikimedia.org/T258193 (10ECohen_WMDE) Thanks! [13:40:02] (03CR) 10jerkins-bot: [V: 04-1] TargetWidget: Use a white background, not transparent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618778 (https://phabricator.wikimedia.org/T259811) (owner: 10Bartosz Dziewoński) [13:40:39] (03CR) 10Jforrester: [C: 03+2] Update OOUI to v0.40.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618627 (owner: 10VolkerE) [13:41:00] (03CR) 10VolkerE: "Revisited, there was a local issue in my config, that seemed to be the source for my confusion (additionally to being super cautious about" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618627 (owner: 10VolkerE) [13:42:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-MediaWiki-Mobile: Provide the VE wikitext editing mode on mobile for users who have enabled the beta feature - https://phabricator.wikimedia.org/T259887 (10Esanders) [13:46:39] (03Merged) 10jenkins-bot: Update OOUI to v0.40.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618627 (owner: 10VolkerE) [13:51:46] (03PS1) 10Jforrester: Update VE core submodule to master (4b36b447d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/618987 [14:09:29] 10Editing-team, 10MassMessage, 10Patch-For-Review, 10Platform Team Workboards (External Code Reviews), 10User-DannyS712: MassMessage: add module to query content of MassMessageListContent pages - https://phabricator.wikimedia.org/T231401 (10Clarakosi) Oops, re-adding CPT. [14:21:57] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 2 others: Investigation: Link to VE media selector - https://phabricator.wikimedia.org/T258195 (10Andrew-WMDE) > Can we re-use the media selector modal but limit its functions as described abov... [14:22:10] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Investigation: Link to VE media selector - https://phabricator.wikimedia.org/T258195 (10Andrew-WMDE) [14:41:47] 10VisualEditor, 10Parsoid, 10MW-1.35-release: Setting up Zero-configuration VisualEditor in 1.35+ results in HTTP 500 RESTbase error - https://phabricator.wikimedia.org/T259693 (10VulpesVulpes825) [14:49:19] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Investigation: Dependent parameters - https://phabricator.wikimedia.org/T258193 (10thiemowmde) Note: Originally, my plan for today was to look into the `sets` feature, what it's state... [14:58:40] (03CR) 10Esanders: [C: 03+2] "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618778 (https://phabricator.wikimedia.org/T259811) (owner: 10Bartosz Dziewoński) [15:02:03] (03Merged) 10jenkins-bot: TargetWidget: Use a white background, not transparent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618778 (https://phabricator.wikimedia.org/T259811) (owner: 10Bartosz Dziewoński) [15:38:49] 10Editing-team, 10DiscussionTools, 10Parsoid, 10User-brennen, 10Wikimedia-production-error: ThreadItem: PHP Notice: Undefined index: href - https://phabricator.wikimedia.org/T259856 (10matmarex) I've looked at this now. This is completely harmless and only causes log noise – we missed an `isset()`. It's... [18:11:03] (03CR) 10Bartosz Dziewoński: "> is the :not required? could you just use background-color instead?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/618778 (https://phabricator.wikimedia.org/T259811) (owner: 10Bartosz Dziewoński) [19:43:49] (03CR) 10Bartosz Dziewoński: [C: 03+2] Support headers in CompletionWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/610327 (https://phabricator.wikimedia.org/T252084) (owner: 10Esanders) [19:51:32] (03CR) 10jerkins-bot: [V: 04-1] Support headers in CompletionWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/610327 (https://phabricator.wikimedia.org/T252084) (owner: 10Esanders) [20:05:32] (03CR) 10Bartosz Dziewoński: "That looks like a problem with CI, not with out code. The tests in Firefox don't want to run. But other patches merged fine today, e.g. ht" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/610327 (https://phabricator.wikimedia.org/T252084) (owner: 10Esanders) [20:05:37] (03PS7) 10Bartosz Dziewoński: Support headers in CompletionWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/610327 (https://phabricator.wikimedia.org/T252084) (owner: 10Esanders) [20:05:56] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Let's try one more time maybe before I start filing tasks about it?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/610327 (https://phabricator.wikimedia.org/T252084) (owner: 10Esanders) [20:08:15] 10Editing-team, 10DiscussionTools, 10Editing Design, 10OWC2020: [EPIC] Visual enhancements: make the actions, activity and content within talk pages easier to understand - https://phabricator.wikimedia.org/T249579 (10ppelberg) [20:11:47] (03CR) 10jerkins-bot: [V: 04-1] Support headers in CompletionWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/610327 (https://phabricator.wikimedia.org/T252084) (owner: 10Esanders) [20:19:45] (03PS1) 10Bartosz Dziewoński: [DO NOT MERGE] Testing CI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/619033 [20:24:53] (03CR) 10jerkins-bot: [V: 04-1] [DO NOT MERGE] Testing CI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/619033 (owner: 10Bartosz Dziewoński) [20:30:04] 10VisualEditor, 10Continuous-Integration-Infrastructure: Karma tests using Firefox in VisualEditor/VisualEditor repo are failing - https://phabricator.wikimedia.org/T259925 (10matmarex) [20:30:55] (03CR) 10Bartosz Dziewoński: "I filed T259925 about this failure." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/619033 (owner: 10Bartosz Dziewoński) [20:31:06] (03CR) 10Bartosz Dziewoński: [C: 03+2] "I filed T259925 about this failure." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/610327 (https://phabricator.wikimedia.org/T252084) (owner: 10Esanders) [20:33:59] 10VisualEditor, 10Continuous-Integration-Infrastructure: Karma tests using Firefox in VisualEditor/VisualEditor repo are failing - https://phabricator.wikimedia.org/T259925 (10matmarex) p:05Triage→03Unbreak! This is preventing us from merging changes, e.g. https://gerrit.wikimedia.org/r/c/VisualEditor/Visu... [20:38:20] (03CR) 10jerkins-bot: [V: 04-1] Support headers in CompletionWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/610327 (https://phabricator.wikimedia.org/T252084) (owner: 10Esanders) [20:58:23] 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: ve.init.target is null - https://phabricator.wikimedia.org/T259566 (10Umherirrender) [20:58:47] 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: TypeError: item is null (getRect called with null) - https://phabricator.wikimedia.org/T259551 (10Umherirrender) [21:00:22] 10Citoid, 10The-Wikipedia-Library: Gale URLs don't produce good Citations via Citoid - https://phabricator.wikimedia.org/T259928 (10Astinson) [21:21:55] 10VisualEditor, 10Parsoid: Remove 'missing page parameter' workaround once RESTBase cache has turned over - https://phabricator.wikimedia.org/T259931 (10cscott) [21:23:29] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10ci-test-error (WMF-deployed Build Failure): Karma tests using Firefox in VisualEditor/VisualEditor repo are failing - https://phabricator.wikimedia.org/T259925 (10Krinkle) [21:24:17] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10ci-test-error (WMF-deployed Build Failure): Karma tests using Firefox in VisualEditor/VisualEditor repo are failing - https://phabricator.wikimedia.org/T259925 (10Krinkle) Can you reproduce the issue locally on the same repo with [fresh](https://gerr... [21:25:06] (03PS1) 10Esanders: Update devDependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/619039 [21:32:47] (03CR) 10jerkins-bot: [V: 04-1] Update devDependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/619039 (owner: 10Esanders) [21:46:13] 10VisualEditor, 10Parsoid, 10MW-1.35-release: Setting up Zero-configuration VisualEditor in 1.35+ results in HTTP 500 RESTbase error - https://phabricator.wikimedia.org/T259693 (10Legoktm) To help with debugging and pinpointing the issue, could whoever is running into this issue provide their database engine... [21:47:10] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10ci-test-error (WMF-deployed Build Failure): Karma tests using Firefox in VisualEditor/VisualEditor repo are failing - https://phabricator.wikimedia.org/T259925 (10Esanders) Ran fine for me with fresh: ` Running "karma:firefox" (karma) task 07 08 2020... [22:09:58] 10VisualEditor, 10Parsoid, 10MW-1.35-release: Setting up Zero-configuration VisualEditor in 1.35+ results in HTTP 500 RESTbase error - https://phabricator.wikimedia.org/T259693 (10KeybladeSpyMaster) The HTTP 500 error always triggers when clicking on "Edit", and reappears when clicking on "Try Again". When s... [22:16:43] 10VisualEditor, 10Parsoid, 10MW-1.35-release: Setting up Zero-configuration VisualEditor in 1.35+ results in HTTP 500 RESTbase error - https://phabricator.wikimedia.org/T259693 (10cscott) I could use a step-by-step on the installation process you are using as well. Is this a clean install, or an upgrade? A... [22:26:02] 10Editing-team, 10DiscussionTools: Develop an approach for to DiscussionTool preferences - https://phabricator.wikimedia.org/T257889 (10ppelberg) [22:27:20] 10Editing-team, 10DiscussionTools: Develop an approach for to DiscussionTool preferences - https://phabricator.wikimedia.org/T257889 (10ppelberg) **Task description updates** Added initial "sketch" of how the tools and enhancements we introduce as part of the [Talk pages project](https://www.mediawiki.org/wiki... [23:22:49] 10VisualEditor, 10Parsoid, 10MW-1.35-release: Setting up Zero-configuration VisualEditor in 1.35+ results in HTTP 500 RESTbase error - https://phabricator.wikimedia.org/T259693 (10KeybladeSpyMaster) OKAY, here goes. It's a clean install, using the web installer. Setup: | **OS** | Windows Server 2019 | **Ser... [23:43:50] 10VisualEditor, 10Parsoid, 10MW-1.35-release, 10Patch-For-Review: Setting up Zero-configuration VisualEditor in 1.35+ results in HTTP 500 RESTbase error - https://phabricator.wikimedia.org/T259693 (10Legoktm) >>! In T259693#6370198, @KeybladeSpyMaster wrote: > `[8905c82407b1566292880c64] /rest.php/avengers... [23:53:56] 10VisualEditor, 10Parsoid, 10MW-1.35-release, 10Patch-For-Review: Setting up Zero-configuration VisualEditor in 1.35+ results in HTTP 500 RESTbase error - https://phabricator.wikimedia.org/T259693 (10KeybladeSpyMaster) That did it! Visual Editor is loading normally from "Edit" and I can switch to it from t... [23:56:29] 10VisualEditor, 10Parsoid, 10MW-1.35-release, 10Patch-For-Review: VisualEditor triggers HTTP 500 RESTbase error on Windows because of exception in GlobalIdGenerator - https://phabricator.wikimedia.org/T259693 (10Legoktm) a:03Legoktm [23:57:19] 10VisualEditor, 10Parsoid, 10MW-1.35-release, 10Patch-For-Review: VisualEditor triggers HTTP 500 RESTbase error on Windows because of exception in GlobalIdGenerator - https://phabricator.wikimedia.org/T259693 (10Legoktm) >>! In T259693#6370263, @KeybladeSpyMaster wrote: > That did it! Visual Editor is load...