[06:13:51] (03CR) 10Thiemo Kreuz (WMDE): Clean up base class reaching into the subclass (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622542 (owner: 10Thiemo Kreuz (WMDE)) [07:40:38] (03CR) 10Raimond Spekking: "i18n review" (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/617702 (https://phabricator.wikimedia.org/T258820) (owner: 10AdhamKhatean) [08:31:50] (03CR) 10AdhamKhatean: Allow different maps to be edited separately (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/617702 (https://phabricator.wikimedia.org/T258820) (owner: 10AdhamKhatean) [10:15:43] (03CR) 10Raimond Spekking: Allow different maps to be edited separately (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/617702 (https://phabricator.wikimedia.org/T258820) (owner: 10AdhamKhatean) [10:38:26] (03PS2) 10Andrew-WMDE: [POC] Add file preview for file type parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623003 (https://phabricator.wikimedia.org/T260803) [10:54:16] (03PS1) 10Tchanders: Fix punctuation for message in the edit dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/623332 [10:55:23] (03CR) 10Tchanders: Allow different maps to be edited separately (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/617702 (https://phabricator.wikimedia.org/T258820) (owner: 10AdhamKhatean) [10:57:46] (03CR) 10AdhamKhatean: Allow different maps to be edited separately (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/617702 (https://phabricator.wikimedia.org/T258820) (owner: 10AdhamKhatean) [11:01:41] (03CR) 10jerkins-bot: [V: 04-1] [POC] Add file preview for file type parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623003 (https://phabricator.wikimedia.org/T260803) (owner: 10Andrew-WMDE) [11:36:02] (03CR) 10Ammarpad: [C: 03+2] Fix punctuation for message in the edit dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/623332 (owner: 10Tchanders) [11:46:23] (03PS2) 10Esanders: Fix pasting cells onto a sparse table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623175 (https://phabricator.wikimedia.org/T261530) [11:50:43] 10VisualEditor, 10Documentation: User guide shows "Cite" dropdown but VisualEditor displays a popover instead when pressing the "Cite" button - https://phabricator.wikimedia.org/T260478 (10Esanders) If you read the documentation above, it says to read https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide... [11:55:38] (03Merged) 10jenkins-bot: Fix punctuation for message in the edit dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/623332 (owner: 10Tchanders) [12:25:22] 10VisualEditor, 10VisualEditor-DataModel, 10Performance Issue, 10Regression: Typing is slow on very long documents - https://phabricator.wikimedia.org/T261634 (10Esanders) [12:27:18] 10VisualEditor, 10VisualEditor-DataModel, 10Performance Issue, 10Regression: Typing is slow on very long documents - https://phabricator.wikimedia.org/T261634 (10Esanders) [12:28:51] 10VisualEditor, 10VisualEditor-DataModel, 10Performance Issue, 10Regression: Typing is slow on very long documents - https://phabricator.wikimedia.org/T261634 (10Esanders) [12:45:48] (03PS1) 10Esanders: getAdjustedPosition: Rewrite inner loop for performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623355 (https://phabricator.wikimedia.org/T261634) [12:46:27] 10VisualEditor, 10VisualEditor-DataModel, 10Patch-For-Review, 10Performance Issue, 10Regression: Typing is slow on very long documents - https://phabricator.wikimedia.org/T261634 (10Esanders) After the above patch we spend ~10ms in `ve.dm.TransactionProcess.prototype.process`. [13:20:19] (03CR) 10Divec: [C: 03+2] getAdjustedPosition: Rewrite inner loop for performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623355 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [13:23:27] (03Merged) 10jenkins-bot: getAdjustedPosition: Rewrite inner loop for performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623355 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [14:12:34] (03PS1) 10Esanders: Follow-up Ic1669009: Use for..in loop instead of Object.Keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623387 [14:13:24] (03PS2) 10Esanders: Follow-up Ic1669009: Use for..in loop instead of Object.Keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623387 [14:45:26] (03PS1) 10Awight: setValue should be chainable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623395 [14:51:45] (03CR) 10Jforrester: [C: 04-2] "This kind of patch must happen in the OOUI library repo, not in a downstream user." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623395 (owner: 10Awight) [14:53:10] (03CR) 10Awight: "> This kind of patch must happen in the OOUI library repo, not in a downstream user." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623395 (owner: 10Awight) [14:53:26] (03PS2) 10Awight: [DNM] setValue should be chainable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623395 [14:58:51] (03CR) 10Awight: "Upstreamed as I8ab39d5b121380e5597e827650c14f69eeef485f" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623395 (owner: 10Awight) [15:15:44] (03PS1) 10Esanders: TreeModifier: More optimizations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623403 [15:16:45] 10Editing-team, 10DiscussionTools, 10Wikimedia-Site-requests: Enable DiscussionTools on jawiki - https://phabricator.wikimedia.org/T261654 (10patilise) [15:17:41] 10Editing-team, 10DiscussionTools, 10OWC2020: [Epic] Scale DiscussionTools to all Wikipedias - https://phabricator.wikimedia.org/T251207 (10patilise) [15:17:43] 10Editing-team, 10DiscussionTools, 10Wikimedia-Site-requests: Enable DiscussionTools on jawiki - https://phabricator.wikimedia.org/T261654 (10patilise) [15:21:55] (03PS1) 10Awight: Fix config argument to explicitly pass api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623404 [15:30:03] 10Editing-team, 10DiscussionTools: Mentioning an email address in DiscussionTools makes the system think I'm going to mention someone - https://phabricator.wikimedia.org/T260443 (10DLynch) Making it configurable would be technically doable, as it's just a lightly modified reversion of [the original removal](ht... [15:54:16] 10VisualEditor, 10VisualEditor-ContentEditable, 10Performance Issue: undo/redo is slow on large documents - https://phabricator.wikimedia.org/T261662 (10Esanders) [15:54:26] (03PS3) 10Esanders: Follow-up Ic1669009: Use for..in loop instead of Object.Keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623387 (https://phabricator.wikimedia.org/T261634) [15:54:27] (03PS2) 10Esanders: TreeModifier: More optimizations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623403 (https://phabricator.wikimedia.org/T261634) [15:54:29] (03PS1) 10Esanders: TreeModifier: Add optimization for short array comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623410 (https://phabricator.wikimedia.org/T261634) [15:54:31] (03PS1) 10Esanders: ve.ce.Surface: Debounce onModelDocumentUpdate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623411 (https://phabricator.wikimedia.org/T261662) [15:54:44] 10VisualEditor, 10VisualEditor-ContentEditable, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Performance Issue: undo/redo is slow on large documents - https://phabricator.wikimedia.org/T261662 (10Esanders) [15:54:59] 10VisualEditor, 10VisualEditor-DataModel, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, and 2 others: Typing is slow on very long documents - https://phabricator.wikimedia.org/T261634 (10Esanders) [16:00:45] (03PS1) 10Awight: [WIP] Experiment with a new FileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623412 (https://phabricator.wikimedia.org/T260886) [16:03:30] 10VisualEditor: EditAttemptStep validation error '0' is not of type 'integer' - https://phabricator.wikimedia.org/T261664 (10DLynch) [16:04:22] (03PS1) 10DLynch: Cast fallback revision_id to a number so it validates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623414 (https://phabricator.wikimedia.org/T261664) [16:09:20] 10Editing-team, 10VisualEditor, 10Growth-Team: EventLogging validation errors for EditAttemptStep - https://phabricator.wikimedia.org/T237063 (10DLynch) Looking at logstash, this seems to have slowed down greatly without us having made any deliberate changes -- I see 2,567 reports of it in the last 7 days. I... [16:10:13] (03CR) 10Thiemo Kreuz (WMDE): "Uh, strange. One is obsolete and can be removed, if I'm not mistaken. The other is – odd." (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623404 (owner: 10Awight) [16:15:06] 10VisualEditor, 10WikiEditor, 10WMF-Legal, 10I18n: Save button on Japanese Wikipedia is unnecessarily long - https://phabricator.wikimedia.org/T244595 (10Esanders) @rxy can this be re-proposed to the community now that we have the opinion from legal that it is not necessary? [16:18:26] 10Editing-team, 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: Production error: Cannot read property 'insertBefore' of null (VeCeDocumentNode.ve.ce.BranchNode.setupSlugs ) - https://phabricator.wikimedia.org/T258190 (10DLynch) So, this'd be happening here in `ve.ce.BranchNode.js` line 329: `... [16:23:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Experiment with a new FileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623412 (https://phabricator.wikimedia.org/T260886) (owner: 10Awight) [16:24:30] (03CR) 10Esanders: [C: 03+2] Cast fallback revision_id to a number so it validates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623414 (https://phabricator.wikimedia.org/T261664) (owner: 10DLynch) [16:27:01] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Wikimedia-production-error: EditAttemptStep validation error '0' is not of type 'integer' - https://phabricator.wikimedia.org/T261664 (10Esanders) [16:29:51] 10VisualEditor: Merging table cells causes the entire row/column disappear - https://phabricator.wikimedia.org/T261582 (10Esanders) In most spreadsheet software, merging cells will only keep the value in the topleft-most cell. Is this what you are referring to? [16:31:46] 10VisualEditor: Merging table cells causes the entire row/column disappear - https://phabricator.wikimedia.org/T261582 (10Esanders) [16:32:09] 10VisualEditor, 10VisualEditor-Tables: Merging table cells in Visual Editor destroys the content of all cells but one - https://phabricator.wikimedia.org/T243748 (10Esanders) [16:32:20] 10VisualEditor, 10VisualEditor-Tables: Merging table cells in Visual Editor destroys the content of all cells but one - https://phabricator.wikimedia.org/T243748 (10Esanders) This is how most spreadsheet software works. [16:34:09] 10VisualEditor, 10VisualEditor-Tables, 10Design: Be able to merge sequential tables into a single table - https://phabricator.wikimedia.org/T128734 (10Esanders) 05Open→03Declined [16:43:24] (03CR) 10Esanders: Fix config argument to explicitly pass api (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623404 (owner: 10Awight) [16:43:55] (03Merged) 10jenkins-bot: Cast fallback revision_id to a number so it validates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623414 (https://phabricator.wikimedia.org/T261664) (owner: 10DLynch) [16:45:19] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Skipped QA, 10Wikimedia-production-error: EditAttemptStep validation error '0' is not of type 'integer' - https://phabricator.wikimedia.org/T261664 (10DLynch) [16:48:36] (03PS1) 10Jforrester: Update VE core submodule to master (89a8d99f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623424 (https://phabricator.wikimedia.org/T259531) [17:01:20] 10Editing-team, 10WikiEditor, 10patch-welcome: Make possible (or document how to) for a gadget to apply WikiEditor to a custom textarea - https://phabricator.wikimedia.org/T231244 (10DLynch) `ext.wikiEditor` already requires everything this requests -- it just doesn't export it. It'd be trivial to do that so... [17:18:39] 10VisualEditor, 10Desktop Improvements, 10Vector, 10Editing-team (Tracking), and 2 others: [Spike,1hr] Consider whether "Article" tab's and VE's left-most edge should have borders - https://phabricator.wikimedia.org/T259273 (10alexhollender) a:03alexhollender [17:33:43] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (89a8d99f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623424 (https://phabricator.wikimedia.org/T259531) (owner: 10Jforrester) [17:52:13] (03Merged) 10jenkins-bot: Update VE core submodule to master (89a8d99f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623424 (https://phabricator.wikimedia.org/T259531) (owner: 10Jforrester) [18:11:53] 10VisualEditor, 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out), 10User-Dyolf77: Change what symbol is prepended to pings on ar.wiki - https://phabricator.wikimedia.org/T258743 (10Esanders) I think the root cause of this is that Arabic, and link prefixes in gene... [18:29:52] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (FY2020-21 Kanban Board), 10Regression, 10Skipped QA: Gap under mobile toolbar tools at tablet width - https://phabricator.wikimedia.org/T260368 (10matmarex) [18:29:56] 10VisualEditor, 10Growth-Team, 10StructuredDiscussions, 10Editing-team (FY2020-21 Kanban Board), and 3 others: Uncaught TypeError: Cannot read property 'ownerDocument' of undefined / TypeError: context is undefined - https://phabricator.wikimedia.org/T259531 (10matmarex) [18:45:21] (03CR) 10DannyS712: Clean up base class reaching into the subclass (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622542 (owner: 10Thiemo Kreuz (WMDE)) [19:27:29] 10VisualEditor, 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out), 10User-Dyolf77: Change what symbol is prepended to pings on ar.wiki - https://phabricator.wikimedia.org/T258743 (10cscott) Our recommendation is to forward this issue to #lang-current to address.... [19:48:32] 10VisualEditor, 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out), 10User-Dyolf77: Change what symbol is prepended to pings on ar.wiki - https://phabricator.wikimedia.org/T258743 (10ppelberg) >>! In T258743#6424685, @Esanders wrote: Nice work, @esanders. Resolving... [20:48:53] 10VisualEditor, 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out), 10User-Dyolf77: Change what symbol is prepended to pings on ar.wiki - https://phabricator.wikimedia.org/T258743 (10ssastry) >>! In T258743#6424887, @cscott wrote: > Although wikitext is *supposed*... [20:53:01] 10Editing-team, 10Desktop Improvements, 10DiscussionTools, 10UI-Standardization, and 4 others: Update link colors in Vector for improved UX (and consistency) - https://phabricator.wikimedia.org/T213778 (10Jdlrobson) [21:46:28] 10VisualEditor, 10VisualEditor-DataModel, 10User-Ryasmeen, 10Wikimedia-production-error: Error thrown when deleting a heading next to a table - https://phabricator.wikimedia.org/T140871 (10Jdlrobson) [21:47:05] 10VisualEditor, 10VisualEditor-DataModel, 10User-Ryasmeen, 10Wikimedia-production-error: Error thrown when deleting a heading next to a table - https://phabricator.wikimedia.org/T140871 (10Jdlrobson) This came up in the production error logs. I believe it's the same: https://logstash.wikimedia.org/app/kiba... [21:55:31] 10VisualEditor, 10VisualEditor-ContentEditable, 10Wikimedia-production-error: "Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly) - https://phabricator.wikimedia.org/T191858 (10Jdlrobson) [21:58:45] 10VisualEditor, 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out), 10User-Dyolf77: Change what symbol is prepended to pings on ar.wiki - https://phabricator.wikimedia.org/T258743 (10ppelberg) [21:59:15] 10VisualEditor, 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out), 10User-Dyolf77: Change what symbol is prepended to pings on ar.wiki - https://phabricator.wikimedia.org/T258743 (10ppelberg) [21:59:20] 10VisualEditor, 10VisualEditor-ContentEditable, 10Wikimedia-production-error: "Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly) - https://phabricator.wikimedia.org/T191858 (10Jdlrobson) Showing up in production error logs. https://logstash.wikimedia... [22:00:10] 10VisualEditor, 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out), 10User-Dyolf77: Change what symbol is prepended to pings on ar.wiki - https://phabricator.wikimedia.org/T258743 (10ppelberg) >>! In T258743#6424937, @ppelberg wrote: > In the meantime, @Dyolf77_WMF...