[02:02:32] (03CR) 10Divec: "> Patch Set 3:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623410 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [02:05:29] (03PS5) 10Divec: TreeModifier: More optimizations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623403 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [02:09:46] (03CR) 10Divec: [C: 03+2] TreeModifier: More optimizations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623403 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [02:12:13] (03Merged) 10jenkins-bot: TreeModifier: More optimizations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623403 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [06:24:17] (03CR) 10Thiemo Kreuz (WMDE): "Nice, thanks a lot! It makes me very happy to see we can make smaller tweaks like this that fast." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/621483 (owner: 10Thiemo Kreuz (WMDE)) [06:28:36] (03PS5) 10Thiemo Kreuz (WMDE): Clean up base class reaching into the subclass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622542 [06:29:34] (03PS6) 10Thiemo Kreuz (WMDE): Clean up base class reaching into the subclass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622542 [06:47:55] (03CR) 10jerkins-bot: [V: 04-1] Clean up base class reaching into the subclass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622542 (owner: 10Thiemo Kreuz (WMDE)) [09:17:24] (03CR) 10Tchanders: [C: 03+2] Add map to Qunit tests [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622810 (https://phabricator.wikimedia.org/T261406) (owner: 10Mvolz) [09:35:54] (03Merged) 10jenkins-bot: Add map to Qunit tests [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622810 (https://phabricator.wikimedia.org/T261406) (owner: 10Mvolz) [15:13:06] 10Editing-team, 10MediaWiki-General: Double-click in text field can cause page reload and data loss - https://phabricator.wikimedia.org/T250945 (10DLynch) 05Open→03Resolved a:03Krinkle Looks like @Krinkle independently made the view-only change in d6f0cd0643d3a66e66c38d35e64c311c6ef1e6e0 without knowing... [15:17:56] (03PS1) 10Esanders: DiffTreeNode: Compare node lengths before doing full comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623809 [15:17:58] (03PS1) 10Esanders: ve.dm.Document: Cache node offsets when read-only [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623810 [15:18:00] (03PS1) 10Esanders: Update treeDiffer to 1.0.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623811 [15:18:40] (03PS4) 10Esanders: TreeModifier: Add optimization for short array comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623410 (https://phabricator.wikimedia.org/T261634) [15:18:42] (03PS4) 10Esanders: ve.ce.Surface: Debounce onModelDocumentUpdate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623411 (https://phabricator.wikimedia.org/T261662) [15:18:44] (03PS3) 10Esanders: Add a "very long" demo file that is 3x longer than long [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623455 [15:24:59] (03CR) 10Awight: "Thanks for bringing attention to this class, it certainly is problematic!" (036 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622542 (owner: 10Thiemo Kreuz (WMDE)) [15:44:45] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (15186ed26) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623655 (https://phabricator.wikimedia.org/T259634) (owner: 10Bartosz Dziewoński) [15:49:39] (03CR) 10Esanders: "It doesn't look like any of our "compare" functions are a bottle neck anywhere else, so I won't bother with that for now, but worth noting" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623410 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [15:52:53] So, I have a Surface, an ActionFactory, an action like ('window', 'open', 'media'), I wait for the promise to return. But no window appears and the promise never completes. What am I missing, attaching the element to the DOM? [15:54:48] (03PS1) 10Jforrester: Update OOUI to v0.40.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623821 [15:56:46] https://phabricator.wikimedia.org/P12435 [15:58:03] (03CR) 10Esanders: "BD: There didn't seem to be any improvement with your version. I think this is because in the most common path (both lengths == 1) you are" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623410 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [15:58:03] hmm, maybe I need more structure to the empty target. [16:00:42] (03PS4) 10Esanders: Add a "very long" demo file that is 3x longer than long [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623455 [16:01:17] (03PS5) 10Esanders: ve.ce.Surface: Debounce onModelDocumentUpdate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623411 (https://phabricator.wikimedia.org/T261662) [16:03:37] (03CR) 10Jforrester: [C: 03+2] Add a "very long" demo file that is 3x longer than long [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623455 (owner: 10Esanders) [16:05:23] (03CR) 10Esanders: "(100 keystrokes in 300k doc spends 0.5ms doing JSON.stringify)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623410 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [16:06:13] (03Merged) 10jenkins-bot: Add a "very long" demo file that is 3x longer than long [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623455 (owner: 10Esanders) [16:07:34] (03Merged) 10jenkins-bot: Update VE core submodule to master (15186ed26) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623655 (https://phabricator.wikimedia.org/T259634) (owner: 10Bartosz Dziewoński) [16:21:53] (03CR) 10DLynch: [C: 03+2] ve.ce.Surface: Debounce onModelDocumentUpdate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623411 (https://phabricator.wikimedia.org/T261662) (owner: 10Esanders) [16:23:04] (03CR) 10Esanders: "> Patch Set 3:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623403 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [16:23:29] edsanders: ^ general question to add to your review queue :-) [16:23:33] 10VisualEditor, 10VisualEditor-ContentEditable, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Performance Issue: undo/redo is slow on large documents - https://phabricator.wikimedia.org/T261662 (10Esanders) a:03Esanders [16:23:40] 10VisualEditor, 10VisualEditor-DataModel, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), and 3 others: Typing is slow on very long documents - https://phabricator.wikimedia.org/T261634 (10Esanders) a:03Esanders [16:24:37] (03Merged) 10jenkins-bot: ve.ce.Surface: Debounce onModelDocumentUpdate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623411 (https://phabricator.wikimedia.org/T261662) (owner: 10Esanders) [16:25:59] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T261522 (10Esanders) a:03Esanders [16:26:07] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10JavaScript, 10Patch-For-Review, 10Wikimedia-production-error: TypeError: item is null (getRect called with null) - https://phabricator.wikimedia.org/T259551 (10Esanders) a:03Esanders [16:41:08] 10VisualEditor, 10Wikimedia-production-error: TypeError: can't access property "length", rects is null in find and replace - https://phabricator.wikimedia.org/T261881 (10Jdlrobson) [16:49:52] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (FY2020-21 Kanban Board): Mobile should inherit desktop editing preferences - https://phabricator.wikimedia.org/T261423 (10JTannerWMF) @ppelberg and @Esanders will add a description to this task during their 1:1 [16:54:12] 10VisualEditor, 10Wikimedia-production-error: TypeError: undefined is not an object (evaluating 'param.aliases.length') - https://phabricator.wikimedia.org/T261884 (10Jdlrobson) [17:08:53] * awight scratches head, looking for where ve.ui.actionFactory.register is called for the 'window' action. [17:09:30] ^oooh lib/ [17:10:08] * awight widens eyes at increased scope of things to learn [17:10:20] :o [17:10:52] did you have some question earlier? (i don't have channel logs) [17:19:16] MatmaRex: Hi! Thanks, I'm just taking first steps and trying to grok the codebase. Today, my question is basically: why doesn't this work? https://phabricator.wikimedia.org/P12435 [17:20:03] Also, is this the right paradigm or is there an even more elegant way to wire the click to a new dialog? [17:21:58] hmm [17:24:10] awight: there's actually a helper method for this, surface.execute( 'window', 'open', 'media', { ... } ) [17:24:31] ooh that's great to hear! [17:25:12] awight: but also, only one window can be open at a time – if that code isn't working for you, then i assume you're using that widget inside some other window [17:25:34] /o\ Darn, that's a fundamental issue. [17:25:42] you'll have to either close it first to open the new one instead, or put your window in a separate WindowManager [17:25:57] yes I'm doing this from within the MWParameterPage [17:26:03] (or put whatever interface you need into the window you have) [17:26:08] :-) kk windowManager it is [17:26:43] Yeah we found the MediaDialog nested within the gallery view, so I see that it's possible. Must be a separate window manager there, like you said. [17:28:36] awight: i think the media search interface is actually just a widget, and it's used in a few places [17:28:45] it's not "attached" to a window [17:29:24] but we also have cases like e.g. if you're writing a gallery image caption, and then try to add a template – that requires another WindowManager to open the template dialog [17:47:11] 10Editing-team, 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog (Kanbanana-2020-21-Q1), 10Wikimedia-production-error: Production error: TypeError: defaultUri is undefined` - https://phabricator.wikimedia.org/T261886 (10Jdlrobson) [17:47:16] Hello! so I keep getting "Error contacting the Parsoid/RESTBase server (HTTP 404)" on the latest master even though I don't have RESTBase, how do I prevent VE from thinking that I have RestBASE? [17:47:39] 10Editing-team, 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog (Kanbanana-2020-21-Q1), 10Wikimedia-production-error: Production error: TypeError: defaultUri is undefined` - https://phabricator.wikimedia.org/T261886 (10Jdlrobson) [17:48:14] you can see this happen here (in Firefox, wont work at all in Chrome for unrelated bug) https://thegoodplace.wmflabs.org/index.php?title=Wednesday&veaction=edit [17:48:17] 10Editing-team, 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog (Kanbanana-2020-21-Q1), 10Wikimedia-production-error: Production error: TypeError: defaultUri is undefined` - https://phabricator.wikimedia.org/T261886 (10Jdlrobson) [17:50:32] davidwbarratt: Do you have the Parsoid extension from git clone ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid ? [17:50:50] (sorry for spam pasta) [17:50:55] I do not, do I need it? [17:51:07] I'm running MediaWiki at master [17:51:25] https://thegoodplace.wmflabs.org/wiki/Special:Version [17:52:56] I've needed to have that extension to enable VE, so far. I'm not sure what the long-term migration path will be though, maybe this has changed already. [17:53:32] Mostly cribbing from https://www.mediawiki.org/wiki/Parsoid/PHP [17:59:15] yeah the extension page is gone? https://www.mediawiki.org/wiki/Extension:Parsoid [17:59:24] MatmaRex: Now stuck at "opening data must contain a fragment"... (paste updated) [17:59:59] davidwbarratt: 🤣 [18:00:57] (sorry, i'll be back in a minute) [18:01:47] No rush of course, I'm just saying out loud the things I would be wondering to myself on a normal day. Happy to keep plugging away and self-educating! [18:05:56] 10VisualEditor, 10Wikimedia-production-error: Error: domNode has no ancestor with a .data( 'view' ) - https://phabricator.wikimedia.org/T261888 (10Jdlrobson) [18:07:58] I must have missed some wiring, I see that WindowAction.open already gets the fragment from the surface. [18:11:25] Okay found it, the data parameter needs to explicitly include a fragment. [18:13:29] Success! MatmaRex thanks for all the hints :-D [18:15:02] and I learned that the fragment is where the media dialog will write its output. Really neat! [18:19:39] (oh I'm way off base, no other caller specifies a fragment directly) [18:25:25] davidwbarratt: btw, I'm running a wmcloud box using this patch cherry-picked onto our deployment branch, https://gerrit.wikimedia.org/r/c/mediawiki/vagrant/+/616521 [18:30:05] i'm around now [18:31:24] davidwbarratt: if you're getting that error, then you have neither RESTBase nor Parsoid, and that's a problem ;) [18:31:41] davidwbarratt: VE should be trying to load the page HTML from Parsoid from this URL: https://thegoodplace.wmflabs.org/rest.php/thegoodplace.wmflabs.org/v3/page/html/Wednesday [18:31:45] and that returns a 404 indeed [18:32:38] if you're on master, you probably need to configure your wiki like this: https://www.mediawiki.org/wiki/Parsoid/PHP#Developer_setup [18:33:24] That page says to use Parsoid extension which no longer exists..? [18:33:47] it's the mediawiki/services/parsoid repository [18:34:24] i'm not sure how exactly it works, it's kind of but not quite an extension?… but you need to load it woth wfLoadExtension() like that :D [18:34:29] with* [18:43:08] ooo, this repo is included in Core now [18:44:28] https://github.com/wikimedia/mediawiki/blob/3e33f832c89e7f18d7ed08f88943268e1fa4c6fb/composer.json#L52 [18:52:38] so apparently this worked for dmaza without the config less than a month ago, and now it's broken [18:54:11] FWIW this is the error I get now after pulling the latest commit "{"messageTranslations":{"en":"The requested relative path (/default.web.mw.localhost/v3/page/html/Main_Page/1) did not match any known handler"},"httpCode":404,"httpReason":"Not Found"}" [18:55:10] davidwbarratt: It should be as simple as the vagrant patch I posted. Just wfLoadExtension on whereever you've cloned mediawiki/services/parsoid. [18:55:59] davidwbarratt: dmaza: it probably worked out-of-the-box on master before this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/622187 where we reverted a big hack that was used for the 1.35 branch [18:56:55] hmm, so mediawiki/services/parsoid is also installed as a composer package. i wonder if you can just wfLoadExtension() it from there? [18:57:59] MatmaRex: In my case, I wanted to reuse the existing vagrant puppet modules so passed a `remote` attribute to mediawiki::extension. [18:58:17] @MatmaRex that seems to do it [18:58:57] (i know nothing about vagrant) [18:59:40] (03CR) 10Divec: [C: 03+2] TreeModifier: Add optimization for short array comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623410 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [18:59:41] I'm confused on why VE wouldn't use the Parsoid library if it's already been autoloaded by core? [19:00:06] something like this? dmaza? wfLoadExtension( "Parsoid", "vendor/wikimedia/parsoid/extension.json" ) [19:00:12] davidwbarratt: Looking at the task https://phabricator.wikimedia.org/T261220 I think that's coming in a short while. [19:00:13] like it shouldn't be making a sub-request anyways... [19:01:35] davidwbarratt: i think core autoloads the library, but some of the required configuration has to be loaded using the "extension stub" [19:02:12] @MatmaRex yes [19:02:43] davidwbarratt: apparently parsoid was causing some problems with PHP's garbage collector, and that's why we're doing a separate HTTP request instead of directly calling the code to parse a page [19:02:48] (03Merged) 10jenkins-bot: TreeModifier: Add optimization for short array comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623410 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [19:04:40] davidwbarratt: actually Parsoid just completely disables GC before it does anything (and it only frees memory once the script terminates). this task looks related https://phabricator.wikimedia.org/T254509 [19:04:53] i remember looking into this because i was also annoyed by the HTTP request thing [19:05:08] but i can't find the task about it right now [19:06:54] here's the one i remembered: https://phabricator.wikimedia.org/T248343#6235747 [19:18:52] I think what I need to do is create a detached surface fragment, and adapt between that and my input field's value. [19:57:31] 10VisualEditor, 10Wikimedia-production-error: TypeError: titleAndFragment is null - https://phabricator.wikimedia.org/T261894 (10Jdlrobson) [20:02:12] (03PS1) 10Esanders: Fix typo in documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623857 [20:02:14] (03PS1) 10Esanders: Handle tables with rowspans that exceed the matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623858 (https://phabricator.wikimedia.org/T191858) [20:03:12] 10Editing-team, 10VisualEditor, 10Parsing-Team, 10Parsoid: Various literal syntax saved in edits via Parsoid/VisualEditor - https://phabricator.wikimedia.org/T261895 (10Krinkle) [20:03:48] 10VisualEditor, 10VisualEditor-ContentEditable, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Wikimedia-production-error: "Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly) - https://phabricator.wikimedia.org/T191858 (10Esanders) [20:03:59] 10Editing-team, 10VisualEditor, 10Parsing-Team, 10Parsoid: Various literal syntax saved in edits via Parsoid/VisualEditor - https://phabricator.wikimedia.org/T261895 (10Krinkle) [20:04:02] 10VisualEditor, 10VisualEditor-ContentEditable, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Wikimedia-production-error: "Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly) - https://phabricator.wikimedia.org/T191858 (10Esanders)... [20:12:25] (03CR) 10Jforrester: [C: 03+2] Fix typo in documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623857 (owner: 10Esanders) [20:12:36] (03CR) 10Jforrester: "Test?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623858 (https://phabricator.wikimedia.org/T191858) (owner: 10Esanders) [20:15:06] (03Merged) 10jenkins-bot: Fix typo in documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623857 (owner: 10Esanders) [20:20:02] MatmaRex: This baroque hunt-and-peck almost does what I want, but not quite. The source wikitext isn't correctly wired in or out of the media dialog. https://phabricator.wikimedia.org/P12435 [20:26:41] (03PS2) 10Esanders: Handle tables with rowspans that exceed the matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623858 (https://phabricator.wikimedia.org/T191858) [20:26:45] awight: it's a bit weird that you're constructing your own ve.dm.Surface and so on… i think i don't actually understand what you're trying to do :D [20:27:30] (03CR) 10Esanders: "I was just writing some 😊" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623858 (https://phabricator.wikimedia.org/T191858) (owner: 10Esanders) [20:27:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs: "Uncaught TypeError: Cannot read property 'node' of undefined" when viewing visual diff - https://phabricator.wikimedia.org/T161646 (10Jdlrobson) It looks like this same error also occurred during the import of a table: https://logstash.wi... [20:29:02] (03PS2) 10Awight: [WIP] Experiment with a new FileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623412 (https://phabricator.wikimedia.org/T260886) [20:29:20] (03CR) 10Esanders: "Inserting a new row doesn't quite work as expected, because it relies on the last row in the matrix to be correctly formed, but one can us" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623858 (https://phabricator.wikimedia.org/T191858) (owner: 10Esanders) [20:29:27] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Experiment with a new FileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623412 (https://phabricator.wikimedia.org/T260886) (owner: 10Awight) [20:30:15] MatmaRex: Good to have this feedback! The idea is (T260886) to enhance pop open a media selector dialog as [20:30:16] T260886: VE Dialog on the Test Instance: Add media selector - https://phabricator.wikimedia.org/T260886 [20:30:18] ugh [20:30:29] awight: ve.ui.MWMediaDialog (and anything else that inherits from ve.ui.FragmentDialog) is supposed to be used for editing content on the VE's surface (or inserting new content there), but it looks like you don't want that, you just want an interface to search for files? [20:30:36] heh [20:32:27] ... idea is to enhance the template parameter dialog by adding a button on wiki-file-type parameters which pops open a media selector dialog. When opening the dialog, the current field value ("Imagename.jpg") is sent in as the initial wikitext, as if we were editing a "[[File:Imagename.jpg]]" node. When closing with action:insert, the chosen filename replaces the field value. [20:33:46] (03Abandoned) 10Jforrester: [FAILING TEST CASE] TableAction: Inserting a mixed th/td row should do so [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/351918 (owner: 10Jforrester) [20:34:19] (03CR) 10Jforrester: [C: 03+1] Handle tables with rowspans that exceed the matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623858 (https://phabricator.wikimedia.org/T191858) (owner: 10Esanders) [20:35:14] (03CR) 10Esanders: "In If5673e59480ee243d60ea4e9c5f53abb6e938746" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/351918 (owner: 10Jforrester) [20:35:32] awight: i would try doing that by using only the search interface from the media dialog (mw.widgets.MediaSearchWidget) in your own dialog [20:36:11] awight: and we have something similar implemented in ve.ui.LanguageInputWidget / ve.ui.LanguageSearchDialog / ve.ui.LanguageSearchWidget [20:36:38] which would correspond to ve.ui.MWFileInputWidget / ....(this dialog you'd have implement) / mw.widgets.MediaSearchWidget in your code [20:37:53] MatmaRex: That makes sense, if necessary I can clone the higher-level behavior, but we really do want to reuse the dialog wholesale (I believe), as a way of creating continuity in the interface. [20:38:24] We want both the search and upload behavior, so the dialog is pretty much perfect. [20:38:39] (you can see that here in the UI: https://i.imgur.com/1UpB8TW.jpg https://i.imgur.com/HcUHBwK.jpg https://i.imgur.com/Z7CHeW3.jpg ) [20:38:48] hmm [20:40:05] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'isPlaceholder' of undefined - https://phabricator.wikimedia.org/T261530 (10Jdlrobson) I found a related bug that will likely also fixed by this? `Uncaught Typ... [20:41:10] awight: the entire upload interface is also a single widget (mw.ForeignStructuredUpload.BookletLayout), i think you'd only need to re-implement the tabs and some (boring…) glue code [20:41:54] awight: ve.ui.MWMediaDialog itself contains mostly the code for setting image caption, size, thumbnail posiion, etc. – you probably don't want any of that, just the file name [20:42:12] MatmaRex: Since you mention it... I think you're right, thanks for the persistence :-) Re-reading our requirements, we want to skip the caption screen -- ^ ah you're way ahead of me! [20:42:13] (03CR) 10Jforrester: [C: 03+1] Fix pasting cells onto a sparse table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623175 (https://phabricator.wikimedia.org/T261530) (owner: 10Esanders) [20:43:50] awight: i'm increasingly agreeing with you that we should have some component that would wrap the search+upload interfaces… we just don't have one [20:43:54] Okay this has been really helpful. I'll try integrating just the MediaSearchWidget and ForeignStructuredUpload tomorrow, and anticipate boring glue code :-) [20:44:05] i just realized that we don't have the upload option in the gallery dialog, only in the media dialog [20:44:19] MatmaRex: cool, I'll consider that refactor as I do this... [20:45:08] :D [20:48:10] * awight enters hibernation mode [21:10:10] 10VisualEditor, 10VisualEditor-DataModel, 10User-Ryasmeen, 10Wikimedia-production-error: Error thrown when deleting a heading next to a table (Unbalanced set of replace operations found) - https://phabricator.wikimedia.org/T140871 (10Esanders) The exception is the same, but I don't think the cause is the s... [21:15:38] (03CR) 10DLynch: [C: 03+2] Fix pasting cells onto a sparse table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623175 (https://phabricator.wikimedia.org/T261530) (owner: 10Esanders) [21:18:21] (03Merged) 10jenkins-bot: Fix pasting cells onto a sparse table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623175 (https://phabricator.wikimedia.org/T261530) (owner: 10Esanders) [21:53:55] (03CR) 10Bartosz Dziewoński: [C: 03+1] TreeModifier: Add optimization for short array comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623410 (https://phabricator.wikimedia.org/T261634) (owner: 10Esanders) [21:57:21] (03CR) 10Bartosz Dziewoński: [C: 03+2] FindAndReplace: Guard against getSelectionRects failing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623069 (https://phabricator.wikimedia.org/T261522) (owner: 10Esanders) [21:59:53] (03Merged) 10jenkins-bot: FindAndReplace: Guard against getSelectionRects failing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623069 (https://phabricator.wikimedia.org/T261522) (owner: 10Esanders) [21:59:55] (03CR) 10Bartosz Dziewoński: "Ah, yeah, I couldn't view the diff of https://meta.wikimedia.org/w/index.php?title=Wikimedia_Foundation_salaries&diff=20405332&oldid=19783" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623809 (owner: 10Esanders) [22:01:03] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T261522 (10Esanders) As we couldn't reproduce this, there is nothing to test. Hopefully it will stop appea... [22:02:51] (03PS2) 10Bartosz Dziewoński: DiffTreeNode: Compare node lengths before doing full comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623809 (owner: 10Esanders) [22:02:58] (03PS3) 10Bartosz Dziewoński: DiffTreeNode: Compare node lengths before doing full comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623809 (owner: 10Esanders) [22:03:06] (03CR) 10Bartosz Dziewoński: [C: 03+2] DiffTreeNode: Compare node lengths before doing full comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623809 (owner: 10Esanders) [22:03:12] (03PS2) 10Bartosz Dziewoński: ve.dm.Document: Cache node offsets when read-only [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623810 (owner: 10Esanders) [22:03:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (FY2020-21 Kanban Board): Mobile should inherit desktop editing preferences - https://phabricator.wikimedia.org/T261423 (10Esanders) [22:03:22] (03CR) 10Bartosz Dziewoński: [C: 03+2] ve.dm.Document: Cache node offsets when read-only [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623810 (owner: 10Esanders) [22:03:28] (03PS2) 10Bartosz Dziewoński: Update treeDiffer to 1.0.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623811 (owner: 10Esanders) [22:03:34] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update treeDiffer to 1.0.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623811 (owner: 10Esanders) [22:04:56] (03PS3) 10Esanders: Handle tables with rowspans that exceed the matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623858 (https://phabricator.wikimedia.org/T191858) [22:05:56] (03Merged) 10jenkins-bot: DiffTreeNode: Compare node lengths before doing full comparison [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623809 (owner: 10Esanders) [22:05:59] (03Merged) 10jenkins-bot: ve.dm.Document: Cache node offsets when read-only [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623810 (owner: 10Esanders) [22:06:04] (03Merged) 10jenkins-bot: Update treeDiffer to 1.0.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623811 (owner: 10Esanders) [22:06:42] 10Editing-team, 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog (Kanbanana-2020-21-Q1), 10Wikimedia-production-error: Production error: TypeError: defaultUri is undefined` - https://phabricator.wikimedia.org/T261886 (10matmarex) Is this the same as T106244? [22:09:22] (03PS2) 10Bartosz Dziewoński: ve.ui.MWSignatureContextItem: Remove useless 'command' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/612981 [22:09:24] (03CR) 10Esanders: "I hadn't seen that one. Will be interesting to see if stops timing out after these fixes. The cutoff is quite low though (1,000ms)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623809 (owner: 10Esanders) [22:10:16] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (b49db9a5b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623875 (https://phabricator.wikimedia.org/T261522) [22:28:48] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (b49db9a5b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623875 (https://phabricator.wikimedia.org/T261522) (owner: 10Bartosz Dziewoński) [23:36:34] 10VisualEditor, 10Desktop Improvements, 10Vector, 10Editing-team (Tracking), 10Readers-Web-Backlog (Kanbanana-2020-21-Q1): [Regression] UI regressions in VE on Beta cluster - https://phabricator.wikimedia.org/T259083 (10Jdlrobson) a:03alexhollender This is awaiting input from Alex.