[00:03:50] Anyone know why I can't get my skin to work with VisualEditor, and I get a console warning saing to check that skin-requirements page. Anyone know why? [00:29:52] (03CR) 10Bartosz Dziewoński: "@Esanders @Divec The test failure looks real at a glance, might be a problem with one of the patches?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623875 (https://phabricator.wikimedia.org/T261522) (owner: 10Bartosz Dziewoński) [06:34:05] 10VisualEditor, 10Expiring-Watchlist-Items, 10Community-Tech (Kanban-2020-21-Q1), 10Patch-For-Review: Watchlist Expiry: Watchstar popup not always usable on VisualEditor - https://phabricator.wikimedia.org/T260432 (10Samwilson) Thanks for the pointers, @Esanders. I think it's still worth pursuing moving t... [07:43:21] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Johnbra) [07:49:26] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Johnbra) [07:56:09] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Johnbra) [08:01:25] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Johnbra) [09:23:43] 10VisualEditor, 10Community-Tech, 10MediaWiki-extensions-TemplateWizard, 10WMDE-Templates-FocusArea: Log template metadata whenever a template dialog is opened - https://phabricator.wikimedia.org/T259705 (10Lena_WMDE) [09:24:43] 10VisualEditor, 10Community-Tech, 10MediaWiki-extensions-TemplateWizard, 10WMDE-Templates-FocusArea: Log template metadata whenever a template dialog is opened - https://phabricator.wikimedia.org/T259705 (10ECohen_WMDE) >which should maybe be edited since I think now these overlap a bit. Discussed in story... [09:51:48] (03PS7) 10Thiemo Kreuz (WMDE): [WIP] Clean up base class reaching into the subclass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622542 [09:53:38] 10WikiEditor, 10MediaWiki-Page-editing: Generate live preview for code editors - https://phabricator.wikimedia.org/T261933 (10Aklapper) 05Open→03Declined Hi, you don't mention which editor you are using (see https://www.mediawiki.org/wiki/Editor ), but this is already possible if you use the #VisualEditor... [10:05:01] 10Editing-team, 10VisualEditor, 10Anti-Harassment, 10MobileFrontend, and 4 others: MobileFrontend should not use moment.js for a single line in its editor - https://phabricator.wikimedia.org/T224635 (10Tchanders) [10:10:36] (03PS1) 10Thiemo Kreuz (WMDE): Add and update soft PHPDoc type hints [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/623996 [10:11:33] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Seb35) I have pretty much the same configuration, except I use nginx and you use Apache, and I have no issue, neither when I create a page with VE... [10:11:45] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Clean up base class reaching into the subclass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622542 (owner: 10Thiemo Kreuz (WMDE)) [10:16:55] (03PS1) 10Thiemo Kreuz (WMDE): Add strict type hints in unambiguous places [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624000 [10:18:10] (03PS1) 10Thiemo Kreuz (WMDE): Make properties in TemplateDataBlob private [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624003 [10:19:57] (03PS1) 10Thiemo Kreuz (WMDE): Make subclass constructors properly call each other [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624004 [10:20:11] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2020): Support 'maps' parameter in TemplateData Editor (GUI) - https://phabricator.wikimedia.org/T208305 (10Mvolz) [10:20:14] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2020), and 3 others: Add maps to QUnit tests - https://phabricator.wikimedia.org/T261406 (10Mvolz) 05Open→03Resolved a:03Mvolz [10:22:26] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects: Model adding / removing individual maps in Model.js and test methods. - https://phabricator.wikimedia.org/T261941 (10Mvolz) [10:22:45] 10WikiEditor, 10MediaWiki-Page-editing: Generate live preview for code editors - https://phabricator.wikimedia.org/T261933 (10Nikolay_Komarov) I'm aware of the Visual Editor. I did mention "**code** editors" in the header of this task. Many WP editors and administrators use code to check and fix markup. Code e... [10:33:22] (03CR) 10jerkins-bot: [V: 04-1] Add and update soft PHPDoc type hints [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/623996 (owner: 10Thiemo Kreuz (WMDE)) [10:39:35] (03CR) 10jerkins-bot: [V: 04-1] Make properties in TemplateDataBlob private [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624003 (owner: 10Thiemo Kreuz (WMDE)) [10:40:45] (03CR) 10jerkins-bot: [V: 04-1] Make subclass constructors properly call each other [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624004 (owner: 10Thiemo Kreuz (WMDE)) [10:55:45] 10Citoid, 10Technical-Debt: Update citoid to latest service-template-node - https://phabricator.wikimedia.org/T248571 (10Mvolz) [10:55:53] 10Citoid, 10Technical-Debt: Update citoid to latest service-template-node - https://phabricator.wikimedia.org/T248571 (10Mvolz) [11:05:56] 10WikiEditor, 10MediaWiki-Page-editing: Generate live preview for code editors - https://phabricator.wikimedia.org/T261933 (10Aklapper) Ah, thanks for elaborating. I don't see how one could preview //code// (if that refers to programming code, e.g. when #CodeEditor is used). If you had "wikitext" in mind inst... [11:09:49] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Johnbra) Thanks for testing this Seb35, my results seem strange when compared to your results. I reverted back to the original version (i.e. no c... [11:12:39] (03PS1) 10Esanders: Follow-up I1361852: Make docs writable when finished [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/624019 [11:37:48] (03PS2) 10Thiemo Kreuz (WMDE): Make subclass constructors properly call each other [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624004 [11:38:16] (03PS2) 10Thiemo Kreuz (WMDE): Make properties in TemplateDataBlob private [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624003 [11:41:03] (03PS2) 10Thiemo Kreuz (WMDE): Add and update soft PHPDoc type hints [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/623996 [11:53:55] (03PS3) 10Awight: [WIP] Experiment with a new FileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623412 (https://phabricator.wikimedia.org/T260886) [11:54:12] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Experiment with a new FileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623412 (https://phabricator.wikimedia.org/T260886) (owner: 10Awight) [11:58:13] (03CR) 10jerkins-bot: [V: 04-1] Make subclass constructors properly call each other [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624004 (owner: 10Thiemo Kreuz (WMDE)) [11:59:19] (03CR) 10jerkins-bot: [V: 04-1] Make properties in TemplateDataBlob private [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624003 (owner: 10Thiemo Kreuz (WMDE)) [12:06:15] (03CR) 10jerkins-bot: [V: 04-1] Add and update soft PHPDoc type hints [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/623996 (owner: 10Thiemo Kreuz (WMDE)) [12:15:20] 10VisualEditor: VE mutliplies ISBN - https://phabricator.wikimedia.org/T261951 (10NicoV) [13:05:56] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Seb35) I tested after installing Apache 2.4.38 with default settings and mod_php7.3 and *I can confirm* the bug when creating a page, and indeed s... [13:24:35] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Seb35) It’s really a difference of treatment by core Apache between: ` http://localhost/mediawiki-1.35.0-rc.2/rest.php/localhost/v3/page/html/Util... [13:50:17] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Seb35) I’m no more accustomed to Apache, but probably it is related to some pathinfo, I tried without success to play with [AcceptPathInfo](https:... [14:08:16] 10VisualEditor: VE mutliplies ISBN - https://phabricator.wikimedia.org/T261951 (10NicoV) Other example: https://fr.wikipedia.org/w/index.php?title=Saint-Martin-V%C3%A9subie&diff=prev&oldid=174058602 [14:16:39] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor not working when : or / characters in the Title. Possible bug? - https://phabricator.wikimedia.org/T261921 (10Johnbra) Thank you, given this is a confirmed bug using Apache (and editing doesn't work even with the changes proposed), I will install nginx for... [14:22:46] 10VisualEditor, 10Parsoid, 10RESTBase: Visual Editor + Apache bug. Visual Editor not working when editing or creating a page with : or / characters in the Title. e.g. http://localhost/w/index.php/User:John/Newpage - https://phabricator.wikimedia.org/T261921 (10Johnbra) [14:27:47] (03PS4) 10Awight: [WIP] Experiment with a new FileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623412 (https://phabricator.wikimedia.org/T260886) [14:28:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Experiment with a new FileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623412 (https://phabricator.wikimedia.org/T260886) (owner: 10Awight) [15:59:03] 10TemplateData, 10VisualEditor, 10Anti-Harassment, 10Google-Summer-of-Code (2020), and 2 others: Allow different maps to be edited separately in the TemplateData dialog - https://phabricator.wikimedia.org/T258820 (10Tchanders) 05Open→03Resolved [16:05:49] 10TemplateData, 10VisualEditor, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Run script to collect one-time stats about TemplateData - https://phabricator.wikimedia.org/T258924 (10Esanders) When we did our TemplateData drives back in the day, we sorted out lists by how frequently... [16:07:16] 10VisualEditor, 10Parsoid: VE mutliplies ISBN template - https://phabricator.wikimedia.org/T261951 (10matmarex) [16:22:32] 10VisualEditor, 10Wikimedia-production-error: TypeError: undefined is not an object (evaluating 'dialog.mediaUploadBooklet.setFile') - https://phabricator.wikimedia.org/T261969 (10Jdlrobson) [16:25:48] 10TemplateData, 10VisualEditor, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Run script to collect one-time stats about TemplateData - https://phabricator.wikimedia.org/T258924 (10ECohen_WMDE) Thanks for raising this point @Esanders ! Agree that this will give us a more useful id... [16:55:38] (03CR) 10DLynch: [C: 03+2] ve.ui.MWSignatureContextItem: Remove useless 'command' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/612981 (owner: 10Bartosz Dziewoński) [17:15:45] (03Merged) 10jenkins-bot: ve.ui.MWSignatureContextItem: Remove useless 'command' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/612981 (owner: 10Bartosz Dziewoński) [17:19:11] (03CR) 10DLynch: "It's specifically failing on the "ve.ui.DiffElement (Cite)" test, which is suggestive as to which patches it might be." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623875 (https://phabricator.wikimedia.org/T261522) (owner: 10Bartosz Dziewoński) [17:35:26] 10VisualEditor, 10Parsoid: VE mutliplies ISBN template - https://phabricator.wikimedia.org/T261951 (10ssastry) Ya, this is a scenario where links are embedded in links -- which just breaks up the HTML as per the HTML spec and which we normally handle -- but, in this case, templates are involved as well which i... [17:40:26] 10VisualEditor, 10Parsoid: VE mutliplies ISBN template - https://phabricator.wikimedia.org/T261951 (10ssastry) Looking at the transcript below, looks like the linting logic doesn't capture the links-in-links scenario. And, I just realized that the ISBN template is not a magic word anymore, it just generates a... [17:48:39] 10VisualEditor, 10Parsoid: VE mutliplies ISBN template - https://phabricator.wikimedia.org/T261951 (10ssastry) As for the primary problem where templates & link-in-link scenarios are involved, looks like about-id continuity is broken up because of the HTML5 tree builder fixups In the output below, parts of th... [17:49:54] 10VisualEditor, 10Parsoid: VE mutliplies ISBN template - https://phabricator.wikimedia.org/T261951 (10ssastry) @NicoV, but, independent of what Parsoid should do, {{ISBN}} template uses should never be embedded inside `[..]` extlink markup since that is bad markup. So, if you can update your WPCleaner to detec... [18:07:45] (03CR) 10Bartosz Dziewoński: [C: 03+2] Follow-up I1361852: Make docs writable when finished [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/624019 (owner: 10Esanders) [18:10:39] (03Merged) 10jenkins-bot: Follow-up I1361852: Make docs writable when finished [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/624019 (owner: 10Esanders) [18:22:01] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] Understand how editing interface preferences are set - https://phabricator.wikimedia.org/T261978 (10ppelberg) [18:24:49] (03PS2) 10Bartosz Dziewoński: Update VE core submodule to master (9534694b4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623875 (https://phabricator.wikimedia.org/T261522) [18:34:44] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] Understand how editing interface preferences are set - https://phabricator.wikimedia.org/T261978 (10ppelberg) [18:34:53] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] Understand how editing interface preferences are set - https://phabricator.wikimedia.org/T261978 (10ppelberg) [18:35:07] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] Understand how editing interface preferences are set - https://phabricator.wikimedia.org/T261978 (10ppelberg) [18:45:57] 10TemplateData, 10VisualEditor, 10WMDE-Technical-Wishes-Team, 10WMDE-Templates-FocusArea, and 3 others: Run script to collect one-time stats about TemplateData - https://phabricator.wikimedia.org/T258924 (10awight) Great to see this discussion happening! >>! In T258924#6433734, @Esanders wrote: > If you w... [18:54:06] 10VisualEditor, 10Wikimedia-production-error: TypeError: this.model is null - https://phabricator.wikimedia.org/T261980 (10Jdlrobson) [18:54:19] 10VisualEditor, 10ContentTranslation, 10Growth-Team, 10RESTBase, 10StructuredDiscussions: Upstream something like VE's ApiParsoidTrait into core - https://phabricator.wikimedia.org/T261310 (10ssastry) [18:55:19] 10VisualEditor, 10Wikimedia-production-error: TypeError: undefined is not an object (evaluating 'param.aliases.length') - https://phabricator.wikimedia.org/T261884 (10Jdlrobson) Error sometimes appears as `TypeError: param.aliases is undefined` e.g. https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/lo... [19:18:20] 10Editing-team, 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog (Kanbanana-2020-21-Q1), 10Wikimedia-production-error: Production error: TypeError: defaultUri is undefined` - https://phabricator.wikimedia.org/T261886 (10Jdlrobson) [19:20:23] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (9534694b4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623875 (https://phabricator.wikimedia.org/T261522) (owner: 10Bartosz Dziewoński) [19:20:26] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design, 10Voice & Tone: Change label "Basic form" to something clearer - https://phabricator.wikimedia.org/T108713 (10iamjessklein) I agree with @Amire80 - the issue here is really the word "form". If we were in an universe where the term... [19:20:52] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design, 10Voice & Tone: Change label "Basic form" to something clearer - https://phabricator.wikimedia.org/T108713 (10iamjessklein) [19:27:46] 10Citoid, 10Technical-Debt: Update citoid to latest service-template-node - https://phabricator.wikimedia.org/T248571 (10Mvolz) [19:42:04] (03Merged) 10jenkins-bot: Update VE core submodule to master (9534694b4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/623875 (https://phabricator.wikimedia.org/T261522) (owner: 10Bartosz Dziewoński) [19:44:58] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design, 10Voice & Tone: Change label "Basic form" to something clearer - https://phabricator.wikimedia.org/T108713 (10Whatamidoing-WMF) "Blank box"? "Empty"? "Create your own"? [20:04:39] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design, 10Voice & Tone: Change label "Basic form" to something clearer - https://phabricator.wikimedia.org/T108713 (10Esanders) * Free text * Simple * Plain [20:16:14] 10VisualEditor, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board), 10User-Ryasmeen, 10Wikimedia-production-error: TableCellNode throws exception if still active when torn down - https://phabricator.wikimedia.org/T256500 (10Krinkle) 05Open→03Resolved No longer seen for 30 days in Logstash. [20:44:41] (03CR) 10Esanders: [C: 03+2] Add strict type hints in unambiguous places [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624000 (owner: 10Thiemo Kreuz (WMDE)) [20:48:56] (03CR) 10Esanders: [C: 03+2] Update OOUI to v0.40.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623821 (owner: 10Jforrester) [20:50:20] (03PS1) 10Jdlrobson: Disable ArticleTargetLoader on invalid UTF-8 URIs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/624266 (https://phabricator.wikimedia.org/T106244) [20:51:29] (03Merged) 10jenkins-bot: Update OOUI to v0.40.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/623821 (owner: 10Jforrester) [21:13:58] (03CR) 10jerkins-bot: [V: 04-1] Disable ArticleTargetLoader on invalid UTF-8 URIs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/624266 (https://phabricator.wikimedia.org/T106244) (owner: 10Jdlrobson) [21:15:17] (03PS2) 10Jdlrobson: Disable ArticleTargetLoader on invalid UTF-8 URIs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/624266 (https://phabricator.wikimedia.org/T106244) [21:24:12] (03Merged) 10jenkins-bot: Add strict type hints in unambiguous places [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624000 (owner: 10Thiemo Kreuz (WMDE)) [21:25:56] (03PS1) 10Tchanders: ve.dm.VisualDiff: Don't return a diff if the tree diff times out [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/624270 (https://phabricator.wikimedia.org/T161646) [21:39:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10Patch-For-Review: "Uncaught TypeError: Cannot read property 'node' of undefined" when viewing visual diff - https://phabricator.wikimedia.org/T161646 (10Tchanders) @matmarex @Jdlrobson - thanks for the examples. Timeouts aen't being ha... [21:40:10] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff shows different result for comparable change (inserting one word) - https://phabricator.wikimedia.org/T187589 (10Esanders) [21:55:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10Wikimedia-production-error: "Uncaught TypeError: Cannot read property 'node' of undefined" when viewing visual diff - https://phabricator.wikimedia.org/T161646 (10Tchanders) [22:36:17] 10VisualEditor, 10Desktop Improvements, 10Editing-team (Tracking), 10Readers-Web-Backlog (Kanbanana-2020-21-Q1), 10Vector (Vector (Tracking)): Highlight on VE not covering full button area - https://phabricator.wikimedia.org/T259331 (10Jdlrobson) The top padding of the content aligns just right with the... [22:39:32] 10VisualEditor, 10Desktop Improvements, 10Vector, 10Editing-team (Tracking), 10Readers-Web-Backlog (Kanbanana-2020-21-Q1): VE toolbar doesn't align with the "Article"/"Discussion" tabs - https://phabricator.wikimedia.org/T259272 (10Jdlrobson) I believe this error has the same root cause as T259331#643478... [23:06:03] (03CR) 10Esanders: [C: 03+2] ve.dm.VisualDiff: Don't return a diff if the tree diff times out [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/624270 (https://phabricator.wikimedia.org/T161646) (owner: 10Tchanders) [23:09:23] (03Merged) 10jenkins-bot: ve.dm.VisualDiff: Don't return a diff if the tree diff times out [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/624270 (https://phabricator.wikimedia.org/T161646) (owner: 10Tchanders)