[01:38:34] (03CR) 10Jayprakash12345: [C: 03+1] Never use example values as a placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625599 (https://phabricator.wikimedia.org/T261284) (owner: 10Awight) [02:27:29] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (a2dbc868a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625769 (https://phabricator.wikimedia.org/T187589) [06:44:37] (03CR) 10Jforrester: [C: 03+2] Update VE core submodule to master (a2dbc868a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625769 (https://phabricator.wikimedia.org/T187589) (owner: 10Bartosz Dziewoński) [06:54:24] (03CR) 10Awight: "> I think removing this from the placeholder is dependent on the other change that makes the example more visible." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625599 (https://phabricator.wikimedia.org/T261284) (owner: 10Awight) [06:55:33] (03PS1) 10Awight: Never use example values as a placeholder [extensions/VisualEditor] (wmde-templates) - 10https://gerrit.wikimedia.org/r/625748 (https://phabricator.wikimedia.org/T261284) [06:57:43] (03CR) 10Awight: "Hmm, well because of the terrible thing I did with our feature branch, it turns out to be annoying to cherry-pick. I'll use the Depends-O" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625599 (https://phabricator.wikimedia.org/T261284) (owner: 10Awight) [06:58:00] (03Abandoned) 10Awight: Never use example values as a placeholder [extensions/VisualEditor] (wmde-templates) - 10https://gerrit.wikimedia.org/r/625748 (https://phabricator.wikimedia.org/T261284) (owner: 10Awight) [06:58:27] (03PS2) 10Awight: Never use example values as a placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625599 (https://phabricator.wikimedia.org/T261284) [07:03:33] (03Merged) 10jenkins-bot: Update VE core submodule to master (a2dbc868a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625769 (https://phabricator.wikimedia.org/T187589) (owner: 10Bartosz Dziewoński) [07:18:38] (03CR) 10jerkins-bot: [V: 04-1] Never use example values as a placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625599 (https://phabricator.wikimedia.org/T261284) (owner: 10Awight) [08:37:19] 10Citoid, 10Patch-For-Review, 10Technical-Debt: Update citoid to latest service-template-node - https://phabricator.wikimedia.org/T248571 (10Mvolz) [09:24:21] 10VisualEditor, 10Expiring-Watchlist-Items, 10Community-Tech (Kanban-2020-21-Q1), 10Editing-team (Tracking), and 2 others: Watchlist Expiry: Temporarily watched page shows full star after publishing in VisualEditor until reload - https://phabricator.wikimedia.org/T260434 (10dom_walden) >>! In T260434#64366... [09:36:21] (03PS1) 10Andrew-WMDE: Adjust the styling of the editor dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/625845 (https://phabricator.wikimedia.org/T261874) [10:52:54] (03CR) 10Mvolz: [C: 04-1] "Thanks for keeping working on this!" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/625639 (https://phabricator.wikimedia.org/T261544) (owner: 10AdhamKhatean) [10:59:25] (03PS3) 10Esanders: Don't show welcome dialog unless switchable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/522119 (https://phabricator.wikimedia.org/T227769) [10:59:27] (03PS1) 10Esanders: Init: Reuse isEditPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625867 [10:59:29] (03PS1) 10Esanders: Init: Remove duplicate check for showBetaWelcome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625868 [11:08:54] (03CR) 10Jforrester: "(Still think this is a bad idea.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/522119 (https://phabricator.wikimedia.org/T227769) (owner: 10Esanders) [11:10:32] (03PS1) 10Andrew-WMDE: Reorder the sections of the editor dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/625870 (https://phabricator.wikimedia.org/T261875) [11:51:26] (03CR) 10Esanders: [C: 04-1] Disable ArticleTargetLoader on invalid UTF-8 URIs (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/624266 (https://phabricator.wikimedia.org/T106244) (owner: 10Jdlrobson) [12:07:02] 10VisualEditor, 10Desktop Improvements, 10Editing-team (Tracking), 10Readers-Web-Backlog (Kanbanana-2020-21-Q1), 10Vector (Vector (Tracking)): Highlight on VE not covering full button area - https://phabricator.wikimedia.org/T259331 (10Esanders) >>! In T259331#6436737, @Jdlrobson wrote: > Is there a way... [12:14:14] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff should not load the whole page - https://phabricator.wikimedia.org/T261191 (10Esanders) Currently the diff can only be calculated in the client so we have to download the full page, or did you have something else in mind? [12:16:33] 10TemplateData, 10VisualEditor, 10I18n, 10good first task: Change the value of 'templatedata-doc-param-type-wiki-page-name' from "Page" to "Page name" in English (en.json file only) - https://phabricator.wikimedia.org/T250292 (10Mvolz) p:05Triage→03Low [12:17:11] 10TemplateData, 10VisualEditor, 10I18n, 10good first task: Change the value of 'templatedata-doc-param-type-wiki-page-name' from "Page" to "Page name" in English (en.json file only) - https://phabricator.wikimedia.org/T250292 (10Mvolz) [12:18:33] 10TemplateData, 10VisualEditor, 10Parsoid, 10Parsoid-Rendering: Retarget TemplateData extension for Parsoid extension - https://phabricator.wikimedia.org/T262266 (10Mvolz) [12:21:11] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff inside the editor doesn't match visual diff from the history page (for changed reference) - https://phabricator.wikimedia.org/T260008 (10Esanders) Can you give a specific example? [12:22:44] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff doesn't show the addition of a template in a reference - https://phabricator.wikimedia.org/T259957 (10Esanders) [12:29:27] 10TemplateData, 10VisualEditor, 10Parsoid, 10Parsoid-Rendering: Retarget TemplateData extension for Parsoid extension - https://phabricator.wikimedia.org/T262266 (10Mvolz) p:05Triage→03Medium [12:44:48] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff should not load the whole page - https://phabricator.wikimedia.org/T261191 (10Bugreporter) So we need a new service in server. [12:54:04] (03CR) 10Esanders: "-1 "Add ve.DiffMatchPatch.test.js" this file is missing" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625769 (https://phabricator.wikimedia.org/T187589) (owner: 10Bartosz Dziewoński) [12:54:44] (03PS1) 10Esanders: Add missing test file (ve.DiffMatchPatch.test.js) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625896 [13:25:30] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Oops, thanks." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625896 (owner: 10Esanders) [13:26:25] (03CR) 10Bartosz Dziewoński: "(https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/625896)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625769 (https://phabricator.wikimedia.org/T187589) (owner: 10Bartosz Dziewoński) [13:39:04] (03CR) 10AdhamKhatean: "> Patch Set 1: Code-Review-1" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/625639 (https://phabricator.wikimedia.org/T261544) (owner: 10AdhamKhatean) [13:44:34] (03Merged) 10jenkins-bot: Add missing test file (ve.DiffMatchPatch.test.js) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625896 (owner: 10Esanders) [14:17:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10Editing-team (FY2020-21 Kanban Board), and 2 others: "Uncaught TypeError: Cannot read property 'node' of undefined" when viewing visual diff - https://phabricator.wikimedia.org/T161646 (10matmarex) [14:17:54] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15): Visual diff shows different result for comparable change (inserting one word) - https://phabricator.wikimedia.org/T187589 (10matmarex) [14:30:54] (03CR) 10Jforrester: [C: 03+2] Init: Reuse isEditPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625867 (owner: 10Esanders) [14:31:16] (03CR) 10Jforrester: [C: 03+2] Init: Remove duplicate check for showBetaWelcome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625868 (owner: 10Esanders) [14:33:03] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MobileFrontend, 10Mobile, and 2 others: VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model - https://phabricator.wikimedia.org/T245172 (10Esanders) [14:47:46] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff shows non-minimal diff that could easily be improved - https://phabricator.wikimedia.org/T197928 (10Esanders) This is how the diff looks after the fix to T187589: {F32250620,size=full} It is slightly sub-optimal in that "Farben" is removed and inserted.... [14:52:25] (03Merged) 10jenkins-bot: Init: Reuse isEditPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625867 (owner: 10Esanders) [14:53:14] 10VisualEditor, 10MediaWiki-Docker, 10Parsoid, 10Editing-team (Tracking): Zeroconf Parsoid + VisualEditor doesn't work with MediaWiki-Docker - https://phabricator.wikimedia.org/T261390 (10DLynch) A possible indicator of whatever's going wrong: the visualeditor API parse call //always// returns Main_Page re... [14:54:23] (03Merged) 10jenkins-bot: Init: Remove duplicate check for showBetaWelcome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625868 (owner: 10Esanders) [15:03:08] 10VisualEditor, 10VisualEditor-VisualDiffs: Sub-optimal visual diff resulting from diff spanning words - https://phabricator.wikimedia.org/T262285 (10Esanders) [15:05:29] (03PS4) 10Andrew-WMDE: [POC] Implement back button warning popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/624780 (https://phabricator.wikimedia.org/T260887) [15:15:49] (03PS3) 10Andrew-WMDE: [POC] Template sidebar is always open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625613 (https://phabricator.wikimedia.org/T261503) (owner: 10Awight) [15:16:21] 10VisualEditor, 10MediaWiki-Docker, 10Parsoid, 10Editing-team (Tracking): Zeroconf Parsoid + VisualEditor doesn't work with MediaWiki-Docker - https://phabricator.wikimedia.org/T261390 (10DLynch) > It's possible that this is being an issue independent of the docker/sqlite setup due to some less-used codepa... [15:24:32] (03PS5) 10Andrew-WMDE: [POC] Implement back button warning popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/624780 (https://phabricator.wikimedia.org/T260887) [15:26:53] (03PS4) 10Andrew-WMDE: [POC] Template sidebar is always open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625613 (https://phabricator.wikimedia.org/T261503) (owner: 10Awight) [15:29:00] 10VisualEditor, 10RESTBase, 10Editing-team (Tracking), 10MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), 10Platform Team Workboards (Clinic Duty Team): Page is blank when edited a page on gomwiktionary with VisualEditor (new pages are missing on some RESTBase servers) - https://phabricator.wikimedia.org/T257124... [15:30:48] 10VisualEditor, 10RESTBase, 10Editing-team (Tracking), 10MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), 10Platform Team Workboards (Clinic Duty Team): Page is blank when edited a page on gomwiktionary with VisualEditor (new pages are missing on some RESTBase servers) - https://phabricator.wikimedia.org/T257124... [15:35:11] (03CR) 10Jdlrobson: "> Patch Set 2:" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/624266 (https://phabricator.wikimedia.org/T106244) (owner: 10Jdlrobson) [15:45:49] (03CR) 10jerkins-bot: [V: 04-1] [POC] Implement back button warning popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/624780 (https://phabricator.wikimedia.org/T260887) (owner: 10Andrew-WMDE) [15:48:48] (03CR) 10jerkins-bot: [V: 04-1] [POC] Template sidebar is always open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/625613 (https://phabricator.wikimedia.org/T261503) (owner: 10Awight) [16:46:27] 10VisualEditor, 10MediaWiki-Docker, 10Parsoid, 10Editing-team (Tracking): Zeroconf Parsoid + VisualEditor doesn't work with MediaWiki-Docker - https://phabricator.wikimedia.org/T261390 (10DLynch) @kostajh suggested I downgrade the docker image to 0.3.0 (from 0.5.0), which stopped this error from occurring. [17:10:35] 10VisualEditor, 10Desktop Improvements, 10Vector, 10Editing-team (Tracking), 10Readers-Web-Backlog (Kanbanana-2020-21-Q1): VE toolbar doesn't align with the "Article"/"Discussion" tabs - https://phabricator.wikimedia.org/T259272 (10Jdlrobson) a:05Peter.ovchyn→03None [18:16:05] 10VisualEditor, 10Wikimedia-production-error: TypeError: null is not an object (evaluating 'rects.length') - https://phabricator.wikimedia.org/T262302 (10Jdlrobson) [18:28:09] 10VisualEditor, 10Wikimedia-production-error: TypeError: node is null ( at ve.adjacentDomPosition ) - https://phabricator.wikimedia.org/T262303 (10Jdlrobson) [18:59:45] 10VisualEditor, 10Parsoid: VE mutliplies ISBN template - https://phabricator.wikimedia.org/T261951 (10NicoV) @ssastry Thanks for the answers. WPCleaner can already detect the {{ISBN}} template in external link, and can fix some instances (where the {{ISBN}} is near the end of the external link I think). More... [19:37:14] 10Cite, 10Book-Referencing, 10WMDE-Technical-Wishes-Team, 10Patch-For-Review, 10Technical-Debt: Cleanup and document code dealing with incomplete follow - https://phabricator.wikimedia.org/T245549 (10thiemowmde) According to https://global-search.toolforge.org/?q=.*®ex=1&namespaces=8&title=Cite+refere... [19:53:25] 10VisualEditor, 10Desktop Improvements, 10Editing-team (Tracking), 10Readers-Web-Backlog (Kanbanana-2020-21-Q1), 10Vector (Vector (Tracking)): Highlight on VE not covering full button area - https://phabricator.wikimedia.org/T259331 (10Catrope) >>! In T259331#6436737, @Jdlrobson wrote: > Alternatively, w... [20:34:08] 10VisualEditor: Editing unregistered at wiki.pt does not generate any kind of warning about ones IP being revealed - https://phabricator.wikimedia.org/T262320 (10Reedy) >>! In T262320#6444340, @Darwinius wrote: > I believe the warning should not be displayed before editing, but before saving, which is what reall... [20:35:16] 10VisualEditor: Editing unregistered at wiki.pt does not generate any kind of warning about ones IP being revealed - https://phabricator.wikimedia.org/T262320 (10Darwinius) >>! In T262320#6444369, @Reedy wrote: >>>! In T262320#6444340, @Darwinius wrote: >> I believe the warning should not be displayed before edi... [21:00:22] 10VisualEditor, 10MediaWiki-Page-editing, 10Patch-For-Review, 10Platform Team Workboards (External Code Reviews), and 2 others: Move "templates on this page" logic out of EditPage - https://phabricator.wikimedia.org/T252962 (10eprodromou) p:05Triage→03Medium [21:24:05] 10Editing-team, 10DiscussionTools, 10OWC2020: Make Reply Tool available as opt-out preference at all Wikipedias - https://phabricator.wikimedia.org/T262331 (10ppelberg) [21:24:24] 10Editing-team, 10DiscussionTools, 10OWC2020: Make Reply Tool available as opt-out preference at all Wikipedias - https://phabricator.wikimedia.org/T262331 (10ppelberg) [21:24:26] 10Editing-team, 10DiscussionTools, 10OWC2020: [Epic] Scale DiscussionTools to all Wikipedias - https://phabricator.wikimedia.org/T251207 (10ppelberg) [21:52:54] (03CR) 10DannyS712: [C: 03+2] Make subclass constructors properly call each other [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624004 (owner: 10Thiemo Kreuz (WMDE)) [21:54:29] (03CR) 10DannyS712: [C: 03+2] Make properties in TemplateDataBlob private [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624003 (owner: 10Thiemo Kreuz (WMDE)) [22:00:05] 10VisualEditor, 10RESTBase, 10Editing-team (Tracking), 10MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), 10Platform Team Workboards (Clinic Duty Team): Page is blank when edited a page on gomwiktionary with VisualEditor (new pages are missing on some RESTBase servers) - https://phabricator.wikimedia.org/T257124... [22:02:27] (03CR) 10DannyS712: [C: 03+2] Use more canonical (object)[] instead of new stdClass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/621250 (owner: 10Thiemo Kreuz (WMDE)) [22:06:08] (03CR) 10DannyS712: [C: 03+2] Make TemplateDataBlob::normaliseInterfaceText() private [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/621267 (owner: 10Thiemo Kreuz (WMDE)) [22:06:36] 10VisualEditor, 10jQuery-Client, 10Browser-Support-Apple-Safari, 10Patch-For-Review: VE won’t load on Chrome+iOS - https://phabricator.wikimedia.org/T262223 (10Krinkle) It looks like other iPhone browsers have the same issue, here is Firefox on iOS: ` Mozilla/5.0 (iPhone; CPU iPhone OS 13_6_1 like Mac OS... [22:17:39] (03Merged) 10jenkins-bot: Make subclass constructors properly call each other [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624004 (owner: 10Thiemo Kreuz (WMDE)) [22:17:42] (03Merged) 10jenkins-bot: Make properties in TemplateDataBlob private [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/624003 (owner: 10Thiemo Kreuz (WMDE)) [22:45:14] (03Merged) 10jenkins-bot: Use more canonical (object)[] instead of new stdClass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/621250 (owner: 10Thiemo Kreuz (WMDE)) [22:45:16] (03Merged) 10jenkins-bot: Make TemplateDataBlob::normaliseInterfaceText() private [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/621267 (owner: 10Thiemo Kreuz (WMDE)) [22:58:08] (03PS3) 10Jdlrobson: Disable ArticleTargetLoader on invalid UTF-8 URIs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/624266 (https://phabricator.wikimedia.org/T106244) [23:12:21] 10VisualEditor, 10Wikimedia-production-error: Uncaught Error: Offset is out of bounds - https://phabricator.wikimedia.org/T262354 (10Jdlrobson) [23:31:52] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff inside the editor doesn't match visual diff from the history page (for changed reference) - https://phabricator.wikimedia.org/T260008 (10AxelBoldt) Click on https://en.wikipedia.org/w/index.php?title=Alice_Dreger&oldid=971360142&veaction=editsource§...