[00:03:34] 10Editing-team, 10DiscussionTools: Add tools to DiscussionTools' source mode - https://phabricator.wikimedia.org/T257391 (10ppelberg) [00:03:36] 10Editing-team, 10DiscussionTools: Add tools to DiscussionTools' source mode - https://phabricator.wikimedia.org/T257391 (10ppelberg) **Task description update** I've updated the task description to include the feedback [user:ネイ](https://www.mediawiki.org/wiki/User:%E3%83%8D%E3%82%A4) shared at mw.org here: h... [05:42:16] 10VisualEditor, 10Growth-Team, 10ProofreadPage, 10StructuredDiscussions, and 2 others: Deprecate SkinMinervaDefaultModules hook - https://phabricator.wikimedia.org/T256086 (10Ammarpad) > ProofReadPage extension uses this hook to disable the editor - this should be replaced by a configuration flag in Minerv... [13:25:59] 10VisualEditor, 10VisualEditor-DataModel, 10JavaScript, 10Wikimedia-production-error: Uncaught Error: Cannot insert text into a break node - https://phabricator.wikimedia.org/T262866 (10Esanders) [13:34:22] (03PS1) 10Esanders: FindAndReplace: Always highlight results when opening [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/628487 (https://phabricator.wikimedia.org/T262877) [13:34:56] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Find and replace fails to highlight words when opened via F3 - https://phabricator.wikimedia.org/T262877 (10Esanders) a:03Esanders [13:37:18] 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) - https://phabricator.wikimedia.org/T262842 (10Esanders) Line 319: `if ( importedCell.node.type !== cell.node.type ) {` Could be pasting a sparse table... [13:37:44] 10VisualEditor, 10VisualEditor-DataModel, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'type' of undefined - https://phabricator.wikimedia.org/T262858 (10Esanders) [13:40:41] 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: TypeError: this.selection.isNull is not a function - https://phabricator.wikimedia.org/T261784 (10Esanders) The gadget must be creating a SurfaceFragment without a selection. We don't generally guard against garbage being passed to constructors, so... [13:46:21] 10Editing-team, 10DiscussionTools: Add tools to DiscussionTools' source mode - https://phabricator.wikimedia.org/T257391 (10Patriccck) >>! In T257391#6383246, @ppelberg wrote: >>>! In T257391#6382434, @Patriccck wrote: >>>>! In T257391#6304943, @JTannerWMF wrote: >>> We will revisit the priority of this task i... [15:05:58] 10VisualEditor, 10CirrusSearch, 10Collection, 10ContentTranslation, and 29 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [15:58:13] (03PS2) 10Thiemo Kreuz (WMDE): Fix all eslint warnings [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/628402 [16:19:06] (03CR) 10jerkins-bot: [V: 04-1] Fix all eslint warnings [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/628402 (owner: 10Thiemo Kreuz (WMDE)) [16:59:35] (03CR) 10Jforrester: [C: 03+1] FindAndReplace: Always highlight results when opening [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/628487 (https://phabricator.wikimedia.org/T262877) (owner: 10Esanders) [17:14:57] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/628503 (https://phabricator.wikimedia.org/T253169) [17:15:47] (03CR) 10Jforrester: [C: 04-1] "Let's not randomly bump VE-core, hmm? ;-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/628503 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [17:16:40] (03CR) 10Jforrester: [C: 04-1] "Especially a rollback, in this case." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/628503 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [17:17:03] (03PS2) 10Jforrester: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/628503 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:17:46] 10VisualEditor, 10CirrusSearch, 10Collection, 10ContentTranslation, and 29 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [18:22:39] (03CR) 10Jforrester: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/628503 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:43:57] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/628503 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:52:29] 10Citoid, 10Patch-For-Review, 10Platform Team Workboards (Clinic Duty Team): In cite journal, do not add URL expanded from existing identifier like DOI - https://phabricator.wikimedia.org/T232771 (10Levivich) There was a recently-closed RFC on enwiki that may be relevant: https://en.wikipedia.org/w/index.php... [20:35:07] 10WikiEditor, 10Community-Tech, 10Browser-Support-Google-Chrome: Charinsert links do not position the cursor correctly when syntax highlighting is enabled - https://phabricator.wikimedia.org/T262835 (10Andyrom75) The issue occurs also with Safari on smartphone (I'm not able to determine its version)