[00:09:48] (03CR) 10Bartosz Dziewoński: [C: 03+2] Don't set alt text if attribute was originally 'null' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/631980 (https://phabricator.wikimedia.org/T264533) (owner: 10Esanders) [00:10:07] 10VisualEditor, 10VisualEditor-Media, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Image gets empty 'alt' attribute when changed - https://phabricator.wikimedia.org/T264533 (10matmarex) [00:12:26] 10VisualEditor, 10VisualEditor-Media, 10Patch-For-Review: Image gets empty 'alt' attribute when changed - https://phabricator.wikimedia.org/T264533 (10Esanders) [00:14:10] 10VisualEditor, 10Desktop Improvements, 10DiscussionTools, 10Vector, 10Editing-team (FY2020-21 Kanban Board): [Regression pre-wmf.11] The footer text is showing through the link inspector suggestions dialog inside Reply tool - https://phabricator.wikimedia.org/T264679 (10matmarex) Old Vector works correc... [00:20:12] 10VisualEditor, 10Desktop Improvements, 10DiscussionTools, 10Vector, 10Editing-team (FY2020-21 Kanban Board): [Regression pre-wmf.11] The footer text is showing through the link inspector suggestions dialog inside Reply tool - https://phabricator.wikimedia.org/T264679 (10Esanders) I think the reading tea... [00:20:53] 10VisualEditor, 10Desktop Improvements, 10DiscussionTools, 10Vector, 10Editing-team (FY2020-21 Kanban Board): [Regression pre-wmf.11] The footer text is showing through the link inspector suggestions dialog inside Reply tool - https://phabricator.wikimedia.org/T264679 (10matmarex) It's probably something... [00:21:56] 10VisualEditor, 10Desktop Improvements, 10DiscussionTools, 10Vector, 10Editing-team (FY2020-21 Kanban Board): New Vector: The footer text is showing through the link inspector suggestions dialog inside Reply tool - https://phabricator.wikimedia.org/T264679 (10Esanders) [00:29:03] (03Merged) 10jenkins-bot: Don't set alt text if attribute was originally 'null' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/631980 (https://phabricator.wikimedia.org/T264533) (owner: 10Esanders) [00:32:30] 10VisualEditor, 10VisualEditor-Media, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Image gets empty 'alt' attribute when changed - https://phabricator.wikimedia.org/T264533 (10matmarex) [00:33:42] 10VisualEditor, 10VisualEditor-Media, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board): Image gets empty 'alt' attribute when changed - https://phabricator.wikimedia.org/T264533 (10matmarex) [00:33:48] 10VisualEditor, 10VisualEditor-Media, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board): Image gets empty 'alt' attribute when changed - https://phabricator.wikimedia.org/T264533 (10matmarex) (no idea how you managed to remove the task from the workboard and simultaneously move it to a different column... [00:34:00] (03CR) 10Esanders: "not sure how I feel about logging the action as toggle. will look into this further" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/631861 (https://phabricator.wikimedia.org/T264146) (owner: 10DLynch) [00:36:35] 10Editing-team, 10DiscussionTools, 10OWC2020, 10Beta-Feature: Enable Reply Tool as Beta Feature on "Phase 2" wikis - https://phabricator.wikimedia.org/T264691 (10ppelberg) [00:44:54] 10VisualEditor, 10MediaWiki-extensions-Lockdown: Lockdown extension and VisualEditor Error - https://phabricator.wikimedia.org/T264680 (10Reedy) [00:47:39] 10Editing-team, 10DiscussionTools, 10OWC2020, 10Beta-Feature: Inform Phase 2 wikis of planned deployment - https://phabricator.wikimedia.org/T264692 (10ppelberg) [00:47:50] 10Editing-team, 10DiscussionTools, 10OWC2020, 10Beta-Feature: Inform Phase 2 wikis of planned deployment - https://phabricator.wikimedia.org/T264692 (10ppelberg) a:03Whatamidoing-WMF [00:54:06] 10Editing-team, 10DiscussionTools, 10OWC2020, 10Beta-Feature: Make config change to enable Reply Tool as Beta Feature at Phase 2 wikis - https://phabricator.wikimedia.org/T264693 (10ppelberg) [00:57:31] 10Editing-team, 10DiscussionTools, 10OWC2020, 10Beta-Feature: Make config change to enable Reply Tool as Beta Feature at Phase 2 wikis - https://phabricator.wikimedia.org/T264693 (10ppelberg) [01:08:04] 10Editing-team, 10DiscussionTools, 10OWC2020, 10Beta-Feature: Enable Reply Tool as Beta Feature on "Phase 2" wikis - https://phabricator.wikimedia.org/T264691 (10ppelberg) [01:45:54] 10VisualEditor, 10Parsoid, 10RESTBase, 10RESTBase-API, 10MW-1.35-release: VisualEditor in 1.35 not working (404 / Permanent Loading) - https://phabricator.wikimedia.org/T263928 (10ssastry) >>! In T263928#6519568, @D3nnis3n wrote: > Well, it's not completely working. On a long page with a lot of modules i... [02:01:48] (03CR) 10DLynch: "> Patch Set 1:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/631861 (https://phabricator.wikimedia.org/T264146) (owner: 10DLynch) [02:02:54] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing QA: Mobile should inherit desktop editing preferences - https://phabricator.wikimedia.org/T261423 (10ppelberg) [03:02:38] 10VisualEditor, 10Growth-Team, 10ProofreadPage, 10StructuredDiscussions, and 3 others: Deprecate SkinMinervaDefaultModules hook - https://phabricator.wikimedia.org/T256086 (10Soda) >>! In T256086#6519529, @Jdlrobson wrote: > I've written the patch for Flow. @soda can you make a change for ProofRead ? Sure... [03:13:47] 10VisualEditor, 10MediaWiki-extensions-Lockdown: Lockdown extension and VisualEditor Error - https://phabricator.wikimedia.org/T264680 (10Jasonba) Thank you for your quick response. I will give it a try and let you know. Thank you so much! [05:00:02] 10VisualEditor, 10Parsoid, 10RESTBase, 10RESTBase-API, 10MW-1.35-release: VisualEditor in 1.35 not working (404 / Permanent Loading) - https://phabricator.wikimedia.org/T263928 (10cscott) >>! In T263928#6519074, @ti_infotrad wrote: > I think this explains why the Parsoid routes were not loaded when I had... [08:24:32] (03CR) 10Mvolz: [C: 03+2] Move sub-page warning to dialog when opened [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/631973 (owner: 10Esanders) [08:25:29] 10Citoid, 10Technical-Debt: Update citoid to latest service-template-node - https://phabricator.wikimedia.org/T248571 (10Mvolz) 05Open→03Resolved [08:26:43] (03PS2) 10Mvolz: Add progressive flags to various buttons [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/631974 (owner: 10Esanders) [08:33:35] (03CR) 10Mvolz: "Whoops, this actually gets rid of the padding in the add parameter dialog." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/631976 (owner: 10Esanders) [08:38:33] (03PS1) 10Mvolz: Also add padding to add parameter panel [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/632439 [08:46:11] 10VisualEditor, 10MediaWiki-extensions-Lockdown: Lockdown extension and VisualEditor Error - https://phabricator.wikimedia.org/T264680 (10Aklapper) Hi @Jasonba, thanks for taking the time to report this and welcome to Wikimedia Phabricator! Which exact MediaWiki version and VisualEditor version and extension... [08:48:36] (03Merged) 10jenkins-bot: Move sub-page warning to dialog when opened [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/631973 (owner: 10Esanders) [08:59:08] (03CR) 10jerkins-bot: [V: 04-1] Also add padding to add parameter panel [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/632439 (owner: 10Mvolz) [12:03:26] (03CR) 10Mvolz: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/632439 (owner: 10Mvolz) [13:01:47] 10VisualEditor, 10VisualEditor-Media, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.12; 2020-10-05): Image gets empty 'alt' attribute when changed - https://phabricator.wikimedia.org/T264533 (10Esanders) This should be testable on the beta cluster. [13:06:16] 10Editing-team, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, and 3 others: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android - https://phabricator.wikimedia.org/T204691 (10Volker_E) [15:05:47] 10VisualEditor, 10Platform Engineering Roadmap Decision Making, 10Code-Health-Objective, 10Platform Engineering Roadmap: Move VE API from RESTBase into core. - https://phabricator.wikimedia.org/T264669 (10Naike) [16:02:54] 10VisualEditor, 10MediaWiki-extensions-Lockdown: Lockdown extension and VisualEditor Error - https://phabricator.wikimedia.org/T264680 (10Jasonba) Hi Reedy, I have tried to enter the entries (`lang=php, `); however, after that I received HTTP 500 error. Could you help? Thanks so much Reedy! I really appreci... [16:04:29] 10VisualEditor, 10MediaWiki-extensions-Lockdown: Lockdown extension and VisualEditor Error - https://phabricator.wikimedia.org/T264680 (10Reedy) >>! In T264680#6522075, @Jasonba wrote: > I have tried to enter the entries (`lang=php, `); however, after that I received HTTP 500 error. That is nothing more than... [16:04:34] * Reedy sighs [16:09:23] 10Editing-team, 10VisualEditor: Double-logging of dialog close events - https://phabricator.wikimedia.org/T264690 (10DLynch) [16:33:07] 10VisualEditor, 10MediaWiki-extensions-Lockdown: Lockdown extension and VisualEditor Error - https://phabricator.wikimedia.org/T264680 (10Jasonba) The Mediawiki 1.31.8, VisualEditor c3c9140. Thanks! [16:41:53] 10Editing-team, 10VisualEditor: Double-logging of dialog close events - https://phabricator.wikimedia.org/T264690 (10DLynch) We have a doubled inheritance via NodeDialog, it seems. 1. NodeDialog inherits FragmentDialog and mixes in NodeWindow. 2. NodeWindow inherits FragmentWindow, and FragmentDialog mixes in... [17:44:33] 10VisualEditor, 10Desktop Improvements, 10DiscussionTools, 10Vector, and 2 others: New Vector: The footer text is showing through the link inspector suggestions dialog inside Reply tool - https://phabricator.wikimedia.org/T264679 (10JTannerWMF) The Web team will investigate what is going on here and touch... [18:00:52] 10Editing-team, 10Editing-Team-Request: [REQUEST] Instrument image search in Visual Editor - https://phabricator.wikimedia.org/T264779 (10CBogen) [18:02:26] 10VisualEditor, 10Desktop Improvements, 10DiscussionTools, 10Readers-Web-Backlog, and 2 others: New Vector: The footer text is showing through the link inspector suggestions dialog inside Reply tool - https://phabricator.wikimedia.org/T264679 (10Jdlrobson) # summary This likely requires a change in Vector... [19:17:35] (03PS1) 10Jforrester: MWCategoryMetaItem: Allow trailing whitespace (e.g. \n) in category names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/632541 [19:21:07] (03CR) 10Esanders: [C: 03+2] MWCategoryMetaItem: Allow trailing whitespace (e.g. \n) in category names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/632541 (owner: 10Jforrester) [19:51:18] (03Merged) 10jenkins-bot: MWCategoryMetaItem: Allow trailing whitespace (e.g. \n) in category names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/632541 (owner: 10Jforrester) [20:14:13] 10Editing-team, 10VisualEditor: Double-logging of dialog close events - https://phabricator.wikimedia.org/T264690 (10Esanders) I think this double inheritance also applies to other methods (e.g. the constructor). Here is the visualisation for reference. ` FragmentWindow <--mixes-- FragmentDialog ^... [20:25:42] (03PS1) 10Esanders: Make NodeWindow a standalone mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/632566 (https://phabricator.wikimedia.org/T264690) [20:28:21] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Double-logging of dialog close events - https://phabricator.wikimedia.org/T264690 (10Esanders) I did a quick test of the above patch with MWGalleryDialog and both the constructor and getTeardownProcess ended up calling each corner o... [20:29:06] (03CR) 10jerkins-bot: [V: 04-1] Make NodeWindow a standalone mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/632566 (https://phabricator.wikimedia.org/T264690) (owner: 10Esanders) [20:48:04] 10VisualEditor, 10Desktop Improvements, 10DiscussionTools, 10Readers-Web-Backlog, and 2 others: New Vector: The footer text is showing through the link inspector suggestions dialog inside Reply tool - https://phabricator.wikimedia.org/T264679 (10nray) @Jdlrobson I put the `position: relative` style on th... [21:22:37] 10Editing-team, 10Editing-Team-Request: [REQUEST] Instrument image search in Visual Editor - https://phabricator.wikimedia.org/T264779 (10JTannerWMF) Hey @CBogen so the request of the Editing team is to build the actual instrumentation? [21:31:48] (03PS2) 10DLynch: Make NodeWindow a standalone mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/632566 (https://phabricator.wikimedia.org/T264690) (owner: 10Esanders) [21:37:15] (03CR) 10DLynch: [C: 03+2] Make NodeWindow a standalone mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/632566 (https://phabricator.wikimedia.org/T264690) (owner: 10Esanders) [21:39:52] (03Merged) 10jenkins-bot: Make NodeWindow a standalone mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/632566 (https://phabricator.wikimedia.org/T264690) (owner: 10Esanders) [21:41:05] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Double-logging of dialog close events - https://phabricator.wikimedia.org/T264690 (10DLynch) a:05DLynch→03Esanders [22:25:38] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board): Double-logging of dialog close events - https://phabricator.wikimedia.org/T264690 (10Esanders) @DLynch can you add QA instructions? [22:43:01] (03CR) 10Esanders: [C: 03+2] Also add padding to add parameter panel [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/632439 (owner: 10Mvolz) [22:46:12] 10Editing-team, 10Editing-Team-Request: [REQUEST] Instrument image search in Visual Editor - https://phabricator.wikimedia.org/T264779 (10CBogen) >>! In T264779#6523264, @JTannerWMF wrote: > Hey @CBogen so the request of the Editing team is to build the actual instrumentation? Yep. Or mentor our team to learn... [22:47:38] (03CR) 10Esanders: "This was in use when in was added: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateData/+/194748/6/modules/ext.templateDataG" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/622337 (owner: 10Thiemo Kreuz (WMDE)) [22:48:42] (03CR) 10Esanders: [C: 03+2] Fix parameter extraction from wikitext source [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/629168 (owner: 10Thiemo Kreuz (WMDE)) [22:49:12] 10Editing-team, 10Editing-Team-Request: [REQUEST] Instrument image search in Visual Editor - https://phabricator.wikimedia.org/T264779 (10JTannerWMF) [22:51:26] 10Editing-team, 10Editing-Team-Request: [REQUEST] Instrument image search in Visual Editor - https://phabricator.wikimedia.org/T264779 (10JTannerWMF) [22:53:32] (03CR) 10Esanders: Update a few confusing variable names in editor code (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/628332 (owner: 10Thiemo Kreuz (WMDE)) [23:02:38] (03Merged) 10jenkins-bot: Also add padding to add parameter panel [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/632439 (owner: 10Mvolz) [23:07:23] (03Merged) 10jenkins-bot: Fix parameter extraction from wikitext source [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/629168 (owner: 10Thiemo Kreuz (WMDE))