[02:24:45] 10Editing-team, 10DiscussionTools, 10Growth-Team, 10Notifications: Take the users to the exact location of the comment when clicking on a mention notification - https://phabricator.wikimedia.org/T253082 (10ppelberg) >>! In T253082#6271002, @Esanders wrote: > As we move from just adding reply links to addin... [03:04:05] 10VisualEditor: VisualEditor should not remove empty new line before section header - https://phabricator.wikimedia.org/T265320 (10Pols12) [08:52:22] 10TemplateData, 10VisualEditor, 10I18n, 10good first task: Change the value of 'templatedata-doc-param-type-wiki-page-name' from "Page" to "Page name" in English (en.json file only) - https://phabricator.wikimedia.org/T250292 (10Diwanshu885) a:03Diwanshu885 [09:01:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Incorrect display of full-width punctuation on 2017 Wikitext Editor - https://phabricator.wikimedia.org/T265332 (10LuciferianThomas) [11:14:37] (03PS1) 10Diwanshu885: Change the value of 'template-doc-param-type-wiki-page-name' from "Page" to "Page name" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/633714 (https://phabricator.wikimedia.org/T250292) [12:46:40] (03CR) 10Esanders: "This change is ready for review." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 (owner: 10Esanders) [12:47:38] (03CR) 10Esanders: "Testing locally I didn't notice much change in conversion time (DOM -> DM) or transactions (a simple insert-and-annotate)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 (owner: 10Esanders) [12:48:58] (03PS8) 10Esanders: Deep-freeze linear data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 (https://phabricator.wikimedia.org/T119236) [12:52:19] 10VisualEditor, 10VisualEditor-DataModel, 10Patch-For-Review, 10Technical-Debt: Evalulate pros and cons of an immutable data type for linear model data - https://phabricator.wikimedia.org/T119236 (10Esanders) Using Object.freeze this is relatively simple, with most of the changes happening in ElementLinear... [12:56:00] 10Citoid: citoid should add spaces before every pipe used in a cite template - https://phabricator.wikimedia.org/T265354 (10Jason_Quinn) [12:56:36] 10Citoid: citoid should add a space before every pipe character used in a cite template - https://phabricator.wikimedia.org/T265354 (10Jason_Quinn) [15:59:42] 10VisualEditor, 10Desktop Improvements: Inaccessible drop-down menu in Visual Editor for New Vector users - https://phabricator.wikimedia.org/T264379 (10ppelberg) [16:00:40] 10VisualEditor, 10Desktop Improvements: Inaccessible drop-down menu in Visual Editor for New Vector users - https://phabricator.wikimedia.org/T264379 (10ppelberg) >>! In T264379#6536744, @Vito-Genovese wrote: > Let me elaborate on the steps to reproduce the problem... The way you've written these reproduction... [16:09:43] 10VisualEditor, 10Desktop Improvements: Inaccessible drop-down menu in Visual Editor for New Vector users - https://phabricator.wikimedia.org/T264379 (10Vito-Genovese) [16:55:09] 10VisualEditor, 10Desktop Improvements, 10Readers-Web-Backlog, 10Vector, 10Editing-team (Tracking): VE toolbar doesn't align with the "Article"/"Discussion" tabs - https://phabricator.wikimedia.org/T259272 (10Jdlrobson) To summarize this task's status: A style in VisualEditor depends on a LESS variable v... [17:59:00] 10VisualEditor, 10Desktop Improvements, 10Readers-Web-Backlog, 10Vector, 10Editing-team (Tracking): VE toolbar doesn't align with the "Article"/"Discussion" tabs - https://phabricator.wikimedia.org/T259272 (10Jdlrobson) Following on our chat today @esanders I'm happy to look into this further but I reall... [18:44:41] 10WikiEditor, 10Wikimedia-production-error: Uncaught TypeError: $.widget.extend is not a function at openDialog (logspam) - https://phabricator.wikimedia.org/T265387 (10Jdlrobson) [18:54:07] 10VisualEditor, 10Wikimedia-production-error: Uncaught TypeError: selection.newFromAdjustment is not a function - https://phabricator.wikimedia.org/T265389 (10Jdlrobson) [18:54:20] 10VisualEditor, 10Wikimedia-production-error: Uncaught TypeError: selection.newFromAdjustment is not a function - https://phabricator.wikimedia.org/T265389 (10Jdlrobson) [19:05:18] 10VisualEditor, 10Wikimedia-production-error: Uncaught Error: Invalid start or end offset in selectNodes - https://phabricator.wikimedia.org/T265391 (10Jdlrobson) [19:05:21] 10VisualEditor, 10Wikimedia-production-error: Uncaught Error: ve.dm.Document.getBranchNodeFromOffset(): offset * is out of bounds - https://phabricator.wikimedia.org/T265392 (10Jdlrobson) [19:21:33] 10Editing-team, 10Editing-Team-Request: [REQUEST] Instrument image search in Visual Editor - https://phabricator.wikimedia.org/T264779 (10ppelberg) >>! In T264779#6532866, @CBogen wrote: >> [X] @CBogen and @JTannerWMF: are y'all okay with repurposing this task (T264779) for the MediaSearch API review consider... [19:34:01] 10VisualEditor, 10Growth-Team, 10StructuredDiscussions, 10Wikimedia-production-error: "TypeError: surface is null" on Flow page - https://phabricator.wikimedia.org/T134992 (10Jdlrobson) Not just Flow pages. https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.10.13/clienterror/?id=AXUi-... [19:35:39] 10WikiEditor, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: $.widget.extend is not a function at openDialog (logspam) - https://phabricator.wikimedia.org/T265387 (10Umherirrender) [19:36:22] 10VisualEditor, 10Growth-Team, 10StructuredDiscussions, 10JavaScript, 10Wikimedia-production-error: "TypeError: surface is null" on Flow page - https://phabricator.wikimedia.org/T134992 (10Umherirrender) [19:36:30] 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: Uncaught Error: ve.dm.Document.getBranchNodeFromOffset(): offset * is out of bounds - https://phabricator.wikimedia.org/T265392 (10Umherirrender) [19:36:36] 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: Uncaught Error: Invalid start or end offset in selectNodes - https://phabricator.wikimedia.org/T265391 (10Umherirrender) [19:36:44] 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: selection.newFromAdjustment is not a function - https://phabricator.wikimedia.org/T265389 (10Umherirrender) [19:49:36] 10VisualEditor, 10Parsoid: VisualEditor should not remove empty new line before section header - https://phabricator.wikimedia.org/T265320 (10matmarex) I don't see an empty paragraph now when trying to edit the old revision of the page (https://fr.wikipedia.org/w/index.php?title=Déclin_de_l%27Empire_romain_d%2... [19:55:05] 10VisualEditor: Stop using tags for bigger text in tooltips - https://phabricator.wikimedia.org/T265287 (10matmarex) There's a long discussion about this on T40487 (it started before VE was a thing). It's not clear if it's desirable to remove or replace the syntax (even if it's obsolete HTML, we might want... [20:02:31] 10VisualEditor, 10Desktop Improvements, 10Readers-Web-Backlog, 10Vector, 10Editing-team (Tracking): VE toolbar doesn't align with the "Article"/"Discussion" tabs - https://phabricator.wikimedia.org/T259272 (10Esanders) I think solution 3 with a TODO comment would at least make any follow-up lower priority. [20:17:33] 10VisualEditor, 10JavaScript, 10Mobile, 10Wikimedia-production-error: Cannot read property 'focus' of undefined on mobile at VeCeSurface.ve.ce.Surface.focus - https://phabricator.wikimedia.org/T265156 (10Umherirrender) [20:17:56] 10VisualEditor, 10Utilities-UnicodeJS, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'length' of null at Object.wordbreak.isBreak - https://phabricator.wikimedia.org/T264904 (10Umherirrender) [20:18:10] 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: Uncaught Error: Remover past end at VeDmTreeModifier.ve.dm.TreeModifier.processRetain - https://phabricator.wikimedia.org/T264956 (10Umherirrender) [20:22:00] 10VisualEditor, 10Parsoid: VisualEditor should not remove empty new line before section header - https://phabricator.wikimedia.org/T265320 (10ssastry) p:05Triage→03Low [20:30:46] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Templated link is editable as text - https://phabricator.wikimedia.org/T265209 (10ssastry) What is the problem? If you edit the link text (and save or review changes), you see `[[{{LOCALDAY}}. {{LOCALMONTHNAME}}|11th Oktober blah blah]]` which is just fine... [20:30:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Templated link is editable as text - https://phabricator.wikimedia.org/T265209 (10ssastry) 05Open→03Invalid [20:34:29] 10VisualEditor, 10Desktop Improvements, 10Readers-Web-Backlog, 10Vector, 10Editing-team (Tracking): VE toolbar doesn't align with the "Article"/"Discussion" tabs - https://phabricator.wikimedia.org/T259272 (10Jdlrobson) I'm not too familiar with how the code is laid out in VisualEditor. If I understand c... [20:46:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Templated link is editable as text - https://phabricator.wikimedia.org/T265209 (10matmarex) When editing, there is no indication that the text is coming from a template/PF (and in this particular case, no indication that it automatically updates to today's... [20:55:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Templated link is editable as text - https://phabricator.wikimedia.org/T265209 (10ssastry) Ya, caching is a different issue. As Parsoid starts generating all the same metadata that core does, that issue will get resolved. In general, even in wikitext like... [21:01:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Templated link is editable as text - https://phabricator.wikimedia.org/T265209 (10ssastry) Filed {T265411} [21:19:27] (03PS1) 10Jdlrobson: [vector modern] VisualEditor margins are tied to Vector variables. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/633834 (https://phabricator.wikimedia.org/T259331) [21:19:39] (03CR) 10Jdlrobson: "(untested)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/633834 (https://phabricator.wikimedia.org/T259331) (owner: 10Jdlrobson) [21:30:07] (03PS2) 10Jdlrobson: [vector modern] VisualEditor margins are tied to Vector variables. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/633834 (https://phabricator.wikimedia.org/T259331) [22:20:33] (03PS3) 10Jdlrobson: [vector modern] VisualEditor margins are tied to Vector variables. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/633834 (https://phabricator.wikimedia.org/T259331) [22:57:22] 10VisualEditor, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'node' of undefined - https://phabricator.wikimedia.org/T265426 (10Jdlrobson) [22:57:31] 10VisualEditor, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'node' of undefined in external-machine-translation campaing - https://phabricator.wikimedia.org/T265426 (10Jdlrobson)