[00:36:53] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 7 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10ppelberg... [01:24:31] (03CR) 10Esanders: "On Windows? I don't understand why it would do that because the local overlay is the only element with the blend applied and when not in u" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644554 (https://phabricator.wikimedia.org/T269145) (owner: 10Esanders) [01:26:03] (03CR) 10Esanders: "why would this behave differently to the DT patch?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644554 (https://phabricator.wikimedia.org/T269145) (owner: 10Esanders) [01:31:45] (03CR) 10Esanders: "if it's already deactivating we should return the pending teardown promise, it may need to be stored as a property when first generated if" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644452 (https://phabricator.wikimedia.org/T268358) (owner: 10Thiemo Kreuz (WMDE)) [02:30:26] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board): Unable to open or switch to VE within UI - https://phabricator.wikimedia.org/T269194 (10ppelberg) [02:30:31] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board): Unable to open or switch to VE within UI - https://phabricator.wikimedia.org/T269194 (10ppelberg) [07:01:53] (03CR) 10Thiemo Kreuz (WMDE): "> I think it should actually be .reject() […]" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644452 (https://phabricator.wikimedia.org/T268358) (owner: 10Thiemo Kreuz (WMDE)) [09:20:21] (03PS9) 10Awight: Migrate to ResourceLoader package files [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644242 [09:20:23] (03PS1) 10Awight: Lint with "commonsjs" rules [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644765 (https://phabricator.wikimedia.org/T260343) [09:20:25] (03PS1) 10Awight: Migrate to package files: ext.templateDataGenerator.editPage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644766 (https://phabricator.wikimedia.org/T260343) [09:20:27] (03PS1) 10Awight: Merge ext.templateDataGenerator.data into main module [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644767 [09:48:23] (03CR) 10jerkins-bot: [V: 04-1] Migrate to ResourceLoader package files [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644242 (owner: 10Awight) [09:51:50] (03CR) 10jerkins-bot: [V: 04-1] Merge ext.templateDataGenerator.data into main module [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644767 (owner: 10Awight) [10:28:13] 10VisualEditor, 10Community-Tech, 10MediaWiki-extensions-TemplateWizard, 10WMDE-Templates-FocusArea, and 4 others: Log template metadata whenever a template dialog is opened - https://phabricator.wikimedia.org/T259705 (10thiemowmde) [10:53:22] (03PS2) 10Awight: Migrate to package files: ext.templateDataGenerator.editPage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644766 (https://phabricator.wikimedia.org/T260343) [10:53:24] (03PS10) 10Awight: Migrate to package files: ext.templateDataGenerator.editTemplatePage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644242 [10:53:26] (03PS2) 10Awight: Merge ext.templateDataGenerator.data into main module [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644767 [10:53:28] (03PS1) 10Awight: Migrate to package files: ext.templateDataGenerator.data [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644778 (https://phabricator.wikimedia.org/T260343) [11:23:05] (03CR) 10jerkins-bot: [V: 04-1] Merge ext.templateDataGenerator.data into main module [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644767 (owner: 10Awight) [11:34:06] (03CR) 10Awight: Migrate to package files: ext.templateDataGenerator.editTemplatePage (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644242 (owner: 10Awight) [12:00:04] 10VisualEditor, 10VisualEditor-CopyPaste: Transform link labels of interwikis on paste - https://phabricator.wikimedia.org/T269221 (10Esanders) [12:01:16] 10VisualEditor, 10VisualEditor-CopyPaste: Transform link labels of interwikis on paste - https://phabricator.wikimedia.org/T269221 (10Esanders) [12:14:58] 10Editing-team, 10Analytics-Radar, 10MediaWiki-Page-editing, 10Platform Engineering, and 2 others: EditPage save hooks pass an entire `EditPage` object - https://phabricator.wikimedia.org/T251588 (10daniel) p:05Medium→03Low [13:20:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Lint with "commonsjs" rules [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644765 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [13:21:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Migrate to package files: ext.templateDataGenerator.editPage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644766 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [13:23:37] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Migrate to package files: ext.templateDataGenerator.data (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644778 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [13:25:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Migrate to package files: ext.templateDataGenerator.editTemplatePage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644242 (owner: 10Awight) [13:41:13] 10TemplateData, 10VisualEditor: Bug: cached TemplateData "suggested" params are incorrect in the custom edit dialog, after also editing in the source editor - https://phabricator.wikimedia.org/T269229 (10awight) [13:48:10] (03CR) 10Awight: Migrate to package files: ext.templateDataGenerator.data (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644778 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [13:51:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Migrate to package files: ext.templateDataGenerator.data (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644778 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [13:54:08] (03PS1) 10Awight: Higher-level distinction when creating new TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644804 (https://phabricator.wikimedia.org/T260343) [14:39:07] (03PS1) 10Awight: Log dialog open, distinguish between create and edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644835 (https://phabricator.wikimedia.org/T260343) [15:04:19] (03CR) 10jerkins-bot: [V: 04-1] Log dialog open, distinguish between create and edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644835 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [15:32:40] (03PS2) 10Awight: Higher-level distinction when creating new TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644804 (https://phabricator.wikimedia.org/T260343) [15:32:42] (03PS2) 10Awight: Send metrics when opening the dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644835 (https://phabricator.wikimedia.org/T260343) [15:32:44] (03PS1) 10Awight: Send metrics when applying changes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644855 (https://phabricator.wikimedia.org/T260343) [15:38:30] (03CR) 10Awight: Migrate to package files: ext.templateDataGenerator.data (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644778 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [15:46:19] (03PS1) 10Awight: Send metrics for template property interactions [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644859 (https://phabricator.wikimedia.org/T260343) [15:57:43] (03CR) 10jerkins-bot: [V: 04-1] Send metrics when opening the dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644835 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [16:00:15] (03CR) 10jerkins-bot: [V: 04-1] Send metrics when applying changes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644855 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [16:09:02] (03CR) 10jerkins-bot: [V: 04-1] Send metrics for template property interactions [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644859 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [17:18:43] (03PS2) 10Esanders: Fix incomplete return in DesktopArticleTarget.tryTeardown() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644452 (https://phabricator.wikimedia.org/T268358) (owner: 10Thiemo Kreuz (WMDE)) [17:18:55] (03CR) 10Esanders: [C: 03+1] "Amended" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644452 (https://phabricator.wikimedia.org/T268358) (owner: 10Thiemo Kreuz (WMDE)) [18:11:51] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Thanks for the update!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644452 (https://phabricator.wikimedia.org/T268358) (owner: 10Thiemo Kreuz (WMDE)) [18:27:25] 10Editing-team, 10DiscussionTools, 10OWC2020: Run A/B test to evaluate impact of Reply tool - https://phabricator.wikimedia.org/T252057 (10JTannerWMF) [18:47:20] 10VisualEditor, 10Growth-Team, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01): EventLogging validation errors for EditAttemptStep - https://phabricator.wikimedia.org/T237063 (10JTannerWMF) In a month, January, @DLynch will check the dashboard. [18:50:20] 10VisualEditor, 10VisualEditor-VisualDiffs: Image previewed at wrong aspect ratio after being swapped out - https://phabricator.wikimedia.org/T269035 (10Esanders) [18:52:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board): Mobile should inherit desktop editing preferences - https://phabricator.wikimedia.org/T261423 (10JTannerWMF) @Ryasmeen Ed left a comment for you in the spreadsheet [18:52:44] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board): Mobile should inherit desktop editing preferences - https://phabricator.wikimedia.org/T261423 (10JTannerWMF) a:05Esanders→03Ryasmeen [18:52:50] 10VisualEditor, 10VisualEditor-VisualDiffs: Image previewed at wrong aspect ratio after being swapped out - https://phabricator.wikimedia.org/T269035 (10Esanders) [18:58:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board): Mobile should inherit desktop editing preferences - https://phabricator.wikimedia.org/T261423 (10Ryasmeen) a:05Ryasmeen→03None Yes, saw that. But that doesn't change the status of failed cases. [18:59:25] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (FY2020-21 Kanban Board): Mobile should inherit desktop editing preferences - https://phabricator.wikimedia.org/T261423 (10Ryasmeen) [19:16:06] (03CR) 10Bartosz Dziewoński: "If we receive from Parsoid, and send back , won't that cause dirty diffs due to not matching in selser? Do we need t" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/641765 (https://phabricator.wikimedia.org/T266143) (owner: 10Esanders) [19:20:33] (03PS1) 10Esanders: Improve appearance of images in diffs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644898 [19:20:37] (03PS1) 10Esanders: Upstream diffElement clearfix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644899 (https://phabricator.wikimedia.org/T187687) [19:21:24] (03PS1) 10Esanders: Remove upstreamed clearfix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644901 [19:21:56] 10Cite, 10Parsoid: Some linebreak chars in 's name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation - https://phabricator.wikimedia.org/T267974 (10Sbailey) ==== to avoid further confusion, there is a unicode \u2028b between 'a' and 'b' in the second... [19:35:11] (03CR) 10Arlolra: "> Patch Set 1:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/641765 (https://phabricator.wikimedia.org/T266143) (owner: 10Esanders) [20:06:07] 10Cite, 10Parsoid: Some linebreak chars in 's name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation - https://phabricator.wikimedia.org/T267974 (10Sbailey) So analyzing the example WT, with current Parsoid/Cite code the following behavior for the $re... [20:13:51] 10Cite, 10Parsoid: Some linebreak chars in 's name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation - https://phabricator.wikimedia.org/T267974 (10Sbailey) It looks like code in Sanitizer.php (line 1302) escapeIdInternal() is insufficient to handle t... [21:09:20] (03CR) 10Jforrester: [C: 03+2] Improve appearance of images in diffs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644898 (owner: 10Esanders) [21:09:24] (03CR) 10Jforrester: [C: 03+2] Upstream diffElement clearfix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644899 (https://phabricator.wikimedia.org/T187687) (owner: 10Esanders) [21:11:18] (03CR) 10Jforrester: Always show heading context in visual diff (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644073 (https://phabricator.wikimedia.org/T268950) (owner: 10Esanders) [21:12:49] (03Merged) 10jenkins-bot: Improve appearance of images in diffs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644898 (owner: 10Esanders) [21:12:51] (03Merged) 10jenkins-bot: Upstream diffElement clearfix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644899 (https://phabricator.wikimedia.org/T187687) (owner: 10Esanders) [21:20:22] 10Cite, 10Parsoid, 10MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), 10Verified, 10VisualEditor (Current work): VE is transforming citation templates into formatted text with "cite class" tags (when copying a reference defined within template-generated reflist) - https://phabricator.wikimedia.org/T209493 (10Iz... [21:21:01] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (b615c2e21) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644925 (https://phabricator.wikimedia.org/T187687) [21:21:41] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (b615c2e21) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644925 (https://phabricator.wikimedia.org/T187687) (owner: 10Bartosz Dziewoński) [21:21:50] (03PS2) 10Bartosz Dziewoński: Remove upstreamed clearfix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644901 (owner: 10Esanders) [21:21:55] (03CR) 10Bartosz Dziewoński: [C: 03+2] Remove upstreamed clearfix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644901 (owner: 10Esanders) [21:22:05] (03CR) 10Bartosz Dziewoński: "Thanks" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644452 (https://phabricator.wikimedia.org/T268358) (owner: 10Thiemo Kreuz (WMDE)) [21:22:11] (03PS3) 10Bartosz Dziewoński: Fix incomplete return in DesktopArticleTarget.tryTeardown() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644452 (https://phabricator.wikimedia.org/T268358) (owner: 10Thiemo Kreuz (WMDE)) [21:22:16] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix incomplete return in DesktopArticleTarget.tryTeardown() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644452 (https://phabricator.wikimedia.org/T268358) (owner: 10Thiemo Kreuz (WMDE)) [21:49:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (b615c2e21) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644925 (https://phabricator.wikimedia.org/T187687) (owner: 10Bartosz Dziewoński) [21:55:26] (03Merged) 10jenkins-bot: Remove upstreamed clearfix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644901 (owner: 10Esanders) [21:55:28] (03Merged) 10jenkins-bot: Fix incomplete return in DesktopArticleTarget.tryTeardown() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/644452 (https://phabricator.wikimedia.org/T268358) (owner: 10Thiemo Kreuz (WMDE)) [23:20:30] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VE silently alters the HTML of an invalid wikitext sequence of a link with an image in the label, which dirty-diffs - https://phabricator.wikimedia.org/T150196 (10matmarex) Oh, I forgot about this completely, and just re-discovered it while fixing T267282. [23:21:24] (03PS2) 10Bartosz Dziewoński: ve.dm.MWExternalLinkAnnotation: Alienate malformed links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/639633 (https://phabricator.wikimedia.org/T64473) [23:21:57] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Patch-For-Review: VE silently alters the HTML of an invalid wikitext sequence of a link with an image in the label, which dirty-diffs - https://phabricator.wikimedia.org/T150196 (10matmarex)