[10:41:51] (03CR) 10WMDE-Fisch: [C: 03+2] Higher-level distinction when creating new TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644804 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [10:44:59] (03CR) 10WMDE-Fisch: [C: 03+2] Send metrics when opening the dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644835 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [10:52:12] (03CR) 10WMDE-Fisch: [C: 03+2] Send metrics for template property interactions [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644859 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [11:04:37] (03Merged) 10jenkins-bot: Higher-level distinction when creating new TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644804 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [11:14:09] (03Merged) 10jenkins-bot: Send metrics when opening the dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644835 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [11:15:49] (03Merged) 10jenkins-bot: Send metrics when applying changes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644855 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [11:24:29] (03Merged) 10jenkins-bot: Send metrics for template property interactions [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644859 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [11:24:32] (03Merged) 10jenkins-bot: Assign reused propertyInput value to a variable [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/645381 (owner: 10Awight) [11:24:34] (03Merged) 10jenkins-bot: Assign reused dependentField value to a variable [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/645382 (owner: 10Awight) [11:24:36] (03Merged) 10jenkins-bot: Rename "property" variable for clarity [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/645383 (owner: 10Awight) [11:47:58] 10VisualEditor, 10ContentTranslation: Visual Editor don't scroll table - https://phabricator.wikimedia.org/T268916 (10Carn) Oh, yes, thanks, @ppelberg - it is definitely a Content Translation bug, not simply a VisualEditor issue. [11:48:14] 10VisualEditor, 10ContentTranslation: Visual Editor don't scroll table - https://phabricator.wikimedia.org/T268916 (10Carn) [12:38:55] (03PS5) 10Esanders: Use CSS 'mix-blend-mode: multiply' for fake selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644554 (https://phabricator.wikimedia.org/T269145) [13:30:22] (03PS1) 10Awight: Track parameter property changes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/646669 (https://phabricator.wikimedia.org/T260343) [13:34:57] (03PS2) 10Awight: Track parameter property changes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/646669 (https://phabricator.wikimedia.org/T260343) [13:40:12] (03PS3) 10Awight: Track parameter property changes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/646669 (https://phabricator.wikimedia.org/T260343) [13:56:48] (03PS3) 10Esanders: ve.dm.MWExternalLinkAnnotation: Alienate malformed links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/639633 (https://phabricator.wikimedia.org/T64473) (owner: 10Bartosz Dziewoński) [13:57:01] (03CR) 10Esanders: [C: 03+2] ve.dm.MWExternalLinkAnnotation: Alienate malformed links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/639633 (https://phabricator.wikimedia.org/T64473) (owner: 10Bartosz Dziewoński) [14:03:25] 10VisualEditor, 10Parsoid, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), 10Patch-For-Review: VisualEditor fails to load when page contains an image inside an external link: imgWrapper is undefined - https://phabricator.wikimedia.org/T267282 (10Esanders) [14:05:00] 10VisualEditor, 10Parsoid, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), 10Patch-For-Review: VisualEditor fails to load when page contains an image inside an external link: imgWrapper is undefined - https://phabricator.wikimedia.org/T267282 (10Esanders) [14:11:00] (03CR) 10Awight: "This is really neat, from the minimal side-channel to precise change comparator." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644506 (https://phabricator.wikimedia.org/T267926) (owner: 10Thiemo Kreuz (WMDE)) [14:12:32] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Looks very good! Since this patch is just a few minutes old, I will wait with a +2 to give others a chance to have a look as well." (034 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/646669 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [14:22:36] (03Merged) 10jenkins-bot: ve.dm.MWExternalLinkAnnotation: Alienate malformed links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/639633 (https://phabricator.wikimedia.org/T64473) (owner: 10Bartosz Dziewoński) [14:24:46] (03PS4) 10Awight: Drop unnecessary top-level closures [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644247 [14:32:49] (03CR) 10Awight: [C: 03+2] "Verified locally." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644506 (https://phabricator.wikimedia.org/T267926) (owner: 10Thiemo Kreuz (WMDE)) [14:34:25] (03PS9) 10Awight: Track when (relevant) changes are made to tags [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644506 (https://phabricator.wikimedia.org/T267926) (owner: 10Thiemo Kreuz (WMDE)) [14:34:51] (03CR) 10Awight: [C: 03+2] "PS 9: manual rebase" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644506 (https://phabricator.wikimedia.org/T267926) (owner: 10Thiemo Kreuz (WMDE)) [14:50:12] (03CR) 10Awight: Track parameter property changes (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/646669 (https://phabricator.wikimedia.org/T260343) (owner: 10Awight) [14:50:52] (03PS1) 10Esanders: Add converter performance tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646699 [14:50:54] (03PS1) 10Esanders: ve.dm.Document: Avoid multiple getProp calls in getFullData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646700 [14:51:16] 10TemplateData, 10VisualEditor, 10MediaWiki-Parser, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), and 2 others: TemplateData extension sets non-json-serializable page properties - https://phabricator.wikimedia.org/T266200 (10Pchelolo) [15:05:01] (03PS1) 10Esanders: Converter: Cache isForPreview [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646725 [15:06:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Drop unnecessary top-level closures [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644247 (owner: 10Awight) [15:34:32] (03Merged) 10jenkins-bot: Drop unnecessary top-level closures [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644247 (owner: 10Awight) [15:56:32] (03CR) 10Jforrester: [C: 03+2] Add converter performance tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646699 (owner: 10Esanders) [15:57:50] (03CR) 10Jforrester: ve.dm.Document: Avoid multiple getProp calls in getFullData (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646700 (owner: 10Esanders) [16:01:03] (03Merged) 10jenkins-bot: Add converter performance tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646699 (owner: 10Esanders) [16:22:55] 10Editing-team, 10MediaWiki-extensions-Graph, 10Platform Engineering, 10Product-Infrastructure-Team-Backlog, and 3 others: Uncaught TypeError: Cannot read property 'items' of null / TypeError: null is not an object (evaluating 'view.model().scene().items') - https://phabricator.wikimedia.org/T269308 (10sdk... [16:35:21] (03CR) 10Thiemo Kreuz (WMDE): "Abandon for now?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/644767 (owner: 10Awight) [18:55:46] (03PS1) 10Esanders: Add 'close' flags to closing actions in dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646800 [18:55:49] (03PS1) 10Esanders: Add 'close' flags to closing actions in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/646801 [19:05:11] 10VisualEditor, 10Parsoid: VisualEditor gives 401 when behind basic auth - https://phabricator.wikimedia.org/T269508 (10matmarex) There is a similar feature for forwarding cookies, to be used when MediaWiki's authentication is required view pages: 10VisualEditor, 10Parsoid: VisualEditor gives 401 when behind basic auth - https://phabricator.wikimedia.org/T269508 (10matmarex) Alternatively, maybe it's already possible to do this if you hard-code the HTTP username and password into the URL configured in `$wgVirtualRestConfig['modules']['parsoid']['url']`? [19:10:10] (03CR) 10Jforrester: [C: 03+2] Add 'close' flags to closing actions in dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646800 (owner: 10Esanders) [19:10:17] (03CR) 10Jforrester: [C: 03+2] Add 'close' flags to closing actions in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/646801 (owner: 10Esanders) [19:13:27] (03Merged) 10jenkins-bot: Add 'close' flags to closing actions in dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646800 (owner: 10Esanders) [19:19:19] (03PS1) 10Jforrester: Update VE core submodule to master (af6ca9404) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/646809 [19:36:34] (03CR) 10Esanders: ve.dm.Document: Avoid multiple getProp calls in getFullData (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646700 (owner: 10Esanders) [19:37:17] (03CR) 10Jforrester: [C: 03+1] "OK. Will let the team merge, as they're the ones as have to fix it if it breaks the world. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646700 (owner: 10Esanders) [19:37:46] (03Merged) 10jenkins-bot: Add 'close' flags to closing actions in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/646801 (owner: 10Esanders) [19:38:18] (03PS2) 10Esanders: Compare meta items by hash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/633203 [19:38:22] (03PS2) 10Esanders: stripMetaLoadInfo: Call earlier, and use ve.copy instead of ve.cloneObject [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/633204 [19:38:24] (03PS9) 10Esanders: Deep-freeze linear data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 (https://phabricator.wikimedia.org/T119236) [19:42:55] (03CR) 10Jforrester: [C: 03+2] Converter: Cache isForPreview [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/646725 (owner: 10Esanders) [20:54:13] 10VisualEditor, 10Parsoid, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08): VisualEditor fails to load when page contains an image inside an external link: imgWrapper is undefined - https://phabricator.wikimedia.org/T267282 (10matmarex) [20:54:19] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Image as part of the anchor of a link is stripped on round-trip - https://phabricator.wikimedia.org/T64473 (10matmarex) [20:54:21] 10VisualEditor, 10Parsoid, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08): VisualEditor fails to load when page contains an image inside an external link: imgWrapper is undefined - https://phabricator.wikimedia.org/T267282 (10matmarex) [20:54:23] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VE silently alters the HTML of an invalid wikitext sequence of a link with an image in the label, which dirty-diffs - https://phabricator.wikimedia.org/T150196 (10matmarex) [20:55:59] 10VisualEditor, 10Editing QA, 10Parsoid, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08): VisualEditor fails to load when page contains an image inside an external link: imgWrapper is undefined - https://phabricator.wikimedia.org/T267282 (10matmarex) [21:04:30] (03CR) 10Bartosz Dziewoński: [C: 03+1] "Thanks for tweaking" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/639633 (https://phabricator.wikimedia.org/T64473) (owner: 10Bartosz Dziewoński) [21:18:02] 10VisualEditor, 10Parsoid: VisualEditor gives 401 when behind basic auth - https://phabricator.wikimedia.org/T269508 (10cscott) >>! In T269508#6674241, @matmarex wrote: > Alternatively, maybe it's already possible to do this if you hard-code the HTTP username and password into the URL configured in `$wgVirtual... [21:26:41] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (af6ca9404) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/646809 (owner: 10Jforrester) [21:48:41] (03Merged) 10jenkins-bot: Update VE core submodule to master (af6ca9404) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/646809 (owner: 10Jforrester)