[00:17:52] (03PS15) 10Esanders: Deep-freeze linear data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 (https://phabricator.wikimedia.org/T119236) [00:17:54] (03PS2) 10Esanders: WIP: Deep-freeze linear data added by transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/656995 (owner: 10Divec) [00:25:55] (03PS11) 10Esanders: Daff table diffing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/455321 (https://phabricator.wikimedia.org/T158445) (owner: 10Tchanders) [05:41:10] (03CR) 10Gergő Tisza: [C: 04-1] "parseFileSyntax() needs to handle the new parameter. Looks good otherwise." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/635053 (https://phabricator.wikimedia.org/T260006) (owner: 10Ammarpad) [09:48:48] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Community-Tech, 10MediaWiki-extensions-TemplateWizard, and 3 others: Fuzzier search - search for keywords out of order in template search (Template findability) - https://phabricator.wikimedia.org/T271802 (10Lena_WMDE) [09:53:10] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Community-Tech, 10MediaWiki-extensions-TemplateWizard, and 2 others: Investigation: improved template search - https://phabricator.wikimedia.org/T272457 (10Lena_WMDE) [11:16:10] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Community-Tech, 10MediaWiki-extensions-TemplateWizard, and 2 others: Investigation: improved template search - https://phabricator.wikimedia.org/T272457 (10Tobi_WMDE_SW) [12:12:09] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References: Allow copy-and-paste to reuse an existing citation (instead of always automatically renaming the reference) - https://phabricator.wikimedia.org/T272251 (10Esanders) Silently keeping the same reference could lead to more errors, ev... [12:14:29] 10VisualEditor, 10WMDE-Templates-FocusArea: VisualEditor template dialog should make good use of screen size - https://phabricator.wikimedia.org/T272245 (10Esanders) [12:16:53] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Unable to place cursor or type after reference at end of line - https://phabricator.wikimedia.org/T272207 (10Esanders) [12:30:45] (03PS10) 10Ammarpad: Allow specifying alt-text in File dialog [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/635053 (https://phabricator.wikimedia.org/T260006) [12:52:59] (03CR) 10jerkins-bot: [V: 04-1] Allow specifying alt-text in File dialog [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/635053 (https://phabricator.wikimedia.org/T260006) (owner: 10Ammarpad) [12:58:49] (03PS11) 10Ammarpad: Allow specifying alt-text in File dialog [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/635053 (https://phabricator.wikimedia.org/T260006) [13:38:21] (03CR) 10Ammarpad: "> Patch Set 9: Code-Review-1" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/635053 (https://phabricator.wikimedia.org/T260006) (owner: 10Ammarpad) [15:39:09] 10VisualEditor, 10Analytics-Data-Quality, 10WMDE-TechWish: Investigate missing dialog close events - https://phabricator.wikimedia.org/T272020 (10awight) [16:02:49] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board): Unable to open or switch to VE within UI - https://phabricator.wikimedia.org/T269194 (10Esanders) I can't reproduce this. [16:29:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10ContentTranslation, 10Language-Team, and 2 others: Suppress EditAttemptStep events from visual editor reusers like Content Translation - https://phabricator.wikimedia.org/T270636 (10MNeisler) a:05MNeisler→03None > In the meantime, @MNeisler can you please re... [16:51:55] 10Editing-team, 10DiscussionTools, 10OWC2020: Make New Discussion Tool available as opt-out feature at partner wikis - https://phabricator.wikimedia.org/T271964 (10ppelberg) [16:52:12] 10Editing-team, 10DiscussionTools, 10Editing Design, 10OWC2020: Redesign empty state for talk pages that have not been created - https://phabricator.wikimedia.org/T252902 (10ppelberg) [17:04:54] Hi! [17:05:06] Question and/or suggestion [17:05:26] We've developed a Form extension for MW that utilizes VE and the TinyMCE extensions. WSForm (extension name) has an autosave option. Now with TinyMCE I can just set an on change event in case something has changed inside the editor. [17:05:26] With VE I cannot find such functionality leaving me running a DOM observer. [17:05:27] So my question... am I missing something ? and if not, my suggestion : Could you create an on change event listener for VE ? [17:23:48] 10TemplateData, 10VisualEditor, 10Abstract Wikipedia (Phase γ): WikiLambda initial installation fails when TemplateData is installed - https://phabricator.wikimedia.org/T272231 (10DVrandecic) [17:24:40] 10TemplateData, 10VisualEditor, 10Abstract Wikipedia (Phase γ): WikiLambda initial installation fails when TemplateData is installed - https://phabricator.wikimedia.org/T272231 (10DVrandecic) p:05Triage→03Medium [17:28:31] 10VisualEditor, 10MediaWiki-Parser, 10Parsoid, 10Parsoid-Rendering, 10Wikipedia-Android-App-Backlog: Strip state: {{Row numbers}} completely fails on the Android app / VisualEditor - https://phabricator.wikimedia.org/T203293 (10Arlolra) [18:05:56] 10VisualEditor: Visual editor gives erroneous warning about missing edit summary when switching editing modes - https://phabricator.wikimedia.org/T186531 (10Tacsipacsi) [18:43:47] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review: Sidebar items are shown in wrong order in visual diffs - https://phabricator.wikimedia.org/T272315 (10matmarex) > Also, the localisation messages for ⧼visualeditor-diff-moved-down⧽ are missing. Fixed in https://gerrit.wikimedia.org/r/c/mediawik... [18:47:44] (03CR) 10Bartosz Dziewoński: [C: 03+2] Create a separate descriptionItemsStack for each reflist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/657212 (https://phabricator.wikimedia.org/T272315) (owner: 10Esanders) [18:48:39] (03PS1) 10Esanders: Factor out disableVETabsForAnons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657389 (https://phabricator.wikimedia.org/T264950) [18:52:08] (03Merged) 10jenkins-bot: Create a separate descriptionItemsStack for each reflist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/657212 (https://phabricator.wikimedia.org/T272315) (owner: 10Esanders) [18:55:02] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review: Sidebar items are shown in wrong order in visual diffs - https://phabricator.wikimedia.org/T272315 (10matmarex) With the patch applied: {F34009742} [18:56:36] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (36e21385b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657393 (https://phabricator.wikimedia.org/T272314) [18:56:48] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (36e21385b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657393 (https://phabricator.wikimedia.org/T272314) (owner: 10Bartosz Dziewoński) [18:57:05] (03CR) 10Jforrester: "This is going to need the Cite patch to be force-merged for it to land." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657393 (https://phabricator.wikimedia.org/T272314) (owner: 10Bartosz Dziewoński) [18:57:37] (03PS2) 10Jforrester: Update VE core submodule to master (36e21385b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657393 (https://phabricator.wikimedia.org/T272314) (owner: 10Bartosz Dziewoński) [19:18:09] 10VisualEditor, 10Wikimedia-Site-requests, 10Editing-team (FY2020-21 Kanban Board), 10User-Kizule: Enable VisualEditor by default for all users of the ku.wikipedia - https://phabricator.wikimedia.org/T270841 (10Kizule) This is done. 1. VisualEditor disappeared from the "beta features" {F34009756} 2. "Edit... [19:27:59] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (FY2020-21 Kanban Board): Mobile should inherit desktop editing preferences - https://phabricator.wikimedia.org/T261423 (10Esanders) @Ryasmeen For all the failure cases (10/24/25) you state that it uses the previously opened editor for that dev... [19:33:56] (03PS2) 10Esanders: Factor out disableVETabsForAnons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657389 (https://phabricator.wikimedia.org/T264950) [19:41:50] (03PS3) 10Esanders: MWSaveDialog: Use MessageWidget (inline, warning) to show save dialog warnings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/656205 [19:48:39] 10Editing-team, 10WikiEditor, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: $button.trigger is not a function - https://phabricator.wikimedia.org/T272171 (10thcipriani) [19:52:05] (03PS1) 10Esanders: MWWikitextStringTransferHandler: Factor out Parsoid->DOM conversion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657405 [20:01:45] (03CR) 10jerkins-bot: [V: 04-1] Factor out disableVETabsForAnons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657389 (https://phabricator.wikimedia.org/T264950) (owner: 10Esanders) [20:04:06] (03CR) 10jerkins-bot: [V: 04-1] MWSaveDialog: Use MessageWidget (inline, warning) to show save dialog warnings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/656205 (owner: 10Esanders) [20:13:50] (03PS5) 10Esanders: CitoidAction: Pass inStaging param [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/634977 [20:15:46] (03CR) 10jerkins-bot: [V: 04-1] MWWikitextStringTransferHandler: Factor out Parsoid->DOM conversion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657405 (owner: 10Esanders) [20:17:39] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657389 (https://phabricator.wikimedia.org/T264950) (owner: 10Esanders) [20:19:31] (03CR) 10jerkins-bot: [V: 04-1] CitoidAction: Pass inStaging param [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/634977 (owner: 10Esanders) [20:26:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (36e21385b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657393 (https://phabricator.wikimedia.org/T272314) (owner: 10Bartosz Dziewoński) [20:32:21] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: "References" section always has a grey background for some reason in visual diffs - https://phabricator.wikimedia.org/T272314 (10matmarex) [20:32:29] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Sidebar items are shown in wrong order in visual diffs - https://phabricator.wikimedia.org/T272315 (10matmarex) [20:32:54] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board): Sidebar items are shown in wrong order in visual diffs - https://phabricator.wikimedia.org/T272315 (10matmarex) [20:32:57] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board): "References" section always has a grey background for some reason in visual diffs - https://phabricator.wikimedia.org/T272314 (10matmarex) [20:38:00] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/656205 (owner: 10Esanders) [20:38:06] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657405 (owner: 10Esanders) [20:38:46] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/634977 (owner: 10Esanders) [20:59:12] (03CR) 10Gergő Tisza: [C: 04-1] Allow specifying alt-text in File dialog (033 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/635053 (https://phabricator.wikimedia.org/T260006) (owner: 10Ammarpad) [20:59:43] (03CR) 10Bartosz Dziewoński: [C: 03+2] MWSaveDialog: Use MessageWidget (inline, warning) to show save dialog warnings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/656205 (owner: 10Esanders) [21:25:01] (03CR) 10Bartosz Dziewoński: [C: 03+2] CitoidAction: Pass inStaging param [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/634977 (owner: 10Esanders) [21:25:05] (03CR) 10Bartosz Dziewoński: [C: 03+2] MWWikitextStringTransferHandler: Factor out Parsoid->DOM conversion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657405 (owner: 10Esanders) [21:29:03] (03Merged) 10jenkins-bot: MWSaveDialog: Use MessageWidget (inline, warning) to show save dialog warnings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/656205 (owner: 10Esanders) [21:34:46] My question just got lost in this spam of wikibugs :p [21:46:15] (03Merged) 10jenkins-bot: CitoidAction: Pass inStaging param [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/634977 (owner: 10Esanders) [22:11:34] (03Merged) 10jenkins-bot: MWWikitextStringTransferHandler: Factor out Parsoid->DOM conversion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657405 (owner: 10Esanders) [22:48:40] 10VisualEditor, 10Patch-For-Review: Use CSS 'mix-blend-mode: multiply' for fake selections - https://phabricator.wikimedia.org/T269145 (10matmarex) I think the changes to text rendering I mentioned earlier make this a change for the worse (at least on Windows, using mix-blend-mode disables subpixel antialiasin... [22:48:51] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Use CSS 'mix-blend-mode: multiply' for fake selections - https://phabricator.wikimedia.org/T269145 (10matmarex) [22:49:32] (03CR) 10Bartosz Dziewoński: [C: 04-1] "In my opinion the effect of this on text rendering is too awful to accept. I posted a longer comment about it at T269145#6763786." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/644554 (https://phabricator.wikimedia.org/T269145) (owner: 10Esanders) [22:51:01] Charly-WikibaseS: yeah, it's annoying sometimes [22:51:57] Charly-WikibaseS: you can probably hook to whatever activates the undo/redo buttons on the toolbar. let me see if there's a nice way to do it [22:54:43] Now why did I not think of that :p [22:54:59] Probably cause it almost midnight :-) [22:55:10] it's* [22:55:55] Charly-WikibaseS: ve.init.target.getSurface().getModel().on( 'history', function () { console.log( "A change was made on the editing surface!" ); } ); [22:56:16] hopefully you can go from here. sorry, this isn't really documented (except in the source code comments) [22:56:47] if you haven't seen it before, https://www.mediawiki.org/wiki/VisualEditor/Gadgets is the closest thing we have to a developer documentation [22:57:37] the event is technically documented here: https://doc.wikimedia.org/VisualEditor/master/js/#!/api/ve.dm.Surface-event-history (generated from the doc comments in source code) [22:57:45] (not that anyone would ever find that) [22:59:06] Well it does look very promosing. Thanks for that answer! No I did not look at that link as yet (I think). Documenting it now and having a go at this tomorrow. And indeed.. I would probably not have found that last link :-) But thanks! If this works the autosave would be very solid and no need for a dom observer as they are a pain in the :-) [22:59:14] actually, maybe 'documentUpdate' would be the better event to use. but either should be close enough. [22:59:23] :) good luck [22:59:52] Thank you! [23:00:11] Argh... midnight already :-) [23:09:08] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Use CSS 'mix-blend-mode: multiply' for fake selections - https://phabricator.wikimedia.org/T269145 (10matmarex) (For context, the idea came out of {b92ae47e005ba42affd7d6c60d493ff9ecc00c71}, where we used mix-blend-mode to display t... [23:09:17] MatmaRex: do you have any clue that might help this person: https://www.mediawiki.org/wiki/Topic:W1wdo0arlgqwqcku [23:10:41] hexmode: i don't think that's possible (unless someone writes the code to do it), the upload dialog has just the one option [23:11:01] at best you can configure the messages and the output using https://www.mediawiki.org/wiki/Manual:$wgUploadDialog , but there's no way to have multiple options [23:11:09] ok, I thought there might be something.... [23:11:11] ty [23:11:17] I'll pass it along [23:16:08] (03PS1) 10Bartosz Dziewoński: Fix typo in doc comment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/657447 [23:17:54] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.28; 2021-01-26): Supported citation needed templates which encapsulate article text - https://phabricator.wikimedia.org/T265907 (10matmarex) https://www.mediawiki.org/wiki/VisualEditor/Citation_tool#"Citation_needed"_tool ne...