[01:45:28] 10Editing-team, 10Growth-Structured-Tasks: Pre-deployment QA: "Add a link" - https://phabricator.wikimedia.org/T278600 (10Etonkovidova) This page [[ https://www.mediawiki.org/wiki/User:Etonkovidova/GrowthExperiments#Add_link_%28AI%29_structured_task | GrowthExperiments#Add_link_(AI)_structured_task ]] has some... [04:21:08] 10VisualEditor: Make the special character toolbar's "Often used" section dynamic - https://phabricator.wikimedia.org/T278915 (10ppelberg) [04:24:13] 10VisualEditor, 10VisualEditor-EditingTools, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), and 3 others: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429 (10ppelberg) 05Open→03Resolved >>! In... [04:25:51] 10Editing-team, 10DiscussionTools, 10OWC2020: Make New Discussion Tool available as opt-out feature at all wikis - https://phabricator.wikimedia.org/T275256 (10ppelberg) [04:25:55] 10Editing-team, 10DiscussionTools, 10OWC2020: Make Reply Tool available as opt-out preference at all Wikipedias - https://phabricator.wikimedia.org/T262331 (10ppelberg) [04:38:15] 10Editing-team, 10DiscussionTools, 10Patch-For-Review: Add edit notice element to New Discussion Tool - https://phabricator.wikimedia.org/T269033 (10ppelberg) [04:39:02] 10Editing-team, 10DiscussionTools, 10OWC2020: Make New Discussion Tool available as opt-out feature at all wikis - https://phabricator.wikimedia.org/T275256 (10ppelberg) [08:22:50] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 4 others: Add combobox to VE to display suggested values - https://phabricator.wikimedia.org/T271898 (10Lena_WMDE) [08:23:24] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 4 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10Lena_WMDE) [08:27:19] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 4 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10awight) [08:30:45] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 4 others: Add combobox to VE to display suggested values - https://phabricator.wikimedia.org/T271898 (10Andrew-WMDE) [09:29:35] (03CR) 10Awight: "Code looks good, I'll make some minor changes. Do others agree with my reasoning about the feature flag? I believe we don't need the fla" (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [09:37:09] (03CR) 10Awight: Add a combo box for suggested values in the transclusion dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [09:40:45] (03PS4) 10Awight: Add a combo box for suggested values in the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [09:41:00] (03PS5) 10Awight: Add a combo box for suggested values in the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [09:42:07] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10User-Josve05a, 10User-notice: Internationalise citoid dates - https://phabricator.wikimedia.org/T132308 (10Mvolz) >>! In T132308#6958016, @Whatamidoing-WMF wrote: >>>! In T132308#6856784, @Jc3s5h wrote: >> >> editors will inevitably write 2011-12 when they... [09:45:58] (03CR) 10Awight: Add a combo box for suggested values in the transclusion dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [10:03:58] (03CR) 10jerkins-bot: [V: 04-1] Add a combo box for suggested values in the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [10:05:02] (03CR) 10Awight: "I see why the raw fallback checkbox appears, and we can suppress by setting a boolean (coming in the next patchset). It's not appropriate" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [10:05:28] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10User-Josve05a, 10User-notice: Internationalise citoid dates - https://phabricator.wikimedia.org/T132308 (10Johan) @Mvolz As a general rule we //prefer// to announce things in beforehand, but it's not a blocker for minor changes that won't affect editing muc... [10:05:58] (03PS6) 10Awight: Add a combo box for suggested values in the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [10:20:01] (03PS7) 10Awight: Add a combo box for suggested values in the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [10:22:23] (03CR) 10Awight: Add a combo box for suggested values in the transclusion dialog (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [10:27:14] (03PS8) 10Awight: Add a combo box for suggested values in the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [10:27:23] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10WMDE-Fisch) a:03WMDE-Fisch [10:27:52] (03CR) 10Awight: [C: 03+1] "Please merge if you agree with the changes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [10:31:50] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10awight) Just some notes about what's missing from the patch here: * Needs to... [10:53:17] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10User-Josve05a, 10User-notice: Internationalise citoid dates - https://phabricator.wikimedia.org/T132308 (10Mvolz) >>! In T132308#6959990, @Johan wrote: > @Mvolz As a general rule we //prefer// to announce things in beforehand, but it's not a blocker for min... [13:18:24] 10Editing-team, 10CodeEditor, 10Patch-For-Review: Search and replace button does not work on first click after closing the dialog with Esc or close button. - https://phabricator.wikimedia.org/T102486 (10Nardog) [14:26:32] 10VisualEditor: Visual Editor on Indonesian Wikipedia doesnt work - https://phabricator.wikimedia.org/T278963 (10Rtnf) [14:30:29] https://phabricator.wikimedia.org/T278963 [14:34:46] 10VisualEditor: Visual Editor on Indonesian Wikipedia doesnt work - https://phabricator.wikimedia.org/T278963 (10Rtnf) [14:35:55] rtnf: when did it last work? [14:39:27] The only thing I can see that's VE in the last week doesn't look big but there's been the ES6 changes [14:47:55] My last edit on VisualEditor is on March 25, 2021 14.56 (GMT+7) [14:49:44] 10VisualEditor, 10Regression: Visual Editor on Indonesian Wikipedia doesnt work - https://phabricator.wikimedia.org/T278963 (10RhinosF1) [14:50:29] 10VisualEditor, 10Regression: Visual Editor on Indonesian Wikipedia doesnt work - https://phabricator.wikimedia.org/T278963 (10RhinosF1) Per IRC, seems this started in the last week. Only related change seems to be the Minify work from reading changelogs. [14:50:45] rtnf: cool! [14:55:59] So... the culprit is Eslint 0.19.0? [14:56:55] Probably the javascript minifier which changed from ES5 -> ES6 [14:57:21] That's my extremely uneducated guess because it's javascript and the only js related change I can see [14:58:34] RoanKattouw: that was your task so maybe you have thoughts? ^ [15:37:52] 10Editing-team, 10DiscussionTools: Create way for individual pages to opt-in to using the New Discussion Tool for preloads - https://phabricator.wikimedia.org/T270797 (10iamjessklein) Different topic, but wanted to bring @Esanders brain to this space. Would it be possible to treat this issue in a similar way... [16:00:50] 10VisualEditor: Turn VE into a Wikipedia Editor - https://phabricator.wikimedia.org/T265163 (10ppelberg) [16:03:14] 10VisualEditor: Turn VE into a Wikipedia Editor - https://phabricator.wikimedia.org/T265163 (10ppelberg) [16:28:57] 10Editing-team, 10Data-Persistence (Consultation), 10DiscussionTools, 10MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), and 3 others: Add reply links to the parser cache - https://phabricator.wikimedia.org/T267404 (10ppelberg) [16:36:12] (03CR) 10DLynch: [C: 03+1] "This works, but it feels like a quick patch over an issue that'll wind up hurting us again in the future. As-is the next time we write a T" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/675582 (https://phabricator.wikimedia.org/T278399) (owner: 10Bartosz Dziewoński) [16:44:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10ContentTranslation, 10Language-Team, and 2 others: Suppress EditAttemptStep events from visual editor reusers like Content Translation - https://phabricator.wikimedia.org/T270636 (10DLynch) a:03DLynch [17:35:32] 10VisualEditor, 10Regression: Visual Editor on Indonesian Wikipedia doesnt work - https://phabricator.wikimedia.org/T278963 (10matmarex) The source code doesn't have the syntax error: https://phabricator.wikimedia.org/diffusion/ESHG/browse/master/modules/ve-syntaxhighlight/ve.ui.MWSyntaxHighlightDialogTool.js$... [17:38:04] MatmaRex: opcache maybe too? [17:38:11] Or is that only php [17:38:53] i don't think opcache is involved here, but there's all sorts of other caches [17:39:25] Cache is amazingly fun at times [17:41:43] 10VisualEditor, 10Regression: Visual Editor on Indonesian Wikipedia doesnt work - https://phabricator.wikimedia.org/T278963 (10matmarex) By the way, there's just a 1 bit difference between `i` and `)` (`01101001` vs `00101001`), so it sure looks like a random bit flip. But it could be good to see at which poin... [18:11:40] 10VisualEditor, 10OOUI, 10Wikimedia Design Style Guide: Icon makes narrow messages longer and more difficult to read - https://phabricator.wikimedia.org/T278989 (10Volker_E) [18:15:21] 10VisualEditor, 10DiscussionTools, 10Growth-Team, 10GrowthExperiments-Help panel, 10OWC2020 (OWC2020 Replying 1.0): Help panel: "Get help with editing" button hides other components of the visual editor - https://phabricator.wikimedia.org/T219966 (10MMiller_WMF) @Etonkovidova -- could you please look int... [18:24:38] 10VisualEditor, 10Editing-team (Tracking), 10JavaScript, 10Release-Engineering-Team (Logspam), 10Wikimedia-production-error: Uncaught Error: Cannot add a child to text node in checkCanInsertNodeType - https://phabricator.wikimedia.org/T261785 (10egardner) This error is still occurring at a similar rate a... [18:29:01] (03CR) 10Bartosz Dziewoński: "Right." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/675582 (https://phabricator.wikimedia.org/T278399) (owner: 10Bartosz Dziewoński) [18:43:12] 10VisualEditor, 10Desktop Improvements, 10MediaWiki-extensions-LiquidThreads, 10QuickSurveys, and 4 others: [1.37] The class mw-ajax-loader will no longer be styled by Vector - https://phabricator.wikimedia.org/T278894 (10matmarex) You should use `$.createSpinner()` from the 'jquery.spinner' module as a re... [18:44:38] 10VisualEditor, 10OOUI, 10Wikimedia Design Style Guide: Icon makes narrow messages longer and more difficult to read - https://phabricator.wikimedia.org/T278989 (10Sunpriat2) [18:46:24] 10VisualEditor, 10OOUI, 10Wikimedia Design Style Guide: Icon makes narrow messages longer and more difficult to read - https://phabricator.wikimedia.org/T278989 (10Sunpriat2) [18:49:05] (03PS1) 10Bartosz Dziewoński: Replace use of deprecated CSS class 'mw-ajax-loader' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/676129 (https://phabricator.wikimedia.org/T278894) [18:53:23] 10VisualEditor: Make the special character toolbar's "Often used" section dynamic - https://phabricator.wikimedia.org/T278915 (10matmarex) [18:53:27] 10VisualEditor, 10WikiEditor, 10Epic: Remember the "often used" special characters on a per user basis - https://phabricator.wikimedia.org/T110722 (10matmarex) [19:06:41] 10VisualEditor, 10Desktop Improvements, 10MediaWiki-extensions-LiquidThreads, 10QuickSurveys, and 5 others: [1.37] The class mw-ajax-loader will no longer be styled by Vector - https://phabricator.wikimedia.org/T278894 (10Jdlrobson) [19:07:14] 10VisualEditor, 10Desktop Improvements, 10MediaWiki-extensions-LiquidThreads, 10QuickSurveys, and 6 others: [1.37] The class mw-ajax-loader will no longer be styled by Vector - https://phabricator.wikimedia.org/T278894 (10Jdlrobson) [19:28:11] 10VisualEditor: Increase contrast of active state buttons in the special character dialog - https://phabricator.wikimedia.org/T276258 (10ppelberg) [19:30:16] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0): Define approach for expanding DiscussionTools `visual` mode toolbar - https://phabricator.wikimedia.org/T249074 (10ppelberg) [19:32:14] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 2.0): Define approach for expanding DiscussionTools `visual` mode toolbar - https://phabricator.wikimedia.org/T249074 (10ppelberg) [20:16:46] 10VisualEditor, 10MediaWiki-extensions-LiquidThreads, 10QuickSurveys, 10Readers-Web-Backlog, and 6 others: [1.37] The class mw-ajax-loader will no longer be styled by Vector - https://phabricator.wikimedia.org/T278894 (10Jdlrobson) [20:23:05] 10VisualEditor, 10Parsoid (Tracking): added around pipes in template - https://phabricator.wikimedia.org/T267505 (10Arlolra) [20:34:17] 10VisualEditor: Turn VE into a Wikipedia Editor - https://phabricator.wikimedia.org/T265163 (10ppelberg) [20:36:17] 10VisualEditor: Turn VE into a Wikipedia Editor - https://phabricator.wikimedia.org/T265163 (10ppelberg) **Task description update** - ADDED links to two related tools to the task description [i] that @Pginer-WMF shared. --- i. https://languagetool.org/ and https://hemingwayapp.com/ [20:39:53] 10VisualEditor: Turn VE into a Wikipedia Editor - https://phabricator.wikimedia.org/T265163 (10ppelberg) [21:41:55] (03CR) 10Bartosz Dziewoński: [C: 03+2] "I don't want this to be stuck forever, so let's just try it. @Divec IIRC you had no objections in the meeting on 2021-03-02 when this was " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/665132 (https://phabricator.wikimedia.org/T53045) (owner: 10Esanders) [21:42:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701 (10matmarex) [21:46:55] 10Editing-team, 10CodeEditor, 10Patch-For-Review: Search and replace button does not work on first click after closing the dialog with Esc or close button. - https://phabricator.wikimedia.org/T102486 (10Nardog) a:05Fomafix→03Nardog Could someone please review [[https://gerrit.wikimedia.org/r/674164|the p... [21:50:03] (03PS4) 10Bartosz Dziewoński: Detect NBSPs being inserted deliberately by IMEs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/665132 (https://phabricator.wikimedia.org/T53045) (owner: 10Esanders) [21:50:10] (03CR) 10Bartosz Dziewoński: [C: 03+2] Detect NBSPs being inserted deliberately by IMEs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/665132 (https://phabricator.wikimedia.org/T53045) (owner: 10Esanders) [21:52:30] (03CR) 10Bartosz Dziewoński: "This is good to go." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255937 (https://phabricator.wikimedia.org/T53045) (owner: 10Bartosz Dziewoński) [21:55:47] (03Merged) 10jenkins-bot: Detect NBSPs being inserted deliberately by IMEs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/665132 (https://phabricator.wikimedia.org/T53045) (owner: 10Esanders) [21:58:50] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (5d0701ea3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/676162 (https://phabricator.wikimedia.org/T53045) [22:00:04] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (5d0701ea3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/676162 (https://phabricator.wikimedia.org/T53045) (owner: 10Bartosz Dziewoński) [22:23:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (5d0701ea3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/676162 (https://phabricator.wikimedia.org/T53045) (owner: 10Bartosz Dziewoński) [22:29:16] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid (Tracking): VisualEditor should not remove empty new line before section header - https://phabricator.wikimedia.org/T265320 (10Arlolra) It looks like, when switching from section editing in the NWE to VE, you end up with an extra linebrea...