[00:10:29] 10Editing-team, 10AbuseFilter, 10Growth-Team, 10Notifications, and 5 others: Mobile user communication issues - https://phabricator.wikimedia.org/T278838 (10GeneralNotability) >>! In T278838#6972791, @Valereee wrote: > I tried to fix a typo and a notice came up that said I had been blocked from editing. Th... [00:23:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid, and 4 others: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701 (10Pols12) OK, this doesn’t matter. However, with 2017 Wikitext Editor, inserting a NBSP make... [01:12:27] 10Editing-team, 10DiscussionTools, 10OWC2020: Deploy the Reply Tool as an opt-out preference at en.wiki - https://phabricator.wikimedia.org/T279397 (10ppelberg) [01:12:37] 10Editing-team, 10DiscussionTools: Deploy the Reply Tool as an opt-out preference at en.wiki - https://phabricator.wikimedia.org/T279397 (10ppelberg) [01:39:50] 10Editing-team, 10AbuseFilter, 10Growth-Team, 10Notifications, and 5 others: Mobile user communication issues - https://phabricator.wikimedia.org/T278838 (10Proc) >>! In T278838#6974614, @GeneralNotability wrote: >>>! In T278838#6972791, @Valereee wrote: >> I tried to fix a typo and a notice came up that s... [01:42:34] 10Editing-team, 10AbuseFilter, 10Growth-Team, 10Notifications, and 5 others: Mobile user communication issues - https://phabricator.wikimedia.org/T278838 (10Proc) [04:43:24] 10VisualEditor, 10Editing-team (Third-party): VisualEditor throws "Error contacting the Parsoid/RESTBase server (HTTP 500)" on fresh installation - https://phabricator.wikimedia.org/T270377 (10TiuriElensar) To narrow the error down: please can everyone confirm, that this error is isolated for EDITING existing... [07:08:56] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10WMDE-Fisch) a:05WMDE-Fisch→03None [09:18:27] (03CR) 10Awight: [C: 03+1] "It's safe to merge this patch ahead of the TemplateData dependency I14012c79b3. There will be no impact on VisualEditor until the `sugges" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/670856 (https://phabricator.wikimedia.org/T271898) (owner: 10Andrew-WMDE) [09:36:20] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10awight) [09:39:57] (03PS10) 10Awight: Add suggested values parameter [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) [09:40:33] (03CR) 10Awight: "PS 10: tweak specification" (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) (owner: 10Awight) [09:46:42] (03CR) 10Awight: [C: 03+2] "Merging because all functionality has been at least validated by manual testing, and we're behind a feature flag which is disabled in prod" (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) (owner: 10Awight) [10:01:04] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10awight) @Lena_WMDE @ECohen_WMDE Two questions: * Should we continue to rende... [10:09:37] (03CR) 10Awight: "Cancelling CR+2, I found that our feature flag is not respected." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) (owner: 10Awight) [10:19:02] (03PS11) 10Awight: Add suggested values parameter [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) [10:21:02] (03CR) 10Awight: [C: 03+2] Add suggested values parameter (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) (owner: 10Awight) [10:38:34] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10awight) Not writing UI tests, because only browser tests would reveal anythi... [10:44:16] (03CR) 10jerkins-bot: [V: 04-1] Add suggested values parameter [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) (owner: 10Awight) [10:54:23] (03PS12) 10Awight: Add suggested values parameter [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) [10:55:39] (03CR) 10Thiemo Kreuz (WMDE): "This is not a full review yet, just a few early remarks." (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) (owner: 10Awight) [11:00:05] (03CR) 10Awight: Add suggested values parameter (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) (owner: 10Awight) [11:48:37] 10VisualEditor, 10MediaWiki-extensions-CategoryTree, 10Parsoid, 10Editing-team (Tracking), 10affects-Kiwix-and-openZIM: The #categorytree magic word doesn't seem to work in VisualEditor - https://phabricator.wikimedia.org/T257344 (10Kelson) @arlorla Great to see a patch here. Thx! A few users had reporte... [12:00:33] 10VisualEditor, 10Editing-team (Third-party): VisualEditor throws "Error contacting the Parsoid/RESTBase server (HTTP 500)" on fresh installation - https://phabricator.wikimedia.org/T270377 (10Seb35) With the narrowing create=working/exiting=non-working, I remind others had this issue. I found T263928, D3nnis3... [12:10:39] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Add suggested values parameter (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) (owner: 10Awight) [12:15:04] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10thiemowmde) > Authors MUST give suggested values which match the field type.... [13:02:06] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10awight) >>! In T271897#6975971, @thiemowmde wrote: >> Authors MUST give sugg... [13:07:19] (03PS13) 10Awight: Add suggested values parameter [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/670461 (https://phabricator.wikimedia.org/T271897) [13:15:03] (03PS1) 10Esanders: Ignore missing matrix cell when importing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/677245 (https://phabricator.wikimedia.org/T262842) [13:20:20] (03CR) 10Esanders: [C: 04-1] DiffElement: Add CSS for tag (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) (owner: 10A. Amritesh) [13:26:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, and 2 others: Navigating back on VE mobile, then pressing "continue editing", results in wrong URL - https://phabricator.wikimedia.org/T263470 (10Esanders) [13:31:59] 10VisualEditor, 10MediaWiki-extensions-CategoryTree, 10Parsoid, 10Editing-team (Tracking), 10affects-Kiwix-and-openZIM: The #categorytree magic word doesn't seem to work in VisualEditor - https://phabricator.wikimedia.org/T257344 (10ssastry) That patch should ride this week's train. [13:38:39] (03CR) 10A. Amritesh: "I did it knowingly as elements with tag already has border(border: 1px solid #eaecf0;) so we must override it otherwise discontinui" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) (owner: 10A. Amritesh) [13:50:08] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10thiemowmde) We realized that "behind a feature flag" can have a surprising l... [14:01:09] (03PS6) 10Esanders: NWE: Always paste rich text as plain, and show context item to convert [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 [14:02:27] (03CR) 10A. Amritesh: DiffElement: Add CSS for tag (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) (owner: 10A. Amritesh) [14:16:43] (03PS7) 10Esanders: NWE: Always paste rich text as plain, and show context item to convert [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 [14:23:09] 10VisualEditor, 10MediaWiki-extensions-CategoryTree, 10Parsoid, 10Editing-team (Tracking), 10affects-Kiwix-and-openZIM: The #categorytree magic word doesn't seem to work in VisualEditor - https://phabricator.wikimedia.org/T257344 (10Kelson) @ssastry thx a lot! [14:47:38] 10VisualEditor, 10BlueSpice, 10Community-Tech, 10Growth-Team, and 23 others: Avoid using User ::isIP, ::getOptions - https://phabricator.wikimedia.org/T275602 (10Vlad.shapik) [15:08:38] 10VisualEditor, 10Release-Engineering-Team (Logspam), 10Wikimedia-production-error: TypeError: Cannot read property 'getModel' of null - https://phabricator.wikimedia.org/T279441 (10Jdlrobson) [15:35:00] 10TemplateData, 10VisualEditor, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 3 others: Add suggested values parameter property to TemplateData and to TemplateData editor - https://phabricator.wikimedia.org/T271897 (10awight) This is a nice framing of the question, thank you. I don't have muc... [15:49:55] 10Editing-team, 10DiscussionTools, 10Wikimedia-production-error: PHP Notice: Trying to get property 'tagName' of non-object - https://phabricator.wikimedia.org/T279445 (10Krinkle) [15:58:31] 10VisualEditor: Content preloaded with visual editor is lost when changing to wikitext editor - https://phabricator.wikimedia.org/T279448 (10Solstag) [16:00:38] 10VisualEditor, 10Editing-team (Tracking), 10Parsoid (Tracking): Changing to visual editor when creating a page breaks parser functions - https://phabricator.wikimedia.org/T250769 (10Solstag) 05Open→03Resolved a:03Solstag I've created the new task as requested: T279448. Marking this one as resolved. [16:03:17] 10VisualEditor, 10DiscussionTools, 10Growth-Team, 10GrowthExperiments-Help panel, 10OWC2020 (OWC2020 Replying 1.0): Help panel: "Get help with editing" button hides other components of the visual editor - https://phabricator.wikimedia.org/T219966 (10RHo) >>! In T219966#6961782, @MMiller_WMF wrote: > @Eto... [16:30:12] 10VisualEditor: Create a system to encode best practices into editing experiences - https://phabricator.wikimedia.org/T265163 (10ppelberg) [17:37:27] 10VisualEditor, 10BlueSpice, 10Community-Tech, 10Growth-Team, and 23 others: Avoid using User ::isIP, ::getOptions - https://phabricator.wikimedia.org/T275602 (10Pchelolo) If all deployed extesions were updated then it's ready for a patch to hard deprecate the methods. [17:39:42] 10VisualEditor, 10BlueSpice, 10Community-Tech, 10Growth-Team, and 23 others: Avoid using User ::isIP, ::getOptions - https://phabricator.wikimedia.org/T275602 (10Vlad.shapik) I am working on a patch for the core. [18:03:01] 10VisualEditor, 10Editing-team (Tracking), 10JavaScript, 10Release-Engineering-Team (Logspam), 10Wikimedia-production-error: TypeError: undefined is not an object (evaluating 'param.aliases.length') - https://phabricator.wikimedia.org/T261884 (10Jdlrobson) [19:03:16] (03CR) 10Bartosz Dziewoński: "?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255937 (https://phabricator.wikimedia.org/T53045) (owner: 10Bartosz Dziewoński) [19:09:36] (03CR) 10Esanders: [C: 04-1] DiffElement: Add CSS for tag (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) (owner: 10A. Amritesh) [19:10:58] (03CR) 10Esanders: [C: 04-1] "Welcome to the project, and thanks for working on this issue!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) (owner: 10A. Amritesh) [19:34:49] 10Editing-team, 10DiscussionTools, 10Wikimedia-production-error: PHP Notice: Trying to get property 'tagName' of non-object - https://phabricator.wikimedia.org/T279445 (10matmarex) It happened only in a single request to a single page on ar.wp. We should investigate but I don't think we need to do it right now. [19:38:47] (03CR) 10Esanders: "Awaiting prod review, but please +1 if happy." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 (owner: 10Esanders) [19:56:27] 10VisualEditor, 10DiscussionTools, 10Growth-Team, 10GrowthExperiments-Help panel, 10OWC2020 (OWC2020 Replying 1.0): Help panel: "Get help with editing" button hides other components of the visual editor - https://phabricator.wikimedia.org/T219966 (10Etonkovidova) Re-checked all cases described in the tas... [20:31:06] 10Editing-team, 10DiscussionTools, 10Wikimedia-production-error: PHP Notice: Trying to get property 'tagName' of non-object - https://phabricator.wikimedia.org/T279445 (10Esanders) I'm surprised phan doesn't detect this. [20:50:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] "When pasting in the middle of existing text, and converting, the pasted wikitext is wrapped in ☀ and ☂." (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 (owner: 10Esanders) [20:54:51] (03CR) 10Jforrester: [C: 03+2] Ignore missing matrix cell when importing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/677245 (https://phabricator.wikimedia.org/T262842) (owner: 10Esanders) [20:59:39] (03Merged) 10jenkins-bot: Ignore missing matrix cell when importing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/677245 (https://phabricator.wikimedia.org/T262842) (owner: 10Esanders) [21:01:38] (03CR) 10Esanders: [C: 04-1] "My comment disappeared!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255937 (https://phabricator.wikimedia.org/T53045) (owner: 10Bartosz Dziewoński)