[05:55:46] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10good first task: Visual diff change colors hidden by tag - https://phabricator.wikimedia.org/T277211 (10A.Amritesh) There are two demos, I will do changes according which you select : @Esanders @Tgr Demo 1 {F34271226} Demo 2 {F34271097} [05:57:43] (03CR) 10A. Amritesh: "Please see T277211 . I have proposed two demos, I would make changes in whichever way you wanted." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) (owner: 10A. Amritesh) [09:49:01] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 2 others: [NWE + CodeMirror] Syntaxhighlighting and actual text out of sync for some special characters - https://phabricator.wikimedia.org/T170382 (10awight) No action needs to be taken.... [10:22:23] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10good first task: Visual diff change colors hidden by tag - https://phabricator.wikimedia.org/T277211 (10Esanders) Thanks for these @A.Amritesh. I’m happy with Demo 1, and it results in cleaner CSS. [10:30:14] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10good first task: Visual diff change colors hidden by tag - https://phabricator.wikimedia.org/T277211 (10Esanders) > What to do, -2 is given to patch? I have made changes to the mentioned directory. Sometimes you will be given guidanc... [10:37:00] (03PS3) 10A. Amritesh: DiffElement: Add CSS for tag [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) [10:42:33] (03PS4) 10A. Amritesh: DiffElement: Add CSS for tag [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) [10:51:10] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10good first task: Visual diff change colors hidden by tag - https://phabricator.wikimedia.org/T277211 (10A.Amritesh) I have updated the code and commit message. Thanks for your guidance and support as it was my first time contribution... [12:06:40] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10JavaScript, 10Release-Engineering-Team (Logspam), 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) - https://phabricator.wikimedia.org/T262842 (10Esanders) [12:08:15] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10JavaScript, 10Release-Engineering-Team (Logspam), 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) - https://phabricator.wikimedia.org/T262842 (10Esanders) Will be considered fixed if the err... [12:17:03] (03CR) 10Esanders: "Looks like I forget to paste the paste contextRange" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 (owner: 10Esanders) [12:39:07] (03CR) 10Esanders: NWE: Always paste rich text as plain, and show context item to convert (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 (owner: 10Esanders) [12:39:15] (03PS8) 10Esanders: NWE: Always paste rich text as plain, and show context item to convert [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 [15:14:49] (03CR) 10Bartosz Dziewoński: [C: 03+1] NWE: Always paste rich text as plain, and show context item to convert [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 (owner: 10Esanders) [15:16:27] 10Editing-team, 10DiscussionTools, 10OWC2020, 10Parsoid (Tracking): Extra blank line appended to comment - https://phabricator.wikimedia.org/T249294 (10Arlolra) > Yes, the blank link at the end will be because of Parsoid. It doesn't happen in every case so it could be a Parsoid bug. Presumably this can be... [15:38:08] (03CR) 10DannyS712: "This change is ready for review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/677396 (owner: 10DannyS712) [15:58:54] (03CR) 10DLynch: [C: 03+1] NWE: Always paste rich text as plain, and show context item to convert [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/551313 (owner: 10Esanders) [17:15:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile should inherit desktop editing preferences - https://phabricator.wikimedia.org/T261423 (10ppelberg) [17:15:51] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01): Change mobile editor preference to a database-stored preference - https://phabricator.wikimedia.org/T266304 (10ppelberg) [17:27:21] 10Editing-team, 10DiscussionTools, 10Patch-For-Review: Introduce a way to view all of the topics you are subscribed to - https://phabricator.wikimedia.org/T273342 (10ppelberg) [17:36:09] (03CR) 10Raimond Spekking: [C: 03+2] Delete empty translation files [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/677396 (owner: 10DannyS712) [17:59:22] (03Merged) 10jenkins-bot: Delete empty translation files [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/677396 (owner: 10DannyS712) [19:33:12] 10Editing-team, 10DiscussionTools: Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters - https://phabricator.wikimedia.org/T278355 (10matmarex) [19:34:09] 10Editing-team, 10DiscussionTools: Enable more signature flexibility in discussion tools - https://phabricator.wikimedia.org/T278442 (10matmarex) [19:34:11] 10Editing-team, 10DiscussionTools: Discussion tools should recognise three and five tilde signatures and add only the missing part - https://phabricator.wikimedia.org/T278357 (10matmarex) [19:34:15] 10Editing-team, 10DiscussionTools: Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters - https://phabricator.wikimedia.org/T278355 (10matmarex) [19:34:17] 10Editing-team, 10DiscussionTools: Allow minor comments to be saved via the reply link - https://phabricator.wikimedia.org/T268558 (10matmarex) [19:40:38] 10Editing-team, 10DiscussionTools: Allow minor comments to be saved via the reply link - https://phabricator.wikimedia.org/T268558 (10dmehus) Cross-referencing this related task, T267663 [19:41:43] 10Editing-team, 10DiscussionTools: Allow minor comments to be saved via the reply link - https://phabricator.wikimedia.org/T268558 (10dmehus) Regarding https://phabricator.wikimedia.org/T268558#6981540, https://phabricator.wikimedia.org/T268558#6671206 already cross-references the task [19:43:44] 10Editing-team, 10DiscussionTools, 10User-RhinosF1: Enable more signature flexibility in discussion tools - https://phabricator.wikimedia.org/T278442 (10dmehus) [19:53:28] 10VisualEditor, 10Utilities-UnicodeJS, 10Editing-team (FY2020-21 Kanban Board), 10JavaScript, and 3 others: Uncaught TypeError: Cannot read property 'length' of null at Object.wordbreak.isBreak - https://phabricator.wikimedia.org/T264904 (10matmarex) That is indeed the same error. I'm not too familiar wi... [20:01:40] 10Editing-team, 10DiscussionTools: Enable more signature flexibility in discussion tools - https://phabricator.wikimedia.org/T278442 (10RhinosF1) Not directly linked to miraheze [20:31:15] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10Serbian-Sites, 10Verified: VisualEditor's Reference dialog sometimes fails to load on wikis with language variants - https://phabricator.wikimedia.org/T278064 (10Ryasmeen) [21:48:10] 10VisualEditor-MediaWiki-2017WikitextEditor: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface - https://phabricator.wikimedia.org/T279600 (10matmarex) [21:48:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid, and 4 others: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701 (10matmarex) Yes, it's easier to keep track of as a separate task. I filed one for this: T2796... [22:04:33] (03PS1) 10Bartosz Dziewoński: Avoid unnecessary wikitext conversion when inserting NBSP in source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/677666 (https://phabricator.wikimedia.org/T279600) [22:05:01] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface - https://phabricator.wikimedia.org/T279600 (10matmarex) a:03matmarex [22:05:11] (03PS8) 10Bartosz Dziewoński: Add command to insert non-breaking space [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255937 (https://phabricator.wikimedia.org/T53045) [22:10:52] (03PS9) 10Bartosz Dziewoński: Add command to insert non-breaking space [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255937 (https://phabricator.wikimedia.org/T53045) [22:11:06] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface - https://phabricator.wikimedia.org/T279600 (10matmarex) [22:11:48] (03CR) 10Bartosz Dziewoński: "Like this? Feels weird, but OK. PS9 also fixed issues in NWE (same as T279600)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255937 (https://phabricator.wikimedia.org/T53045) (owner: 10Bartosz Dziewoński) [22:13:42] 10VisualEditor, 10VisualEditor-ContentEditable, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: VisualEditor: Ctrl+Shift+Space/Opt+Space to insert a non-breaking space (NBSP) - https://phabricator.wikimedia.org/T53045 (10matmarex) [22:14:12] (03PS5) 10Esanders: DiffElement: Add CSS for tag [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) (owner: 10A. Amritesh) [22:15:59] (03CR) 10Esanders: [C: 03+2] "Good stuff, thanks again." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) (owner: 10A. Amritesh) [22:17:34] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface - https://phabricator.wikimedia.org/T279600 (10matmarex) [22:20:25] (03CR) 10Bartosz Dziewoński: [C: 03+2] Apply monospace,monospace font size fix to tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676915 (owner: 10Esanders) [22:21:16] (03Merged) 10jenkins-bot: DiffElement: Add CSS for tag [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676786 (https://phabricator.wikimedia.org/T277211) (owner: 10A. Amritesh) [22:21:21] (03CR) 10Bartosz Dziewoński: [C: 03+2] Add extra check for annotation node height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676910 (https://phabricator.wikimedia.org/T261992) (owner: 10Esanders) [22:22:11] 10VisualEditor, 10Product-Analytics: Write query for Editing Team to access edit completion rate - https://phabricator.wikimedia.org/T223498 (10ppelberg) >>! In T223498#6660660, @MNeisler wrote: > Based on current team priorities, I am aiming to complete this in Q3. Today, @MNeisler and I came to agree this ti... [22:23:23] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10good first task: Visual diff change colors hidden by tag - https://phabricator.wikimedia.org/T277211 (10matmarex) [22:24:36] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, and 2 others: Visual diff change colors hidden by tag - https://phabricator.wikimedia.org/T277211 (10matmarex) [22:25:01] (03Merged) 10jenkins-bot: Apply monospace,monospace font size fix to tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676915 (owner: 10Esanders) [22:25:29] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, and 2 others: Visual diff change colors hidden by tag - https://phabricator.wikimedia.org/T277211 (10matmarex) @A.Amritesh Sorry I didn't reply to your messages earlier, I get lots of notificatio... [22:25:43] (03Merged) 10jenkins-bot: Add extra check for annotation node height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/676910 (https://phabricator.wikimedia.org/T261992) (owner: 10Esanders) [22:32:40] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (83f89605d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/677670 (https://phabricator.wikimedia.org/T261992) [22:33:07] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (83f89605d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/677670 (https://phabricator.wikimedia.org/T261992) (owner: 10Bartosz Dziewoński) [22:38:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10Editing-team (FY2020-21 Kanban Board): [TRACKING] VE navigation issues when cancelling a close - https://phabricator.wikimedia.org/T263472 (10matmarex) [22:38:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10Editing-team (FY2020-21 Kanban Board): [TRACKING] VE navigation issues when cancelling a close - https://phabricator.wikimedia.org/T263472 (10matmarex) All subtasks resolved [22:57:40] (03Merged) 10jenkins-bot: Update VE core submodule to master (83f89605d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/677670 (https://phabricator.wikimedia.org/T261992) (owner: 10Bartosz Dziewoński) [23:14:15] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10JavaScript, 10Release-Engineering-Team (Logspam), 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) - https://phabricator.wikimedia.org/T262842 (10matmarex) (check logs after it's deployed)