[00:53:32] 10VisualEditor, 10MediaWiki-extensions-InputBox, 10MinervaNeue, 10Mobile, and 2 others: Preload does not work correctly on mobile view - https://phabricator.wikimedia.org/T126190 (10Xaosflux) [07:24:38] (03CR) 10WMDE-Fisch: [C: 03+2] Use standard search API when searching for templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/667641 (https://phabricator.wikimedia.org/T274903) (owner: 10Thiemo Kreuz (WMDE)) [07:42:48] (03PS1) 10VolkerE: Remove obsolete vendor prefixed properties [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684272 (https://phabricator.wikimedia.org/T278670) [08:07:43] (03CR) 10jerkins-bot: [V: 04-1] Remove obsolete vendor prefixed properties [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684272 (https://phabricator.wikimedia.org/T278670) (owner: 10VolkerE) [08:12:36] (03Merged) 10jenkins-bot: Use standard search API when searching for templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/667641 (https://phabricator.wikimedia.org/T274903) (owner: 10Thiemo Kreuz (WMDE)) [08:30:47] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 2 others: Add truncation to descriptions - https://phabricator.wikimedia.org/T273426 (10awight) a:03awight [08:48:11] (03CR) 10Awight: [C: 04-1] "Indeed "show" was a dead-end, the method is called explicitly in ve.ui.MWLiveExtensionInspector." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [08:59:00] edsanders: I'm trying to play nice with the `no-jquery/no-visibility` rule in VisualEditor, but having a hard time accomplishing a special effect without it: we want to implement an expandable element that gets notified by a MutationObserver once it's attached to the DOM, and measures its own expected height, etc. [09:00:08] ^ the patch above is close, but I can't tell if .css('display', 'none') is cheating the spirit of the visibility rule, or if we're really just avoiding jQuery and it's okay to directly manipulate visibility? [09:07:08] (03CR) 10WMDE-Fisch: "Yeah, we haven't had the time to solve it properly. The hack where we replace the method from the unicode lib was only necessary because w" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/683829 (owner: 10WMDE-Fisch) [09:12:32] (03PS1) 10VolkerE: Unify `list-style` CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/684296 [09:13:41] Awight, that works, or you can use a CSS class: oo-ui-element-hidden [09:14:04] The problem with hide and show is performance [09:14:42] edsanders: Great to hear, thank you! [09:14:44] As it has to calculate the current display value from the CSS tree. [09:18:15] edsanders: I'm concerned that the way we use MutationObserver is expensive, anyway. We're attaching one of these to the `window.document` for every parameter with a long description. [09:19:05] The only other usage of that API seems to be in TextInputWidget, where we do something like a shadow DOM. [09:20:26] Yeah, I don't know much about the performance of MO [09:22:03] (03CR) 10Awight: [C: 03+1] "@esanders confirmed that we're avoiding jQuery show/hide for performance reasons, but the css display hack is okay." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [09:27:08] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 2 others: Add truncation to descriptions - https://phabricator.wikimedia.org/T273426 (10awight) a:05awight→03None [09:31:32] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Templates-FocusArea, 10WMDE-TechWish-Sprint-2021-04-28: Increase VE template dialog size - https://phabricator.wikimedia.org/T273971 (10awight) a:03awight [10:43:00] (03PS1) 10Awight: Optional feature makes the transclusion dialog bigger [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) [10:46:16] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Templates-FocusArea, 10Patch-For-Review, 10WMDE-TechWish-Sprint-2021-04-28: Increase VE template dialog size - https://phabricator.wikimedia.org/T273971 (10awight) There may be a range of window widths in which non-ideal things happen with the di... [10:46:22] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Templates-FocusArea, 10Patch-For-Review, 10WMDE-TechWish-Sprint-2021-04-28: Increase VE template dialog size - https://phabricator.wikimedia.org/T273971 (10awight) a:05awight→03None [11:19:23] (03CR) 10WMDE-Fisch: Add collapsible descriptions to the transclusion dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [11:29:27] (03CR) 10Awight: [C: 03+1] Add collapsible descriptions to the transclusion dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [11:36:07] (03PS2) 10Esanders: ve.ce.Surface: Move var declarations inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/684114 [11:55:29] (03CR) 10Esanders: "While using an MO to detect when the element is attached as visible is a fine approach it may be over-engineering when the widget is used " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [12:12:42] (03CR) 10Esanders: [C: 04-1] Add collapsible descriptions to the transclusion dialog (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [12:20:24] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Templates-FocusArea, 10Editing-team (Tracking), and 2 others: Add truncation to descriptions - https://phabricator.wikimedia.org/T273426 (10Esanders) NB There is also "Read more" functionality in the media search widget: {F34438818} [12:38:49] (03CR) 10Esanders: [C: 04-1] "It woud be" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) (owner: 10Awight) [12:41:05] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10WMDE-Templates-FocusArea, 10Patch-For-Review, 10WMDE-TechWish-Sprint-2021-04-28: Increase VE template dialog size - https://phabricator.wikimedia.org/T273971 (10Esanders) The existing sizes in OOUI are: ` small: { width: 300 }, medium: { width:... [12:46:18] (03CR) 10Awight: Optional feature makes the transclusion dialog bigger (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) (owner: 10Awight) [12:47:41] (03PS1) 10Awight: [WIP] Optional verbose template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684385 (https://phabricator.wikimedia.org/T277028) [13:02:49] (03PS2) 10Awight: Optional feature makes the transclusion dialog bigger [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) [13:02:57] (03CR) 10Awight: Optional feature makes the transclusion dialog bigger (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) (owner: 10Awight) [13:14:09] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Optional verbose template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684385 (https://phabricator.wikimedia.org/T277028) (owner: 10Awight) [13:35:26] (03PS1) 10Esanders: ArticleTarget: Always set fromEditedState when preloaded is true [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684400 (https://phabricator.wikimedia.org/T279448) [13:47:50] (03PS1) 10Esanders: Make convert to wikitext on paste feature configurable (temporarily) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684409 (https://phabricator.wikimedia.org/T280745) [13:53:30] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Content preloaded with visual editor is lost when changing to wikitext editor - https://phabricator.wikimedia.org/T279448 (10Esanders) a:03Esanders [13:53:49] 10WikiEditor, 10Better Use Of Data, 10Product-Analytics, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Create logging instrumentation for Wikitext editor not affected by ad blockers - https://phabricator.wikimedia.org/T263505 (10Esanders) a:03DLynch [13:57:13] (03CR) 10Esanders: [C: 03+1] "Using the VEFeatureUseSchema seems pretty funky, but I assume you discussed that?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/683998 (https://phabricator.wikimedia.org/T263505) (owner: 10DLynch) [14:20:11] (03CR) 10jerkins-bot: [V: 04-1] Make convert to wikitext on paste feature configurable (temporarily) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684409 (https://phabricator.wikimedia.org/T280745) (owner: 10Esanders) [14:27:48] (03PS2) 10Awight: Optional verbose template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684385 (https://phabricator.wikimedia.org/T277028) [14:43:56] (03CR) 10DLynch: "Yeah, we talked about it, and it was Megan's preferred option." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/683998 (https://phabricator.wikimedia.org/T263505) (owner: 10DLynch) [14:49:49] (03CR) 10jerkins-bot: [V: 04-1] Optional verbose template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684385 (https://phabricator.wikimedia.org/T277028) (owner: 10Awight) [14:53:32] (03PS3) 10Awight: Optional feature makes the transclusion dialog bigger [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) [15:11:20] (03PS2) 10Jforrester: Remove obsolete vendor prefixed properties [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684272 (https://phabricator.wikimedia.org/T278670) (owner: 10VolkerE) [15:12:58] (03CR) 10Jforrester: [C: 03+2] Unify `list-style` CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/684296 (owner: 10VolkerE) [15:16:53] edsanders: Thanks for all the advice! I'm trying to somehow bind to the getReadyProcess hook, but that's only on OO.ui.Window descendants, but my collapsible fields are children of each ParameterPage. I don't see a nice way to wire that through... [15:17:46] (03Merged) 10jenkins-bot: Unify `list-style` CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/684296 (owner: 10VolkerE) [15:26:18] awight: Oh right, that makes it a bit more complicated [15:27:52] we have a setup method that gets called on the pages, during getSetupProcess [15:28:29] we then cal 'focus' on the current page during getReadyProcess, which you could (ab)use [15:29:34] ty [15:33:27] getSetupProcess is also on OO.ui.Window, but I only see the 'focus' wiring you're describing on OO.ui.MessageDialog, on its actions. [15:34:17] 10TemplateData: Syntax error in JSON in Template Namespace - https://phabricator.wikimedia.org/T281729 (10Neechalkaran) [15:34:32] But I think I get the idea, I can just iterate over ParameterPages, call an event on each, and handle that in the child by updating the collapsible element. [15:39:03] (03CR) 10Jforrester: [C: 03+2] ve.dm.Converter: Move var declarations inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/684102 (owner: 10Esanders) [15:43:22] (03PS3) 10Awight: Internally rename container for adding an unknown paramter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682526 [15:43:24] (03PS3) 10Awight: Internally rename container for parameter docs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682527 [15:43:26] (03PS3) 10Awight: Container as a local field [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682544 [15:43:29] (03PS2) 10Awight: Fix tab order: actions before field [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682567 [15:43:30] (03PS11) 10Awight: Add collapsible descriptions to the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [15:44:46] (03CR) 10VolkerE: [C: 03+1] "Thanks!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684272 (https://phabricator.wikimedia.org/T278670) (owner: 10VolkerE) [15:44:52] (03Merged) 10jenkins-bot: ve.dm.Converter: Move var declarations inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/684102 (owner: 10Esanders) [15:45:10] (03CR) 10Awight: "PS 11 uses an explicit mechanism to call methods from the dialog's readyProcess lifecycle hook. There's still a tiny flash, hopefully thi" (038 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [15:47:06] (03PS12) 10Awight: Add collapsible descriptions to the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [15:47:21] edsanders: Awesome, MutationObserver is gone :-) [15:53:46] 10TemplateData, 10VisualEditor: Syntax error in JSON in Template Namespace - https://phabricator.wikimedia.org/T281729 (10Pcoombe) 05Open→03Resolved a:03Pcoombe There was an extra comma in the TemplateData JSON. I fixed it with [this edit](https://ta.wikipedia.org/w/index.php?title=%E0%AE%B5%E0%AE%BE%E0%... [15:54:30] (03CR) 10jerkins-bot: [V: 04-1] Optional feature makes the transclusion dialog bigger [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) (owner: 10Awight) [15:57:42] (03PS3) 10Awight: Optional verbose template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684385 (https://phabricator.wikimedia.org/T277028) [15:59:58] 10TemplateData, 10VisualEditor: Syntax error in JSON in Template Namespace - https://phabricator.wikimedia.org/T281729 (10Neechalkaran) Thank you Pcoombe [16:01:43] (03PS2) 10Esanders: Make convert to wikitext on paste feature configurable (temporarily) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684409 (https://phabricator.wikimedia.org/T280745) [16:04:25] (03CR) 10Awight: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) (owner: 10Awight) [16:16:19] (03CR) 10jerkins-bot: [V: 04-1] Add collapsible descriptions to the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [16:36:53] 10VisualEditor, 10Growth-Team, 10Growth-Team-Filtering, 10MediaWiki-extensions-GuidedTour: Allow hiding VE onboarding experience programmatically to avoid sidetracking users using a different onboarding experience - https://phabricator.wikimedia.org/T122623 (10Catrope) a:05Catrope→03None [16:48:21] 10Editing-team, 10VisualEditor-MediaWiki-Templates: How to get from VE transclusion dialog to Lua module page? - https://phabricator.wikimedia.org/T281736 (10Krinkle) [16:48:28] 10Editing-team, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: How to get from VE transclusion dialog to Lua module page? - https://phabricator.wikimedia.org/T281736 (10Krinkle) [16:48:40] 10Editing-team, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: How to get from VE transclusion dialog to Lua module page? - https://phabricator.wikimedia.org/T281736 (10Krinkle) [16:57:38] (03CR) 10Awight: "Unrelated test failure:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) (owner: 10Awight) [16:57:42] (03CR) 10Awight: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684328 (https://phabricator.wikimedia.org/T273971) (owner: 10Awight) [17:02:35] (03CR) 10Esanders: [C: 04-1] Add collapsible descriptions to the transclusion dialog (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [18:12:18] (03PS13) 10Awight: Add collapsible descriptions to the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [18:12:28] (03CR) 10Awight: Add collapsible descriptions to the transclusion dialog (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [18:12:43] (03CR) 10Awight: "Great reviews, keep 'em coming!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [18:30:07] 10Editing-team, 10DiscussionTools, 10Performance-Team (Radar): Reduce DiscussionTools' usage of the parser cache - https://phabricator.wikimedia.org/T280599 (10Krinkle) [18:35:24] (03CR) 10Esanders: [C: 03+2] Log whether Javascript was supported on saveSuccess [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/683998 (https://phabricator.wikimedia.org/T263505) (owner: 10DLynch) [19:03:52] 10Editing-team, 10DiscussionTools, 10OWC2020 (OWC2020 Replying 1.0): Reply link is missing on some user talk pages on ar.wiki (old timezone translation) - https://phabricator.wikimedia.org/T245789 (10Izno) [19:06:08] 10Editing-team, 10VisualEditor, 10Parsoid: Parsoid corruption (loss of content, removed newlines) when editing pages with fostered content (often caused by unclosed table inside a list item `:{|`) - https://phabricator.wikimedia.org/T240280 (10Izno) [19:55:56] (03Merged) 10jenkins-bot: Log whether Javascript was supported on saveSuccess [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/683998 (https://phabricator.wikimedia.org/T263505) (owner: 10DLynch) [20:47:32] 10Editing-team, 10MediaWiki-Page-history: Edit incorrectly tagged as "reverted" - https://phabricator.wikimedia.org/T281754 (10AlexisJazz) [20:47:40] 10Editing-team, 10MediaWiki-Page-history: Edit incorrectly tagged as "reverted" - https://phabricator.wikimedia.org/T281754 (10AlexisJazz) [21:12:21] 10WikiEditor, 10Better Use Of Data, 10Product-Analytics, 10Editing-team (FY2020-21 Kanban Board), 10Skipped QA: Create logging instrumentation for Wikitext editor not affected by ad blockers - https://phabricator.wikimedia.org/T263505 (10DLynch) QA can't meaningfully check this one, because it's all serv... [21:13:03] 10Editing-team, 10MediaWiki-Page-history: Edit incorrectly tagged as "reverted" - https://phabricator.wikimedia.org/T281754 (10RhinosF1) It went back to https://en.wikipedia.org/w/index.php?title=Monami_Ghosh&oldid=972817785 so I think MediaWiki is right here [21:16:33] (03CR) 10DLynch: Make convert to wikitext on paste feature configurable (temporarily) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684409 (https://phabricator.wikimedia.org/T280745) (owner: 10Esanders) [21:17:00] (03PS3) 10DLynch: Make convert to wikitext on paste feature configurable (temporarily) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684409 (https://phabricator.wikimedia.org/T280745) (owner: 10Esanders) [21:56:14] (03CR) 10DLynch: [C: 03+2] Make convert to wikitext on paste feature configurable (temporarily) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684409 (https://phabricator.wikimedia.org/T280745) (owner: 10Esanders) [22:19:53] (03Merged) 10jenkins-bot: Make convert to wikitext on paste feature configurable (temporarily) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/684409 (https://phabricator.wikimedia.org/T280745) (owner: 10Esanders) [22:47:05] 10VisualEditor, 10Product-Analytics, 10Editing-team (FY2020-21 Kanban Board), 10Readers-Web-Backlog (Tracking), 10User-Ryasmeen: Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10ppelberg) [22:47:17] 10WikiEditor, 10Better Use Of Data, 10Product-Analytics, 10Editing-team (FY2020-21 Kanban Board), 10Skipped QA: Create logging instrumentation for Wikitext editor not affected by ad blockers - https://phabricator.wikimedia.org/T263505 (10ppelberg) 05Open→03Resolved >>! In T263505#7055043, @DLynch wro... [22:50:23] 10WikiEditor, 10Better Use Of Data, 10Product-Analytics, 10Editing-team (Tracking): Post-deployment QA: verify ad blocking instrumentation working as expected - https://phabricator.wikimedia.org/T281409 (10ppelberg) Per T263505#7054699, work on this task can technically begin //as early as// this upcoming... [23:28:35] 10Editing-team, 10MediaWiki-Page-history: Edit incorrectly tagged as "reverted" - https://phabricator.wikimedia.org/T281754 (10AlexisJazz) 05Open→03Invalid >>! In T281754#7055048, @RhinosF1 wrote: > It went back to https://en.wikipedia.org/w/index.php?title=Monami_Ghosh&oldid=972817785 so I think MediaWiki...