[01:19:36] 10Editing-team, 10DiscussionTools, 10Performance-Team (Radar): Reduce DiscussionTools' usage of the parser cache - https://phabricator.wikimedia.org/T280599 (10ppelberg) [01:20:52] 10Editing-team, 10DiscussionTools: Introduce permalinks for talk page topics - https://phabricator.wikimedia.org/T273341 (10ppelberg) **Open question** - [ ] How tractable is this task? What needs to be true for us to be able to implement this? - This actually not currently tractable because we haven't thought... [01:22:06] 10VisualEditor, 10Patch-For-Review: Use CSS 'mix-blend-mode: multiply' for fake selections - https://phabricator.wikimedia.org/T269145 (10ppelberg) [01:23:14] 10Editing-team, 10VisualEditor, 10VisualEditor-MediaWiki, 10DiscussionTools: Consider switching from sessionStorage to localStorage for autosave - https://phabricator.wikimedia.org/T218663 (10ppelberg) [01:26:39] 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board): VisualEditor client-side errors review (April 2021) - https://phabricator.wikimedia.org/T279707 (10ppelberg) a:03dchan [01:27:20] 10VisualEditor, 10Product-Analytics, 10Editing-team (Tracking), 10Readers-Web-Backlog (Tracking), 10User-Ryasmeen: Measure % of edits coming from users without JS - https://phabricator.wikimedia.org/T240697 (10ppelberg) [02:08:50] edsanders: Kemayo: just fyi - installing DT locally and initially noticed encountered ` Wikimedia\Rdbms\Database::makeList: empty input for field sub_item Backtrace: […] DiscussionTools\SubscriptionStore->fetchSubscriptions` after a plain install with just the default settings. [02:09:11] I guess that means a custom schema change is now used by default, but the mw.org instructions don't (yet) say that running update.php is required. [02:09:29] assuming all good and intentional, worth updating https://www.mediawiki.org/wiki/Extension:DiscussionTools :) [02:11:59] hm.. well bummer, after running update.php it still fatals when editing Talk:Main_Page [02:13:02] It seems User_talk:Admin is fine, so I'll use that for now, but yeah, seems like something might be arise there [02:24:02] 10Editing-team, 10DiscussionTools, 10Performance-Team, 10Patch-For-Review: Reduce parser cache retention temporarily for DiscussionTools - https://phabricator.wikimedia.org/T280605 (10Krinkle) [04:36:28] 10Editing-team, 10DBA, 10DiscussionTools, 10Performance-Team, 10Patch-For-Review: Reduce parser cache retention temporarily for DiscussionTools - https://phabricator.wikimedia.org/T280605 (10Marostegui) [04:58:27] 10Editing-team, 10DBA, 10DiscussionTools, 10Performance-Team, 10Patch-For-Review: Reduce parser cache retention temporarily for DiscussionTools - https://phabricator.wikimedia.org/T280605 (10Marostegui) [05:51:54] 10Editing-team, 10DBA, 10DiscussionTools, 10Performance-Team (Radar): Post-deployment: (partly) ramp parser cache retention back up - https://phabricator.wikimedia.org/T280604 (10Marostegui) [05:52:20] 10Editing-team, 10DBA, 10DiscussionTools, 10Performance-Team (Radar): Post-deployment: (partly) ramp parser cache retention back up - https://phabricator.wikimedia.org/T280604 (10Marostegui) a:05Marostegui→03None Not assigning it to me specifically, as anyone could pick this up after the mitigation [07:17:39] (03PS1) 10Kosta Harlan: Check if actionTools.notices is set before using [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685318 (https://phabricator.wikimedia.org/T281960) [07:28:16] (03PS2) 10Kosta Harlan: Check if actionTools.notices is set before using [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685318 (https://phabricator.wikimedia.org/T281960) [08:27:56] (03PS3) 10Kosta Harlan: Check if actionTools.notices is set before using [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685318 (https://phabricator.wikimedia.org/T281960) [10:51:24] (03CR) 10Svantje Lilienthal: [C: 04-1] "Not sure why that is, but when testing this patch locally, the info text does not appear when adding a field, but only when editing it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [11:26:03] Krinkle: what's the error? [12:20:51] edsanders: fatal db error from ` Wikimedia\Rdbms\Database::makeList: empty input for field sub_item Backtrace: […] DiscussionTools\SubscriptionStore->fetchSubscriptions` [12:31:16] 10Citoid: Citoid generate different citation in arwiki compared with enwiki - https://phabricator.wikimedia.org/T263632 (10Mvolz) >>! In T263632#6702707, @alaa wrote: >> 2. The authors are different? > > Yes, per arwiki user complain So this is probably down to your template data and or how your template work... [12:53:09] 10Citoid: Citoid generate different citation in arwiki compared with enwiki - https://phabricator.wikimedia.org/T263632 (10Mvolz) To fix this I've submitted a change to the template data. [13:26:15] krinkle I can create new wikis with DiscussionTools on Patch Demo... [13:26:37] what's the full stack trace? [14:14:05] 10TemplateData, 10VisualEditor: TemplateData support for specifying parameters that are allowed to be empty - https://phabricator.wikimedia.org/T280078 (10Nux) >>! In T280078#7051257, @matmarex wrote: > > I don't think that solves the problem though. We still need to distinguish two kinds of suggested paramet... [14:46:45] (03CR) 10Jforrester: [C: 03+2] Check if actionTools.notices is set before using [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685318 (https://phabricator.wikimedia.org/T281960) (owner: 10Kosta Harlan) [15:16:45] (03Merged) 10jenkins-bot: Check if actionTools.notices is set before using [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685318 (https://phabricator.wikimedia.org/T281960) (owner: 10Kosta Harlan) [15:31:21] Krinkle: Which database are you using locally? I could see us having missed updating one of the schemas. [15:33:48] Or e.g. not having tested some of them since they were rebuilt. [15:57:06] (03PS1) 10Esanders: ArticleTargetLoader/Saver: Move vars inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685514 [16:07:00] (03PS1) 10Esanders: Support watchist expiry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685517 (https://phabricator.wikimedia.org/T251348) [16:25:00] (03CR) 10Esanders: Add collapsible descriptions to the transclusion dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [16:25:48] (03CR) 10Esanders: Add collapsible descriptions to the transclusion dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/682001 (https://phabricator.wikimedia.org/T273426) (owner: 10Andrew-WMDE) [16:43:06] Kemayo: mysql (mariadb), mediawiki-docker-dev. [16:43:15] Kemayo: viewing Talk:Main_Page leads to https://paste.toolforge.org/view/ae1b6167 [16:44:12] It's an empty stock install with just DT + VE + Linter enabled [16:45:24] update.php output, just in case: https://paste.toolforge.org/view/a89d48b9 [16:46:19] When I go to Talk:Main_Page2 and try to create/save it with "foo", the same error happens there as well [16:46:25] 10VisualEditor: VE problem: Links does not work with the non-breaking space correctly - https://phabricator.wikimedia.org/T282023 (10Patriccck) [16:46:46] I'm logged in as user Admin while doing this [16:47:58] I've disabled/commented out all other LocalSettings.php statements besides three extension loads and two settings required for DT ( $wgLocaltimezone = 'UTC'; $wgFragmentMode = [ 'html5' ]; ) [17:03:18] $conditions in fetchSubscriptions() encodes to { "sub_user": 1, "sub_item": [] } , where sub item is array() from $itemNames = $matches[1]; in postprocessTopicSubscription() , presumably because the talk page contains nothing no DT comments yet. [17:03:31] although if it was that simple, I'm not sure what is making it not fail on patchdemo, for example. [17:06:55] (03PS1) 10Esanders: Move vars inline in preinit code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685530 [17:07:06] he, spoke to soon, wasn't logged-in on patch demo [17:07:07] edsanders: https://patchdemo.wmflabs.org/wikis/5c38ec39c4/w/index.php?title=Talk:Main_Page2 [17:07:28] username "Foo", password "5c38ec39c4" [17:08:18] Thanks [17:18:23] 10VisualEditor, 10ConfirmEdit (CAPTCHA extension), 10Editing-team (FY2020-21 Kanban Board), 10MW-1.37-notes (1.37.0-wmf.3; 2021-04-27): "Invalid response from server." when using hCaptcha and Visual Editor - https://phabricator.wikimedia.org/T264684 (10Esanders) a:03matmarex [17:24:16] 10Editing-team, 10DiscussionTools, 10Growth-Team, 10Growth-Team-Filtering, 10Notifications: Take the users to the exact location of the comment when clicking on a mention notification - https://phabricator.wikimedia.org/T253082 (10ppelberg) [17:52:49] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Change wikitext output for block templates without parameters - https://phabricator.wikimedia.org/T282031 (10Agabi10) [18:12:45] edsanders: do you recall why you made this change from mw-body-content to mw-parser-output for external links styles? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/390423 [18:12:54] it seems VE modal dialogs also don't set this class anymore [18:13:08] I notice that external links in edit notices in VE, for example, are no longer styled correctly it seems [18:14:14] I'm digging through various changelogs to try and trace it [18:17:47] I think at the time mw-body-content wasn't to be reused [18:17:57] and mw-parser-output could be applied to parsed snippets [18:18:19] e.g. full page previews, in-context previews (e.g. of references) [18:19:10] (This is the DB bug you found: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/685548 ) [19:07:27] edsanders: hm.. I see. I think there was some confusion at the time and probably some misuses of that class. [19:08:11] I think those have been ironed out, or if not, they'd be straight forward to fix. [19:08:13] https://phabricator.wikimedia.org/T281540#7063458 [19:08:32] unrelated to that task overall, but VE missing externa link, h2 and other skin-provided content styles in edit notices [19:09:03] although for etxerla links, they're missing outside VE as well because the issue isn't (only) lack of mw-content-body in VE, it's also that the core styles no longer target that. [19:09:13] so on edit page they are also missing [19:11:39] (03CR) 10Krinkle: [C: 03+2] Move vars inline in preinit code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685530 (owner: 10Esanders) [19:40:15] (03Merged) 10jenkins-bot: Move vars inline in preinit code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/685530 (owner: 10Esanders) [19:56:06] 10VisualEditor-ContentEditable: Visualeditor on iPad in Desktop mode: cut-and-paste of references sometimes fails - https://phabricator.wikimedia.org/T282049 (10AxelBoldt) [21:29:37] 10Editing-team, 10DiscussionTools: Topic subscriptions: calculate engagement metrics - https://phabricator.wikimedia.org/T280898 (10ppelberg) [21:29:49] 10Editing-team, 10DiscussionTools: Topic subscriptions: calculate engagement metrics - https://phabricator.wikimedia.org/T280898 (10ppelberg)