[01:25:20] Hi, I did not exactly understand this part: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Prepare_to_work_with_Gerrit [01:26:12] I have installed git-review using sudo apt-get install git-review [01:26:22] mertyildiran: okay what do you need help with [01:26:30] I did not executed these lines: [01:26:31] git config --global gitreview.remote origin [01:26:38] git config --global gitreview.username myusername [01:26:42] Ok? [01:26:50] I thought it was already configured [01:27:01] No [01:27:06] and I skipped directly to git review -s [01:27:23] it asked me rsa passphrase [01:27:24] You can edit the config at any poimt [01:27:36] After nothing happened [01:27:43] I don't understand the functionality of that part [01:27:48] How can I edit? [01:27:55] rsa passphrase is the the pass that you entered when you generated the key [01:28:04] No no that's OK [01:28:04] It wont be visable when you type [01:28:12] I entered and nothing happened [01:28:16] The same commmands you mentioned [01:28:47] I entered the password no problem [01:28:52] But nothing happened [01:29:04] Also how can I edit the config because I missed that part [01:29:28] Its the git config commands [01:30:07] Is it exactly the same command with: git config --global user.name "John Doe"? [01:30:31] git is already perfectly configured in my environment. [01:31:06] Instead of user.name its gitreview.username [01:31:13] Also why there is a need for assigning remote origin git config --global gitreview.remote origin [01:31:34] Because if not it will create 2 origins [01:32:21] how can I check the current status of my repository? [01:32:40] This is what happened: [01:32:41] mertyildiran@Corsair:~/Documents/MediaWiki/core$ git review -s [01:32:48] Enter passphrase for key '/home/mertyildiran/.ssh/id_rsa': [01:32:53] mertyildiran@Corsair:~/Documents/MediaWiki/core$ ls -al [01:32:56] mertyildiran: status is git status [01:33:55] hmm [01:34:16] What exactly git review -s did to my directory? [01:34:22] Let me look [01:34:42] How? [01:35:25] Nothing [01:35:34] I just look at documentation [01:35:35] :D [01:35:38] Of git review [01:35:42] oh OK [01:36:07] what part should I change on this command? git config --global gitreview.remote origin [01:36:23] mertyildiran: https://docs.openstack.org/infra/git-review/usage.html https://git-scm.com/documentation are good references also [01:36:28] Nothing [01:36:40] git config --global gitreview.remote gerrit.wikimedia.org:29418/mediawiki/core.git ? [01:36:48] Nope just origin [01:36:58] Correct origin [01:37:04] OK [01:37:55] git config --global gitreview.username "mertyildiran" [01:38:12] or git config --global gitreview.username "Mehmet Mert Yıldıran" (my full name on GitHub) [01:38:17] Which one is correct [01:38:32] Whats your gerrit username? [01:38:37] I would like to be visible on GitHub [01:38:39] mertyildiran [01:38:44] Use mertyildiran [01:38:48] OK [01:41:54] I called git review -s again after executing these two commands [01:42:02] ..and nothing happened again. [01:42:15] no out [01:42:55] on which step I should call git add -A and git commit -m "blabla..." [01:43:40] After changing a file [01:43:59] Then what you do is exucute git review after running git commit [01:44:13] And i mean just "git review" [01:45:41] OK I will try to go through the step imperfectly as it seems, I will let you know thanks for the help. [01:47:52] Thats what im here for [01:57:33] Zppix: I sent it Change-Id: Ib36063b69d6846fc197800bba44287493b0632c0 [01:57:44] Is there a problem? Could you take a look? [01:58:08] mertyildiran: looking [02:00:18] mertyildiran: im having our continuous integration system check your code... and then ill test it personally [02:01:40] Zppix: oh OK thank you so much. I will periodically check my gerrit account and this chat room for your messages. [02:02:07] It wont take long mertyildiran [02:02:21] oh OK then I'm waiting here. [02:08:39] mertyildiran: failed https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-jessie/181/checkstyleResult/ [02:10:41] Zppix: oh so I should add spaces ( $skipping ) [02:10:49] How can I update this push? [02:12:08] Amend the patch [02:13:05] How can I do that? Please guide me [02:15:20] Zppix: I made it, I fixed the issue [02:15:26] Could you please take a look again. [02:45:03] Zppix: Are you there? Is there anything I have to do? [04:49:32] hi, does table with "mw-collapsible mw-collapsed" generates toggle or toggle? [06:04:50] Hi all. I've followed some instructions to export Template:Note from mediawiki.org with the goal to import it into my own install. The resulting XML file was 8.8mb. Have i done something wrong? 8.8mb for a colored box? [08:08:44] After a system rboot, I have to *also* restart memcached, or I get this after trying to login to MW: [08:08:45] There seems to be a problem with your login session; this action has been canceled as a precaution against session hijacking. Go back to the previous page, reload that page and then try again. [08:09:04] i think this looks like a MW bug. [08:10:02] anyone know how to best check if it has been filed? [10:12:14] hi! i've a question about installation visualeditor on mediawiki. I installed Visualeditor 1.28.2 with parsoid server when i tried to editing with VE i've a popup message with "http". Thank for your help [10:13:37] parsoid is running on port 8142 i've a page with welcome parsoid api web service [10:55:02] Hi, I'm having problem criating thumbnails... Error generating thumbnail timeout: can't execute '180': No such file or directory Error code: 127 [10:55:13] mediawiki 1.28.2 [10:55:48] also, is there a way to force generation of a thumb? [13:39:34] (EoN probably exported the whole history.) [13:40:15] cpg: what do you use to start/restart memcached? (On the same server?) [14:39:34] Hi all. Can you plz tell me if the error seen here https://postimg.org/image/mj8wx0ye9/ means my parsoid setup is wrong? [15:22:26] Hi, when the review process of this change I have pushed will be finished?: https://gerrit.wikimedia.org/r/#/q/Ib36063b69d6846fc197800bba44287493b0632c0 [15:23:53] Is there anything I have to do now? Current state is jenkins Main test build succeeded. [15:47:58] mertyildrian: The tests passed, also sorry about last night I unexpectily had to go without warning [15:56:04] Zppix: oh OK no problem. So you guys review the code and accept or reject it, right? There is nothing I have to do now, am I correct? [16:59:53] mertyildiran: all i ask is to check in every now and then in case someone has something for you to change, but basically yes it will either be merged into the code or it will be rejected (which doesnt normally happen) [17:00:03] and by check in i mean on gerrit [17:00:31] mertyildiran: however if you have any questions feel free to ask here or to ask me personally and ill try to assist [17:41:53] Any updates with 1.29? [18:47:48] Zppix: OK, thank you so much. [20:10:01] Nemo_bis: it's a centos system using systemd, so it's whatever mechanisms are at play at starting services [20:56:29] !hss | dr0ptp4kt [20:56:29] dr0ptp4kt: https://upload.wikimedia.org/wikipedia/mediawiki/6/69/Hesaidsemanticga2.jpg