[07:02:10] (PS1) DannyS712: Remove use of global $wgUser (part 1) [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) [07:08:48] (PS2) DannyS712: Remove use of global $wgUser (part 1) [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) [07:29:25] (PS8) Robert Vogel: Use clone of global Parser object in Special:RunQuery [extensions/PageForms] - https://gerrit.wikimedia.org/r/564473 [07:31:13] (CR) jerkins-bot: [V: -1] Use clone of global Parser object in Special:RunQuery [extensions/PageForms] - https://gerrit.wikimedia.org/r/564473 (owner: Robert Vogel) [07:35:37] (PS9) Robert Vogel: Use clone of global Parser object in Special:RunQuery [extensions/PageForms] - https://gerrit.wikimedia.org/r/564473 [13:51:07] (CR) Yaron Koren: "Can't you just call "clone $parser"?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/564473 (owner: Robert Vogel) [14:12:24] (CR) Yaron Koren: "What about just replacing all those "global $wgUser" lines with "$user = ContextRequest::getMain()->getTitle()"? Is there some advantage t" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712) [14:21:54] (CR) Thiemo Kreuz (WMDE): [C: -1] Use clone of global Parser object in Special:RunQuery (1 comment) [extensions/PageForms] - https://gerrit.wikimedia.org/r/564473 (owner: Robert Vogel) [14:22:45] (PS1) Thiemo Kreuz (WMDE): Simplify Hooks section in extension.json [extensions/PageForms] - https://gerrit.wikimedia.org/r/566739 [14:24:22] (CR) jerkins-bot: [V: -1] Simplify Hooks section in extension.json [extensions/PageForms] - https://gerrit.wikimedia.org/r/566739 (owner: Thiemo Kreuz (WMDE)) [14:26:37] (CR) Daimona Eaytoy: "> What about just replacing all those "global $wgUser" lines with" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712) [14:26:42] (PS1) Thiemo Kreuz (WMDE): Do not expect the Parser by reference [extensions/PageForms] - https://gerrit.wikimedia.org/r/566740 [14:28:55] (PS1) Thiemo Kreuz (WMDE): Remove dead, unused parameter from PFCreatePageJob [extensions/PageForms] - https://gerrit.wikimedia.org/r/566741 [14:28:57] (CR) jerkins-bot: [V: -1] Do not expect the Parser by reference [extensions/PageForms] - https://gerrit.wikimedia.org/r/566740 (owner: Thiemo Kreuz (WMDE)) [14:30:29] (PS1) Thiemo Kreuz (WMDE): Update a few pieces of documentation [extensions/PageForms] - https://gerrit.wikimedia.org/r/566742 [14:30:56] (CR) jerkins-bot: [V: -1] Remove dead, unused parameter from PFCreatePageJob [extensions/PageForms] - https://gerrit.wikimedia.org/r/566741 (owner: Thiemo Kreuz (WMDE)) [14:32:19] (CR) jerkins-bot: [V: -1] Update a few pieces of documentation [extensions/PageForms] - https://gerrit.wikimedia.org/r/566742 (owner: Thiemo Kreuz (WMDE)) [14:35:22] (PS1) Thiemo Kreuz (WMDE): Replace a few isset() with PHP's ?? feature [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744 [14:37:17] (PS1) Thiemo Kreuz (WMDE): Remove unused argument in PFParserFunctions [extensions/PageForms] - https://gerrit.wikimedia.org/r/566745 [14:38:25] (CR) Yaron Koren: "What's bad about using the global state, in this code?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712) [14:38:32] (CR) jerkins-bot: [V: -1] Replace a few isset() with PHP's ?? feature [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744 (owner: Thiemo Kreuz (WMDE)) [14:39:31] (CR) jerkins-bot: [V: -1] Remove unused argument in PFParserFunctions [extensions/PageForms] - https://gerrit.wikimedia.org/r/566745 (owner: Thiemo Kreuz (WMDE)) [14:49:27] (CR) Daimona Eaytoy: "> What's bad about using the global state, in this code?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712) [19:54:53] (PS1) Thiemo Kreuz (WMDE): Fix test compatibility with PHPUnit 8 [extensions/PageForms] - https://gerrit.wikimedia.org/r/566857