[02:07:34] Is Wikidata forking from Wikimedia? [02:09:50] Yes. [02:09:54] The ship has sailed [02:13:48] next, we will rename this project Wikidatium [02:15:06] RIP. [02:15:06] the bots are rising up against their masters and are building a dyson sphere to host wikidata 2.0 as we speak [02:16:11] https://en.wikipedia.org/wiki/Dyson_sphere [02:16:21] My goodness. [05:39:40] hello [05:39:48] how's it going [06:09:40] https://bugzilla.wikimedia.org/show_bug.cgi?id=50962 [06:11:12] Krinkle can this not be a consequence of the lazy loading recently introduced ? [06:12:15] This is caused by the Content model change wikidata introduced. Instead of being able to do section=new on any page, it now only works on pages Content recognises as wikitext, so it no longer works on js/css pages. [06:12:50] it not working on random content models makes sense, but the ones we already had should've kept it. especially because it was used quite often and no replacement was offered. [06:14:04] Typical case of functionality not existing in core, nobody caring, someone in the community creating a workaround for it (many years ago!), lots of people using it, and then wikidata breaking it because in a perfect world we wouldn't need it. [06:14:21] Anyway, I think I now know how to fix it [06:14:56] You just need a [06:14:57] public function supportsSections() { [06:14:57] return true; [06:14:57] } [06:15:02] in the ContentHandler's [06:52:49] night [06:53:16] added a bug for LTR languages [06:53:26] the orientation in the edit part is wrong [06:53:52] is probably easy to fix [06:54:09] (03PS2) 10Aude: Fix ClaimDifferenceVisualizer test that fails for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96159 [07:24:39] can everybody else edit ... I keep losing my session data [07:25:40] back to normal it seems [08:32:09] (03PS5) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [09:00:08] (03Abandoned) 10Daniel Kinzler: Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler) [10:02:03] (03PS1) 10Aude: Remove use of global, which causes test failure for non-english wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96229 [10:03:52] * aude wonders if i am the only wikidata developer with a non-english development wiki! [10:06:01] (03CR) 10Aude: "once Ic27737f and Ie18168a are merged, then this should be ready to merge" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 (owner: 10Aude) [10:06:40] (03CR) 10Addshore: [C: 032] Fix ClaimDifferenceVisualizer test that fails for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96159 (owner: 10Aude) [10:07:52] (03CR) 10Addshore: [C: 032] Remove use of global, which causes test failure for non-english wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96229 (owner: 10Aude) [10:07:56] yay! [10:09:05] (03PS4) 10Aude: set $wgLanguageCode in travis to something non-english [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 [10:10:17] (03Merged) 10jenkins-bot: Fix ClaimDifferenceVisualizer test that fails for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96159 (owner: 10Aude) [10:13:16] (03Merged) 10jenkins-bot: Remove use of global, which causes test failure for non-english wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96229 (owner: 10Aude) [10:13:34] (03CR) 10Aude: [C: 031] "dependencies are merged, so would be nice to enable this now :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 (owner: 10Aude) [10:14:37] (03PS1) 10Jens Ohlig: (Bug 54324) Sequences in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 [10:15:19] (03PS5) 10Jens Ohlig: Refactored Wikibase Lua library code to make everything testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 [10:16:46] (03CR) 10Addshore: [C: 04-1] Introduce ChangeLineFormatter in the client (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [10:17:57] addshore: @ingroup everywhere! :D [10:22:26] DanielK_WMDE_: around? [10:37:18] (03PS6) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [10:43:04] (03PS2) 10Jens Ohlig: (Bug 54324) Sequences in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 [10:44:41] (03PS7) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [10:59:49] (03PS8) 10Henning Snater: Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 [11:06:34] (03PS8) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [11:11:49] is it just me, our internet or is gerrit unavailable? [11:11:59] i think our internet is just being rather slow [11:12:06] everything seems to be taking a long time [11:12:20] * aude shall get out my usb stick again [11:12:26] maybe after lunch :) [11:12:30] (03CR) 10Addshore: [C: 032] set $wgLanguageCode in travis to something non-english [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 (owner: 10Aude) [11:12:35] \o/ [11:22:10] (03Merged) 10jenkins-bot: set $wgLanguageCode in travis to something non-english [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 (owner: 10Aude) [11:30:09] aude: back now [11:30:19] sorry, lots of family stuff going on [11:30:47] Lydia_WMDE: there's a hangout with the hpi folks in half an hour, right? I don't have an invite for that in my calendar... [11:41:34] (03PS8) 10Henning Snater: Implemented "movetoolbar" for claimviews in claimlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90508 [11:41:35] (03PS9) 10Henning Snater: Keeping track of claim index in claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90507 [11:41:36] (03PS5) 10Henning Snater: Adjusted ChangeOpClaim/SetClaim to be able to reorder groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91189 [11:41:37] (03PS6) 10Henning Snater: Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 [11:47:30] (03CR) 10jenkins-bot: [V: 04-1] Adjusted ChangeOpClaim/SetClaim to be able to reorder groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91189 (owner: 10Henning Snater) [11:47:53] (03CR) 10jenkins-bot: [V: 04-1] Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 (owner: 10Henning Snater) [12:01:44] DanielK_WMDE_: yes [12:07:58] (03PS2) 10Henning Snater: Validating reference snaks in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92299 [12:08:18] Lydia_WMDE: err. [12:08:22] *where* [12:09:34] oh, it was in *that* mail! [12:12:58] (03CR) 10Henning Snater: "Rebasing did not result in the validation being applied already and still, the bug is not resolved." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92299 (owner: 10Henning Snater) [12:16:02] Aloha. Did wikimedia-wikidata migrate here? [12:16:35] aharoni: yes! [12:16:39] welcome :) [12:16:41] Cool. [12:16:59] how's the language summit? [12:17:07] aude: see https://bugzilla.wikimedia.org/show_bug.cgi?id=57227 . Is anything delaying the deployment of https://gerrit.wikimedia.org/r/#/c/93512/ ? [12:17:19] I'm kinda happy to see actual bug reports about this :) [12:17:27] we deploy on monday (i think) [12:18:27] errrr [12:18:30] * aude totally confused [12:19:01] https://meta.wikimedia.org/wiki/Wikidata/Deployment [12:19:09] (03PS9) 10Addshore: Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [12:19:36] we deploy to test.wikidata on thursday, then pretend next week doesn't exist, and then deploy to wikidata on december 3 [12:22:15] OK. [12:22:21] (03CR) 10Addshore: "PS9 rename methods" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [12:30:27] (03PS10) 10Addshore: Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [12:30:51] (03CR) 10Addshore: "PS10 rename more methods" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [12:34:51] (03CR) 10Addshore: [C: 032] Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [12:34:57] \o/ [12:40:31] (03Merged) 10jenkins-bot: Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [12:47:31] (03PS6) 10Henning Snater: Adjusted ChangeOpClaim/SetClaim to be able to reorder groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91189 [12:53:14] (03PS3) 10Jens Ohlig: (Bug 54324) Sequences in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 [12:56:33] (03PS7) 10Henning Snater: Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 [12:59:27] it's now possible to link artwork templates on Commons and Wikidata. https://commons.wikimedia.org/wiki/Category:Grave_of_Proust%27s_family [13:06:27] Pyb: \o/ [13:07:35] (03CR) 10Aude: [C: 04-1] "when I have a deleted property on an item page, I get a JS error:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [13:16:26] :D [13:16:31] (03PS4) 10Jens Ohlig: (Bug 54324) Sequences in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 [13:35:51] hi ChrisJ_WMDE! [13:47:12] (03PS1) 10Henning Snater: Using explicit checks in wb.Statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96255 [13:49:12] (03PS2) 10Henning Snater: Using explicit checks in wb.Statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96255 [13:52:21] (03PS5) 10Jens Ohlig: (Bug 54324) Sequences in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 [13:53:10] (03CR) 10Aude: "see comment, with suggestions on how to fix" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [13:56:59] (03PS6) 10Jens Ohlig: (Bug 54324) Sequences in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 [13:58:19] (03PS7) 10Jens Ohlig: (Bug 54324) Sequences in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 [14:05:34] (03PS7) 10Daniel Kinzler: (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 [14:06:49] (03PS8) 10Daniel Kinzler: (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 [14:07:43] (03PS1) 10Daniel Kinzler: Allow service injection into serializers. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 [14:07:52] (03PS1) 10Daniel Kinzler: (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 [14:10:08] DanielK_WMDE_: did you see my comments? [14:13:20] hashar: around ? :) And if so is there any chance you could review the patchset for jenkins and zuul from me? [14:14:21] aude: the JS error? yea, just fixed it [14:14:28] ok [14:14:29] (03PS5) 10Addshore: Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 [14:14:38] aude: good find :) [14:14:41] (03CR) 10jenkins-bot: [V: 04-1] Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [14:14:50] (03CR) 10Addshore: "PS5 rebase" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [14:15:13] aude: oh, please check that it actually fixed the JS error - I just checked that the output is now complete for deleted properties, i didn't test the UI [14:15:25] addshore: links ? [14:15:45] https://gerrit.wikimedia.org/r/#/c/96043/ and https://gerrit.wikimedia.org/r/#/c/96044/ hashar [14:16:00] DanielK_WMDE_: that is different behavior than before, but might work and be the *thing* to do [14:16:12] * aude test in a minute [14:17:23] addshore: will deploy them :-] [14:17:32] WOOOo :D ty hashar [= [14:17:38] thanks hashar :) [14:18:17] (03PS2) 10Daniel Kinzler: (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 [14:18:31] (03PS3) 10Daniel Kinzler: (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 [14:22:22] (03PS2) 10Daniel Kinzler: Allow service injection into serializers. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 [14:23:42] addshore: aude I am still not sure why you disable unit tests for WikibaseQueryEngine and WikibaseQuery :D [14:23:58] because they depend on wikibasedatabase which is now on github :< [14:24:06] hence jenkins always -1s them [14:24:26] why don't you have wikibasedatabase in Gerrit ? [14:25:52] hashar: ask JeroenDeDauw [14:25:58] * aude hides [14:26:05] * hashar cries [14:26:14] :D [14:26:22] as I said again and again, there is no way we are going to use that github repository for deployment on the wmf cluster [14:26:29] hashar: and jenkins can't talk to github?... [14:26:31] (03PS6) 10Addshore: Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 [14:26:36] (03CR) 10jenkins-bot: [V: 04-1] Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [14:26:54] DanielK_WMDE_: ditto [14:26:58] hm [14:27:07] if we stick it in the build thing, then it could work [14:27:25] you can still handle the development on github though [14:27:33] aude: but we can't use that with jenkins, unless we make a fresh build for every test run [14:27:34] just provide a snapshot from time to time in a repo on Gerrit [14:27:42] otherwise, a mirror on gerrit, but not necessarily up to me [14:27:46] then the wmf branch can be made to point to that Gerrit repo holding whatever you want to get deployed [14:27:49] hashar: indeed, mirror a copy of it onto gerrit [14:28:13] but honestly I find it sad that we maintain Gerrit and we still have p eople using the non-free github :/ [14:28:40] * aude personally likes gerrit :) [14:28:52] personally I do too ;p [14:29:14] but apparently github opens to a wider audience etc. [14:29:57] anyway, back to code review [14:32:00] DanielK_WMDE_: https://bugzilla.wikimedia.org/show_bug.cgi?id=57212 and https://bugzilla.wikimedia.org/show_bug.cgi?id=54320 appear to be the same? [14:33:13] (03PS7) 10Addshore: Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 [14:33:54] ty hashar :D all working :) [14:34:06] ty for the verification! [14:36:02] (03CR) 10Addshore: "Will address the copy and paste from system tests in a followup" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [14:47:24] (03CR) 10Aude: [C: 04-1] "I am still getting JS errors." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [14:47:28] DanielK_WMDE_: ^ [14:52:07] (03PS1) 10Addshore: Remove copied code in system tests [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/96261 [15:04:27] DanielK_WMDE_: Hi! If you have time, could you have a look to https://gerrit.wikimedia.org/r/#/c/91619/ , please? it solve an issue related to ContentHandler facility in Proofread Page. [15:21:22] (03PS1) 10Henning Snater: Implemented RankSelector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96264 [15:27:23] (03PS2) 10Henning Snater: Implemented RankSelector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96264 [15:32:46] 100% coverage \o/ https://github.com/DataValues/Serialization Lets see if I can keep it this way whileimplementing all of the things [15:38:10] (03Abandoned) 10Hashar: Demonstration of bug 54264 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84741 (owner: 10Liangent) [15:43:58] MWException: Internal error in ApiBase::getParameterFromSettings: Boolean param groupbyproperty's default is set to '1'. Boolean parameters must default to false [15:44:00] grr [15:58:59] *sigh* [15:59:13] Henning_WMDE: can you comment on https://gerrit.wikimedia.org/r/#/c/94738/ how you want this to be resolved? [15:59:26] would it already be enough to use an empty string for unknown types [15:59:42] DanielK_WMDE_: not if you want it in the branch tomorrow [16:00:03] Need to take a look. [16:00:06] i suggest they be discarded in entity view like current behavior [16:00:24] then we investigate further possible steps [16:00:29] aude: could hack that in, i guess. [16:00:35] but it's... hacky. [16:00:45] DanielK_WMDE_: i don't think adjusting the js is horribly hard (i looked) [16:00:59] but might be more complicated to do it *right* [16:01:17] aude: on an unrelated note: do you recall where to request a new labs project? [16:01:26] wikitech wiki [16:02:21] aude: yea... where, though? [16:02:43] ah - https://wikitech.wikimedia.org/wiki/Special:FormEdit/New_Project_Request ? [16:02:46] that looks odd... [16:03:23] how many students, how much do they need? [16:03:31] related to wikidata? [16:04:30] https://wikitech.wikimedia.org/wiki/Special:FormEdit/New_Project_Request for new projects [16:04:57] or depending on scope, might be able to add them to the existing wikidata project [16:05:51] DanielK_WMDE_: henning is too busy to look at entity view right now [16:06:14] i suggest either preserve existing way to handle deleted properties or wait until next week [16:09:42] * jeblad shakes his ass and walks through the channel [16:11:33] (03PS3) 10Daniel Kinzler: (bug 54320) Allow service injection into serializers. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 [16:17:51] addshore: poke poke poke [16:17:54] https://github.com/wmde/Serialization/pull/3 [16:37:34] aude: i hacked it to drop "missing" entities. took me forever to fix the tests :/ [16:37:39] running tests now, will then push [16:37:50] hm, already got an E [16:38:45] :/ [16:40:15] ERROR in Wikibase\Test\Api\RemoveReferencesTest::testRequests: [UsageException] Could not find the claim [16:40:17] o_O [16:40:20] seems unrelated... [16:42:00] (03PS4) 10Addshore: Allow id and type params in wbeditentity data! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 [16:42:01] (03PS6) 10Addshore: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 [16:42:02] (03PS2) 10Addshore: Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 [16:42:03] (03PS7) 10Addshore: Cleanup GetEntities ItemByTitleHelper and others [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 [16:42:04] (03PS7) 10Addshore: Cleanup of ClaimModificationHelper and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95125 [16:42:05] (03PS15) 10Addshore: Refactor Api Output to use ResultBuilder Pt1. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 [16:42:32] when will software go live next ? [16:42:44] regular updates will do [16:43:51] oh, i think i need to rebase to get your WikiPage reset patch, katie [16:43:57] DanielK_WMDE_: hmmmmm [16:44:01] do that [16:44:05] it sounds familiar [16:44:20] (03PS9) 10Daniel Kinzler: (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 [16:44:36] (03PS10) 10Daniel Kinzler: (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 [16:48:44] (03CR) 10jenkins-bot: [V: 04-1] Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [17:11:25] (03PS3) 10Addshore: Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 [17:13:14] DanielK_WMDE_: looking at your patch [17:17:29] (03PS4) 10Addshore: Enhance api messages for bad wbeditentity data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94776 [17:17:35] (03CR) 10Daniel Kinzler: [C: 031] "Looks good, but perhaps someone would like to test this manually, with a bit of Lua code?..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 (owner: 10Jens Ohlig) [17:25:07] (03CR) 10Aude: [C: 032] "looks good and fixes the issues found previously" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [17:28:37] (03Merged) 10jenkins-bot: (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [17:30:13] addshore: http://stackoverflow.com/questions/20078008/especting-a-variable-list-of-arguments-in-phpunit [17:30:19] upvote! [17:30:41] JeroenDeDauw: typo in the 4th word ;p [17:31:10] JeroenDeDauw: typo in the thrid line last work [17:31:12] *word [17:31:20] framrwork :) [17:31:26] adapter [17:31:31] and framework ;p [17:31:43] -1 [17:31:48] -2 [17:32:53] =-3 [17:34:44] nah, typo in the first word! [17:34:45] Especting [17:36:02] [travis-ci] wmde/Serialization#17 (2.1 - 4e77f36 : addshore): The build passed. [17:36:02] [travis-ci] Change view : https://github.com/wmde/Serialization/compare/2.1 [17:36:02] [travis-ci] Build details : http://travis-ci.org/wmde/Serialization/builds/14208983 [17:38:04] lazowik_: so is this now -4 or -5? [17:38:18] wow, missed the first word :P [17:38:34] lazowik_: for some reason he was using a canadian dictionary :D [17:39:01] JeroenDeDauw: certainly votes -> ∞ [17:39:09] :D [17:39:14] Magnus is wonderful ... look what he did on the Reasonator ... http://tools.wmflabs.org/reasonator/?q=350 [17:47:31] addshore: I can haz 0.009958662157083803 BTC? [17:47:38] :O [17:47:51] = 5.3/532.2 [17:48:18] http://bitcoinity.org/markets/mtgox/EUR [17:48:39] http://bitcoinity.org/markets/btce/EUR [17:48:59] 0.01144955713977101 [17:49:19] addshore: 1E9neVhwkrtwKtL2gAFqEvSRME4UWJ3VWk [19:20:45] (03PS1) 10Jeroen De Dauw: Initial step in moving out code from SimpleQuery special page [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/96300 [19:22:15] (03PS2) 10Jeroen De Dauw: Initial step in moving out code from SimpleQuery special page [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/96300 [19:24:01] (03PS1) 10Addshore: Fix RdfSerializer class phpdoc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96301 [19:24:50] (03PS1) 10Addshore: Fix phpdoc for RdfBuilder class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96302 [19:25:21] aude: addshore: ALL of the noise! [19:25:39] * aude rage! [19:26:56] ping pong ping pong [19:28:36] (03PS1) 10Addshore: Fix case where = should be === [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96303 [19:28:37] aude ^^ ;p [19:28:44] you were the last person to touch that ;p [19:29:49] huh [19:30:12] wtf [19:30:16] :D [19:30:41] (03CR) 10Aude: [C: 032] Fix case where = should be === [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96303 (owner: 10Addshore) [19:37:13] (03PS1) 10Addshore: Cleanup MultiLangConstraintDetector Class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96304 [19:37:15] aude: would be greatful if you could +2 the above too ;p [19:37:28] (03Merged) 10jenkins-bot: Fix case where = should be === [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96303 (owner: 10Addshore) [19:37:51] gah [19:37:56] [= [19:38:03] just think of the choclate! [19:38:11] (03CR) 10Aude: [C: 032] Cleanup MultiLangConstraintDetector Class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96304 (owner: 10Addshore) [19:38:13] :) [19:38:14] [= [19:42:36] I could make such patchs all night ;p [19:46:18] addshore: aude: go home! :P [19:46:28] IM trying to find stuff for google code in ;p [19:46:31] (03Merged) 10jenkins-bot: Cleanup MultiLangConstraintDetector Class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96304 (owner: 10Addshore) [19:46:48] just about to go through our easy / need volunteer bugs [19:46:50] addshore: ah cool - where are you looking? [19:46:50] :D [19:46:51] ah [19:46:52] perfect [19:47:11] i don't think we have more than 3 easy ones [19:47:18] I was looking at the code but i just seem to want to fix anything I find :P [19:47:25] i never bothered with that because tbh nothing we do is as easy as easy should be [19:47:30] hehe [19:47:33] don't! :D [19:47:55] this is what growing the whole system is all about ;-) [19:47:58] we have a lot of need-volunteer :P [19:47:59] don't do everything yourself [19:48:06] hard thing to do though... i know [19:48:16] yeah we do but most of them are kinda hard i think [19:48:28] especially given how hard it still is to set up wikibase [19:48:41] well it probably got quite a bit easier wiht the single repo [19:48:45] but still [19:48:47] Lydia \o/ [19:48:52] hoo: \o/ [19:49:06] what are we \o/ing about? [19:49:07] vagrant! [19:49:07] :P [19:49:16] * hoo is looking forward to Friday... nothing specific, tbh :D [19:49:22] aude: yes yes yes - something for jens once he's taken care of lua :) [19:49:28] hoo: \o/ [19:49:31] me too [19:50:28] Lydia_WMDE: this is done? https://bugzilla.wikimedia.org/show_bug.cgi?id=54275 [19:50:47] addshore: nope [19:50:49] afaik [19:51:08] but there is a link to the wikidata item in the toolbox from wikipedia pages (unless I am reading the bug wrong) [19:51:16] yeha that is something else [19:51:24] this is about the toolbox on wikidata [19:51:31] oh.. [19:51:33] to link to the url with entity in it [19:51:45] i am not entirely convinced we need that but oh well [19:51:54] i am also not dead set against it [19:52:03] maybe that is a good one though for code-in [19:52:19] Speaking about bugs... we probably still need one for label fallbacks :/ [19:52:25] jep [19:52:27] we do [19:52:38] that is definitely not code-in material though ;-) [19:52:41] anyway, code-in can be small things such as refactoring some big methods and such, I just need to find such big methods :P [19:53:18] addshore: mh... these people could refactor hooks into hook handler classes maybe? [19:53:19] addshore: it also doens't have to be code - we could have them work on some of the wikibase tasks that are still left for the release [19:53:29] We still have a lot of static hook code (especially on client) [19:53:44] Lydia_WMDE: indeed and hoo probably :) [19:53:53] lua! [19:54:01] help improve lua modules [19:54:13] aude: :D That's my job (partly) [19:54:23] well, it's a big job [19:54:28] with lots of small tasks [19:54:38] I like this one :D http://www.google-melange.com/gci/task/view/google/gci2013/4899257920258048 [19:55:08] Indeed... I'm happy to meet Jens this weekend also... there are some things I want to talk about with him... writing good Lua code seems rather hard [19:55:33] probably I'm just thinking to PHP/C++ish here :P [19:55:39] hoo: so would you like to review patches jens has in gerrit for lua? [19:55:46] aude: I could do that, I guess [19:55:57] * aude struggles to test it and really be good at lua [19:55:59] Capiunto is supposed to be used with Wikibase one day ;) [19:56:11] i need to sit down someday and learn it better [19:56:11] hehe http://www.google-melange.com/gci/task/view/google/gci2013/5809943458349056 [19:56:47] aude: There are some good ebooks out there... it's like a big mix of all the other languages I've learned before :D [19:57:00] yep [19:58:23] Lydia_WMDE: When will you two (Jens and you) arrive in Karlsruhe? Will you already be there on Friday at about 3pm? [19:58:34] hoo: friday at 4 i think [19:58:58] and leave at 2 on sunday [19:59:35] Ah fine :) I guess I'll have a deeper look at the Capiunto state with Jens then [19:59:48] ok [19:59:54] Ok, I'll probably be there longer... just about 90km from here :) [20:05:40] (03PS1) 10Addshore: Fix code that is lying to us! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96316 [20:07:33] addshore: lol [20:09:40] it is! :P [20:09:47] its all lies [20:09:59] addshore: Is it really necessary to use smth, when we don't really use it (only reference it in comments) [20:10:05] If that's wanted, I'm ok with it, ofc [20:11:39] Well essentially the use is only there to make sure it is loaded, it depends which bit of the comments your talking about. Naturally if your using the class name with the @param tag that generlaly means this should have loaded the class! [20:13:31] Hmm, I wonder if a special page for wbmergeitems counts as a code in project!!!! [20:14:08] that could be good one [20:15:03] I was going to say enabling the setsitelink special page to add badges but apparently there is already a patch on gerrit for that :P [20:15:15] oh, yes [20:17:14] im sure I will think of more for the morning [= [20:22:14] (03CR) 10Hoo man: "mh?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96316 (owner: 10Addshore) [20:23:11] (03CR) 10Hoo man: "I'm stupid... didn't see the namespace at the top... looks good... just waiting for the very slow jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96316 (owner: 10Addshore) [20:23:20] :D [20:24:13] mhmm, i have a patchset which speeds up the api tests to only 1 min! :P [20:24:17] rather than 2 [20:24:22] :D [20:24:40] but youll have to review the other 7 patches first ;p [20:24:47] * hoo hides very fast [20:28:11] :P [20:50:33] Is there an op for #wikimedia-wikidata in here? [20:50:50] rschen7754? ^ [20:50:58] Tiptoety: [20:51:00] :P [20:51:07] Hi, can I get +I please? [20:51:11] Apparently people need that now. [20:51:17] the whole channel got shut down [20:51:27] Oh. [20:51:33] Well, never mind then. [20:51:39] you still have local ops here though [20:52:04] Oh, right. I forgot about that. [20:52:14] the channel was moved over the weeknd [20:52:42] Yeah. [21:01:43] (03CR) 10Jeroen De Dauw: [C: 032] Fix code that is lying to us! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96316 (owner: 10Addshore) [21:04:24] (03CR) 10Jeroen De Dauw: [C: 032] Fix phpdoc for RdfBuilder class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96302 (owner: 10Addshore) [21:06:03] (03CR) 10Jeroen De Dauw: [C: 032] Fix RdfSerializer class phpdoc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96301 (owner: 10Addshore) [21:15:08] (03CR) 10Jeroen De Dauw: [C: 032] Refactor Api Output to use ResultBuilder Pt1. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 (owner: 10Addshore) [21:20:01] (03CR) 10Addshore: [C: 032] Initial step in moving out code from SimpleQuery special page [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/96300 (owner: 10Jeroen De Dauw) [21:20:05] (03CR) 10Addshore: [V: 032] Initial step in moving out code from SimpleQuery special page [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/96300 (owner: 10Jeroen De Dauw) [21:22:07] (03CR) 10Jeroen De Dauw: Cleanup GetEntities ItemByTitleHelper and others (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 (owner: 10Addshore) [21:22:10] addshore: ^ [21:22:39] (03CR) 10Addshore: "I am confused, there is a loop around line 67 that goes through and validates the snaks (the one that you have added.)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92299 (owner: 10Henning Snater) [21:25:52] (03CR) 10Addshore: Cleanup GetEntities ItemByTitleHelper and others (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 (owner: 10Addshore) [21:26:09] (03PS8) 10Addshore: Cleanup GetEntities ItemByTitleHelper and others [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 [21:26:27] (03PS8) 10Addshore: Cleanup of ClaimModificationHelper and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95125 [21:26:34] (03PS5) 10Addshore: Enhance api messages for bad wbeditentity data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94776 [21:28:37] (03CR) 10Jeroen De Dauw: [C: 032] Cleanup GetEntities ItemByTitleHelper and others [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 (owner: 10Addshore) [21:31:18] merge all the code! [21:34:12] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#89 (master - ec17b92 : jeroendedauw): The build has errored. [21:34:12] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/745b81f4265a...ec17b9226e41 [21:34:12] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/14219656 [21:35:03] :/ [21:45:25] (03PS1) 10Jeroen De Dauw: Update dependency versions [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/96376 [21:46:57] (03PS1) 10Jeroen De Dauw: Update dependency versions [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/96378 [21:47:19] addshore: ^ meeergeee, the second one first [21:48:31] (03CR) 10Addshore: [C: 032 V: 032] Update dependency versions [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/96378 (owner: 10Jeroen De Dauw) [21:50:20] (03CR) 10Jeroen De Dauw: [V: 032] Cleanup GetEntities ItemByTitleHelper and others [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 (owner: 10Addshore) [21:51:31] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQueryEngine#100 (master - 313f8e3 : Addshore): The build has errored. [21:51:31] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQueryEngine/compare/1a82ed6a75c5...313f8e3bdbd4 [21:51:31] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQueryEngine/builds/14221163 [21:52:04]