[00:10:33] https://pl.wikipedia.org/w/index.php?title=Specjalna%3ASzukaj&search=Valerie&fulltext=1 [03:00:54] https://bitbucket.org/metabrainz/musicbrainz-server/pull-request/557/mbs-6239-where-available-use-wikidata [03:01:06] a bit late, but I just found that [03:01:09] pretty cool :D [06:33:10] good morning [07:15:18] GerardM-: woah! [07:15:32] :) [07:15:39] ok i have to say i was already surprised about itwp [07:15:46] but a second big one within a day? [07:15:48] nice! [07:15:59] and, the software is localised as well ... did you notice ? [07:16:21] not yet [07:16:24] awesome [07:16:28] lazyktm: \o/ [07:16:49] :) [07:16:59] this went so smooth because of me having been to the CSS conference in Modra [07:17:21] sweet [07:17:45] such events pave the way for new things [07:17:47] ohhhhh and since last nights deployment diff links in email notifications work again already [07:17:49] wohoooooooo [07:18:06] so far this week seems a bit too good to be true :P [07:18:15] (not complaining though!) [07:18:23] nah there is still half a week to come [07:18:31] haha [07:18:32] right [07:18:59] I expect that Indian Wikipedias will also start to adopt this [07:19:32] what we really want is support in Wikidata for this [07:19:46] yeah of course [07:20:10] it means that languages in incubator and languages that are not even in incubator have image search as well [07:21:12] on a different note ... I seem to remember that Magnus said that he could not retrieve Wikivoyage links in the same way as Wikipedia links ... is this correct ? [07:21:37] hmmmm it should work the same way - if not that's a bug [07:21:58] it should work the same way [07:22:12] might just be that all the pages havent been linked yet [07:22:28] if so it is trivial to add a Wikivoyage logo where applicable [07:22:46] it should be [07:22:49] Amsterdam IS linked [07:23:35] and with something trivial added there is another reason to celebrate and blog [07:23:49] :D [07:25:07] ok time to get ready to head to work and do some bug triage and planning for the next sprint [07:25:09] laters :) [07:26:14] I wonder how many people would get upset if I enabled that on enwiki. [07:27:04] oh [07:27:08] it loads external js [07:27:11] argh [07:30:49] I posted about it on the Wikimedia Language Engineering (the Facebook group) [07:31:29] lazyktm it loads js that is LOCAL to English Wikipedia .. you may want to play with that one line [07:31:53] GerardM-: i'm looking at importScriptURI("//tools.wmflabs.org/wikidata-todo/autodesc.js"); [07:32:12] ah [07:32:27] I leave it in your capable hands [07:32:30] i'm going to post on the talk page [07:32:45] I would like to enable this as a gadget on enwiki, and then when no one's looking, enable for everyone ;) [07:33:03] hmmm I want to do the telling [07:33:25] I very much, very very much want to do that telling [07:35:56] :D [07:36:07] https://en.wikipedia.org/wiki/MediaWiki_talk:Wdsearch.js#Don.27t_load_external_JS [07:37:18] those are blockers to deploying on enwiki [07:37:36] I'll try and fix those when I'm more awake if no one beats me to it [07:39:58] a lot of this would be sooo much easier with Gadgets 2.0 [07:41:54] good night [07:45:01] sleep well [08:35:59] Lydia_WMDE Tamil is the first Indian Wikipedia :) [08:59:59] GerardM-: :D [09:00:01] nice [09:24:08] (03PS7) 10Lydia Pintscher: Store serialized entity in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [09:24:16] (03CR) 10jenkins-bot: [V: 04-1] Store serialized entity in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [09:41:51] (03PS5) 10Henning Snater: Reset claimgroup when cancelling edit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98819 [09:52:16] (03PS1) 10Henning Snater: ByPropertyIdArray: Improved remove mechanism [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99058 [09:52:19] (03CR) 10jenkins-bot: [V: 04-1] ByPropertyIdArray: Improved remove mechanism [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99058 (owner: 10Henning Snater) [09:52:54] :/ [09:54:10] someone care to merge https://gerrit.wikimedia.org/r/#/c/98794/ Tobi_WMDE aude ? [09:56:25] addshore: looking :) [09:56:46] (03PS2) 10Henning Snater: ByPropertyIdArray: Improved remove mechanism [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99058 [09:56:57] (03CR) 10Lydia Pintscher: "Is this still needed then or can it be abandoned and the bug closed?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94585 (owner: 10Yuvipanda) [09:58:17] (03CR) 10Addshore: "This is still needed [=" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94585 (owner: 10Yuvipanda) [09:58:26] :) [09:59:13] (03PS17) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [10:14:44] (03PS6) 10Henning Snater: Reset claimgroup when cancelling edit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98819 [10:26:21] (03CR) 10Addshore: [C: 04-1] "Apparently needs a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [10:27:52] addshore: do you have your items in the "Item" namespace? [10:28:00] yup [10:28:08] so does jenkins and travis apparently. [10:28:20] testAddEntityRevision in result builder depends on settings [10:28:36] * addshore goes to look [10:28:37] and fails for me because my items are in main namespace [10:29:00] * aude notes to change jenkins settings [10:30:18] aude: whats the error it fails with? :) [10:30:45] the expected title is Qxxx [10:30:50] errr actual [10:30:54] ahhhh [10:30:55] it expects Item:Qxxx [10:31:13] also expected ns is different [10:31:17] obviously [10:31:39] i suppose you need to figure out which globals to set in setUp [10:31:45] or another solution, perhaps [10:32:00] hmmm, I thought I injected mock things, will take a look today [10:32:15] mock stuff is fine, although not sure about mock title [10:32:24] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [10:34:13] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [10:35:26] (03CR) 10Aude: [C: 04-1] "I get some test failures on Wikibase, with this change applied." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99058 (owner: 10Henning Snater) [10:36:36] heh aude, I love the way on line 105 there is just an empty todo :P [10:37:03] heh [10:40:43] (03CR) 10Aude: [C: 032] Refactor Api LangAttributes to Terms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98794 (owner: 10Addshore) [10:44:07] (03Merged) 10jenkins-bot: Refactor Api LangAttributes to Terms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98794 (owner: 10Addshore) [10:46:28] (03PS1) 10Aude: Utilize rc_source column in client recent changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99065 [10:47:39] (03CR) 10Aude: "this class is due for refactoring, however this is a very simple change to use the new column. sooner we use the column, the better :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99065 (owner: 10Aude) [10:47:43] addshore: ^ [10:47:47] easy chocolate [10:54:30] (03CR) 10Tobias Gritschacher: [C: 032] (bug 57588) Scientific notation for quantities. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97907 (owner: 10Daniel Kinzler) [10:54:38] aude: varbinary(16) might be a bit small if we end up with soemthing worse than wikibase:wikidatawiki [10:55:07] (03Merged) 10jenkins-bot: (bug 57588) Scientific notation for quantities. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97907 (owner: 10Daniel Kinzler) [10:55:17] \o/ [10:55:38] hmmm [10:59:41] DanielK_WMDE_: how about just 'wb'? [11:00:16] when we have multiple repos, maybe wb.d (interwiki prefix) [11:01:25] (03PS2) 10Aude: Utilize rc_source column in client recent changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99065 [11:01:39] aude: looking at what core puts into that column, perhaps we'd be using something like wb.new/d [11:02:00] hmmm [11:02:45] or perhaps better: wb/d.new, wb/d.edit, etc [11:03:16] depends on what we want to filter by [11:03:31] not sure about using a slash [11:03:45] flow puts "flow" [11:03:51] whatever, could just as well be : or # or + or whatever [11:03:53] aude: does it really make sense to jsut put "wikibase" there now? [11:03:56] not that we should follow their example [11:04:07] "wb" is fine [11:04:19] we just want to distinguish wikibase from flow [11:04:24] or core changes [11:04:25] right [11:04:35] not sure we want more complex filtering [11:04:58] once we have wikibase changes, then we use info in rc_params to do stuff [11:05:27] in the future, distinguishing multiple wikibase repos will be important [11:05:32] and is appropriate for rc_source [11:07:41] (03CR) 10Tobias Gritschacher: [C: 032] Reset claimgroup when cancelling edit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98819 (owner: 10Henning Snater) [11:07:49] aude: got a bunch of errors when running the notification jobs: http://pastebin.com/SrqUSP9y [11:07:58] huh [11:08:49] worked fine for me, so that's odd [11:11:03] aude: well, it did work. just complained a lot. [11:11:11] (03Merged) 10jenkins-bot: Reset claimgroup when cancelling edit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98819 (owner: 10Henning Snater) [11:11:19] aude: might just be broken crap in the database. trying with fresh data now [11:11:24] no idea [11:12:21] hi, is there and admin to delete https://www.wikidata.org/wiki/Q1813022 ? It was a duplicate of https://www.wikidata.org/wiki/Q5243868 [11:12:32] DanielK_WMDE_: there have been some core changes relating to refresh links [11:12:37] not sure they are related, though [11:12:54] https://gerrit.wikimedia.org/r/#/c/98071/ [11:13:00] no issue here [11:14:01] hm, what i'm seeing in recentchanges now is completely wrong :( [11:15:52] ? [11:17:07] aude: still investigating. i'm still getting this one though, for fresh data: [11:17:09] PHP Notice: Undefined property: RefreshLinksJob::$mTitle in /var/www/daniel/wikidata/includes/job/jobs/RefreshLinksJob.php on line 100 [11:17:42] oh, the code looks wrong to me [11:17:51] might be a bug in core [11:17:58] i guess it is, yea [11:18:06] * aude makes patch [11:18:43] oh, my pull failed... maybe it's already fixed... [11:18:46] oh, in master, it looks fixed [11:18:53] $this->runForTitle( $this->title ); [11:19:00] vs $this->runForTitle( $this->mTitle ); [11:19:09] in https://gerrit.wikimedia.org/r/#/c/98071/ [11:19:16] eek [11:19:24] must have been fixed [11:19:59] https://gerrit.wikimedia.org/r/#/c/96199/ is a big pile of more changes [11:20:03] i guess so. works after pulling again. [11:20:31] (03PS1) 10Henning Snater: Filter events when moving $.wikibase.*view objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99069 [11:20:59] https://gerrit.wikimedia.org/r/#/c/98850/ : [11:21:00] :) [11:21:10] (03CR) 10Daniel Kinzler: [C: 032 V: 031] Utilize rc_source column in client recent changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99065 (owner: 10Aude) [11:21:21] \o/ [11:23:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1322 (master - 5d1efba : jenkins-bot): The build was broken. [11:23:13] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/574bfee6f41c...5d1efba01fa5 [11:23:13] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14917096 [11:24:25] why these random failures in travis? [11:25:52] (03Merged) 10jenkins-bot: Utilize rc_source column in client recent changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99065 (owner: 10Aude) [11:28:22] (03CR) 10Daniel Kinzler: [C: 031] "Looking good. Would +2, but for addshore's nitpicks." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [11:28:59] hello! getting "unresponsive script" errors on large items (eg Q80) [11:30:46] inductiveload: we're aware of that issue, see https://bugzilla.wikimedia.org/show_bug.cgi?id=54098 [11:31:16] great, just making sure it wasn't just me! [11:32:16] (03CR) 10Daniel Kinzler: [C: 04-1] "merge artifact messing with the logic" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 (owner: 10Addshore) [11:32:31] inductiveload: in general, chrome browser is more performant on these things, firefox sometimes throws these "unresponsive script" errors [11:34:23] i noticed that chrome tends to be a bit faster, but I like (or I want to like) firefox! [11:34:40] though firefox is doing its damndest to prevent me doing so... [11:35:21] chalk up another one for our evil corporate overlords [11:36:33] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1323 (master - 867abdc : jenkins-bot): The build is still failing. [11:36:33] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/5d1efba01fa5...867abdc57d36 [11:36:33] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14917727 [11:43:08] (03CR) 10Daniel Kinzler: [C: 04-1] "Special pages need entries in Wikibase.i18n.alias.php, otherwise Special:Specialpages will trigger this:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [12:05:05] (03CR) 10Daniel Kinzler: "documentation issues" (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [12:32:56] Lydia_WMDE_: http://lmgtfy.com/?q=coinbase [12:33:32] Tobi_WMDE: :P [12:36:38] (03PS18) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [12:37:26] (03CR) 10Aude: Introduce ChangeLineFormatter in the client (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [12:38:25] (03PS3) 10Tobias Gritschacher: (bug #56685) Parsing of localized decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 (owner: 10Daniel Kinzler) [12:38:45] (03CR) 10jenkins-bot: [V: 04-1] (bug #56685) Parsing of localized decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 (owner: 10Daniel Kinzler) [12:39:06] (03PS2) 10Tobias Gritschacher: (bug #56685) allow localized output of decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97778 (owner: 10Daniel Kinzler) [12:42:54] (03PS4) 10Daniel Kinzler: (bug #56685) Parsing of localized decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 [12:43:21] (03PS3) 10Daniel Kinzler: (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 [12:44:49] (03CR) 10Tobias Gritschacher: [C: 04-1] (bug #56685) allow localized output of decimal values. (032 comments) [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97778 (owner: 10Daniel Kinzler) [12:47:44] (03PS3) 10Daniel Kinzler: (bug #56685) localize quantities when formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 [12:48:07] (03CR) 10Daniel Kinzler: "PS3 is a rebase, fixes pending" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 (owner: 10Daniel Kinzler) [12:49:07] (03CR) 10Tobias Gritschacher: (bug #56685) allow localized output of decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97778 (owner: 10Daniel Kinzler) [12:49:33] (03CR) 10jenkins-bot: [V: 04-1] (bug #56685) localize quantities when formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 (owner: 10Daniel Kinzler) [12:53:25] (03CR) 10Tobias Gritschacher: [C: 032] (bug #56685) allow localized output of decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97778 (owner: 10Daniel Kinzler) [12:53:59] (03Merged) 10jenkins-bot: (bug #56685) allow localized output of decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97778 (owner: 10Daniel Kinzler) [13:01:56] (03PS1) 10Daniel Kinzler: Adding test case for MediaWikiNumberUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99081 [13:03:12] (03CR) 10Daniel Kinzler: "added test case in follow-up" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 (owner: 10Daniel Kinzler) [13:04:28] (03PS4) 10Daniel Kinzler: (bug #56685) localize quantities when formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 [13:04:37] (03CR) 10jenkins-bot: [V: 04-1] Adding test case for MediaWikiNumberUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99081 (owner: 10Daniel Kinzler) [13:05:07] (03PS2) 10Daniel Kinzler: Adding test case for MediaWikiNumberUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99081 [13:09:38] (03CR) 10jenkins-bot: [V: 04-1] Adding test case for MediaWikiNumberUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99081 (owner: 10Daniel Kinzler) [13:40:42] (03CR) 10Daniel Kinzler: [C: 031] "looks good now, want to do some manual testing." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [13:59:08] (03PS3) 10Henning Snater: ByPropertyIdArray: Improved remove mechanism [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99058 [14:17:20] (03CR) 10Addshore: [C: 04-1] Special page for wbmergeitems api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [14:19:31] (03CR) 10Addshore: [C: 04-1] ByPropertyIdArray: Improved remove mechanism (031 comment) [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99058 (owner: 10Henning Snater) [14:20:59] http://ultimategerardm.blogspot.nl/2013/12/tamil-does-wikidata.html [14:21:07] pfff [14:22:47] anyway ... I do not understand what is going on here [14:27:14] why can I not தமிழ் search on Wikidata when ta is the language of choice ? [14:27:27] (03PS3) 10Addshore: Add basic readme [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 [14:27:49] (03PS3) 10Addshore: implement MergeItemsUnitTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95645 [14:28:16] it IS the label for the Tamil language in Tamil so I SHOULD find it [14:36:39] (03PS4) 10Henning Snater: ByPropertyIdArray: Improved remove mechanism and added test [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99058 [14:37:26] (03PS5) 10Yuvipanda: Add sites parameter to API action=wbsearchentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94585 [14:42:12] (03CR) 10Addshore: [C: 04-1] "Still needs tests :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94585 (owner: 10Yuvipanda) [14:45:00] (03CR) 10Addshore: [C: 04-1] (bug #56685) Parsing of localized decimal values. (033 comments) [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 (owner: 10Daniel Kinzler) [14:45:16] [travis-ci] wikimedia/mediawiki-extensions-DataValues#298 (mw1.23-wmf6 - 88cb234 : daniel): The build passed. [14:45:16] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/mw1.23-wmf6 [14:45:16] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/14925535 [14:45:48] (03CR) 10Addshore: [C: 031] "Looks fine, Just have to wait for the dependancy!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99081 (owner: 10Daniel Kinzler) [14:46:25] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDataModel#136 (mw1.23-wmf6 - 99260c1 : aude): The build has errored. [14:46:26] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDataModel/commit/99260c171bcd [14:46:26] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDataModel/builds/14925541 [14:47:39] (03CR) 10Addshore: [C: 04-1] (bug #56685) Parsing of localized quantities. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 (owner: 10Daniel Kinzler) [14:48:08] [travis-ci] wikimedia/mediawiki-extensions-Diff#93 (mw1.23-wmf6 - b2bf353 : aude): The build passed. [14:48:08] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Diff/commit/b2bf3531f499 [14:48:08] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Diff/builds/14925547 [14:48:18] [travis-ci] wikimedia/mediawiki-extensions-DataTypes#49 (mw1.23-wmf6 - e6ae102 : aude): The build has errored. [14:48:18] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataTypes/commit/e6ae102447cf [14:48:18] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataTypes/builds/14925560 [14:48:32] * aude stab travis [14:48:35] (03CR) 10Addshore: [C: 04-1] (bug #56685) localize quantities when formatting. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 (owner: 10Daniel Kinzler) [14:48:52] Tobi_WMDE: around then? :) [14:49:18] it takes a minute for branches to be visible via composer [14:49:28] ;_; [14:49:28] so i think they are just not found [14:50:50] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1324 (mw1.23-wmf6 - e2d350c : aude): The build has errored. [14:50:50] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/e2d350c6fdb5 [14:50:50] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14925576 [14:51:06] (03CR) 10Addshore: [C: 032] ByPropertyIdArray: Improved remove mechanism and added test [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99058 (owner: 10Henning Snater) [14:51:21] (03Merged) 10jenkins-bot: ByPropertyIdArray: Improved remove mechanism and added test [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99058 (owner: 10Henning Snater) [14:51:25] \o/ [14:51:55] \o/ [14:52:09] aude: I cant push anything :/ [14:52:28] addshore: go to the gym and practice? [14:52:33] haha :P [14:53:57] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [14:55:23] * aude stuff is rotting :/ [14:56:15] indeed [14:57:07] we haz branches [14:57:34] if anything didn't make it in but needs to be in, let me know and we can backport [15:00:12] aude: thx! at least the remaining fixes for ordering and the patch to make ordering and ranks non-experimental have to go in. I tell you when they are ready [15:08:42] (03PS2) 10Henning Snater: Filter events when moving $.wikibase.*view objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99069 [15:11:17] heh, this is genuinly nothing for me to review any more in the wikibase repos :D [15:13:01] addshore: review matmarex's stuff in core :) [15:13:06] hah! [15:13:06] or hoo's stuff [15:13:13] :) [15:13:17] since they are kind to review our stuff sometimes [15:13:44] * aude needs to do more core review myself... maybe on weekend [15:17:01] (03CR) 10Aude: [C: 04-1] Add basic readme (032 comments) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 (owner: 10Addshore) [15:18:20] (03CR) 10Addshore: Add basic readme (032 comments) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 (owner: 10Addshore) [15:24:10] (03PS3) 10Henning Snater: Filter events when moving $.wikibase.*view objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99069 [15:26:26] (03CR) 10Jeroen De Dauw: Add basic readme (031 comment) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 (owner: 10Addshore) [15:27:45] Tobi_WMDE: https://github.com/DataValues/Serialization/pulls [15:28:41] DanielK_WMDE: revieww!!! https://github.com/DataValues/Serialization/pulls [15:29:28] JeroenDeDauw: you eman i have to actually understand the github workflow now? [15:31:14] (03CR) 10Addshore: Add basic readme (031 comment) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 (owner: 10Addshore) [15:37:21] JeroenDeDauw: added a comment. i think this is quite a bad idea. [15:52:47] (03CR) 10Daniel Kinzler: [C: 04-1] "I suppose the backend has to apply the same order normalization (sorting) before applying any index changes." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98888 (owner: 10Daniel Kinzler) [15:53:38] addshore: CR-1 just for spacing?.... [15:54:57] DanielK_WMDE: yeah [15:55:14] you don't like comments with no -1 or +1 [15:55:46] aude: true :) [15:57:37] (03PS4) 10Daniel Kinzler: (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 [15:58:14] (03Abandoned) 10Daniel Kinzler: Adding test case for MediaWikiNumberUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99081 (owner: 10Daniel Kinzler) [16:00:19] (03CR) 10jenkins-bot: [V: 04-1] (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 (owner: 10Daniel Kinzler) [16:00:43] (03PS5) 10Daniel Kinzler: (bug #56685) Parsing of localized decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 [16:00:56] (03CR) 10Daniel Kinzler: (bug #56685) Parsing of localized decimal values. (033 comments) [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 (owner: 10Daniel Kinzler) [16:05:45] DanielK_WMDE: It happens to me :D [16:12:38] (03CR) 10Addshore: [C: 032] (bug #56685) Parsing of localized decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 (owner: 10Daniel Kinzler) [16:13:02] (03PS5) 10Daniel Kinzler: (bug #56685) localize quantities when formatting. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 [16:13:24] (03Merged) 10jenkins-bot: (bug #56685) Parsing of localized decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 (owner: 10Daniel Kinzler) [16:13:50] (03PS5) 10Addshore: (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 (owner: 10Daniel Kinzler) [16:58:23] (03CR) 10Daniel Kinzler: [C: 032 V: 031] Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [16:58:50] (03PS9) 10Daniel Kinzler: Split ChangeHandler::getPagesToUpdate into new class with tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96384 (owner: 10Aude) [16:59:09] (03CR) 10Daniel Kinzler: [C: 032] "restoring CR+2 after rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96384 (owner: 10Aude) [17:06:53] (03CR) 10Daniel Kinzler: [C: 04-1] "code clarity issues" (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94585 (owner: 10Yuvipanda) [17:08:19] (03CR) 10Daniel Kinzler: "Do we have to use markdown? Github doe support limited mediawiki syntax, right? If we stuck to that, we could more easily copy the stuff f" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 (owner: 10Addshore) [17:30:20] * ugh pokes hoo [17:30:54] hey ugh :) [17:31:13] hello :) [17:31:17] wanna do some easy code review? :D [17:31:30] https://gerrit.wikimedia.org/r/#/c/97851/ and/or https://gerrit.wikimedia.org/r/#/c/97757/ [17:31:32] mh [17:31:57] I have these on my list, but not today, no... [17:32:33] okay :( [17:32:45] root@hoo vmstat [17:33:10] 18:32:42 up for a long time, 1 user, load average: 2.29, 2.19, 1.87 [17:33:14] while I only have on brain [17:33:18] * uptime, doh [17:33:25] anyway... overly busy today... :/ [17:34:45] you do everything as root? :P [17:35:17] nah, but you have to be root to see my personal (human) load :D [17:36:07] oh [17:36:08] hahaha [17:36:09] i get it [17:36:24] I think I broke my python [18:22:44] (03Abandoned) 10Daniel Kinzler: Sort statements in EntityView by rank. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98888 (owner: 10Daniel Kinzler) [18:23:00] Lydia_WMDE_: can you verify? https://bugzilla.wikimedia.org/show_bug.cgi?id=57666#c2 [18:23:08] Henning_WMDE: you too, perhaps [18:23:11] k [18:24:34] DanielK_WMDE: looks good to me [18:24:39] thx for writing it down [18:43:52] lolz [18:44:01] labs under ddos [18:44:10] no wd in plwiki search :( [18:48:35] lazowik: :( [18:48:41] Henning_WMDE: DanielK_WMDE: https://www.wikidata.org/wiki/Wikidata:Project_chat#Firefox_freezes_opening_an_item_in_a_new_tab [18:49:00] Lydia_WMDE_: https works though [18:49:09] only http is ddosed [18:49:25] Oo [18:57:10] Lydia_WMDE_: the backend performance improvements don't really impact time between receiving HTML and finishing executing JS. [18:57:18] there'S not much i can do regarding this on my end. [18:58:27] Lydia_WMDE_ does my bug make sense .... [18:59:35] GerardM: i guess only if more specific conditions can be identified [18:59:49] or at leaqst a specific point in time when this started to happen for a bug number of people [19:00:03] we need some basis for investiagtion [19:19:59] (03PS1) 10Daniel Kinzler: (bug 42992) reduce churn on wb_terms table. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99187 [19:34:53] does anyone know if the oauth extension needs any specifc rights to be registered for wikidata, or does it just work as is? [19:34:55] https://www.wikidata.org/wiki/Special:OAuth/grants [19:35:06] aude: , DanielK_WMDE^^ ? [19:35:38] i have no clue [19:36:41] dennyvrandecic: we actually define a whole bunch of special rights, but i don' think we are actualyl using them [19:37:10] i mean, they are just granted to "*" per default, and i'm not even sure they are checked consistently. [19:37:17] i guess we should get rid of them [19:37:19] Lydia_WMDE_: ---^ [19:37:21] but for the "usual" things, like setlabel, editentity, etc., edit right is probably sufficient and should work out of the box? [19:37:44] DanielK_WMDE: noted [19:37:45] what is missing is stuff like propertycreator and similar, i assume [19:37:52] dennyvrandecic: well, there *are* specific rights defined and maybe checked for these. but they default to "*", so can be ignored on our setup [19:38:04] ah, ok [19:38:17] maybe i should just try writing a small hello world oauth site :) [19:38:27] dennyvrandecic: rights are defiend in repo/Wikibase.php. Look for $wgGroupPermissions [19:59:36] dennyvrandecic: you need to apply for a token for your app (consumer) [19:59:52] aude: yeah, I know that part [19:59:59] k [20:00:20] I just wondered if wikibase and oauth are already playing well together, or if there is work left to do [20:00:30] they should be [20:00:40] * aude is trying it out on the weekend :) [20:01:04] aude: cool! please let me know the results! [20:01:11] sure [20:01:24] right now i have oauth talking to my test wiki [20:01:27] it works fine [20:02:00] (03PS36) 10Bene: Extend API to support editing badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [20:02:04] then i can make api requests with the token to do restricted actions like accessing a watchlist or editing on behalf of the user [20:03:21] aude: sweet. what i was wondering if this includes the wikidata-api modules usually [20:03:40] haven't tried yet [20:03:53] next thing to try :) [20:03:59] :) [20:05:29] (03CR) 10Bene: Special page for wbmergeitems api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [20:06:53] addshore: https://gerrit.wikimedia.org/r/#/c/82637 jenkins says yes to Bene \o/ [20:07:58] lazowik: Never trust something called Jenkins :p [20:08:15] (03PS1) 10Daniel Kinzler: (bug 57749) reduce churn on wb_items_per_site table. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99194 [20:11:11] (03PS5) 10Bene: Rename SpecialSetEntity to SpecialModifyTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 [20:14:22] (03PS7) 10Bene: (bug 46217) Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 [20:15:33] (03CR) 10Daniel Kinzler: [C: 031] "Looks good, but we need to make sure all the message keys and html element ids got renamed in the correct way, and the change doesn't brea" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [20:15:38] (03CR) 10Bene: "Ok, rebased, exception prevented and added more test cases. Anything more to do?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [20:17:40] JohnLewis: :p [20:18:05] addshore: reeeeeeevieeeeeew [20:19:02] (03CR) 10Daniel Kinzler: "Would be nice if it actually showed the number of sitelinks..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [20:21:48] (03PS8) 10Bene: (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 [20:23:04] (03CR) 10Daniel Kinzler: [C: 04-1] "This uses paging via OFFSET on a query that involves GROUP BY and JOIN, and has a potentially big result set (several million on wikidata." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [20:28:52] (03CR) 10Bene: "@Daniel #1: This is not really possible with the SpecialWikibaseQueryPage class. Is this feature really needed or could we create another " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [20:31:32] lazowik: i will review it either later today or tommorw [= [20:32:37] :) [20:32:40] k [20:35:39] (03CR) 10Daniel Kinzler: "@Bene: all that needs to be done is replacing the number "offset" in the field of SpecialWikibaseQueryPage with an array for field/value p" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [20:35:51] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [20:38:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1325 (master - 8ab0ed4 : Translation updater bot): The build is still failing. [20:38:34] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/867abdc57d36...8ab0ed4a6d13 [20:38:34] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14944533 [20:39:01] DanielK_WMDE: hi :) [20:39:18] what do you mean with "array for field/value pairs" ? [20:39:59] benestar: the offset would not be a number but something like array( 'item_id' => 'Q12345' ). [20:40:09] Meaning "Items with ID > 'Q12345'" [20:40:23] and how could this be used in EntitiesPerPage ? [20:41:24] benestar: actually, you need to use something you ordered by - so, the number of sitelinks, and *then* the entity id. paging on a ranked result is always pretty inefficient, not sure whether it can be helped :/ [20:41:43] benestar: in EntitiesPerPage? Just pass the values as individual parameters to your function. [20:41:49] hm... [20:41:51] so... [20:41:55] sorry, meant EntitesPerPageTable [20:42:02] yea, that [20:42:31] so something like 'WHERE ips_item_id > 123' ? [20:42:58] benestar: yea, in theory. but thinking about it, it's not going to work. it works only with whatever you used to sort your result by. [20:43:14] and since that'S a computed value, your paging will be inefficient, no matter what [20:43:22] so... keep using OFFSET, but limit it [20:43:34] so no offset greater than x ? [20:43:42] yea [20:43:47]