[00:11:00] legoktm: http://ultimategerardm.blogspot.nl/2013/12/the-tech-barnstar.html [00:54:47] :D [01:03:35] wikidata just confused me [01:03:51] I couldn't work out wtf interwikis were displaying on a page, but weren't in the article text [01:10:12] Reedy: gj [02:55:02] Lydia_WMDE_: I'm going to be taking a break from Wikidata for a while, as I've gotten back in the mood to do content creation at Wikipedia. Please ping me if you need any more mockups. I'm not /abandoning/ WD, just shifting foucs. [02:55:13] The rest of you, feel free to come get me if something is on fire. [05:29:00] (03CR) 10Bene: "The API module is merged now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [07:01:18] good morning [07:55:41] dennyvrandecic: ping [08:07:01] GerardM-: ping [08:07:32] hoi lbenedix [08:09:02] I'm searching the map of geolocations in wikidata created by denny: http://lbenedix.monoceres.uberspace.de/screenshots/items_map_small.png [08:09:22] I took this image from lydias slides from the metrics meeting [08:09:43] You know where the cool things about wikidata are ;) [08:11:47] I think it is on commons, but I cant find [08:14:52] Happy to be considered the person who knows these things . .. except I do not [08:16:48] :( [08:20:31] So I have to wait for dennyvrandecic and ask him directly [08:20:52] there is a WMF blogpost where it was mentioned [08:21:02] do you have a link? [08:21:46] http://tools.wmflabs.org/wikidata-analysis/map/map.html [08:22:18] this page does not load here... it makes my browser crash [08:22:54] I'm looking for the pngs he created with this script: https://github.com/vrandezo/wikidata-analytics/blob/master/geo2png.py [08:22:58] good morning Lydia_WMDE_ [08:23:22] map.png in the url should do it [08:23:30] and map_huge.png [08:23:35] GerardM-: good morning ;-) [08:23:51] great! [08:23:54] thx a lot [08:24:06] it was quite a night yesterday ... with labs having trouble, the search functionality suspended and back up again [08:24:33] I wonder why http://tools.wmflabs.org/wikidata-analysis/map_huge.png and http://tools.wmflabs.org/wikidata-analysis/map_small.png look sooooooo different [08:25:11] I understand that en,wp gets a page view for every Wikidata search ... [08:25:17] is that correct [08:25:24] because that will screw statistics [08:46:25] has anyone ever considered putting the wikipedia pages for languages the user speaks at the top of the list? [09:28:55] nikki [09:29:06] ? [09:29:07] what is your #Babel information [09:29:15] an example [09:29:29] https://www.wikidata.org/wiki/User:GerardM [09:29:41] that WILL put the languages on top of your page [09:29:44] I have that [09:29:58] but english is still in the middle of the list where I can't easily find it [09:31:37] given that Wikidata is not feature complete, that we cannot order statements in a meaningful way ... yeah it may be nice to have [09:32:02] .. did not consider that you actually were interested in the interwiki list [09:34:05] yeah, I meant the interwiki list [09:36:01] it already shows me labels/descriptions based on the languages I told it I speak, so it seems like it would also be able to put the wikipedia pages for the same languages at the top of the interwiki list [09:36:40] changing this would make it less useful when you are actually working on the interwikis [09:37:10] because with such an approach showing the other interwikis actually is not really useful [09:37:17] the columns are sortable if you really want them alphabetically [09:38:02] nikki: there's a gadget: Main language firs [09:40:52] aha, yes, exactly like that! thanks :D [09:44:34] np :-) [09:50:34] Lydia_WMDE_: when daily today? 15:00 is so late! ;p [09:51:03] JeroenDeDauw: let's do 14:30 because we have to leave at 15:00 [10:05:03] (03PS1) 10Henning Snater: Use explicit checks for setClaim's/setReference's index parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99343 [10:12:07] (03PS1) 10Henning Snater: Prevent "movetoolbar" initialization on pending claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99346 [10:15:44] Lydia_WMDE_: sorry! [10:15:48] i've been busy :/ [10:15:58] rschen7754: don't worry :) it happens [10:16:27] i've got another bug to report too [10:16:33] ok [10:16:35] which one? [10:16:45] GS and stewards who are not local admins cannot edit protected items [10:16:57] huh [10:17:01] oh I am local admin [10:17:24] ok [10:17:30] pirsquared17 was complaining about that the other day [10:17:35] *nod* [10:17:38] also, should use WikibaseDatabase [10:17:42] *i use [10:17:59] (03CR) 10Daniel Kinzler: "Thinking about this, it would probably be best to just record the number of sitelinks in the page_props table (bug 40157), and then query " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [10:18:02] for those bugs? no wikidata-repo [10:18:26] Lydia_WMDE_: got a minute? [10:18:30] * Lydia_WMDE_ hands rschen7754 a flower [10:18:32] DanielK_WMDE: jep [10:18:40] Lydia_WMDE_: what is it under? [10:18:42] ok, i'll come over [10:18:51] rschen7754: mediawiki extensions [10:19:08] ah, see it now [10:19:10] Lydia_WMDE_: for reference, https://bugzilla.wikimedia.org/show_bug.cgi?id=40157 and https://gerrit.wikimedia.org/r/#/c/94830/ [10:19:28] rschen7754: also as long as you file it in one of the wikidata parts of bugzilla don't worry - we'll see it and move if needed [10:19:58] (03PS1) 10Henning Snater: Improved reordering mechanics of ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99347 [10:20:11] (03CR) 10jenkins-bot: [V: 04-1] Improved reordering mechanics of ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99347 (owner: 10Henning Snater) [10:23:09] (03PS2) 10Henning Snater: Improved reordering mechanics of ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99347 [10:38:09] Lydia_WMDE_: https://bugzilla.wikimedia.org/show_bug.cgi?id=58030 [10:38:54] DanielK_WMDE: thx [10:43:29] addshore: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Access_of_the_full_precision_in_datetime_datatype <- if you could answer that'd be great [10:43:52] DanielK_WMDE: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Q14269834_is_deleted_but_do_not_appear_as_deleted_in_statements <- can you have a quick look please? [10:43:57] not urgent though [10:45:49] (03CR) 10Tobias Gritschacher: [C: 032] Improved reordering mechanics of ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99347 (owner: 10Henning Snater) [10:45:59] (03Merged) 10jenkins-bot: Improved reordering mechanics of ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/99347 (owner: 10Henning Snater) [10:49:16] DanielK_WMDE: is jenkins on holiday? [10:49:34] * aude wonders why my stuff is not merged [10:50:27] but jenkins is merging henning's stuff.... [10:51:36] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/98164/ [10:51:40] addshore: Tobi_WMDE: DanielK_WMDE: reviewwww https://github.com/wmde/AskSerialization/pull/1 [10:51:53] Henning_WMDE: thnx [10:52:03] aude: i guess it was asleep for a while last night, and needs to be re-triggered on changes that got stuck... [10:52:12] ok [10:55:24] (03CR) 10Aude: [C: 032] "already approved. retriggering jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [10:55:33] * aude waits [10:59:07] (03CR) 10Tobias Gritschacher: Module for interacting with Wikibase-API in browser tests (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 (owner: 10Tobias Gritschacher) [10:59:13] (03PS7) 10Tobias Gritschacher: Module for interacting with Wikibase-API in browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 [10:59:35] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] "Approved by zeljkof" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 (owner: 10Tobias Gritschacher) [11:01:08] (03PS4) 10Tobias Gritschacher: Include statement browsertests again on beta.wmflabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98172 [11:01:19] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Include statement browsertests again on beta.wmflabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98172 (owner: 10Tobias Gritschacher) [11:05:10] (03CR) 10Tobias Gritschacher: [C: 032] Filter events when moving $.wikibase.*view objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99069 (owner: 10Henning Snater) [11:05:13] Henning_WMDE: how do I run the tests? I'm htting Special:JavaScriptTest/qunit but nothing is happening there [11:05:20] (03CR) 10Tobias Gritschacher: [C: 032] Use explicit checks for setClaim's/setReference's index parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99343 (owner: 10Henning Snater) [11:05:26] Even though I have DataValues and ValueView loaded [11:05:27] (03CR) 10Tobias Gritschacher: [C: 032] Prevent "movetoolbar" initialization on pending claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99346 (owner: 10Henning Snater) [11:05:44] Tobi_WMDE: +2 ALL of the commits? [11:06:01] \o/ [11:07:52] stop flooding jenkins :) [11:09:00] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1328 (master - bb10795 : Tobias Gritschacher): The build was fixed. [11:09:00] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3704512263f5...bb107953272e [11:09:00] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14976229 [11:09:08] JeroenDeDauw: You have $wgEnableJavaScriptTest = true; in LocalSettings? You probably also need the related Wikibase change set for all tests to run properly: https://gerrit.wikimedia.org/r/#/c/98165/ [11:09:55] * aude need to overrule jenkins? [11:10:09] all the gate and submit tests pass [11:12:17] oh think i found a bug [11:12:29] (03Draft18) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [11:12:39] it got turned back into a draft! [11:12:42] (03Merged) 10jenkins-bot: Filter events when moving $.wikibase.*view objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99069 (owner: 10Henning Snater) [11:13:20] (03CR) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [11:13:34] (03CR) 10Aude: [C: 032] "already approved" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [11:15:14] (03Merged) 10jenkins-bot: Use explicit checks for setClaim's/setReference's index parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99343 (owner: 10Henning Snater) [11:17:03] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1329 (master - 5cab458 : Tobias Gritschacher): The build was fixed. [11:17:03] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/bb107953272e...5cab4587508f [11:17:03] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14976304 [11:17:40] (03Merged) 10jenkins-bot: Prevent "movetoolbar" initialization on pending claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99346 (owner: 10Henning Snater) [11:22:33] (03Merged) 10jenkins-bot: Split ChangeHandler::getPagesToUpdate into new class with tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96384 (owner: 10Aude) [11:22:34] (03Merged) 10jenkins-bot: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [11:22:38] yay [11:23:21] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1330 (master - b19e0d2 : jenkins-bot): The build was broken. [11:23:21] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/5cab4587508f...b19e0d244fbd [11:23:21] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14976742 [11:25:53] (03PS1) 10Aude: Improved reordering mechanics of ByPropertyIdArray [extensions/WikibaseDataModel] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99350 [11:26:01] (03CR) 10Aude: [C: 032] Improved reordering mechanics of ByPropertyIdArray [extensions/WikibaseDataModel] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99350 (owner: 10Aude) [11:26:13] (03Merged) 10jenkins-bot: Improved reordering mechanics of ByPropertyIdArray [extensions/WikibaseDataModel] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99350 (owner: 10Aude) [11:26:33] (03PS1) 10Aude: Filter events when moving $.wikibase.*view objects [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99351 [11:26:40] (03CR) 10Aude: [C: 032] Filter events when moving $.wikibase.*view objects [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99351 (owner: 10Aude) [11:26:53] (03PS1) 10Aude: Use explicit checks for setClaim's/setReference's index parameter [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99352 [11:27:00] (03CR) 10Aude: [C: 032] Use explicit checks for setClaim's/setReference's index parameter [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99352 (owner: 10Aude) [11:27:09] (03PS1) 10Aude: Prevent "movetoolbar" initialization on pending claims [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99353 [11:27:15] (03CR) 10Aude: [C: 032] Prevent "movetoolbar" initialization on pending claims [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99353 (owner: 10Aude) [11:29:06] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1331 (master - 5c4cf1c : jenkins-bot): The build was broken. [11:29:06] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/b19e0d244fbd...5c4cf1c8d608 [11:29:06] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14976849 [11:32:09] (03Merged) 10jenkins-bot: Filter events when moving $.wikibase.*view objects [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99351 (owner: 10Aude) [11:35:57] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1332 (master - bc439b1 : jenkins-bot): The build was broken. [11:35:57] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/5c4cf1c8d608...bc439b12502d [11:35:57] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14976925 [11:37:01] (03Merged) 10jenkins-bot: Use explicit checks for setClaim's/setReference's index parameter [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99352 (owner: 10Aude) [11:42:29] (03Merged) 10jenkins-bot: Prevent "movetoolbar" initialization on pending claims [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99353 (owner: 10Aude) [11:43:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1333 (master - 205b1f8 : jenkins-bot): The build was broken. [11:43:26] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/bc439b12502d...205b1f8bbdd5 [11:43:26] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14977105 [11:45:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1334 (mw1.23-wmf6 - 924dde2 : Henning Snater): The build has errored. [11:45:05] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/e2d350c6fdb5...924dde21e9c9 [11:45:06] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14977425 [11:46:56] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1335 (mw1.23-wmf6 - 738110f : jenkins-bot): The build has errored. [11:46:56] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/924dde21e9c9...738110fe414b [11:46:56] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14977611 [11:49:21] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1336 (mw1.23-wmf6 - fcaf3d1 : jenkins-bot): The build has errored. [11:49:21] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/738110fe414b...fcaf3d1126c5 [11:49:21] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14977866 [11:52:58] ... fyi http://panlex.org/people/ check out my name and affiliation [11:57:02] apparently travis / composer can't find diff [11:57:12] other than that things not broken [11:59:22] Tobi_WMDE: Lydia_WMDE_: this is very bad https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds [12:00:02] (03PS1) 10Addshore: Simplify item disambig i18n search message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99362 [12:00:32] (03PS1) 10Addshore: Fix ResultBuilderTest fail when items in ns 0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99363 [12:04:17] (03CR) 10Aude: [C: 032] Simplify item disambig i18n search message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99362 (owner: 10Addshore) [12:05:11] JeroenDeDauw: needs investigating why edit entity etc. fails [12:05:21] indeed bad [12:05:50] aude: we had the same already some weeks ago [12:06:04] addshore investigated and fixed it back then [12:06:05] * aude knows [12:06:20] and it's broken again apparently in random test runs [12:07:18] it was because some tests create properties or items with a defined ID (a pretty low one) and some other tests try to create entities with the same ID again.. (IIRC) [12:07:32] it depends in what order the tests run [12:07:44] for the branches, it would be nice for travis/composer to work but i'm not investigating it today [12:07:54] maybe tomorrow .... [12:08:00] (03Merged) 10jenkins-bot: Simplify item disambig i18n search message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99362 (owner: 10Addshore) [12:08:37] Tobi_WMDE: then the tests might not be cleaning up properly [12:08:53] * aude looks [12:10:28] aude: indeed [12:11:50] (03PS1) 10Henning Snater: $.ui.suggester: Added functionality to flip horizontal offset [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/99367 [12:12:04] (03PS1) 10Henning Snater: Ensure entityselector's suggestion list is assigned absolute position [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99368 [12:14:07] [travis-ci] wmde/AskSerialization#9 (master - 3653423 : Jeroen De Dauw): The build passed. [12:14:07] [travis-ci] Change view : https://github.com/wmde/AskSerialization/compare/a64fa5051862...3653423426b0 [12:14:07] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14979017 [12:14:13] DanielK_WMDE: meeergeeee https://github.com/DataValues/Serialization/pull/1 [12:15:20] Henning_WMDE: what is the test group I should run for testing your commit? [12:16:12] Henning_WMDE: ?filter=valueParsers ? [12:17:42] JeroenDeDauw: Yes, that should do it. [12:18:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1337 (master - b80db5b : jenkins-bot): The build is still failing. [12:18:19] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/205b1f8bbdd5...b80db5bf3b98 [12:18:20] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14978884 [12:20:18] (03PS1) 10Henning Snater: Taking "movetoolbar" out of experimental features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99370 [12:25:55] (03PS1) 10Aude: Set self::$hasSetup = true earlier during EditEntityTest setUp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99371 [12:34:08] (03PS2) 10Henning Snater: Taking "movetoolbar" and "rankselector" out of experimental features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99370 [12:42:58] Henning the patch for the pasting problem ... I have also learned that by changing the search engine this problem goes away as well ... can you confirm this ? [12:47:49] (03PS3) 10Henning Snater: Taking "movetoolbar" and "rankselector" out of experimental features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99370 [12:51:07] aude: Tobi_WMDE random tests failing? :D [12:51:10] link? :) [12:53:31] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Taking "movetoolbar" and "rankselector" out of experimental features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99370 (owner: 10Henning Snater) [12:53:52] Henning_WMDE: https://www.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js [12:54:12] GerardM-: What do you mean by changing the search engine? The bug appears to be a problem with the styles - or the loading order of the styles. [12:55:14] the problem I posted is about searching in Tamil.. it turns out that changing to the new search engine has the problem go away [12:56:20] (03PS1) 10Tobias Gritschacher: Taking "movetoolbar" and "rankselector" out of experimental features [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99378 [12:57:12] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Taking "movetoolbar" and "rankselector" out of experimental features [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99378 (owner: 10Tobias Gritschacher) [12:57:17] GerardM-: Okay, no, that is not related... The problem is front-end exclusive. [12:58:01] ok .. is it possible to specify the search engine when using the API ? [13:01:26] addshore: on travis [13:01:31] https://gerrit.wikimedia.org/r/#/c/99371/ to potentially fix [13:01:36] will take a look :) [13:01:42] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds [13:03:03] GerardM-: Not sure, maybe aude knows. [13:03:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1339 (mw1.23-wmf6 - 6845dc4 : Henning Snater): The build has errored. [13:03:43] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/fcaf3d1126c5...6845dc43be59 [13:03:43] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14980717 [13:05:15] * aude doesn't know [13:05:23] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1338 (master - feb49f1 : Tobias Gritschacher): The build was fixed. [13:05:23] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/b80db5bf3b98...feb49f1b2913 [13:05:24] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14980566 [13:05:44] Henning_WMDE: I am fine with your commit if you take care of this DataValue instance vs DataValue type issue [13:05:53] aude: it isnt editentity that is failing :P [13:06:05] addshore: it is [13:06:15] Wikibase\Test\Api\BotEditTest::testBotEdits with data set #10 [13:06:19] JeroenDeDauw: Okay, thanks. Will do! [13:06:34] Wikibase\Test\Api\EditEntityTest::testEditEntity [13:06:44] maybe multiple stuffs [13:06:52] yes, but that has nothing to do with the editentitytest class [13:06:52] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/14976931 [13:07:27] aude: ^^ should fix it [13:07:30] (03PS1) 10Addshore: Set isSetup in botEditTest class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99382 [13:07:31] ^^ [13:08:32] * aude turns blind eye to whitespace :P [13:08:39] wait ill do a PS2 [13:08:40] [= [13:08:49] you didn't introduce it [13:09:15] I was going to do more cleanup too [= [13:09:21] k [13:09:25] [travis-ci] wmde/AskSerialization#10 (master - 8e14e62 : Jeroen De Dauw): The build has errored. [13:09:26] [travis-ci] Change view : https://github.com/wmde/AskSerialization/compare/3653423426b0...8e14e62836f5 [13:09:26] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14981039 [13:11:20] (03PS2) 10Addshore: Set isSetup in botEditTest class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99382 [13:11:21] aude ^^ :) [13:12:04] (03CR) 10Addshore: [C: 04-2] "Uneeded change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99371 (owner: 10Aude) [13:12:06] (03CR) 10Aude: [C: 032] Set isSetup in botEditTest class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99382 (owner: 10Addshore) [13:12:19] addshore: well, let's see if that fixes everything [13:12:25] hopefully :) [13:12:26] * aude not totally convinced [13:12:31] * addshore is ;p [13:12:34] think there might be multiple issues [13:12:47] indeed, but thats the only test that seems to be failing :) [13:12:59] not that i see [13:13:20] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/14976931 [13:13:24] looks pretty unrelated [13:13:32] Wikibase\Test\Api\SearchEntitiesTest::testSearchEntities with data set #0 (array('berlin', 'en'), array('Berlin')) [13:13:33] UsageException: Could not create a new page [13:13:36] interesting [13:13:42] yeah [13:13:52] only on travis which runs stuff in parallel [13:13:57] [travis-ci] wmde/AskSerialization#11 (firstrel - ecb832f : jeroendedauw): The build has errored. [13:13:57] [travis-ci] Change view : https://github.com/wmde/AskSerialization/commit/ecb832f9759b [13:13:57] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14981178 [13:14:05] travis runs things in parallel? O_o [13:14:10] no idea [13:14:18] addshore, aude: i'm working on it [13:14:20] hopfully not or else our api tests should always fail [13:14:25] DanielK_WMDE: ? [13:14:31] addshore: not the phpunit tests part of a single build [13:14:34] addshore, aude: the problem is EditEntityTest saving entities with fixed ids [13:14:36] PHPUnit does not support this yet [13:14:40] which conflict with ids uses in other tests [13:15:01] DanielK_WMDE: EditEntity api test or the other editentity? [13:15:18] DanielK_WMDE: that would "fix" this but not convinced it's a great solution [13:15:31] better yet would be the tests do cleanup [13:16:04] if it is conflicting hardcoded ids causing the problem and you know where they are just make them large random number [13:16:07] *numbers [13:16:15] easy fix [13:16:25] indeed [13:16:44] lazy [13:16:44] * [13:16:46] usually its not the api tests that are wrong, but something else somewhere breaking them :P [13:16:49] (03Merged) 10jenkins-bot: Set isSetup in botEditTest class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99382 (owner: 10Addshore) [13:19:00] addshore: the api one [13:19:25] ahh, the badges stuff? [13:19:32] aude: a full database reset after each test would be best, btu would make test even slower than they already are [13:19:46] aude: the solution is to never use fixed ids in tests. [13:19:51] i'm working on implementing this [13:19:56] getting different errors now :) [13:19:58] [travis-ci] wmde/AskSerialization#13 (firstrel - a7999e4 : jeroendedauw): The build passed. [13:19:58] [travis-ci] Change view : https://github.com/wmde/AskSerialization/compare/ecb832f9759b...a7999e4341ee [13:19:58] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14981382 [13:20:01] DanielK_WMDE: ok [13:20:12] use the next available id would be good too [13:20:17] indeed [13:20:58] or all test classes cleanup after themselves explicitly :P [13:21:01] * aude only objects to lazy fix [13:21:56] aude, addshore: yes, but that means a buch of "inject the actual id here" on the data coming from the providers. [13:22:03] that's kind of icky. but it works. sort of. [13:23:38] [travis-ci] wmde/AskSerialization#15 (rem - 1c2731b : jeroendedauw): The build passed. [13:23:38] [travis-ci] Change view : https://github.com/wmde/AskSerialization/commit/1c2731b6e227 [13:23:38] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14981513 [13:25:02] [travis-ci] wmde/AskSerialization#17 (master - 9a35fdb : Jeroen De Dauw): The build passed. [13:25:03] [travis-ci] Change view : https://github.com/wmde/AskSerialization/compare/8e14e62836f5...9a35fdb68d72 [13:25:03] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14981554 [13:25:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1340 (master - e1d46ff : addshore): The build was broken. [13:25:47] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/feb49f1b2913...e1d46ffe3215 [13:25:47] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14981357 [13:26:18] addshore: easy choloclate: https://github.com/wmde/AskSerialization/pull/3 [13:26:34] Wikibase\Test\EditEntityTest::testGetWatchDefault [13:26:35] huh [13:26:45] the other EditEntity [13:27:14] [travis-ci] wmde/AskSerialization#18 (remdep - 4e92d43 : jeroendedauw): The build passed. [13:27:15] [travis-ci] Change view : https://github.com/wmde/AskSerialization/commit/4e92d4341d83 [13:27:15] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14981662 [13:30:14] [travis-ci] wmde/AskSerialization#19 (remdep - b3b2988 : jeroendedauw): The build has errored. [13:30:14] [travis-ci] Change view : https://github.com/wmde/AskSerialization/compare/4e92d4341d83...b3b29882d16e [13:30:14] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14981870 [13:32:24] [travis-ci] wmde/AskSerialization#22 (1.0 - dd886e4 : Jeroen De Dauw): The build passed. [13:32:24] [travis-ci] Change view : https://github.com/wmde/AskSerialization/compare/1.0 [13:32:24] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14981924 [13:35:07] aude: easy fix would be to find all hardcoded ids in ests and nuke them ;p [13:35:30] Tobi_WMDE: did you recently say that rubymine now complains about double quotes in ruby files? [13:35:55] Tobi_WMDE: you can disable that in preferences-inspections-ruby-double quoted string [13:36:36] (03PS1) 10Daniel Kinzler: (bug 40157) store entity status in page_props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 [13:36:40] JeroenDeDauw: merged the pull req [13:36:42] (03CR) 10jenkins-bot: [V: 04-1] (bug 40157) store entity status in page_props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [13:37:07] looks like the service for reporting github stuff here has been broken for a while :/ [13:40:55] (03PS1) 10Aude: Some cleanup in EditEntityTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99389 [13:41:43] (03CR) 10Aude: "EditEntityTest needs quite a bit of attention. this only cleans up the most obvious stuff" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99389 (owner: 10Aude) [13:43:02] aude: you removed the @since but left the @ingroup :P [13:43:13] huh [13:43:35] heh, its a test so it doesnt need since! [13:43:50] (03CR) 10Addshore: [C: 032] Some cleanup in EditEntityTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99389 (owner: 10Aude) [13:44:21] whatever, put it back [13:44:41] mhhm, tests dont really need them :P [13:44:55] it's helpful to know how ancient the test is [13:45:09] although it's obvious just looking at the code [13:47:37] Tobi_WMDE: some selenium tests still use special pages to set stuff right? [13:48:14] addshore: yes. almost all of the tests which are not on cucumber yet [13:48:39] Im guessing changing the id's for certain input fields would break the selenium tests then? [13:48:54] if so what files do I need to look at to fix the selenium tests ? ;p [13:49:08] addshore: yes [13:49:23] addshore: depends on what you changed [13:49:33] Tobi_WMDE: see https://gerrit.wikimedia.org/r/#/c/98198/ [13:49:46] we should probably get a patch up to fix the selenium tests before merging it [13:53:32] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1341 (master - b1c6f6f : Addshore): The build is still failing. [13:53:32] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/e1d46ffe3215...b1c6f6f43096 [13:53:32] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14982512 [13:53:56] addshore: that would be in set_entity_ppage.rb [13:54:01] addshore: that would be in set_entity_page.rb [13:54:53] [= [13:55:04] addshore: from a short look I would say adjusting the ids in that file is everything [13:55:17] but please do it in the same change [13:55:38] yup [= [13:57:16] addshore: probably worth to also check set_sitelink_page.rb, set_label_page.rb, set_description_page.rb, set_aliases_page.rb [13:57:37] willdo [13:57:38] but as far as I can see none of these ids has changed [13:59:22] (03PS6) 10Addshore: Rename SpecialSetEntity to SpecialModifyTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [13:59:35] Tobi_WMDE: would be great if you could just run a few tests that use the special pages on that patch and see if they work :D [13:59:59] (03PS1) 10Daniel Kinzler: Fix ID conflicts in EditEntityTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99393 [14:00:09] addshore, aude: --^ [14:00:14] (03CR) 10Addshore: [C: 031] "PS6 updated the selenium tests that use these special pages." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [14:01:31] DanielK_WMDE: that code looks nice :D [14:01:34] (03PS2) 10Daniel Kinzler: (bug 40157) store entity status in page_props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 [14:02:40] Daily time? :D [14:04:10] (03CR) 10Aude: [C: 032] "looks good and works fine" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99393 (owner: 10Daniel Kinzler) [14:04:49] * aude hopes travis is happy [14:05:43] else we will have to do more digging! [14:05:56] yeah [14:06:01] good morning [14:06:27] hi aude [14:07:01] hi [14:07:16] (03CR) 10jenkins-bot: [V: 04-1] (bug 40157) store entity status in page_props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [14:08:18] i was wondering if daniel would want to look at my new attempt at configuration extension... [14:08:22] is he around? [14:08:45] https://www.mediawiki.org/wiki/Requests_for_comment/Json_Config_pages_in_wiki [14:08:51] think he left [14:09:05] should be around tomorrow [14:09:22] wow, europe is ahead of ny :) [14:09:49] (03Merged) 10jenkins-bot: Fix ID conflicts in EditEntityTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99393 (owner: 10Daniel Kinzler) [14:10:22] will try to catch him later than. And maybe i can bug him enough to get the new wikidata api as i described before ... if anyone has any spare cycles... [14:10:55] (03CR) 10Addshore: Special page for wbmergeitems api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [14:11:52] aude: no daily today? :O [14:15:57] addshore: nope [14:19:46] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1342 (master - 199af99 : jenkins-bot): The build is still failing. [14:19:46] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/b1c6f6f43096...199af9966573 [14:19:46] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14983552 [14:20:07] whaaat [14:20:42] get entities? [14:20:58] * aude also wonders why the client runs repo tests [14:21:57] ill see when they started failing [14:22:04] then we should be able to see the change that broke stuff [14:22:08] ok [14:24:49] https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/37ed06e87cc9...8d2ac53c886b [14:24:50] bingo [14:25:37] ill make a fix now, guess I could try something like daniel did at a later date :) [14:27:43] (03CR) 10Jeroen De Dauw: [C: 032] (bug 42992) reduce churn on wb_terms table. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99187 (owner: 10Daniel Kinzler) [14:29:18] (03PS1) 10Addshore: Use higher ids in SetReferenceTest to fix travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99399 [14:29:21] aude ^^ [14:29:36] (03CR) 10Jeroen De Dauw: [C: 032] (bug 57749) reduce churn on wb_items_per_site table. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99194 (owner: 10Daniel Kinzler) [14:30:55] (03CR) 10Nikerabbit: Simplify item disambig i18n search message (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99362 (owner: 10Addshore) [14:33:31] (03CR) 10Aude: [C: 032] "alright :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99399 (owner: 10Addshore) [14:34:04] addshore: https://gerrit.wikimedia.org/r/#/c/99362/1/repo/Wikibase.i18n.php [14:34:07] * aude missed that [14:35:00] haha, itwrapped it :P [14:35:12]