[00:01:27] (03PS3) 10Aude: Add test for EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99557 [00:07:53] (03PS12) 10Addshore: Allow id and type params in wbeditentity data! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 [00:08:22] finally got around to some followups! [00:08:44] (03CR) 10jenkins-bot: [V: 04-1] Allow id and type params in wbeditentity data! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 (owner: 10Addshore) [00:12:22] addshore: can you take a look at test.wikidata and see if you have any js issues? [00:12:30] will so in 2 ticks [00:12:33] * aude has caching issues [00:19:14] the js is fixed! [00:20:38] (03PS13) 10Addshore: Allow id and type params in wbeditentity data! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 [00:20:44] not fixed [00:20:56] fixed when looking at first page, broken on subsequent pages [00:21:49] broken in firefox now also [00:22:58] checking now [00:23:18] i think it's a bug, with order modules are loaded or dependencies defined [00:23:28] (03CR) 10jenkins-bot: [V: 04-1] Allow id and type params in wbeditentity data! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 (owner: 10Addshore) [00:23:28] dependency is mw.util which should be there [00:23:43] :/ [00:23:44] but maybe not loaded in time [00:27:43] (03PS1) 10Aude: Move jquery.valueview.experts.commonsmediatype to mediawiki resources, define dependency [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/99582 [00:27:52] * aude coding js! [00:27:58] well resource modules [00:30:18] (03CR) 10Aude: "error that i am seeing on test.wikidata" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/99582 (owner: 10Aude) [00:59:42] (03PS14) 10Addshore: Allow id and type params in wbeditentity data! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 [01:00:38] ! [01:14:00] legoktm: ! [01:35:01] (03PS8) 10Addshore: Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 [01:36:32] (03CR) 10jenkins-bot: [V: 04-1] Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [01:39:57] (03PS9) 10Addshore: Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 [01:41:27] (03CR) 10jenkins-bot: [V: 04-1] Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [01:48:57] (03PS10) 10Addshore: Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 [01:50:26] (03CR) 10jenkins-bot: [V: 04-1] Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [09:04:07] good morning [09:14:16] Lydia_WMDE_ can we talk about Gapminder [09:32:17] hello! i'm having a little trouble setting up a repo to work with WM Gerrit. You froods seem like you would know where your git towels are :-) When I do "git review -s", I get "Problems encountered installing commit-msg hook" and the process stops. [09:33:14] pastebin of "git review -sv" : http://pastebin.com/nuEzSzfy [09:38:23] inductiveload: Hi! I think you should try "git push gerrit HEAD:refs/for/master" with "gerrit" the name of the remote repository and "master" the name of the branch you want to push to. [09:38:41] GerardM-: yes we should talk but i have a few other things on my plate first [09:38:43] sorry [09:38:48] It's what I use because git review doesn't works well everytime [09:39:07] that is ok ... can you give me a guestimate ? [09:39:28] Tpt_: I don't think git review has set up the gerrit repo [09:39:44] git review -s hasn't done anything as far as I can tell [09:40:07] inductiveload: so use "git push gerrit HEAD:refs/for/master" [09:40:09] or do you mean just don't use review? [09:40:22] Yes it what I mean [09:40:34] just do "git push origin HEAD:refs/for/master" [09:40:41] sorry having a slow morning! [09:42:11] do the change id things work then? [09:42:25] yes [09:42:40] I think so [09:43:01] But I can't remind if a specific setup is needed. [10:00:39] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikibase.git/refs%2Fheads%2Fmw1.23-wmf6 [10:00:42] Lydia_WMDE_: [10:02:03] https://www.mediawiki.org/wiki/User:Aude/Deployments is important stuff [10:02:09] wmf6 [10:02:17] GerardM-: 3:30? [10:02:26] ok [10:02:42] PS have a potential way of doing this [10:03:32] https://gerrit.wikimedia.org/r/#/c/99582/ is effort to fix test.wikidata [10:55:25] hey there [10:55:40] hi [10:55:45] I found out some ContentHandler exceptions on Wikimedia cluster [10:55:50] Format json is not supported for content model javascript :D [10:55:59] probably related to proofread page [10:55:59] let me paste the full trace [10:56:07] ok [10:56:16] javascript, don't know.... [10:56:31] http://paste.debian.net/69656/ [10:56:57] basically a gadget .js file being edited with action=edit&format=json [10:57:01] hmmm [10:57:12] i think there is a patch for that [10:57:15] one sec... [10:57:44] https://gerrit.wikimedia.org/r/#/c/97835/ [10:57:48] believe that would fix [10:58:09] great [10:58:12] cherry pick https://gerrit.wikimedia.org/r/#/c/99518/ https://gerrit.wikimedia.org/r/#/c/99519/ [10:58:18] maybe DanielK_WMDE can review? ^ [10:58:19] hashar: Format json is *indeed* not supported for content model javascript [10:58:27] * aude can't +2 [10:58:45] yeah was just wondering whether the exception was known [10:58:51] seems so :-] thank you aude! [10:58:58] (and daniel for confirming) [10:59:18] sure [11:02:46] aude, hashar: as far as I can tell, this code just causes an MWException to be raised earlier, with less information. [11:03:00] does that actually improve the situation? [11:03:01] * aude looking at patch [11:03:17] line 796 of EditPage.php [11:04:08] confirm [11:06:33] so, that's a -1 [11:06:37] yeah [11:07:04] * aude was only aware of the patch and didn't look at it [11:07:22] * aude love EditPage! [11:54:25] (03PS3) 10Daniel Kinzler: (bug 40157) store entity status in page_props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 [12:12:56] https://gerrit.wikimedia.org/r/#/c/99582/ is effort to fix test.wikidata [12:13:56] merge it! [12:14:00] Henning_WMDE: ^ [12:14:10] reeeeeeeeevvvvvvvview! :) [12:14:35] if that doesn't fix it then i don't know what else to try [12:19:36] (03CR) 10Henning Snater: [C: 032] Move jquery.valueview.experts.commonsmediatype to mediawiki resources, define dependency [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/99582 (owner: 10Aude) [12:20:04] thanks! [12:20:13] (03Merged) 10jenkins-bot: Move jquery.valueview.experts.commonsmediatype to mediawiki resources, define dependency [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/99582 (owner: 10Aude) [12:21:11] (03PS1) 10Aude: Move jquery.valueview.experts.commonsmediatype to mediawiki resources, define dependency [extensions/DataValues] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99636 [12:21:25] (03CR) 10Aude: [C: 032] Move jquery.valueview.experts.commonsmediatype to mediawiki resources, define dependency [extensions/DataValues] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99636 (owner: 10Aude) [12:22:16] (03PS1) 10Daniel Kinzler: (bug 47135) Make row IDs use BIGINT. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99637 [12:23:58] (03Merged) 10jenkins-bot: Move jquery.valueview.experts.commonsmediatype to mediawiki resources, define dependency [extensions/DataValues] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99636 (owner: 10Aude) [12:35:36] (03CR) 10Daniel Kinzler: [C: 04-1] "test for error case?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 (owner: 10Addshore) [12:40:09] DanielK_WMDE: gave you new stuff to review [12:40:53] (03PS1) 10Tobias Gritschacher: Browsertests: wait for entity to load after page-reload [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99639 [12:45:40] Lydia_WMDE_: y are my points not under development? :( [12:47:31] JeroenDeDauw: wasn't sure whether release announcements count as "development". [12:47:41] don't care either way [12:48:12] DanielK_WMDE: these points are not about release announcements but about the dev work to release them [12:48:26] i'll sort it out later [12:48:45] Lydia_WMDE_: someone vanaliszed the document, and it totally was not m [12:48:47] e [12:48:53] :D [12:49:26] rage [12:49:43] (03CR) 10Jeroen De Dauw: [C: 031] (bug 47135) Make row IDs use BIGINT. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99637 (owner: 10Daniel Kinzler) [13:55:07] DanielK_WMDE: poke [13:55:32] we have a problem with property label lookup in the parser function, which i can't reproduce on mw1.23-wmf5 [13:55:35] Tobi_WMDE: [13:55:48] addshore: [13:56:07] i wonder if it's a caching issue and if so, exactly waht to do [13:56:44] * aude investigating [13:57:17] aude: TermPropertyLabelResolver is probably what you want to look at [13:57:21] yeah [13:57:24] it uses memcached [13:57:28] it uses shared cache [13:57:41] yes, per language [13:57:43] i have my test repo + client on wmf5 and can't reproduce [13:57:53] we can try changing cache key [13:57:55] * aude tries [13:58:13] sharing that cache isn't super-important [13:58:29] the cache is specific to version, though [13:58:32] it would have changed [14:00:43] if the version number in the cache key got bumped, yes [14:00:59] it gets bumped every branch / core version change [14:01:31] * aude tries to reproduce [14:02:49] $key = $this->repoWiki . '/Wikibase/CachingPropertyInfoStore/' . WBL_VERSION; [14:02:50] hah [14:03:14] wtf! [14:05:48] (03PS1) 10Aude: Use setting for property info table cache key [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99644 [14:06:02] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/99644/ [14:06:22] does that look sane? so the cache gets kicked each time we change versions [14:06:29] each deployment [14:06:41] errr [14:06:43] one sec [14:06:54] yeah [14:07:04] * aude thinks it helps [14:08:03] should do same thing in repo [14:08:03] (03CR) 10Daniel Kinzler: [C: 04-1] Use setting for property info table cache key (031 comment) [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99644 (owner: 10Aude) [14:08:08] huh? [14:08:25] ok [14:08:29] aude: looks good, the suffix should just look a bit different, for consistency [14:08:33] good find! [14:08:38] i hope that fixes [14:08:38] should fix this on master too [14:08:44] yes and in wmf6 [14:08:49] i'll do same for repo [14:09:05] loooks like i simply forgot this. samn [14:09:12] damn even [14:10:26] (03PS1) 10Aude: Use setting for property info table cache key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99645 [14:10:34] (03CR) 10jenkins-bot: [V: 04-1] Use setting for property info table cache key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99645 (owner: 10Aude) [14:10:34] DanielK_WMDE: ^ [14:10:39] gah, waht [14:10:47] do i have to update tests [14:10:57] oh stupid [14:11:08] (03Abandoned) 10Aude: Use setting for property info table cache key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99645 (owner: 10Aude) [14:11:13] we don't have tests for caching, i don't think [14:11:26] i just submitted to wrong branch [14:11:34] need to do clean cherrypick for master [14:12:38] aude: oh, found more stuff... [14:12:48] * aude nods [14:13:20] (03PS2) 10Aude: Use setting for property info table cache key [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99644 [14:13:54] (03CR) 10Daniel Kinzler: Use setting for property info table cache key (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99645 (owner: 10Aude) [14:14:00] aude: commented there anyway [14:14:04] k [14:14:40] thanks [14:16:02] (03PS3) 10Aude: Use setting for property info table cache key [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99644 [14:16:05] there [14:17:23] aude: looks good, waiting for jenkins [14:17:27] k [14:17:56] (03CR) 10jenkins-bot: [V: 04-1] Use setting for property info table cache key [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99644 (owner: 10Aude) [14:18:09] ok, i think data model is incompatible [14:18:15] * aude can try a patch for master [14:18:42] yea, master first, so we can see what jenkins sais [14:18:46] yeah [14:19:19] i think jenkins is the issue of some quantity thing not found [14:19:45] that would be in DV, not DM [14:20:25] yeah [14:23:07] git annoying [14:23:12] (03PS1) 10Aude: Use setting for property info table cache key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99647 [14:23:15] ok [14:24:58] (03CR) 10jenkins-bot: [V: 04-1] Use setting for property info table cache key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99647 (owner: 10Aude) [14:25:06] huh [14:25:25] oh [14:25:27] k [14:26:32] (03PS2) 10Aude: Use setting for property info table cache key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99647 [14:29:22] (03PS4) 10Aude: Use setting for property info table cache key [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99644 [14:32:29] * aude runnign tests on the branch [14:34:03] huh, jenkins is happy https://gerrit.wikimedia.org/r/#/c/99644/ [14:34:31] (03CR) 10Aude: [V: 031] "also ran tests myself on the branch and tested manually in the client" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99644 (owner: 10Aude) [14:35:04] DanielK_WMDE: ^ [14:37:08] (03CR) 10Daniel Kinzler: [C: 032] Use setting for property info table cache key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99647 (owner: 10Aude) [14:37:21] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#signature_property_problem [14:37:25] aude: you can merge the backports yourself i guess [14:37:38] got em [14:38:07] (03CR) 10Aude: [C: 032] "approved on master" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99644 (owner: 10Aude) [14:38:20] * aude prepares patch for reedy [14:38:35] aude: the description of the issue sonds like more than caching is wrong [14:38:42] could be [14:38:44] the label and the language code getting mixed up? wtf? [14:38:57] i cannot reproduce [14:39:08] not even on wikipedia? [14:39:16] also not on test2 though that has wmf6 [14:40:53] (03PS1) 10Aude: Use setting for property info table cache key [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99650 [14:41:02] (03CR) 10Aude: [C: 032] "approved on master" [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99650 (owner: 10Aude) [14:42:04] (03Merged) 10jenkins-bot: Use setting for property info table cache key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99647 (owner: 10Aude) [14:43:01] aude: the actual exception is constructed with the parameters swapped [14:43:04] hence the confusion [14:43:08] that's nto the cause of the error though [14:43:09] huh [14:43:18] * aude can fix [14:43:36] aude: PropertyParserFunctionRenderer, line 107 [14:43:49] new PropertyLabelNotResulvedException [14:43:51] k [14:45:09] aude: i'm still wondering what's causing the error [14:45:14] * aude too [14:45:15] (03Merged) 10jenkins-bot: Use setting for property info table cache key [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99644 (owner: 10Aude) [14:45:30] debug log might help [14:45:39] anyone around to enable this? [14:45:46] Reedy: [14:46:14] (03PS1) 10Aude: Fix order of parameters for PropertyLabelNotResolvedException [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99651 [14:48:53] (03Merged) 10jenkins-bot: Use setting for property info table cache key [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99650 (owner: 10Aude) [14:49:14] https://gerrit.wikimedia.org/r/#/c/99651/ is so trivial [14:49:41] (03PS1) 10Aude: Fix order of parameters for PropertyLabelNotResolvedException [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99652 [14:49:49] (03PS1) 10Aude: Fix order of parameters for PropertyLabelNotResolvedException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99653 [14:50:17] https://gerrit.wikimedia.org/r/#/c/99651/ anyone? [14:52:23] no one? [14:52:49] jenkins approves [14:53:16] DanielK_WMDE: aude: please one of you to review https://gerrit.wikimedia.org/r/#/c/96771/ - should be easy chocolate [14:53:25] Lydia_WMDE_: review https://gerrit.wikimedia.org/r/#/c/99651/ :) [14:53:31] * aude self merging in a minute [14:54:20] Lydia_WMDE_: i have no idea whjat the implications of this are [14:54:37] * aude neither [14:54:44] DanielK_WMDE: aude: who does? [14:54:56] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/96771/ [14:54:58] Lydia_WMDE_: siebrand? [14:55:03] 3. [14:55:04] 2. [14:55:16] 1..... [14:55:43] 0.5 [14:55:50] nobody? [14:56:03] (03CR) 10Aude: [C: 032] "trivial, jenkins approves" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99651 (owner: 10Aude) [14:56:07] ignore rules [14:59:25] (03Merged) 10jenkins-bot: Fix order of parameters for PropertyLabelNotResolvedException [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99651 (owner: 10Aude) [15:08:36] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1351 (master - e512132 : aude): The build is still failing. [15:08:36] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/d3cdc67c0041...e5121321d52f [15:08:36] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15041699 [15:13:58] (03PS1) 10Aude: Add debug points in term property label resolver [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99657 [15:16:30] (03CR) 10Aude: [C: 032] "just in case we need more debugging, this works fine and just in the branch" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99657 (owner: 10Aude) [15:19:58] (03Merged) 10jenkins-bot: Add debug points in term property label resolver [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99657 (owner: 10Aude) [15:21:39] ChrisJ_WMDE: are you the analytics guy? [15:24:41] (03CR) 10Aude: [C: 032] Fix order of parameters for PropertyLabelNotResolvedException [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99652 (owner: 10Aude) [15:26:50] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1353 (mw1.23-wmf6 - 2583639 : aude): The build passed. [15:26:50] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/6845dc43be59...2583639c28dc [15:26:50] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15042048 [15:27:28] \o/ [15:28:34] (03Merged) 10jenkins-bot: Fix order of parameters for PropertyLabelNotResolvedException [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99652 (owner: 10Aude) [15:36:40] (03PS1) 10Daniel Kinzler: (bug 45529) use composite indexes on wb_terms. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 [15:38:51] (03PS6) 10Tobias Gritschacher: (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 (owner: 10Daniel Kinzler) [15:38:54] (03PS6) 10Tobias Gritschacher: (bug #56685) localize quantities when formatting. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 (owner: 10Daniel Kinzler) [15:39:24] (03PS2) 10Daniel Kinzler: (bug 45529) use composite indexes on wb_terms. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 [15:41:18] (03PS1) 10Aude: add wikibase css class for parser function errors [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99662 [15:41:31] DanielK_WMDE: we might want that ^ [15:41:32] (03CR) 10Jeroen De Dauw: [C: 031] (bug 45529) use composite indexes on wb_terms. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 (owner: 10Daniel Kinzler) [15:41:48] (03CR) 10Daniel Kinzler: [C: 032] Add test for EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99557 (owner: 10Aude) [15:42:41] aude: should go into master too, don't you think? [15:42:51] (03CR) 10Daniel Kinzler: [C: 032] add wikibase css class for parser function errors [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99662 (owner: 10Aude) [15:42:51] if we like the css class, then backporting and matser too [15:42:56] * aude just on that branch [15:43:19] too late for pages parsed, and we really should rethink the error display / handling approach [15:43:19] there you go :) [15:43:28] errr, it goes in output page so probalby ok [15:43:47] well, we have to make it obvious when people used the wrong label for a property. that shouldn't be hidden... [15:43:58] true but maybe too obvious? [15:44:19] well, we can't do it inline. so it's either top of bottom, right? [15:44:19] (03PS1) 10Aude: add wikibase css class for parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99664 [15:44:28] Lydia_WMDE_: you are totally not 1337 anmoar :( https://www.ohloh.net/accounts/nightrose/kudos [15:44:32] bottom is better [15:44:32] but we could hide such errors for all anons, for example [15:44:34] would be okay [15:44:38] bottom will never be found :) [15:44:41] true [15:45:03] also, ONE THOUSAND ONE HUNDERD SEVENTY NINETH!!!!!!!!!11!!!one https://www.ohloh.net/accounts/jeroendedauw/kudos [15:45:04] (03CR) 10Aude: [C: 032] "trivial, already approved" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99664 (owner: 10Aude) [15:45:11] (03PS1) 10Aude: add wikibase css class for parser function errors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99665 [15:45:16] * aude loves cherry pick button [15:45:26] (03CR) 10Daniel Kinzler: [C: 032] Improve function documentation in LanguageFallbackChain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99556 (owner: 10Aude) [15:48:18] (03CR) 10Daniel Kinzler: [C: 04-1] Remove unused params in EntityView::getHtmlForEditSection (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99545 (owner: 10Aude) [15:49:06] (03CR) 10Daniel Kinzler: [C: 032] add wikibase css class for parser function errors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99665 (owner: 10Aude) [15:55:13] (03Merged) 10jenkins-bot: add wikibase css class for parser function errors [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99662 (owner: 10Aude) [16:00:06] (03Merged) 10jenkins-bot: add wikibase css class for parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99664 (owner: 10Aude) [16:07:32] (03Merged) 10jenkins-bot: add wikibase css class for parser function errors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99665 (owner: 10Aude) [16:15:26] (03CR) 10Tobias Gritschacher: [C: 032] (bug #56685) localize quantities when formatting. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 (owner: 10Daniel Kinzler) [16:18:51] (03Merged) 10jenkins-bot: (bug #56685) localize quantities when formatting. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 (owner: 10Daniel Kinzler) [16:22:19] (03PS7) 10Tobias Gritschacher: (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 (owner: 10Daniel Kinzler) [16:24:26] (03CR) 10Tobias Gritschacher: [C: 032] (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 (owner: 10Daniel Kinzler) [16:24:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1357 (mw1.23-wmf6 - 576daf7 : aude): The build was broken. [16:24:34] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/80583162ff31...576daf7f5455 [16:24:34] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15044961 [16:25:30] (03CR) 10Tobias Gritschacher: [C: 032] Browsertests: wait for entity to load after page-reload [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99639 (owner: 10Tobias Gritschacher) [16:28:04] (03Merged) 10jenkins-bot: (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 (owner: 10Daniel Kinzler) [16:31:04] (03Merged) 10jenkins-bot: Browsertests: wait for entity to load after page-reload [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99639 (owner: 10Tobias Gritschacher) [16:39:26] (03PS1) 10Aude: Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 [16:39:32] Tobi_WMDE: & [16:39:34] (03CR) 10jenkins-bot: [V: 04-1] Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 (owner: 10Aude) [16:39:35] ^ [16:39:38] ok [16:39:41] not mergable [16:40:35] (03PS2) 10Aude: Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 [16:40:43] (03CR) 10jenkins-bot: [V: 04-1] Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 (owner: 10Aude) [16:40:59] gah [16:42:28] (03PS3) 10Aude: Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 [16:42:48] Tobi_WMDE: it's for the branch only. we can consider it on monday for wmf6 etc [16:43:52] (03CR) 10Aude: [V: 031] "verified this" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 (owner: 10Aude) [16:44:26] * aude will merge in a few minutes but prefers someone else approve [16:46:33] (03CR) 10Tobias Gritschacher: [C: 031] Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 (owner: 10Aude) [16:46:40] Henning_WMDE: https://gerrit.wikimedia.org/r/#/c/99673/ [16:46:44] one look? [16:47:25] would be nice :) [16:47:45] in case of an issue, we can have a settign to control display of the errors [16:48:09] whilst, one can override css and see the errors, if they choose [16:52:26] Yes, looking... [16:53:01] thanks [16:57:33] (03PS8) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [16:58:23] (03PS9) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [16:58:55] (03PS10) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [17:01:43] (03CR) 10Henning Snater: "Should be fine. Just one minor thing apart from the spelling error in the hooks file ("userss"):" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 (owner: 10Aude) [17:01:47] thanks [17:05:26] (03PS4) 10Aude: Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 [17:05:33] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1359 (master - e6694a2 : aude): The build is still failing. [17:05:33] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/e5121321d52f...e6694a2ebbaf [17:05:33] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15045656 [17:05:52] (03CR) 10Aude: "fixed spelling and module name." [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 (owner: 10Aude) [17:06:11] Tobi_WMDE: ^ [17:06:43] where's the review chocolate, btw? [17:07:54] (03CR) 10Aude: [C: 032 V: 031] "got enough +1's (i have verified)" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 (owner: 10Aude) [17:07:55] (03CR) 10Tobias Gritschacher: [C: 032] Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 (owner: 10Aude) [17:08:00] :) [17:08:20] * aude waits for jenkins [17:11:38] (03Merged) 10jenkins-bot: Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99673 (owner: 10Aude) [17:14:53] (03PS1) 10Aude: Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99675 [17:14:59] (03CR) 10Aude: [C: 032] Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99675 (owner: 10Aude) [17:20:54] (03Merged) 10jenkins-bot: Add setting to disable displaying parser function errors [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/99675 (owner: 10Aude) [17:25:49] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1360 (master - 966da6f : jenkins-bot): The build is still failing. [17:25:49] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/e6694a2ebbaf...966da6f278a1 [17:25:49] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15046343 [17:26:13] * aude rage [17:55:08] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1362 (master - 65f2782 : jenkins-bot): The build was fixed. [17:55:08] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/0b7e1f1c73d3...65f2782e79e6 [17:55:08] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15046982 [18:18:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1364 (mw1.23-wmf6 - 779e89a : aude): The build was fixed. [18:18:46] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/576daf7f5455...779e89a24ddb [18:18:46] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15049647 [19:26:41] (03PS1) 10Aude: Fix mismatching wfProfileIn / wfProfileOut calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99708 [19:26:51] (03CR) 10jenkins-bot: [V: 04-1] Fix mismatching wfProfileIn / wfProfileOut calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99708 (owner: 10Aude) [19:27:26] (03PS2) 10Aude: Fix mismatching wfProfileIn / wfProfileOut calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99708 [19:27:33] (03CR) 10jenkins-bot: [V: 04-1] Fix mismatching wfProfileIn / wfProfileOut calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99708 (owner: 10Aude) [19:28:02] no can merge [19:29:04] (03PS3) 10Aude: Fix mismatching wfProfileIn / wfProfileOut calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99708 [19:48:19] aude: http://www.youtube.com/watch?v=50MxmKU_bUY [19:49:17] :) [19:53:55] (03CR) 10Jeroen De Dauw: [C: 032] "This kind of profiling code is so bad >_>" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99708 (owner: 10Aude) [20:09:57] Lydia_WMDE: when's the next test.wikidata deploy? [20:10:58] lazowik: hmmm good question - not sure there still will be one this year because of christmas [20:11:25] mhm [20:11:44] lazowik: anything specific you want to have/try/...? [20:11:52] badges api :) [20:11:59] bene finished that! [20:12:30] ah :D [20:14:22] Lydia_WMDE: anyways, fancy features on test I see ;) [20:14:40] :) [20:14:44] * Lydia_WMDE is very happy about those [20:15:06] Lydia_WMDE: no links on project chat! [20:15:19] * lazowik is lazy, does not want to login :p [20:15:26] lol [20:15:29] sorry [20:15:37] i'll try to fix it later [20:15:42] need to finish a few other things first [20:15:50] if someone wants to do it please go ahead [20:16:01] * lazowik could try not to be lazy [20:16:08] haha [20:16:09] nah [20:16:10] it's fine [20:41:41] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [21:18:02] https://www.wikidata.org/w/index.php?title=Q15279878&action=history [21:18:19] could you tell how this number should be plz? [21:22:50] Hey, i’ve got post. :D [21:23:40] any one could help? [21:35:03] (03PS1) 10Aude: Ensure TermPropertyLabelResolve memcached is per language [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99742 [21:41:10] yannf: take a look at description here: https://www.wikidata.org/wiki/Property:P213 [21:41:50] lazowik, I saw that [21:42:31] but this link works: http://isni-url.oclc.nl/isni/0000000108692986 [21:42:45] but adding spaces breaks it [21:42:53] (03CR) 10Aude: "in this case, $language is "$wikiLanguage" so i think this is okay to do here." [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99742 (owner: 10Aude) [21:43:12] hmm [21:45:31] yannf: looks like a bug [21:45:35] Lydia_WMDE: ^ [21:45:41] see https://www.wikidata.org/wiki/Q6060 [21:45:45] it's also broken [21:46:06] (not a bug in software, rather logic bug) [21:46:32] ah ;) [21:47:50] yannf: maybe write on project chat or somewhere [21:47:58] yeah, doesn't work here either [21:48:50] and here https://www.wikidata.org/wiki/Q215215 [21:48:55] I'd say confirmed [21:51:39] (03CR) 10Aude: [C: 032] "verified." [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/99742 (owner: 10Aude) [21:52:04] lazowik, https://bugzilla.wikimedia.org/show_bug.cgi?id=58124 [21:52:52] yannf: as I said that's _not_ a wikibase software bug [21:53:38] yannf: see the discussion page [21:53:40] well, the links *without* the spaces work [21:53:42] https://www.wikidata.org/wiki/Property_talk:P213 [21:54:04] yannf: but it's not something that wikibase code can control [21:54:32] it seems pretty simple to fix [21:54:53] yannf: you can't just remove space from links [21:55:10]