[00:18:01] (03PS1) 10Aude: Get entity from parser output for EntityView js config [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101791 [00:18:55] (03CR) 10Aude: [C: 04-2] Get entity from parser output for EntityView js config [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101791 (owner: 10Aude) [01:31:20] (03PS1) 10Aude: Fix covers tag in repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101792 [01:42:07] (03CR) 10Hoo man: [C: 032] Fix covers tag in repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101792 (owner: 10Aude) [01:42:33] * hoo wants to see whether that passes travis [01:45:32] (03Merged) 10jenkins-bot: Fix covers tag in repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101792 (owner: 10Aude) [01:58:08] nope :/ [01:58:29] GetEntities "UsageException: Could not create a new page." [01:59:15] testRebuildPropertyInfo failed to deserialize [02:00:50] aude: :( [02:01:17] aude: I tried to debug that a bit yesterday, but I got nowhere... except to various "WTF?" [02:01:23] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1428 (master - 67813a7 : jenkins-bot): The build was broken. [02:01:23] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/479e74b9636d...67813a7ca286 [02:01:23] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15501424 [02:01:43] (03PS1) 10Aude: Improve test coverage for WikibaseRepo factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101795 [02:02:07] i can't reproduce with a fresh setup, same settings as travis [02:02:15] aude: I could [02:02:18] ah [02:02:28] did you use --group Wikibase to run the tests? [02:02:33] yes [02:02:45] that's weird... SQLite or MySQL/Maria? [02:03:05] I had failures 100% on MariaDB (but different ones... yay) [02:03:14] even excluded ChangeHandlerTest [02:03:25] mysql, although travis fails on both [02:03:32] that one should be safe these days, btw (if I saw it right) [02:03:39] agree [02:05:29] (03PS1) 10Aude: Remove postgres job from travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101796 [02:05:42] (03CR) 10Hoo man: [C: 032] "Looks safe and passes" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101795 (owner: 10Aude) [02:06:38] (03CR) 10Hoo man: [C: 032] "Indeed... eats resources with exactly zero additional value." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101796 (owner: 10Aude) [02:06:41] (03PS1) 10Aude: Re-enable ChangeHandlerTest on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101797 [02:06:43] :) [02:07:19] (03CR) 10Hoo man: [C: 032] ""can't possibly make things worse" ... that's it ;)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101797 (owner: 10Aude) [02:11:41] (03Merged) 10jenkins-bot: Improve test coverage for WikibaseRepo factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101795 (owner: 10Aude) [02:11:49] (03PS1) 10Hoo man: Make EditEntityTest a little more sane [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101801 [02:12:12] aude: ^ I have the (slight) hope that using EDIT_UPDATE in there will help to circle down the problems more [02:13:53] s/circle/narrow/ [02:13:58] to much German for me today :P [02:14:21] (03CR) 10Aude: [C: 032] "looks sane" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101801 (owner: 10Hoo man) [02:14:27] alright, let's see [02:14:31] (03Merged) 10jenkins-bot: Remove postgres job from travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101796 (owner: 10Aude) [02:19:09] (03Merged) 10jenkins-bot: Re-enable ChangeHandlerTest on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101797 (owner: 10Aude) [02:23:58] (03Merged) 10jenkins-bot: Make EditEntityTest a little more sane [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101801 (owner: 10Hoo man) [02:24:05] aude: Hey... you didn't even tell me you now have +2 on core.... congrats! \o/ [02:27:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1429 (master - a30ab5f : jenkins-bot): The build is still failing. [02:27:51] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/67813a7ca286...a30ab5f0ac19 [02:27:51] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15502285 [02:29:17] :D [02:29:27] merge all the stuff! [02:30:03] All of it, eh? [02:30:37] :) [02:33:13] aude: WMDE core cabal :D [02:39:24] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1430 (master - 30daa08 : jenkins-bot): The build is still failing. [02:39:24] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a30ab5f0ac19...30daa0855120 [02:39:24] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15502428 [02:46:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1431 (master - 18d5810 : jenkins-bot): The build is still failing. [02:46:26] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/30daa0855120...18d58106fca9 [02:46:26] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15502544 [02:56:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1432 (master - eaaadef : jenkins-bot): The build is still failing. [02:56:20] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/18d58106fca9...eaaadef6198c [02:56:20] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15502700 [03:07:28] (03PS1) 10Aude: move $hasProperties static variable out of SetReferenceTest setUp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101803 [03:08:52] aude: That's the value of moving that out? (I'm probably missing smth.) [03:10:03] it will persist across tests [03:10:23] those in set reference [03:11:20] mh... wont it anyway? [03:11:58] I mean, isn't that what static variables are about? [03:12:02] not convinced [03:12:43] not in how the tests run [03:13:12] aude: Does this fix any tests for you? [03:14:19] they aren't broken for me [03:14:26] * aude can't reproduce [03:14:37] ewk [03:14:45] I'll give them a run with that patch [03:15:02] (03PS2) 10Hoo man: move $hasProperties static variable out of SetReferenceTest setUp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101803 (owner: 10Aude) [03:15:06] rebased [03:15:33] k [03:15:55] it's a challenge to debug when i can't reproduce the issues [03:16:38] I could... and I still didn't find much useful information [03:17:38] only thing I found out in the past days is that the phpunit tests run in about 60% of the time if you disable xdebug :P [03:19:58] * aude nods [03:29:54] 1) Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit with data set #0 (array(), array(), array(array('foo', 'foo', true), array('bar', 'bar', true), array('foo', 'Foo', true), array('bar', 'Bar', true))) [03:29:54] array ( [03:29:54] 0 => [03:29:54] array ( [03:29:55] 0 => 'edit-already-exists', [03:29:55] ), [03:29:55] ) [03:29:56] Failed asserting that false matches expected true. [03:30:15] aude: ^ :( [03:31:33] gah [03:32:12] (03CR) 10Hoo man: [C: 04-1] "I doubt this helps (still see the same failures locally)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101803 (owner: 10Aude) [03:33:41] aude: Some code calls out to wikipage to do deletions, other code only clears old entities... do you think that might be related? [03:34:07] we no longer have any leaks into production DBs, btw (I cleared them all... and it didn't help at all) [03:34:29] could be [03:36:58] * aude gives up for now [03:47:45] Yeah... let's hack on that tomorrow or so [07:33:27] (03CR) 10Springle: "These indexes are now on s5 slave db1026. First impression:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 (owner: 10Daniel Kinzler) [07:35:02] (03PS1) 10Shirayuki: i18n: consistency tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101818 [07:40:16] (03PS2) 10Shirayuki: i18n: consistency tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101818 [08:01:43] (03CR) 10Siebrand: [C: 032] "Thanks." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101818 (owner: 10Shirayuki) [08:05:09] (03Merged) 10jenkins-bot: i18n: consistency tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101818 (owner: 10Shirayuki) [08:09:36] moin Henning_WMDE [08:21:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1433 (master - 38cd3e4 : Yuki Shira): The build is still failing. [08:21:25] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/eaaadef6198c...38cd3e477330 [08:21:25] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15511875 [08:56:34] what is the right category in bugzilla? [08:58:14] for what? [09:00:02] DanielK_WMDE, good morning :) [09:00:02] wikibase [09:00:45] wikidatarepo for things on wikidata.org, wikidataclient for bugs on client sites (eg wikipedia) due to wikidata [09:04:01] DanielK_WMDE, this patch has been asking for you [09:04:03] https://gerrit.wikimedia.org/r/#/c/98767/ [09:09:06] hi [09:09:20] is it possible to show two languages at the same time? [09:12:17] Schisma___: if you add babel boxes to your user page, you will see the labels and descriptions of items in all the languages you have babel boxes for. [09:12:54] https://meta.wikimedia.org/wiki/User_language [09:13:05] hm, https://www.wikidata.org/wiki/Wikidata:Babel should really explain that. [09:13:11] we should make this feature mor discoverable [09:13:46] yurik: sorry, kind of swamped right now [09:13:49] it's on the list [09:17:39] DanielK_WMDE: thats awesome. thanks ^^ [09:19:06] i thought I had an original idea ^^ [09:59:10] (03Draft1) 10Aude: Improve NamespaceChecker test and class usage in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101669 [10:08:15] https://www.mediawiki.org/wiki/Wikidata_deployment [10:08:18] Lydia_WMDE: [10:17:35] aude: you moved the checklist to the bottom? it's probably going to be lost & forgotten there :/ [10:17:41] maybe on a subpage or something? [10:17:53] even more lost [10:18:11] it should be in a infobox template thingy :) [10:18:57] how do I ask Hazard-Bot to do archiving [10:36:16] * aude desperately try to reproduce test failures on travis [10:36:21] can't reproduce [10:39:06] mh [10:39:20] moin! [10:41:02] aude: mh... anything special about your setup? [10:42:52] nope [10:43:02] PHPUnit 3.7.23 by Sebastian Bergmann. [10:43:03] PHP 5.5.7 (cli) (built: Dec 11 2013 07:51:06) [10:43:13] that's what I'm using in my test VM [10:43:30] PHP 5.3.27 (cli) (built: Jul 19 2013 18:25:06) [10:43:46] PHPUnit 3.7.1 by Sebastian Bergmann. [10:43:55] * aude should update phpunit [10:44:15] might help [11:08:44] Is Jens around? [11:08:48] Lydia_WMDE: ^ [11:08:58] hoo: he is in an all-day meeting [11:09:10] meh... ok :) [11:09:11] anything i can help you with? [11:10:06] Lydia_WMDE: I doubt it... questions about Lua implementations [11:10:15] k [11:12:55] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/100411/5/includes/InfoboxParserFunction.php I can cache it in a static var, if you want [11:19:12] hoo: hm, looks like we actually can't, since it has to know $parser. oh, well [11:19:19] ignore my comment, then [11:19:58] (03CR) 10Daniel Kinzler: Implement {{#infobox:...}} as a simple wrapper (031 comment) [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [11:20:00] heh [11:20:33] merge then? :P [11:20:41] * aude wish i know how / where i installed phpunit from [11:21:12] hoo: would need to test & poke. kind of tangled in something else right now [11:21:17] DanielK_WMDE: k [11:21:21] aude: pear? [11:21:32] that works for me. the ubuntu package dopesn't. [11:21:34] maybe but [11:21:38] which phpunit [11:21:40] ;) [11:21:45] exactly [11:22:05] it says it has nothing pear to update [11:22:06] Yeah, the Debian/Ubunutu package is missing files... there a bug in launchpad for that [11:22:43] pear list no phpunit [11:25:45] PHPUnit 3.7.28 by Sebastian Bergmann. [11:26:16] that sounds up to date :) [11:26:35] * aude hopes tests fail now [11:27:03] First time ever someone said this, I guess :D [11:27:09] heh [11:32:03] (03PS2) 10Aude: Get entity from parser output for EntityView js config [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101791 [11:32:17] DanielK_WMDE: ^ follow up to storing stuff in parser cache [11:32:43] the tests are quite basic and more todo [11:34:07] (03PS3) 10Aude: Get entity from parser output for EntityView js config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101791 [11:35:45] (03CR) 10Aude: "much more can be done to improve tests, as well as follow up to put / use more stuff in parser cache" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101791 (owner: 10Aude) [11:43:32] (03PS1) 10Daniel Kinzler: Remove unnecessary dependencies from EntityData stuff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101827 [12:00:17] will it be possible to have a query definition associated with a "list" ... ie "list of presidents of the Czech republic" ? [12:09:38] GerardM-: you have them in Q213 [12:12:12] lbenedix: looking [12:13:05] it is not obvious [12:13:12] can you explain ? [12:14:23] there are 3 claims for P35 [12:14:42] that is ? [12:14:45] Milos Zeman, Vaclav Klaus and Vaclav Havel [12:14:49] yes [12:15:24] I added one some time ago [12:15:34] Vaclav Klaus [12:16:11] but how is that a query ? [12:16:25] It is no query [12:16:49] btw. including this statement into wikipedia with {{#property:P35}} is not working well [12:16:55] you get the list of names [12:18:39] I just added this for Firefox in dewiki and adding more versions to wikidata would break the infobox [12:18:59] lbenedix lists are wrong. [12:19:09] I agressively split them when I find them [12:19:20] into the list and its part [12:20:50] |STAATSOBERHAUPT = [[Präsident (Tschechien)|Präsident]] {{#property:P35}} [12:21:01] gives: Präsident Miloš Zeman, Václav Klaus, Václav Havel [12:21:20] yep [12:21:48] they are dated and there is functionality I understand to give precedence to a value ... [12:22:01] do not know how ... just know that it has been released [12:22:27] I couldnt find documentation about how to get a specific claim for a statement [12:22:43] ... no [12:22:56] or how to get the qualifiers for the claim [12:24:44] the best I found was: https://meta.wikimedia.org/wiki/Wikidata/Notes/Inclusion_syntax [12:27:43] is there better documentation about how to use wikidata stuff in wikipedia? [12:33:51] to be honest, I champion its use but I concentrate on Wikidata [12:33:58] I do not know [12:36:30] I think one of the primary goals of wikidata is centralizing the infoboxes... [12:36:47] so it has to be possible to include wikidata data in wikipedia [12:42:55] lbenedix to do that you have to have the data [12:43:07] and that is what I am interested in [12:43:15] there is a lot of data allready in wikidata [12:43:58] http://tools.wmflabs.org/wikidata-todo/stats.php?reverse look at the number of statements per item [12:44:05] and yes there is a lot [12:44:13] but most data is not there [12:44:51] you will notice how many items do not have one statement and how quickly that is changing [12:45:43] Is there an overview what the bots are importing right now? [12:45:47] no [12:45:58] do you use Widar ? [12:46:03] nope [12:46:10] do you know of it ? [12:46:19] You told me this weekend [12:46:48] I used it on two Dutch literature prizes .. http://ultimategerardm.blogspot.nl/2013/12/pc-hooft-award-2014.html [12:47:03] several authors have now one statement [12:47:13] or two (for two prizes) [12:47:21] great [12:47:45] I think bots are harvesting the infoboxes and add new statements [12:47:52] they do [12:48:06] but they concentrate on en,wp [12:48:17] and that makes for one sided information [12:48:27] there is no helping it really [12:48:53] because warts and all, en.wp is the most comprehensive source of info [12:49:23] right [12:49:57] wp categories are another good source [12:50:02] what I would like is for people to use tools like Widar on the subjects of their culture / language [12:50:20] as it is there is so much to do [12:50:37] do you go for your culture or for impact ? [12:50:45] I have to admitt, that I didnt understand how to use widar [12:51:22] I use it ... ask [12:51:30] ping [12:51:44] maybe tonight ;) [12:51:55] is ok [12:51:59] :) [13:33:17] (03CR) 10Aude: [C: 032] Remove unnecessary dependencies from EntityData stuff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101827 (owner: 10Daniel Kinzler) [13:36:47] (03Merged) 10jenkins-bot: Remove unnecessary dependencies from EntityData stuff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101827 (owner: 10Daniel Kinzler) [13:46:39] (03PS8) 10Jens Ohlig: Add mw.wikibase.formattedPropertyValues as a Lua function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 [13:47:32] (03CR) 10Jens Ohlig: "Addressed formatting issues raised by Daniel Kinzler and renamed function to "formattedPropertyValues"" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 (owner: 10Jens Ohlig) [14:01:27] DanielK_WMDE: will open hangout for daily [14:08:23] Lydia_WMDE: sorry, kiddy alert at the wrong time. will write an email in a minute [14:08:38] k [14:15:06] (03PS1) 10Daniel Kinzler: Use EntityRevision for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101851 [14:34:14] (03PS1) 10Daniel Kinzler: Use ResultBuilder for EntityData. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 [14:50:31] (03CR) 10Zfilipin: [C: 04-1] Use snake_case in Aliases (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101054 (owner: 10Aaron1011) [14:55:49] (03PS3) 10Daniel Kinzler: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 [15:04:22] (03PS2) 10Daniel Kinzler: Use ResultBuilder for EntityData. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 [15:04:53] ugh! what'S wrong with gerrit? seems like it has gone JS-mad! [15:05:10] ? [15:05:15] it keeps hanging/timing out [15:05:23] nearly as bad as wikidata :) [15:05:38] (03PS4) 10Daniel Kinzler: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 [15:16:12] (03PS6) 10Jens Ohlig: Implementation of snakformatted property table in Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101201 [15:16:30] (03CR) 10Jens Ohlig: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101201 (owner: 10Jens Ohlig) [15:17:48] Lydia_WMDE: \o/ less divergence in DVs than I feared. Only 8ish commits, all touching the same code anyway [15:17:56] Actually only one of the new components is out of date now [15:18:11] JeroenDeDauw: great [15:20:12] Oh, remebered some other thing I did: DataModel is now PSR-0 compliant [15:32:18] DanielK_WMDE: Hi! could you have a look to https://gerrit.wikimedia.org/r/#/c/97835/ , please? I've made the requested improvements. [15:35:07] (03PS7) 10Jens Ohlig: Implementation of snakformatted property table in Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101201 [15:35:55] (03CR) 10Jens Ohlig: "Removed merge errors due to rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101201 (owner: 10Jens Ohlig) [15:37:01] DanielK_WMDE: just compliled a list of changes to the number dv stuff you made recently: https://github.com/DataValues/Number#02-2013-12-16 [15:37:07] Anything obviously missing there? [15:37:17] Some nice stuff in there [15:37:24] To bad the localization thing is implemented oddly [15:38:00] DanielK_WMDE: https://scrutinizer-ci.com/g/DataValues/Number/inspections/87144724-a528-45df-912d-7cb8a12890e9/code-structure/ [15:41:15] JeroenDeDauw: the change log looks good. how would you have done the localization stuff? [15:41:46] what i needed was basically a wrapper around the string->string (un)localization functions in Language