[00:49:16] I am now :/ [00:49:26] * legoktm huggles addshore [04:04:24] (03CR) 10Springle: [C: 04-1] "There is one more issue to consider here regarding the modified PRIMARY KEY on (term_row_id, term_language). While the auto_increment stil" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 (owner: 10Daniel Kinzler) [04:10:27] (03CR) 10Springle: "Oh, there's another possibility:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 (owner: 10Daniel Kinzler) [08:49:10] (03PS1) 10Adrian Lang: Make sure snaklistview test cases pass in Firefox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106215 [08:54:28] Hoi Lydia_WMDE are you there ? [08:55:14] GerardM: hey [08:56:11] I got confirmation that I will be in India for something like a MONTH talking up Wikidata !! [08:56:36] sweet! [08:56:37] so I can talk at the DBpedia conference as well [08:56:43] nice [08:56:52] and tomorrow I meet Jan-Bart [08:57:23] it sounds like I live Wikidata [08:57:27] but seriously [08:57:57] \o/ [08:58:29] I have been thinking about a presentation project for Wikidata ... probably a seperate URL [08:58:58] combining things like Reasonator Commons search / wikipedia search [08:59:09] how does that sound to you [09:00:01] https://www.wikidata.org/wiki/Wikidata:Tools should actually be that but it could use some more improvements [09:00:11] bene* has made it prettier already [09:00:27] or do you mean something else? [09:00:34] (that page is also missing tools) [09:00:47] what page do you refer to ? [09:01:22] https://www.wikidata.org/wiki/Wikidata:Tools [09:02:06] alright - i have to leave for work now - back online in 45 mins probably [09:02:09] laters :) [09:02:12] no... more like the :) [09:03:55] [travis-ci] wmde/Wikibase#41 (master - 6300e5d : Translation updater bot): The build was fixed. [09:03:55] [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/c69dd20420c0...6300e5d9e52d [09:03:55] [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/16577229 [09:14:27] [travis-ci] wmde/Wikibase#43 (newcomponents - a5a4694 : jeroendedauw): The build has errored. [09:14:27] [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/5ffd74e64433...a5a4694ec9f2 [09:14:27] [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/16577756 [09:51:21] Henning_WMDE: Adrian_WMDE I will provide an overview of where the things are now later today [09:51:29] Great [09:59:17] Henning_WMDE: can you have a quick look at https://github.com/wmde/DataValuesJavascript/pull/2/files ? This is merging the formatter stuff into the fork. [10:00:34] What do you mean with quick look here? [10:01:01] Henning_WMDE: see if anything there looks fishy to you [10:02:28] No fish detected. [10:02:52] Good, fish are evil [10:20:34] [travis-ci] wmde/DataValuesJavascript#27 (0.1.1 - 6e21cd7 : Jeroen De Dauw): The build failed. [10:20:34] [travis-ci] Change view : https://github.com/wmde/DataValuesJavascript/compare/0.1.1 [10:20:34] [travis-ci] Build details : http://travis-ci.org/wmde/DataValuesJavascript/builds/16580620 [10:25:28] [travis-ci] wmde/WikibaseDataModel#36 (master - 584a9d4 : jeroendedauw): The build has errored. [10:25:28] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/compare/38c1c3491c57...584a9d4d6537 [10:25:28] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/16580840 [10:26:51] Hoi, what is the problem with enabling a language on Wikidata .... There are many more in the pipeline [10:32:30] [travis-ci] wmde/DataValuesJavascript#29 (0.1.1.1 - 392e74c : jeroendedauw): The build failed. [10:32:30] [travis-ci] Change view : https://github.com/wmde/DataValuesJavascript/compare/0.1.1.1 [10:32:30] [travis-ci] Build details : http://travis-ci.org/wmde/DataValuesJavascript/builds/16581277 [10:32:46] [travis-ci] wmde/DataValuesJavascript#28 (master - 392e74c : jeroendedauw): The build was broken. [10:32:46] [travis-ci] Change view : https://github.com/wmde/DataValuesJavascript/compare/6e21cd79d792...392e74c421b9 [10:32:46] [travis-ci] Build details : http://travis-ci.org/wmde/DataValuesJavascript/builds/16581274 [10:36:32] DanielK_WMDE_: Tobi_WMDE: ready? [10:37:10] Lydia_WMDE: added a bunch of comments, have a look. i'm getting another coffee and comming over [10:40:45] [travis-ci] wmde/Wikibase#44 (newcomponents - 1ac4ab6 : jeroendedauw): The build has errored. [10:40:45] [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/a5a4694ec9f2...1ac4ab6af5a8 [10:40:45] [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/16581628 [10:53:10] (03PS1) 10Hoo man: Slim down wbCurrentSite to only hold information we need [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106226 [10:55:05] Low hanging code-review-fruit --^ [10:55:47] yay [10:57:23] DanielK_WMDE_: would you look at https://bugzilla.wikimedia.org/show_bug.cgi?id=59788 [10:57:49] suggestions on how to do things most properly? [10:58:34] the issue does not occur in production now since we reverted the spam blacklist change [10:58:50] but i am not happy with that as a solution [11:01:19] aude: What if we use a "random" item page over there (like Q1) [11:02:25] that's probably the only way out we have (despite changing the order of the creation process to fetch the new id earlier) [11:03:04] * aude thinks $title is not needed in spam blacklist for new pages [11:03:14] but would require a sensible way to log something [11:03:54] otherwise maybe make a title with one of our blacklist ids? (hacky) [11:04:53] aude: Do we have the entity already at that stage? If so, we could just call EntityContent::grabFreshId and construct a title from that [11:05:06] we do [11:05:13] (potential) problem: We start wasting even more item ids [11:05:27] that changes when we assign the id (or waste them) [11:05:42] aude: Exactly [11:06:04] Not sure how many creations fail at this point, but it *could* lead ot significant gaps between item numbers [11:06:12] yeah [11:09:46] aude: We could also just use like Q2^31+1 (an item id which can never be reached, I guess)... that would also make it clear that we're taking about a dummy... or like Q-1 or Q0 or something else that's clearly invalid [11:10:03] maybe [11:10:18] that's the hacky way out, but I don't actually see a 3rd option [11:10:27] Q0 would work [11:11:05] how do i see the logs for spam blacklist? [11:11:27] wgLogSpamBlacklistHits [11:11:44] aude: Need to be +sysop [11:11:49] false by default [11:12:16] I think it's enabled on some WMF wikis [11:12:35] yeah common settings has $wgLogSpamBlacklistHits = true; [11:12:41] https://meta.wikimedia.org/wiki/Special:Log/spamblacklist [11:12:49] only on meta? [11:12:57] that's where the blacklist is hosted [11:13:08] no, also for wikidata.org [11:13:12] oh [11:13:21] I think we initially had it only for meta or so [11:13:23] https://test.wikidata.org/wiki/Special:Log/spamblacklist [11:13:27] 21:45, 7 January 2014 Aude (talk | contribs | block) caused a spam blacklist hit on Special:NewItem by attempting to add http://j.mp. [11:13:34] hah [11:13:49] aude: You're the first hit in ages [11:13:54] https://www.wikidata.org/wiki/Special:Log/spamblacklist [11:14:06] that doesn't sound very accurate... mh [11:14:10] in that case "Special:NewItem" makes it obvious [11:14:19] yep [11:14:38] but will be misused to make a wiki page possibly [11:15:06] * aude adding http://j.mp/wmfatal btw [11:15:08] :) [11:15:27] j.mp/wmfatal [11:15:56] mh... do you think the log is accurate... do we really have so few hits? [11:16:05] i don't know [11:16:33] are IP hits even logged? [11:16:42] why not? [11:16:51] there aren't any in the log [11:17:16] on meta there is one IP in the log [11:17:38] aren't they not allowed to add links unless they do a captcha [11:17:54] * aude thinks captchas are ineffective [11:17:59] True [11:18:17] But I doubt the captchas can stop anything besides very simple hacky scripts [11:19:13] wow, really infrequent [11:20:15] quite a lot of enwiki entries [11:20:43] ips included [11:21:11] don't have the permission to view the log there, meh [11:21:23] what's its name? [11:21:34] same as anywhere [11:21:54] anyway, that's how the title is used and something sensible like Special:NewItem makes sense [11:23:36] It makes sense, but it doesn't work [11:23:55] what if we constructed a title 'NewItem' in the wiki's item ns? [11:25:11] Log entries would be like "(Item:)NewItem" then... I'm pretty sure that would work [11:28:59] * aude booted from internet [11:29:12] it might [11:30:03] commented on the bug [11:30:45] of course spam blacklist has no tests and this code is in static methods / hooks [11:33:26] [travis-ci] wmde/Wikibase#44 (newcomponents - 1ac4ab6 : jeroendedauw): The build passed. [11:33:26] [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/a5a4694ec9f2...1ac4ab6af5a8 [11:33:26] [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/16581628 [11:43:48] Is there a reference for the naming scheme used in resources/? [11:44:13] Didn't find anything in the coding conventions [11:44:27] i don't think there is a convention [11:44:42] extensions vary in how they do that [11:45:03] but generally should be in a "namespace" like wikibase or "wb" [11:45:17] I'd pick mw.ext.wikibase for a new module [11:45:20] or "ext.wikibase" sometimes is done [11:45:23] could be [11:45:55] So I'd mkdir lib/resources/mw.ext.wikibase/ and put the module in a file lib/resources/mw.ext.wikibase/wikibase.modulename.js? [11:46:15] Adrian_WMDE: We don't usually use mw.ext.wikibase [11:46:35] Do you have a jquery module, or ...? [11:46:39] * aude confused [11:47:03] aude: all our modules are wikibase.* [11:47:08] hoo: No, it's not jQuery [11:47:23] i know that [11:47:25] except the jquery ones, those are jquery.wikibase [11:47:28] that's why I asked [11:47:40] Adrian_WMDE: ok, than you probabably want wikibase.whatever [11:47:44] * then [11:47:45] other extensions do ext.blah but not us [11:47:54] hoo: aude: We don't, yet, but in the spirit of https://gerrit.wikimedia.org/r/#/c/89109/7 I thought I might take mw.ext.wikibase for something MediaWiki-related [11:49:23] mh, didn't know that change yet [11:49:34] Well, it didn't land [11:49:37] (and won't) [11:49:44] but I guess for now we want to stick with our current naming scheme [11:49:48] all right [11:51:42] Also, what's wikibase.libs for? [11:52:08] for external libs [11:52:12] I think it's empty, though [11:52:19] Yeah, it is [12:16:53] :-( [12:17:02] what does OBSOLETE mean :-( [12:19:39] https://www.wikidata.org/wiki/Q2144050 [12:19:39] it's all over my railway stations :-( [12:20:03] twkozlowski: that has been superseded by instance of [12:21:08] Will bots remove it? [12:21:22] I guess so, don't really know [12:29:49] (03CR) 10Daniel Kinzler: "@springle: I was told that a single column primary key is required for online updates. Also, someone (you?) told me that a large primary k" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 (owner: 10Daniel Kinzler) [12:29:50] twkozlowski: you volunteering? :) [12:29:58] * aude doesn't know either [12:37:34] Adrian_WMDE: do you have an account on wikimedia labs yet? (e.g. https://wikitech.wikimedia.org/) [12:39:47] out of curiosity, is there an easy way for me to get a list off all railway stations (Q55488) located in Poland (P17 = Q36) that do not have coordinate location (P625) added to them? [12:40:26] might be with magnus' query tool [12:40:38] http://208.80.153.172/wdq/ [12:40:50] * aude does not know exactly all it can do [12:41:23] nothing official though [12:43:09] (03CR) 10Addshore: [C: 032 V: 031] (bug 58422) omit TOC with less than 3 sections [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101433 (owner: 10Daniel Kinzler) [12:43:25] (03PS10) 10Daniel Kinzler: (bug 45529) use composite indexes on wb_terms. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 [12:45:00] addshore: for the Wikidata git repo, it is a superproject that automatically updates submodules [12:45:12] if we remove "branch = master" does that stop the updating? [12:45:23] Adrian_WMDE: your irc handle looks a lot like the one of Abraham, please change your name or something [12:46:33] aude: Yes [12:47:10] Adrian_WMDE: if you want (privately if you like) tell me your labs shell name and then we can add you to our ldap group [12:47:19] aude: adrian [12:47:20] this means we can resubmit jobs in jenkins [12:47:22] ok [12:47:23] easy [12:48:52] (03Merged) 10jenkins-bot: (bug 58422) omit TOC with less than 3 sections [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101433 (owner: 10Daniel Kinzler) [12:51:55] (03CR) 10Springle: [C: 032] "Sure, leaving the partitioning to Ops is fine; I only bring up the problems and options in case someone has a "what-if-we-did-X-instead" t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 (owner: 10Daniel Kinzler) [12:52:56] aude: justc checking what we have now [12:53:23] addshore: thanks [12:53:34] i know we switch it to the branches for the branch [12:53:51] I image if we remove that it would stop [12:54:10] also I believe I maty have read somewhere that a '.' also does something [12:54:22] hah [12:54:23] that might either track the same branch that it is currently on [12:54:33] i will try removing it [12:54:57] since the change with composer might break it along the way, so we want to stop updating [12:55:09] and then switch it to use composer [12:57:23] :) [12:57:49] (03PS1) 10Aude: remove tracking branch for submodules [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106231 [12:58:00] hope it's that simple [12:58:16] (03CR) 10Addshore: [C: 032] Use EntityRevision for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101851 (owner: 10Daniel Kinzler) [12:58:21] if i make it track github, that would definitely stop it [12:58:28] yup xD [12:58:36] you could just blank the submodules file ;p [12:58:40] heh [13:00:02] (03PS1) 10Addshore: General cleanup of files touched in G101851 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106232 [13:00:09] aude: ^^ :P [13:00:15] (03CR) 10Aude: [C: 032] "works fine, together with the other two dependent patches" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99637 (owner: 10Daniel Kinzler) [13:00:47] (03CR) 10Addshore: [C: 032 V: 032] remove tracking branch for submodules [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106231 (owner: 10Aude) [13:01:30] (03PS9) 10Aude: Refactor SqlStore::doSchemaUpdates [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100361 (owner: 10Daniel Kinzler) [13:01:52] (03CR) 10Addshore: [C: 04-1] "needs manual rebase :<" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 (owner: 10Daniel Kinzler) [13:01:52] no can merge :( [13:02:07] can't? [13:02:08] (03CR) 10jenkins-bot: [V: 04-1] General cleanup of files touched in G101851 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106232 (owner: 10Addshore) [13:02:19] interesting.. [13:02:44] oh, doh [13:02:53] schema thing depends on the other stuff to merge first [13:03:22] (03PS2) 10Addshore: General cleanup of files touched in G101851 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106232 [13:03:23] :D [13:05:39] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1525 (master - 710cca5 : Addshore): The build was broken. [13:05:39] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/93e10ee5768b...710cca510e9b [13:05:40] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16587453 [13:05:44] :( [13:05:47] (03PS1) 10Jeroen De Dauw: Update repo to use a build rather than git submodules [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106233 [13:05:48] (03PS1) 10Jeroen De Dauw: Add first Wikibase build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106234 [13:06:07] Tobi_WMDE: totally unsuspicious change id no? https://gerrit.wikimedia.org/r/#/c/106234/ [13:06:07] ohgah [13:06:20] segfault >.< [13:06:27] still... [13:06:33] is Travis still on PHP 5.3.27? [13:06:46] (03CR) 10Hoo man: [C: 032] "Style-only change" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106232 (owner: 10Addshore) [13:07:28] (03CR) 10Aude: [C: 04-1] "prefer this to be submitted to a branch first." [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106234 (owner: 10Jeroen De Dauw) [13:07:49] is there no way for us to re run the jobs on travis now? that button seems to have vanished [13:07:59] (03CR) 10Aude: "where is the vendor directory? where is composer lock?" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106234 (owner: 10Jeroen De Dauw) [13:08:42] addshore: logged in? [13:08:49] yup :/ [13:08:58] missing rights, that is [13:10:33] i wonder why it segfaults in mysql only [13:10:41] aude: it doesn't [13:10:47] really? [13:11:00] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16533178 [13:11:10] ignore me [13:11:19] (03Abandoned) 10Jeroen De Dauw: Add first Wikibase build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106234 (owner: 10Jeroen De Dauw) [13:11:23] eg. https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/16256640 [13:11:34] initially I even suspected it could be SQLite only :P [13:11:41] ah [13:14:09] (03PS1) 10Jeroen De Dauw: Update repo to use a build rather than git submodules [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106237 [13:14:10] (03PS1) 10Jeroen De Dauw: Add first Wikidata build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106238 [13:14:13] (03Abandoned) 10Jeroen De Dauw: Update repo to use a build rather than git submodules [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106233 (owner: 10Jeroen De Dauw) [13:14:34] (03Abandoned) 10Jeroen De Dauw: Add first Wikidata build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106238 (owner: 10Jeroen De Dauw) [13:15:24] (03PS1) 10Jeroen De Dauw: Add first Wikibase build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106239 [13:18:04] (03Abandoned) 10Jeroen De Dauw: Add first Wikibase build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106239 (owner: 10Jeroen De Dauw) [13:25:58] (03PS5) 10Addshore: Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 [13:26:26] (03CR) 10Addshore: [C: 04-1] "Rebased," [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 (owner: 10Addshore) [13:27:14] (03Abandoned) 10Addshore: implement MergeItemsUnitTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95645 (owner: 10Addshore) [13:27:18] (03PS2) 10Jeroen De Dauw: Update repo to use a build rather than git submodules [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106237 [13:27:19] (03PS1) 10Jeroen De Dauw: Add first Wikibase build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106241 [13:27:28] where is jenkins? [13:27:48] https://gerrit.wikimedia.org/r/#/c/99637/ started gate and submit 27 minutes ago [13:28:08] 262654 lines added in one commit. I am rather productive today! [13:29:10] looks better! but think this should be submitted to a branch first before going on beta [13:29:38] just in case it doesn't work perfect, although probably it does [13:29:47] aude: it is on a branch, you can easily get it if you want to try it out [13:30:00] aude: also, we have already run some Selenium tests [13:30:11] branch = master? [13:30:33] aude: no. master is the branch into which it will be merged when you do the review thing [13:30:33] (03PS1) 10Adrian Lang: Untangle wikibase.store module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106242 [13:30:39] it is not the branch on which the commit is now [13:30:52] ok [13:31:37] It's "usebuild", though gerrit might be doing weird stuff with it [13:31:48] Eiether way, you can easily fetch it with the git review thing [13:31:54] it says Branch master [13:32:29] i guess it's on a topic branch, but has master as the target branch? [13:32:47] i guess we will approve it once we test locally and hope it doesn't cause a problem on beta [13:32:51] if it does then we revert [13:32:55] aude: that is the target branch [13:32:55] aude: what do you want to do? [13:33:28] it if's on a branch on gerrit, then we can briefly try it on beta with stuff like localisation cache [13:33:34] without actually deploying it yet [13:33:35] (03PS6) 10Daniel Kinzler: (bug 57231) Use ResultBuilder for EntityData. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 [13:33:44] (03CR) 10jenkins-bot: [V: 04-1] (bug 57231) Use ResultBuilder for EntityData. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 (owner: 10Daniel Kinzler) [13:33:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1526 (master - 6544488 : addshore): The build was fixed. [13:33:51] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/710cca510e9b...65444889ef8f [13:33:51] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16588958 [13:34:18] although shouldn't interfere with production [13:34:21] either way [13:34:30] wtf? i just did rebase that? [13:35:21] huh, stuff got merged in the mean time :/ [13:35:49] aude: there now is a branch named "beta" on the remote that has the commits [13:36:19] (03PS7) 10Daniel Kinzler: (bug 57231) Use ResultBuilder for EntityData. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 [13:37:25] ok, great [13:43:19] aude: as you can see, the branch is on the remote with my 2 commits on it: https://git.wikimedia.org/branches/mediawiki%2Fextensions%2FWikidata.git [13:44:12] ok [13:44:19] (03CR) 10Hashar: [C: 032] "seems to hit a bug in Zuul, it is no more processing ;(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99637 (owner: 10Daniel Kinzler) [13:45:38] bah [13:45:44] Zuul has a bug, it is blocked somehow :( [13:45:51] :/ [13:45:56] Uncaught TypeError: Cannot call method 'getFormatter' of null [13:45:57] valueview.valueview.js:728 [13:46:04] anyone know about that? [13:46:16] with composer [13:46:20] hashar: zuul current status https://i.chzbgr.com/maxW500/1515312384/hD1E4BC60/ [13:46:35] * aude wonders why me only? [13:46:49] aude: when do you get that error? [13:46:55] loading an item [13:47:07] master or wikidata? [13:47:18] https://gerrit.wikimedia.org/r/#/c/103609/ [13:47:57] let me try the build [13:48:22] (03CR) 10Jeroen De Dauw: [C: 04-2] "To make clear this should not be merged" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/103609 (owner: 10Aude) [13:48:30] (03PS9) 10Daniel Kinzler: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 [13:48:33] JeroenDeDauw: huh? [13:48:46] obviously it does not work [13:49:05] what do we use instead? [13:56:00] jenkin jenkins [13:56:18] (03CR) 10Hashar: [C: 032] "restarted zuul" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99637 (owner: 10Daniel Kinzler) [13:56:25] yay [13:57:31] * aude needs new stuff merged [13:58:14] aude: you want the new component stuff merged? [13:58:21] (03Abandoned) 10Aude: Make Wikibase work with the new DataValues and DataModel components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/103609 (owner: 10Aude) [13:58:32] JeroenDeDauw: not yet [13:58:34] something else :) [13:58:53] just to verify that we indeed stopped the submodules from updating [13:59:42] (03CR) 10Aude: [C: 032] "this is good, together with the two other schema patches" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100361 (owner: 10Daniel Kinzler) [14:00:30] really need to make your tests runnable in parralel [14:00:53] also there might be some overlap between mwext-Wikibase-testextensions-master and the client/repo/repoapi jobs [14:01:12] probably [14:01:18] yeah... [14:01:25] hashar: Are you using groups for these? [14:01:31] no clue [14:01:32] cant remember [14:01:36] client repo api do [14:01:53] mwext-Wikibase-testextensions-master might just be running everything [14:02:06] half of the repo api test is just getentities [14:02:18] it has over 900 or so tests [14:03:40] It might be worth to split it out, actually [14:03:45] (03Merged) 10jenkins-bot: (bug 47135) Make row IDs use BIGINT. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99637 (owner: 10Daniel Kinzler) [14:04:42] hashar: yes testextensions runs everything [14:05:13] the file to look at is https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/Wikibase.php [14:05:24] addshore: I think we may overdid the GetEntitiesTest a little... [14:05:38] I can't remember why you made three different jobs though [14:06:00] Back then you couldn't have everything on one wiki [14:07:59] hashar: testextensions only runs on gate-submit [14:08:23] ahh [14:08:25] that is it [14:08:37] so I guess it is to do a final over paranoid verification [14:08:47] also the api tests run takes the same ammount of time if not slightly less time than the quint tests [14:08:59] (03Merged) 10jenkins-bot: (bug 45529) use composite indexes on wb_terms. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 (owner: 10Daniel Kinzler) [14:09:09] and indeed, over paranoid verification :P if testextensions fails something else really should have failed already [14:09:18] works for me [14:09:24] also I added progress bars on https://integration.wikimedia.org/zuul/ [14:09:45] lamely copy pasted from Openstack status page at http://status.openstack.org/zuul/ :D [14:10:48] hashar: I dont see the status bars :p [14:10:55] * hoo does [14:11:05] where? :p [14:11:20] heh, refreshed a few times and they appeared :) [14:11:21] yo addshore [14:14:30] yo! [14:14:34] (03Merged) 10jenkins-bot: Refactor SqlStore::doSchemaUpdates [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100361 (owner: 10Daniel Kinzler) [14:15:54] addshore, when I wanna request autopatrol for you on Commons, I go and see your user rights then remember you work for OTRS :( [14:16:02] :( [14:16:06] :) [14:16:22] oops that thing slip 2 times [14:28:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1529 (master - 6245988 : jenkins-bot): The build was broken. [14:28:11] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/273a1e6878d8...6245988c2e1c [14:28:11] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16591622 [14:31:28] yay jenkins [14:31:52] submodules seem to stop [14:32:38] JeroenDeDauw: ^ [14:32:52] it's safe to merge stuff into master wikibase [14:34:52] aude: \o/ [14:35:46] dewiki m( [14:42:20] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDataModel#145 (master - 584a9d4 : jeroendedauw): The build has errored. [14:42:20] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDataModel/compare/25ba9a102856...584a9d4d6537 [14:42:21] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDataModel/builds/16592989 [14:47:43] (03CR) 10Daniel Kinzler: "Seems like wgUsedEntities gets cached with labels in only the current user's language. That's bad." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [14:49:46] [travis-ci] wmde/Wikibase#46 (master - 6923066 : jeroendedauw): The build has errored. [14:49:46] [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/6300e5d9e52d...692306688230 [14:49:46] [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/16593149 [14:49:50] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=59820 [14:50:19] DanielK_WMDE_: ok [14:50:59] DanielK_WMDE_: https://bugzilla.wikimedia.org/show_bug.cgi?id=59788 [14:51:48] Lydia_WMDE, tobi: bug 59820 is somethign to keep in mind; should be done in the current sprint, i guess. [14:52:00] DanielK_WMDE_: thx - will check [14:52:01] agree [14:52:42] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1530 (master - 6923066 : jeroendedauw): The build was fixed. [14:52:42] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/6245988c2e1c...692306688230 [14:52:42] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16593180 [14:56:31] aude: prepareContentForEdit is just horribly evil. [14:56:37] it is! [14:57:03] (03CR) 10Jeroen De Dauw: [C: 032] Add first Wikibase build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106241 (owner: 10Jeroen De Dauw) [14:57:09] (03CR) 10Jeroen De Dauw: Add first Wikibase build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106241 (owner: 10Jeroen De Dauw) [14:57:25] (03PS2) 10Jeroen De Dauw: Add first Wikibase build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/106241 [14:57:35] aude: getParserOutput could be made to cache the last value it returned, and just return it again if the parameters are the same. [14:57:46] then no such evil hackery would be needed [14:58:05] hmmm, yeah [14:58:25] please comment in the bug so anomie etc sees [14:58:40] he wants to revert revert [14:58:53] eek. [14:59:17] revert revert pending "wikibase gets fixed" [14:59:31] https://gerrit.wikimedia.org/r/#/c/106126/ [14:59:43] did you decide on smth. now, btw? [14:59:50] no [15:00:17] but i tend to think spam blacklist can be improved and passing special:newitem isn't so horrible [15:00:24] in case of new item [15:00:44] mh, Anomie was a bit upset yesterday [15:00:52] * aude nods [15:03:14] there also was an issue on wikitech wiki that required https://gerrit.wikimedia.org/r/#/c/106146/ [15:03:18] as a work around [15:03:39]