[03:32:33] (03PS32) 10Aude: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:32:37] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/18/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:32:47] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:36:41] (03PS33) 10Aude: (DNM) just testing stuffs [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:36:55] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:37:02] (03PS34) 10Aude: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:37:15] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:40:45] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:40:47] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/19/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:44:36] (03PS35) 10Aude: (DNM) just testing stuffs [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:44:51] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:49:10] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:49:12] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/20/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:57:10] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [03:57:12] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/21/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [04:05:10] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [06:11:03] http://lists.wikimedia.org/pipermail/analytics/2014-January/001515.html :D [08:16:06] 01[13DataValuesJavascript01] 15snaterlicious created 06inheritjquerydep (+1 new commit): 02http://git.io/57klpg [08:16:06] 13DataValuesJavascript/06inheritjquerydep 1417acce3 15snaterlicious: Removed jQuery dependency from inherit function [08:38:05] 01[13DataValuesJavascript01] 15snaterlicious pushed 1 new commit to 06inheritjquerydep: 02http://git.io/kSTV_A [08:38:05] 13DataValuesJavascript/06inheritjquerydep 14c057527 15snaterlicious: Additional clean-up and documentation update [08:42:03] (03CR) 10Daniel Werner: "Conceptual review." (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [08:42:17] (03CR) 10Daniel Werner: [C: 04-1] Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [08:55:08] any admin here? [08:57:40] ? [08:59:49] (03CR) 10Daniel Werner: Replace wb.fetchedEntities with wb.store.EntityStore (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [09:20:12] (03CR) 10Daniel Werner: "Missing test for seedEntityStoreFromMwConfig. This would be an important test." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [10:27:36] (03CR) 10Daniel Kinzler: [C: 04-1] "nitpicks" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [10:35:04] (03CR) 10Daniel Kinzler: [C: 04-1] "A lot better, naming could still be improved." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [10:35:55] (03CR) 10Daniel Kinzler: "(commented on PS9 by mistake, comments still apply to PS10)" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [10:38:33] 01[13DataValuesJavascript01] 15snaterlicious created 06inheritutil (+1 new commit): 02http://git.io/5ExqyQ [10:38:33] 13DataValuesJavascript/06inheritutil 1457043fd 15snaterlicious: Moved dataValues.util.inherit to util.inherit... [10:41:36] (03CR) 10Daniel Kinzler: [C: 032] Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [10:42:02] (03Merged) 10jenkins-bot: Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [10:45:37] 01[13DataValuesJavascript01] 15snaterlicious pushed 1 new commit to 06inheritutil: 02http://git.io/JYI-MA [10:45:37] 13DataValuesJavascript/06inheritutil 14c2652cc 15snaterlicious: Fixed old inherit reference [10:49:22] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1568 (master - 7632550 : jenkins-bot): The build was broken. [10:49:22] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/4126fe934662...763255099159 [10:49:23] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17119710 [10:59:50] DanielK_WMDE: finally replied on the assertValidHTML change https://gerrit.wikimedia.org/r/#/c/98853/ :( [10:59:56] DanielK_WMDE: sorry for the delay [11:09:18] [13DataValuesJavascript] 15snaterlicious opened pull request #9: Removed jQuery dependency from inherit function (06master...06inheritjquerydep) 02http://git.io/RN9FlA [11:12:44] hashar: we really need that thing in... [11:13:11] addshore: accidentally merged without verification: https://gerrit.wikimedia.org/r/#/c/96268/ [11:13:30] [13DataValuesJavascript] 15snaterlicious opened pull request #10: Moved dataValues.util.inherit to util.inherit (06master...06inheritutil) 02http://git.io/EnAOzg [11:14:19] i'm afraid there's a failure there: [11:14:20] Undefined property: Wikibase\Api\GetClaims::$resultBuilder [11:14:22] /var/www/daniel/wikidata/extensions/Wikibase/repo/includes/api/GetClaims.php:53 [11:14:28] will fix in a second... [11:17:44] any admin here? [11:18:01] (03PS1) 10Daniel Kinzler: Fix undefined property in GetClaims. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108028 [11:18:15] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108028 (owner: 10Daniel Kinzler) [11:18:15] !admin [11:18:31] Jianhui67: what? [11:19:48] can you remove the rollback right from my mobile account (JianhuiMobile) legoktm? I don't really find myself using it because I will be busy. having it on my main account would be enough [11:19:49] addshore, aude, Tobi_WMDE, JeroenDeDauw: i just broke master, please merge https://gerrit.wikimedia.org/r/108028 to fix! [11:20:08] okay [11:20:19] (i'll self-approve in a bit if nobody is around to do it, but would prefer not to) [11:20:24] I will be busy preparing for national exams. when I need it again, I'll ask [11:20:45] (change visibility) 11:20, 17 January 2014 Legoktm (talk | contribs | block) changed group membership for User:JianhuiMobile from rollbacker to (none) ([03:19:48 AM] can you remove the rollback right from my mobile account (JianhuiMobile) legoktm? I don't really find myself using it because I will be busy. having it on my main account would be enough) [11:20:47] hm... WikidataJenkins doesn't seem to actually test much... [11:21:13] nothing, in fact [11:21:27] (03CR) 10WikidataJenkins: [C: 032] Fix undefined property in GetClaims. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108028 (owner: 10Daniel Kinzler) [11:21:27] thanks legoktm [11:21:33] np [11:21:48] (03Merged) 10jenkins-bot: Fix undefined property in GetClaims. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108028 (owner: 10Daniel Kinzler) [11:22:19] errrrr [11:22:26] did the bot just auto merge it? [11:23:22] (03CR) 10Tobias Gritschacher: "WikidataJenkins did if for us! :-P" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108028 (owner: 10Daniel Kinzler) [11:23:48] DanielK_WMDE: fixed [11:24:15] legoktm: nevermind, was my fault. [11:24:20] ah [11:28:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1569 (master - 7aada2a : daniel): The build was fixed. [11:28:34] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/763255099159...7aada2a2d67d [11:28:34] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17121664 [11:30:14] silly Tobi_WMDE :> [11:30:32] addshore: :>>> [11:43:20] hashar: updated https://gerrit.wikimedia.org/r/#/c/98853/ [11:43:25] me -> food [11:47:17] same [11:56:12] (03PS2) 10Addshore: Cleanup ChangeOp related files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107576 [11:56:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107576 (owner: 10Addshore) [12:00:47] (03PS4) 10Addshore: Cleanup ChangeOp related files. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107576 [12:01:00] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107576 (owner: 10Addshore) [12:03:13] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/98853/ merged [12:03:15] I am out [12:04:26] (03CR) 10Addshore: Create ChangeOpReferenceRemove class (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [12:04:43] (03PS2) 10Addshore: Create ChangeOpReferenceRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 [12:04:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [12:09:37] (03PS4) 10Addshore: Create ChangeOpReferenceRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 [12:09:51] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [12:10:23] (03PS3) 10Addshore: Create ChangeOpQualifierRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 [12:10:40] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 (owner: 10Addshore) [12:15:16] (03PS11) 10Addshore: Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 [12:15:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [12:15:33] (03CR) 10Addshore: "Addressed all of the comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [12:15:47] (03PS12) 10Addshore: Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 [12:16:01] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [12:17:59] (03PS13) 10Addshore: Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 [12:18:15] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [12:18:21] (03CR) 10Addshore: "cherry picked to be on top of the ChangeOpReferenceRemove class change" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [12:18:31] whahaha so many pings [12:28:30] (03PS5) 10Addshore: Create ChangeOpReferenceRemove class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 [12:28:43] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [12:28:49] (03PS14) 10Addshore: Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 [12:29:02] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [12:30:04] (03PS4) 10Addshore: Create ChangeOpQualifierRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 [12:30:18] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 (owner: 10Addshore) [12:51:18] hashar: woot :) [12:56:30] (03CR) 10Daniel Kinzler: [C: 032 V: 031] Cleanup ChangeOp related files. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107576 (owner: 10Addshore) [12:56:53] (03Merged) 10jenkins-bot: Cleanup ChangeOp related files. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107576 (owner: 10Addshore) [12:56:53] mhhhm, wh is daniel not on irc :P [12:57:56] addshore: went off for lunch [12:58:00] ? [12:58:12] silly him :D [12:59:27] hashar: any idea why i cannot login to gerrit with user WikidataJenkins anymore? though I can login to wikitech.. [13:02:22] LDAP being funky ?:D [13:02:40] hashar: dunno [13:03:31] Tobi_WMDE: I know have an issue with Gerrit / LDAP as well [13:04:24] hashar: so should I just wait? [13:04:31] or is there anything I can do? [13:04:45] I can login with my ordinary user as usual [13:04:59] it's just the WikidataJenkins [13:13:19] moin! [13:13:41] aude: moin [13:13:42] :) [13:14:02] so, in the job definition, i gave it a list of things to do [13:14:10] jenkins only does the first one [13:14:45] /srv/scripts/mw-core-get.sh master [13:14:51] aude: looking at the jobs configuration I only see /srv/scripts/mw-core-get.sh master [13:15:02] no idea why the rest does not get added [13:15:08] aude: there's nothing else in the configuration [13:15:31] https://github.com/wmde/jenkins-job-builder-config/blob/master/wikibase.yaml [13:15:37] where is the jobs-builder config that is supposed to be used? [13:15:42] thy [13:15:45] thx [13:15:56] this one is supposed to install sqlite and other stuff [13:16:36] (03PS1) 10Addshore: Create ChangeOpClaimRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108035 [13:16:39] morning aude [= [13:16:43] also, i think it's supposed to work to put the builder definitions in a macro.yaml file [13:16:46] and defaults.yaml [13:16:49] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108035 (owner: 10Addshore) [13:16:56] but it's not finding those [13:17:06] at least not macro [13:17:34] hashar: does anything look obviously wrong here https://github.com/wmde/jenkins-job-builder-config/blob/master/wikibase.yaml [13:17:34] aude: so, in this wikibase.yaml, we would have to add more builders to the wikibase-test job, right? [13:17:46] they are listed [13:17:59] but they are not added to the job [13:18:21] right [13:18:25] the spaces look off [13:19:06] https://www.irccloud.com/pastebin/FHcI8UdJ [13:19:16] a.s.o. [13:20:02] does that work? [13:20:27] aude: I think we need to add all the builders to the job [13:20:40] they are listed above [13:20:42] otherwise when the job is running it wont execute them [13:20:43] I guess [13:21:02] oh doh [13:21:06] you are right [13:21:12] :) [13:21:18] * aude totaly confused [13:21:33] I guess by doing -builder: blabla you just define them [13:21:41] then you need to actually use them in a job [13:22:25] right [13:22:34] it's suppose to be possible to put them in macro.yaml [13:22:37] but this works [13:22:59] can you try? [13:23:10] (03PS36) 10Aude: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:23:14] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/22/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:23:17] everything is there [13:23:22] now do the scripts work? [13:23:26] I am not entirely sure why you ended up duplicating the wikimedia CI infra :D [13:23:30] aude: I tried to get jenkins-jobs update working from within the instance [13:23:32] but I failed [13:23:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:23:38] aude: for JJB what I do is that I generate the jobs in a directory [13:23:49] aude: then I do my hacking and generate the new jobs in a different directory [13:24:01] I replaced the url in jnekins-jobs.ini with 127.0.0.1 and then the connection works but I get another error then [13:24:06] hmmm [13:24:21] aude: I can then review the modification by using diff against both directories [13:24:38] remote: fatal: '/srv/ssd/gerrit/mediawiki/extensions/Wikibase.git' does not appear to be a git repository [13:24:41] ok that's obvious [13:24:54] hashar: ok [13:24:55] and [13:24:59] that could be made a jenkns job :-D [13:25:53] just trying to simplify what wmf jenkins does to what we need [13:27:08] well if you get any idea to simply the wmf jenkins setup, I am all for it :] [13:27:08] brb reconnecting [13:29:12] (03PS37) 10Aude: (DNM) just testing stuffs [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:29:43] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:32:37] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:32:39] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/23/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:32:44] aude: can't we do the checkout of wikibase with the jenkins git plugin? like it would be done when using gerrit trigger? [13:38:31] probably but "git checkout ..." also works [13:38:34] Tobi_WMDE, addshore: master is completely borked for me since about now. [13:38:43] :O [13:38:49] in what way? [13:39:04] getting a gazillion of these when running tests: UsageException: You need read permission to use this module [13:39:23] again? [13:39:24] hmmm [13:39:31] aude: didn't see that before [13:39:34] * addshore tries to remember what caused that last time [13:40:37] hardcoded ids [13:40:40] might be an oddity with my setup, but i can't think what i changed in the last couple of hours [13:41:06] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:41:12] aude: no, that's a different error. that causes failures when trying to save items, or failures because items silently failed to save [13:42:00] these are not "a few" tests failing. it's more than a thousand tests failing. something very odd must have happened... [13:42:16] a new tests that scruws up $wgUser?... [13:43:02] thats what it was last time yes! [13:43:24] i just ran all the tests on master fine though :/ [13:44:48] addshore: it'S triggered by your "clean up changeops" patch. [13:44:50] (03PS1) 10Addshore: Inject Guid Validator and Parser in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 [13:44:55] if i go back before that, thests work fine [13:44:57] we're probably going to want https://www.mediawiki.org/wiki/Continuous_integration/Zuul#Git_replications [13:45:02] really O_o [13:45:04] for now, we can clone [13:45:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [13:45:25] thats really odd.. [13:45:33] wait. what?! [13:45:52] i'm back on master now. the failures are gone?? [13:45:53] wtf? [13:45:59] xD [13:46:08] messed up state carrying between invocation of phpunit?? [13:46:08] could just be a fluke fail [13:46:20] maybe something in memcached... but phpunit should diable external caches! [13:46:54] yay, ghost bugs! [13:46:54] DanielK_WMDE: aude: JeroenDeDauw: who's gonna join the daily? [13:47:10] i'll join, unless the little one wakes up. [13:49:28] * aude here [13:52:30] aude: DanielK_WMDE we don't have our external mic today, so it could be a bit harder to understand [13:52:41] :( [13:54:27] (03PS3) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [13:54:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [13:54:36] (03CR) 10jenkins-bot: [V: 04-1] Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [13:56:06] (03PS4) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [13:57:04] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [13:57:49] (03PS38) 10Aude: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:57:52] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/24/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [13:58:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:06:51] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:08:02] DanielK_WMDE: o you want me to make travis run over all of my patches? [14:08:06] would that help? :> [14:08:18] addshore: sure :) [14:08:55] addshore: anyway, re-testing your "Merge References" patch now. if all goes well, i'll merge it [14:09:27] (03PS39) 10Aude: (DNM) just testing stuffs [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:09:27] even though $toMergeToClaim seems a strange name to me - how about $targetClaim? :D [14:09:31] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/25/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:09:47] hehe, that does indeed sound better :P [14:09:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:09:58] The data provider specified for Wikibase\Test\ChangeOpReferenceTest::testApplyAddNewReferenceWithIndex is invalid. [14:09:59] $referenceHash needs to be set [14:10:09] hmmm [14:10:17] rage [14:10:26] wonder why i didnt catch that.... [14:11:10] also, in MergeItemsTest: UsageException: $referenceHash needs to be a string and must not be empty [14:12:02] grr i fixed these and apparently lost the patchset somewhere... [14:12:23] (03PS40) 10Aude: (DNM) just testing all the stuffs! [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:13:06] yay its cloning! [14:13:19] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:15:00] hmmm, my mind isnt working..... [14:18:59] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:19:01] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/26/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:27:57] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:28:54] DanielK_WMDE: any idea why that test is failing? me and Tobi_WMDE seem to be struggling working it out >.> [14:29:15] because it is set.... :P [14:35:44] (03CR) 10Addshore: [V: 04-1] Create ChangeOpReferenceRemove class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [14:47:08] [13WikibaseDatabase] 15addshore closed pull request #9: Improve autoloading and tests code + split interface (06master...06stuff) 02http://git.io/txILyQ [14:51:19] (03CR) 10Adrian Lang: "Henning: I'll have a look at the whitespace issues." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [14:55:55] (03PS41) 10Aude: (DNM) just testing the stuffs! [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:55:59] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/27/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:56:02] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:57:10] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:05:31] (03PS42) 10Aude: (DNM) just testing stuffs! [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:05:34] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/28/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:05:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:06:40] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:12:47] (03CR) 10Daniel Kinzler: [C: 04-1 V: 04-1] "1) Warning" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [15:15:16] addshore: ChangeOpReferenceTest, line 75: $referenceHash is given as '', which triggers the (misleadingly worded) error. [15:15:29] that's in the *provider*, not in the test case [15:16:56] addshore: actually - if there are no references, wouldn't '' be the correct hash? [15:17:24] that'S regarding the error in MergeItemsTest [15:20:53] (03CR) 10Daniel Kinzler: [C: 031 V: 031] Create ChangeOpQualifierRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 (owner: 10Addshore) [15:36:25] (03PS43) 10Aude: (DNM) just testing stuffs [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:36:29] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/29/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:36:31] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:36:52] (03CR) 10WikidataJenkins: "Build failed." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:38:27] aude: I'm gonna disable wikibase-ci job ok? [15:38:39] (03PS44) 10Aude: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:38:42] ok [15:38:43] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-ci/30/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:38:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:39:00] less irc channel spamming then.. :-) [15:39:16] good [15:39:22] we now have composer working [15:39:34] need it to checkout the patch [15:39:47] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:40:28] aude: yay! \o/ [15:40:44] so, now including the php command? [15:40:48] *phpunit [15:41:41] not yet [15:42:05] awww [15:42:07] it has "refs/changes/03/106703/42" [15:42:12] where does "03" come from? [15:43:37] aude: where in the jobs console can we actually see what revision was checked out? [15:45:15] /srv/scripts/apply-change.sh [15:45:18] it doesn't say [15:45:38] http://wikidata-jenkins.wmflabs.org/ci/job/wikibase-tests/43/parameters/? lists the available parameters [15:45:38] let's make it verbose.. [15:46:03] yes [15:46:36] want it to do "git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/Wikibase refs/changes/03/106703/42" [15:46:46] but what is "03"? [15:47:11] aude guess that's ok [15:47:17] 42! [15:47:59] aude: if you copy the url for fetching from gerrit it also has the "03" [15:48:09] guess it's a gerrit thing [15:48:52] it won't say that it's mergable though [15:49:00] it will need to rebase against master [15:50:50] aude: hm, can't we just do a git checkout [15:51:20] "git checkout ZUUL_COMMIT" [15:51:55] it probably wont find.. [15:52:17] yeah, just thought of it [15:53:08] doesn't work [15:57:20] aude: what's about just rebasing against master? [15:57:27] after fetching [15:57:56] and -1 if not successful [15:58:53] yeah [16:12:54] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/107577/ [16:18:13] Lydia_WMDE: Hi! When do you plan to deploy phase 2 on Wikisources? [16:18:59] it would be useful to automatize links to Wikipedia in templates like https://en.wikisource.org/wiki/Template:Author [16:19:47] Tpt_: i don't have a date yet but i hope to have one when publishing the plan for 2014+ this month [16:19:56] noted that you want it soon [16:20:41] Lydia_WMDE: Thanks. It would be very useful to do only one bot run to remove site links and Wikipedia parameter in various templates. [16:49:20] Lydia, would it be a problem to have the Commons "Creator" namespace linked to Wikidata.. they are the people who created paintings photographs et al they have their own Wikipedia article (typically) [16:50:00] i don't see why it would be an issue [16:51:11] * Lydia_WMDE leaves to go to the WMF office for a few last meetings and then alcatraz [16:51:13] laters! [16:54:03] \o/ [17:06:17] (03PS45) 10Aude: (DNM) just testing stuffs [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [17:07:00] GerardM-: no issue as far as I see. [17:07:19] (03CR) 10WikidataJenkins: [V: 032] "Build succeeded." [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [17:09:54] DanielK_WMDE: hey, did you read my comment on gerrit? [17:59:18] DanielK_WMDE: ping [18:10:30] Lydia_WMDE: Still in San Francisco..? [18:10:44] hoo: yes - for another day [18:11:39] Lydia_WMDE: ok... it's probably hard for you to poke DanielK_WMDE then, even if he's in the office :D [18:11:51] indeed [18:11:54] ;-) [18:12:34] Lydia_WMDE: hoo: see, more proof we need ICBMs at WMDE [18:14:31] JeroenDeDauw: Cold programmer war? :P One should be shot towards SF every time someone adds more clutter to horrible legacy extensions :D [18:15:38] * JeroenDeDauw wonders how long it would take for the crater to become so deep it pops up at the other side of the globe [18:17:38] Sometimes I think, I should just delete AbuseFilter from gerrit and pretend it never existed :D [18:17:56] {{support}} [18:18:31] AbuseFilter? What is that? :D [18:19:11] hoo: Not until we have a HooFilter :P [18:20:07] # HooFilter extension... [18:20:07] die( "Stop doing things... you've been filtered" ); [18:20:43] -1, it is using # as comment rather than // [18:21:23] +1 for ironic sad face at the end [18:28:22] benestar: :* (bug comment) [18:29:24] Lydia_WMDE: ;) [18:29:37] +2 because I can :p [18:30:34] * FastLizard4 sets Verified +2 on JohnLewis [18:31:58] FastLizard4 :D [20:20:16] ok, no doing stuff with jenkins [20:29:35] Lydia_WMDE: might you ping Daniel to ask him whether he or someone else has already started working on entity redirects? [21:01:16] benestar|afk: currently at the foundation in SF so don't have access to him :)