[00:26:48] legoktm: does Wikisource have to wait for a later stage of implementation to be able to pull WD data? [00:27:15] sDrewth: yes [00:27:15] sDrewth: Yep. [00:27:22] k [00:27:40] what they said :P [00:32:08] oh, disp;ute them, don't let them beat you ionto submission!!! [00:32:15] fffff typing ffff [02:09:31] (03PS1) 10Aude: Add new build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109607 [02:10:15] (03CR) 10Aude: [C: 032 V: 032] "to allow testing on beta, etc" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109607 (owner: 10Aude) [02:41:33] (03PS1) 10Aude: Register Wikidata build in Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109609 [02:42:40] (03CR) 10Aude: "not convinced https://www.mediawiki.org/wiki/Extension:Wikidata is the best page to link. (suggestions?)" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109609 (owner: 10Aude) [09:01:06] (03PS2) 10Adrian Lang: Implement a CommonsLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109068 [09:01:08] (03CR) 10jenkins-bot: [V: 04-1] Implement a CommonsLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109068 (owner: 10Adrian Lang) [09:02:35] (03PS3) 10Adrian Lang: Implement a CommonsLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109068 [09:07:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109068 (owner: 10Adrian Lang) [09:10:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109068 (owner: 10Adrian Lang) [09:40:18] (03CR) 10Fomafix: "Mark more copyable whitespaces." (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104727 (owner: 10Gerrit Patch Uploader) [09:57:42] This is so awesome .... http://magnusmanske.de/wordpress/?p=92 [10:12:46] 01[13ValueView01] 15adrianlang created 06commonsMediaFormatting (+1 new commit): 02http://git.io/nUU_ww [10:12:46] 13ValueView/06commonsMediaFormatting 1433494aa 15Adrian Lang: Use value formatters for formatting commons media links... [10:14:00] [13ValueView] 15adrianlang opened pull request #8: Use value formatters for formatting commons media links (06master...06commonsMediaFormatting) 02http://git.io/qvwyJQ [10:17:06] (03PS1) 10Adrian Lang: Support formatting commons media links via API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109638 [10:21:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109638 (owner: 10Adrian Lang) [10:35:24] (03CR) 10Addshore: "The build should perhaps have a different page" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109609 (owner: 10Aude) [10:37:09] (03CR) 10Adrian Lang: [C: 032] Migrating statement string value browsertests to cucumber [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109089 (owner: 10Tobias Gritschacher) [10:37:30] (03Merged) 10jenkins-bot: Migrating statement string value browsertests to cucumber [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109089 (owner: 10Tobias Gritschacher) [10:49:28] (03CR) 10Addshore: [C: 032] Implement a CommonsLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109068 (owner: 10Adrian Lang) [10:49:49] (03Merged) 10jenkins-bot: Implement a CommonsLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109068 (owner: 10Adrian Lang) [11:04:41] (03CR) 10Addshore: [C: 031 V: 031] Support formatting commons media links via API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109638 (owner: 10Adrian Lang) [11:05:28] .. and this is another report ... http://ultimategerardm.blogspot.nl/2014/01/reasonator-need-for-speed.html [11:13:23] (03CR) 10Addshore: [C: 032] Set the right audience in ContentRetriever::getContentForRequest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108334 (owner: 10Hoo man) [11:13:44] (03Merged) 10jenkins-bot: Set the right audience in ContentRetriever::getContentForRequest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108334 (owner: 10Hoo man) [11:44:08] (03PS1) 10Addshore: Remove deprected getEntityIdFormatter use:w [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109645 [11:46:32] (03PS2) 10Addshore: Remove all use of deprecated getEntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109645 [11:49:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109645 (owner: 10Addshore) [11:53:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109645 (owner: 10Addshore) [11:54:09] (03PS1) 10Addshore: Remove all use of deprecated getIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109647 [11:58:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109647 (owner: 10Addshore) [12:02:15] (03PS1) 10Addshore: Remove deprected unused getEntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109648 [12:02:18] (03PS1) 10Addshore: Remove use of idFormatter in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109649 [12:03:01] (03PS1) 10Addshore: Remove deprecated unused getIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109650 [12:07:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109648 (owner: 10Addshore) [12:11:24] (03PS16) 10Addshore: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [12:11:40] (03CR) 10Addshore: "PS16 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [12:12:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109649 (owner: 10Addshore) [12:13:30] (03CR) 10Addshore: [C: 04-1] "Comments in PS15 still apply" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [12:16:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109650 (owner: 10Addshore) [12:19:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [12:24:49] (03PS2) 10Zfilipin: Access statements dynamically on a specific index (browser-tests) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher) [12:26:57] (03PS1) 10Adrian Lang: Implement rendering item links as HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109654 [12:30:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher) [12:34:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109654 (owner: 10Adrian Lang) [13:22:09] (03PS2) 10Adrian Lang: Implement rendering item links as HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109654 [13:23:21] !admin https://www.wikidata.org/wiki/User:Jianhui67/QIDs_to_delete one is enough [13:23:23] (03PS3) 10Tobias Gritschacher: [browser-tests] Access claims dynamically on a specific index [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 [13:28:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109654 (owner: 10Adrian Lang) [13:31:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher) [13:32:01] (03CR) 10Zfilipin: [C: 031] [browser-tests] Access claims dynamically on a specific index [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher) [13:36:54] (03Draft1) 10Addshore: Format dates with more than 4 digit years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109657 [13:39:53] (03PS3) 10Adrian Lang: Implement rendering item links as HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109654 [13:41:14] (03CR) 10Adrian Lang: [C: 032] Format dates with more than 4 digit years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109657 (owner: 10Addshore) [13:41:34] (03Merged) 10jenkins-bot: Format dates with more than 4 digit years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109657 (owner: 10Addshore) [13:42:05] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109657 (owner: 10Addshore) [13:45:35] (03PS1) 10Addshore: Revert "Format dates with more than 4 digit years" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109659 [13:45:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109654 (owner: 10Adrian Lang) [13:46:05] (03CR) 10Addshore: [C: 032 V: 032] Revert "Format dates with more than 4 digit years" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109659 (owner: 10Addshore) [13:47:24] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/910eab7 : addshore The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17697172 [13:47:30] :D [13:47:34] silly Adrian_WMDE :> [13:50:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109659 (owner: 10Addshore) [13:57:29] moin! [13:57:34] morning aude! [13:57:41] aude: join the daily? [13:57:41] (03PS4) 10Tobias Gritschacher: [browser-tests] Access claims dynamically on a specific index [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 [13:57:45] yeah [13:57:57] ok, then I'm setting up hardware.. :) [13:58:03] great [14:02:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher) [14:10:54] meeeeeeeeeeerrrrrrrrrrrggggggge: https://gerrit.wikimedia.org/r/#/c/104946/ ! [14:21:53] (03PS5) 10Tobias Gritschacher: [browser-tests] Access claims dynamically on a specific index [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 [14:26:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher) [14:38:57] 01[13ValueView01] 15adrianlang created 06parseNullValue from 06commonsMediaFormatting (+0 new commits): 02http://git.io/DbOohA [14:40:59] 01[13ValueView01] 15adrianlang 04force-pushed 06parseNullValue from 1433494aa to 14909887d: 02http://git.io/DbOohA [14:40:59] 13ValueView/06parseNullValue 14909887d 15Adrian Lang: Correctly handle null values in _parseValue [14:41:40] [13ValueView] 15adrianlang opened pull request #9: Correctly handle null values in _parseValue (06master...06parseNullValue) 02http://git.io/jHMCKA [14:42:48] aude: the change breaks JS for me [14:43:19] it's intermittent but yes i ssee [14:43:21] see* [14:43:31] it wants to load http://bits.beta.wmflabs.org/static-master/extensions/..ter/extensions/Wikidata/Wikibase/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js [14:43:39] wtf! [14:43:54] * aude back in 15 minutes [14:44:04] aude: I mean the copyright-change [14:44:36] as an anon, when I try to add e.g. a statement, the copyright notice is shown. when I then want to dismiss it, I can do that but when cancelling the edit-mode afterwards it breaks [15:00:04] Tobi_WMDE: hmmm [15:13:00] (03PS22) 10Tobias Gritschacher: Allow specifying different license for "data" namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 (owner: 10Aude) [15:13:35] hi, I have a question... is there a way (wikidata.org/w/api.php or 208.80.153.172/api_documentation.html) for getting a list of entities using P569 (date of birth) or P570 (date of death) AND with value.calendarmodel == http://www.wikidata.org/entity/Q1985786 (Julian calendar) ? [15:15:06] Tobi_WMDE: did you rebase? [15:17:09] aude: I just uploaded a fix [15:17:40] does it work? did you change entityview? [15:17:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 (owner: 10Aude) [15:18:50] aude: yes, I've added parse() to the msg [15:18:52] https://gerrit.wikimedia.org/r/#/c/104946/21..22/repo/resources/wikibase.ui.entityViewInit.js seems odd [15:19:05] i see the js error, but why is that needed now? [15:19:29] aude: it is unrelated to your change [15:19:58] aude: could make a separate change but.. [15:20:10] it has to do with the copyright and it needed a fix [15:20:21] and I just realized the bug for the first time [15:20:31] ok [15:21:01] so, this way we just have to backport this change [15:21:51] aude: I guess it's fine now [15:21:57] so I'm gonna merge it [15:22:21] works fine [15:22:39] (03CR) 10Tobias Gritschacher: [C: 032] Allow specifying different license for "data" namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 (owner: 10Aude) [15:23:02] (03Merged) 10jenkins-bot: Allow specifying different license for "data" namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 (owner: 10Aude) [15:23:15] (03PS1) 10Addshore: Format dates with more than 4 digit years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109663 [15:23:17] (03PS1) 10Addshore: Also Format 10years+ precisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109664 [15:24:14] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/108334/ also should be backported, fyi [15:24:54] aude: hm.. ok [15:25:15] are you making a new build? [15:25:34] we need to [15:25:38] yeah [15:27:28] (03PS1) 10Aude: Set the right audience in ContentRetriever::getContentForRequest [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109665 [15:27:32] (03PS1) 10Aude: Allow specifying different license for "data" namespaces [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109666 [15:27:47] (03CR) 10Aude: [C: 032 V: 032] Set the right audience in ContentRetriever::getContentForRequest [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109665 (owner: 10Aude) [15:28:30] (03CR) 10Aude: [C: 032 V: 032] Allow specifying different license for "data" namespaces [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109666 (owner: 10Aude) [15:29:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109663 (owner: 10Addshore) [15:33:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109664 (owner: 10Addshore) [15:35:53] (03PS1) 10Aude: update build, backport copyright and revdel patches [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109667 [15:35:55] (03CR) 10jenkins-bot: [V: 04-1] update build, backport copyright and revdel patches [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109667 (owner: 10Aude) [15:37:25] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109665 (owner: 10Aude) [15:38:32] (03PS2) 10Addshore: Also Format 10years+ precisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109664 [15:41:46] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109666 (owner: 10Aude) [15:42:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.23-wmf11/8645e96 : aude The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17703196 [15:42:45] (03PS1) 10Aude: update build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109668 [15:43:06] (03CR) 10Aude: [C: 032 V: 032] update build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109668 (owner: 10Aude) [15:44:44] (03PS2) 10Aude: update build, backport copyright and revdel patches [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109667 [15:44:46] (03CR) 10jenkins-bot: [V: 04-1] update build, backport copyright and revdel patches [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109667 (owner: 10Aude) [15:45:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109664 (owner: 10Addshore) [15:46:37] (03Merged) 10jenkins-bot: update build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109668 (owner: 10Aude) [15:55:12] (03CR) 10Jeroen De Dauw: [C: 032] Remove deprected unused getEntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109648 (owner: 10Addshore) [15:57:53] (03CR) 10Jeroen De Dauw: Remove all use of deprecated getIdFormatter (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109647 (owner: 10Addshore) [15:58:21] [13ValueView] 15addshore closed pull request #9: Correctly handle null values in _parseValue (06master...06parseNullValue) 02http://git.io/jHMCKA [15:58:34] (03CR) 10Jeroen De Dauw: [C: 032] Remove all use of deprecated getEntityIdFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109645 (owner: 10Addshore) [16:00:05] [13ValueView] 15addshore closed pull request #8: Use value formatters for formatting commons media links (06master...06commonsMediaFormatting) 02http://git.io/qvwyJQ [16:00:10] 01[13ValueView01] 15addshore 04deleted 06commonsMediaFormatting at 1433494aa: 02http://git.io/eVv0uw [16:02:10] (03PS2) 10Addshore: Remove use of idFormatter in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109649 [16:02:24] (03PS2) 10Addshore: Remove deprecated unused getIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109650 [16:07:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109649 (owner: 10Addshore) [16:08:07] (03CR) 10Addshore: [C: 04-1] Implement rendering item links as HTML (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109654 (owner: 10Adrian Lang) [16:10:18] (03PS3) 10Tobias Gritschacher: Toolbar edit group widget optimization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [16:10:37] (03PS2) 10Addshore: Remove all use of deprecated getIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109647 [16:11:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109650 (owner: 10Addshore) [16:13:50] (03Abandoned) 10Aude: update build, backport copyright and revdel patches [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109667 (owner: 10Aude) [16:13:58] (03PS1) 10Aude: update build, backport copyright and revdel patches [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109674 [16:14:19] (03CR) 10Aude: [C: 032 V: 032] update build, backport copyright and revdel patches [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109674 (owner: 10Aude) [16:14:50] oh gah, broke beta! [16:15:05] Is there a Wikidata-sysop here? [16:15:10] (03CR) 10Jeroen De Dauw: [C: 032] Remove all use of deprecated getIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109647 (owner: 10Addshore) [16:15:17] (03PS2) 10Jeroen De Dauw: Remove deprected unused getEntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109648 (owner: 10Addshore) [16:15:22] (03CR) 10Jeroen De Dauw: [C: 032] Remove deprected unused getEntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109648 (owner: 10Addshore) [16:15:30] (03PS3) 10Jeroen De Dauw: Remove use of idFormatter in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109649 (owner: 10Addshore) [16:15:38] (03Merged) 10jenkins-bot: Remove all use of deprecated getIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109647 (owner: 10Addshore) [16:15:43] (03Merged) 10jenkins-bot: Remove deprected unused getEntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109648 (owner: 10Addshore) [16:15:51] (03CR) 10Jeroen De Dauw: [C: 032] Remove use of idFormatter in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109649 (owner: 10Addshore) [16:16:01] (03PS3) 10Jeroen De Dauw: Remove deprecated unused getIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109650 (owner: 10Addshore) [16:16:17] (03CR) 10Jeroen De Dauw: [C: 032] Remove deprecated unused getIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109650 (owner: 10Addshore) [16:16:19] (03Merged) 10jenkins-bot: Remove use of idFormatter in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109649 (owner: 10Addshore) [16:16:42] (03Merged) 10jenkins-bot: Remove deprecated unused getIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109650 (owner: 10Addshore) [16:17:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [16:20:11] (03CR) 10Jeroen De Dauw: [C: 031] "So many itty bitty details - I can't review this ;p" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109663 (owner: 10Addshore) [16:22:19] (03CR) 10Jeroen De Dauw: Also Format 10years+ precisions (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109664 (owner: 10Addshore) [16:23:27] (03PS3) 10Addshore: Also Format 10years+ precisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109664 [16:23:34] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109647 (owner: 10Addshore) [16:28:29] aude: sjoerddebruin no chatting in here, this is a bot-only channel! [16:28:36] :> [16:29:10] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109648 (owner: 10Addshore) [16:29:21] The bots shall prevail! [16:30:55] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/7e5bb0f : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17706513 [16:30:58] :( [16:32:07] JohnLewis secretly is a bot? O_o [16:33:12] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109649 (owner: 10Addshore) [16:33:33] JeroenDeDauw: No... [16:33:41] * JohnLewis shuts self down quickly [16:35:47] it's a bot! [16:35:53] :) [16:36:43] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109650 (owner: 10Addshore) [16:37:18] :p [16:40:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109664 (owner: 10Addshore) [16:41:33] (03PS1) 10Addshore: Remove duplicate i18n key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109675 [16:44:54] (03CR) 10Aude: [C: 032] Remove duplicate i18n key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109675 (owner: 10Addshore) [16:45:14] (03Merged) 10jenkins-bot: Remove duplicate i18n key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109675 (owner: 10Addshore) [16:46:09] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109675 (owner: 10Addshore) [16:46:37] aude: whats your opinion on the following i18nj keys? [16:47:06] https://www.irccloud.com/pastebin/jUNuSTuc [16:47:19] for use in the bottom method of https://gerrit.wikimedia.org/r/#/c/109664/3/lib/includes/formatters/MwTimeIsoFormatter.php [16:49:57] https://www.irccloud.com/pastebin/adZNgnJE [16:50:05] i.e. the above or something similar [16:58:56] addshore: seems good [16:59:18] which method should I be calling to get the message with a param in it ? O_o [17:00:03] what is the param? [17:00:10] the number of years [17:00:41] ie 'wikibase-time-precision-Gannum' => 'in $1 billion years', [17:00:44] Message::numParams [17:01:06] does that work here? [17:01:21] work here? where? :P [17:01:25] now why is beta asking for http://bits.beta.wmflabs.org/static-master/extensions/..ter/extensions/Wikidata/Wikibase/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js ? [17:01:48] addshore: here = number of years [17:02:03] im confused :> [17:02:38] Language::getMessage apparently doesnt return a message... [17:05:43] $message = new Message( $key, $params ) ? [17:05:52] ->inLanguage( ) [17:05:56] :> [17:05:57] ->numParams [17:06:10] i don't see the point in the wfMessage things [17:23:24] (03PS1) 10Addshore: Add i18n support in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 [17:23:26] bingo, cheers aude :) [17:24:13] yay! [17:24:40] the datetime formatter is now up to speed with the UI so we can switch that too! [17:24:52] just string and url to go i believe [17:24:58] and string isnt exactly hard xD [17:28:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore) [17:28:51] (03PS2) 10Addshore: Support formatting commons media links via API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109638 (owner: 10Adrian Lang) [17:28:57] (03CR) 10Addshore: [C: 031 V: 031] Support formatting commons media links via API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109638 (owner: 10Adrian Lang) [17:33:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109638 (owner: 10Adrian Lang) [17:33:37] (03PS1) 10Addshore: Support formatting time dataType via API in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 [17:38:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [17:42:41] (03PS6) 10Bene: Reduce badges to items listed in config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 [17:42:57] (03CR) 10jenkins-bot: [V: 04-1] Reduce badges to items listed in config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [17:44:19] (03PS1) 10Addshore: Remove space that should not be! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 [17:48:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [17:51:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 (owner: 10Addshore) [18:04:33] legoktm: thank you! [18:10:22] (03PS7) 10Bene: Reduce badges to items listed in config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 [18:13:25] addshore: the way we load resources is not working well on beta [18:13:26] http://dpaste.com/1572443/ [18:13:39] i'd like another approach [18:13:54] ideas? [18:15:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [18:43:31] hmmmm [18:43:57] where does the patch become wrong? :> [18:48:38] i am looking in Wikibase/lib/resources/Resources.php [18:49:22] we can't make the assumption that $IP is part of the file path, due to weird symlinking and what not [18:50:45] in dpaste, $dir is the value for __DIR__ [18:50:50] $ip is value of $IP [18:56:07] hmm [18:57:19] i would be happier with a setting (say if available) and we could fall back to how it's done now [18:57:34] might be more reliable [18:58:29] also wonder how the submodules worked and this doesn't [18:58:50] the paths are slightly different I guess [18:59:04] shouldn't be [18:59:26] before everything was in the repo, now its in /vendor if I am not mistaken? [18:59:38] not how we have it here [18:59:42] (in the future probably) [18:59:44] oh :P [18:59:51] remoteExtPath is what we are talking about right? [18:59:56] yep [19:00:06] and it needs to point to what exactly? O_o [19:00:10] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikidata/1b52a39cfe0de5a88a46b97b5572e2b4beef9e7e/build.sh [19:00:29] it needs to be ''Wikidata/Wikibase/lib/resources' [19:00:36] $wgExtensionAssetsPath gets prepended [19:00:59] but then its equal to localBasePath [19:01:01] which makes no sense [19:01:02] //bits.beta.wmflabs.org/static-master/extensions (although unimportant) [19:01:38] '/data/project/apache/common-local/php-master/extensions/Wikidata/Wikibase/lib/resources'; is local [19:01:40] oh, it literally just needs to be Wikidata/Wikibase/lib/resources [19:01:44] yes! [19:01:45] ahhhh [19:02:02] well substr( __DIR__, strlen( $GLOBALS['IP'] ) ), just seems stupid anyway! [19:02:09] it's brittle [19:03:49] i thought of explode( '/extensions/', __DIR__ ); [19:04:08] makes assumption about extensions directory name [19:04:52] end( explode( '/extensions/', __DIR__ ) ) [19:05:00] yeh thats what I just typed out :P [19:05:09] heh [19:05:31] imo thats a lot better than doing it from the length of the include patch [19:06:05] i suppose it's ok assumption although for value view, we put it in extensions subdir of wikibase [19:06:44] 'remoteExtPath' => '..' . end( explode( '/extensions/', __DIR__, 2 ) ), [19:07:08] thus it will only split it at the first /extensions/ [19:07:52] ok [19:08:24] just testing it now [19:08:30] seem to get errors [19:09:51] i don't think we need '..' [19:09:55] true [19:11:29] i get strict notices [19:11:30] something like this then? :) ^^ [19:11:42] *waits for the bot... [19:11:54] what are the notices? [19:12:07] https://gerrit.wikimedia.org/r/#/c/109704/ [19:13:04] (03PS2) 10Addshore: improve the way we get remoteExtPath in Resources.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109704 [19:14:11] trict standards: Only variables should be passed by reference in /Library/WebServer/Documents/wikidata/extensions/Wikidata/Wikibase/repo/resources/Resources.php on line 16 [19:14:16] Strict* [19:14:22] Only variables should be passed by reference [19:14:29] hmm [19:14:37] if i split that into two lines, then it works [19:14:40] w/o notice [19:14:45] ugly [19:15:01] hah [19:16:22] hmm, as in the explode and the end methods? [19:17:01] yep [19:17:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109704 (owner: 10Addshore) [19:17:33] (03PS3) 10Addshore: improve the way we get remoteExtPath in Resources.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109704 [19:17:38] only used the end as it looked tidier all on one line :P [19:17:50] agree [19:18:06] looks like thats it then! [19:19:02] hi guys :) [19:19:07] addshore: I changed https://gerrit.wikimedia.org/r/108337 [19:19:07] hi benestar :D [19:19:17] maybe you wanna review ;) [19:20:27] benestar: maybe ;p [19:20:39] 01[13ValueView01] 15addshore created 06remoteExtPath (+1 new commit): 02http://git.io/NCBCyg [19:20:39] 13ValueView/06remoteExtPath 14e2d9ccc 15addshore: improve the way we get remoteExtPath for resources [19:20:49] aude: also see that ^^ [19:20:54] ok [19:20:55] addshore: you would make me happy ;) [19:20:59] well ... https://github.com/wmde/ValueView/pull/10 [19:21:00] [13ValueView] 15addshore opened pull request #10: improve the way we get remoteExtPath for resources (06master...06remoteExtPath) 02http://git.io/CGWt8A [19:21:42] benestar: if you take another look at your merge items special page I would love to merge that :P [19:21:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109704 (owner: 10Addshore) [19:21:54] addshore: :O [19:22:10] i get bored of using the api for testing the module ;p [19:22:10] I thought it needs to wait until the merge feature works well [19:22:31] well it does to be enabled on wikidata, but we can merge it and set it as experimental until then [19:22:36] [= [19:22:38] ^^ not sure if it works well enought to enable it for people though [19:22:50] addshore: does to be enabled??? [19:22:59] it worked when I tested an older patchset :P [19:25:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109704 (owner: 10Addshore) [19:25:40] i get undefined offset [19:25:51] lol, I cannot start eclipse xD [19:25:59] hmm aude where? [19:26:53] potentially need to use DIRECTORY_SEPARATOR instead of an actually / or \ [19:28:15] (03CR) 10Addshore: [C: 04-1] Reduce badges to items listed in config (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [19:29:03] addshore: we use array keys because the values will contain an icon in future [19:29:20] in repo? [19:29:27] true about separator [19:29:43] perhaps not an elegant way, maybe you have an idea [19:30:04] (03PS4) 10Addshore: improve the way we get remoteExtPath in Resources.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109704 [19:31:10] 01[13ValueView01] 15addshore 04force-pushed 06remoteExtPath from 14e2d9ccc to 1474ecc42: 02http://git.io/jY84-w [19:31:11] 13ValueView/06remoteExtPath 1474ecc42 15addshore: improve the way we get remoteExtPath for resources [19:31:12] aude amended them both [19:31:28] ok [19:31:35] try again :D [19:32:40] benestar: I think the team needs to discuss the badges before it moves forward again [19:33:12] addshore: I think they already discussed but lets ask Lydia_WMDE [19:33:21] she isnt here :> [19:34:32] -.- [19:34:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109704 (owner: 10Addshore) [19:35:44] i think it needs 'resources' appended [19:36:11] value view [19:36:20] my fault [19:36:30] I left the ones that had resources with resources in valueview! [19:37:06] right [19:38:38] looks good [19:40:43] [13ValueView] 15filbertkm comment on commit 1474ecc42: $IP can't be relied up to be used like this, in all setups. this change is a more reliable way that works. 02http://git.io/zsvE5Q [19:40:49] guess i can merge [19:43:37] (03CR) 10Aude: [C: 032] "$IP can't be relied upon to determine resourceExtPath. this approach is more reliable for a variety of setups" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109704 (owner: 10Addshore) [19:43:56] (03Merged) 10jenkins-bot: improve the way we get remoteExtPath in Resources.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109704 (owner: 10Addshore) [19:44:27] then delete branch? [19:44:34] 01[13ValueView01] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/zcLWmQ [19:44:34] 13ValueView/06master 14484402d 15Katie Filbert: Merge pull request #10 from wmde/remoteExtPath... [19:44:41] aude: yep [19:45:04] aude: ready to merge something hillarious? :P [19:45:24] ok :) [19:45:30] (03PS1) 10Addshore: Remove pointless comments in test files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109716 [19:45:45] 01[13ValueView01] 15filbertkm 04deleted 06remoteExtPath at 1474ecc42: 02http://git.io/ibhySw [19:45:48] hah [19:46:24] gonna do another string of cleanup patches [19:46:35] I have some goals :P [19:47:33] all the tests! [19:48:13] (03CR) 10Aude: [C: 032] "looks fine" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109716 (owner: 10Addshore) [19:48:36] alright, eat and then fix resources in the other places [19:48:37] (03Merged) 10jenkins-bot: Remove pointless comments in test files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109716 (owner: 10Addshore) [19:48:37] indeed, [19:49:57] (03PS17) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [19:50:06] (03CR) 10jenkins-bot: [V: 04-1] Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [19:50:09] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109716 (owner: 10Addshore) [19:50:46] oh no, rebase... [19:54:25] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [19:55:21] (03PS18) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [19:58:21] (03PS19) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [19:58:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/fbd64e2 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17719929 [20:00:47] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [20:04:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [20:04:39] :D [20:04:44] addshore: --^ [20:04:48] :D [20:11:18] heh benestar this change has more than just the special page in doesnt it :P [20:11:35] (03Draft1) 10Addshore: Remove unused uses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109720 [20:11:55] addshore: how do you mean? [20:12:09] Like in SpecialWikibaseRepoPage.php :P [20:12:31] (03CR) 10Jeroen De Dauw: [C: 032] Remove unused uses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109720 (owner: 10Addshore) [20:12:37] lol [20:12:41] addshore: that's just moving code [20:12:50] (03Merged) 10jenkins-bot: Remove unused uses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109720 (owner: 10Addshore) [20:13:00] because it was formerly only used in modifyentity but is now also needed by other pages [20:13:23] (03CR) 10Jeroen De Dauw: [C: 032] Remove space that should not be! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 (owner: 10Addshore) [20:16:39] (03CR) 10Jeroen De Dauw: Add i18n support in MwTimeIsoFormatter (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore) [20:16:47] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109720 (owner: 10Addshore) [20:18:16] (03CR) 10Jeroen De Dauw: [C: 031] Support formatting time dataType via API in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [20:18:55] (03CR) 10Jeroen De Dauw: "I'm very concerned with having this kind of state in lib... Not something introduced in this commit tho." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [20:19:39] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0e84bc9 : addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17721288 [20:20:37] (03CR) 10Addshore: [C: 04-1] Special page for wbmergeitems api module (0323 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [20:25:56] (03CR) 10Addshore: "Lots of small things." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [20:41:13] 01[13DataTypes01] 15filbertkm created 06resourcepath (+1 new commit): 02http://git.io/ROIcRQ [20:41:13] 13DataTypes/06resourcepath 14d67e0fa 15aude: Improve resource path registration... [20:41:56] [13DataTypes] 15filbertkm opened pull request #3: Improve resource path registration (06master...06resourcepath) 02http://git.io/Hb74CQ [20:42:05] hope i did it correctly [20:44:04] [travis-ci] wmde/DataTypes#13 (resourcepath - d67e0fa : aude): The build passed. [20:44:04] [travis-ci] Change view : https://github.com/wmde/DataTypes/commit/d67e0fa2c182 [20:44:04] [travis-ci] Build details : http://travis-ci.org/wmde/DataTypes/builds/17723085 [20:52:07] 01[13DataValuesJavascript01] 15filbertkm created 06resourcepath (+1 new commit): 02http://git.io/4xDO6A [20:52:08] 13DataValuesJavascript/06resourcepath 147248ae7 15aude: Improve resource path registration... [20:52:26] [13DataValuesJavascript] 15filbertkm opened pull request #20: Improve resource path registration (06master...06resourcepath) 02http://git.io/lgpgjQ [20:52:43] addshore: if you are around ^ [20:53:06] Lydia_WMDE: around? [20:53:17] aude: yeah [20:53:20] wasup? :) [20:53:26] so we're sorting out beta.... js broken [20:53:26] aude i am ;p [20:53:33] 01[13DataValuesJavascript01] 15addshore pushed 2 new commits to 06master: 02http://git.io/QoUEVg [20:53:33] 13DataValuesJavascript/06master 147248ae7 15aude: Improve resource path registration... [20:53:33] 13DataValuesJavascript/06master 14900b971 15addshore: Merge pull request #20 from wmde/resourcepath... [20:53:34] done [20:53:37] yay! [20:54:03] aude: ok - anything i can help with? [20:54:15] i wonder if it makes sense to jump ahead with deploy tomorrow [20:54:22] considering we've not had time on test wikidata yet [20:54:48] kind of tricky since last week was no deploys [20:55:02] hmmm yeah if we're seeing more issues on beta now... [20:55:04] (let's see how beta does) [20:55:19] i then need to figure otu how to pull in the updates into the build and into master [20:56:00] to update master youd need to bump the version everywhere and update composer file [20:56:21] where do i update version? [20:56:31] ok let me know what you think after your fixes now [20:56:34] ok [20:56:43] if it's too risky we'll do another run on test instead [20:56:48] ok [20:56:59] i don't know if anyone is around to get our stuff on test wikidata today [20:57:04] ok [20:57:22] aude not sure if that really what we want to do for the dpeloyment though [20:57:29] shame you cant pull in the specific revs [20:57:37] * aude misses cherry picks [20:57:52] if i update all the dependencies, then no idea what else gets pulled in [20:57:58] JeroenDeDauw: ^^ [20:58:17] addshore: a fix somewhere should not result into a cascade of new versions [20:58:30] i could "patch" the build but that makes it tricky if we have a bunch more things to patch later [20:59:01] Lydia_WMDE: also with the parser cache, i think it's wise to let it sit [20:59:05] on test wikidata [20:59:14] aude: *nod* [20:59:26] anyway, back to beta.... [20:59:58] you can also still cherry pick stuff onto branches and hae those used [21:00:06] Can't say much more without a more concerte question [21:00:26] where are the branches? [21:00:32] so we patched DatavalueJavascript, Datavales and Wikibase [21:00:34] DataValuesJavascript? [21:00:36] ValueView [21:00:40] DataTypes [21:01:08] so we just need to make another branch from the version 0.1.1-mw12 or whatever [21:01:16] then update the composer file in the build to include those? [21:02:00] aude: i can make the branches if you wish :) [21:02:08] sure, if that's the way to go [21:02:34] what mw number are we on? [21:02:44] wmf11 [21:06:27] give me a while to get my head around it all :P [21:06:47] yeah [21:10:17] aude: Valueview is a submodule? [21:10:38] shouldn't be [21:10:47] of, its just in wikibase! [21:11:15] "data-values/value-view": "0.*,>=0.1.1", [21:11:22] ahh datavalues valueview! [21:11:36] whats the valueview in Wikibase/extensions ? O_o [21:11:38] so confusing [21:11:58] i guess ""type": "mediawiki-extension", [21:12:03] is why it gets put into extensions [21:12:31] interesting, wonder why we have to do that [21:12:47] it's not really a library, is it? [21:13:08] * aude wonders where types are defined [21:14:31] uses MediaWikiInstaller? [21:16:57] 01[13DataTypes01] 15addshore created 060.1.1-mw1.23wmf11 (+1 new commit): 02http://git.io/V3SHXA [21:16:57] 13DataTypes/060.1.1-mw1.23wmf11 144b97e96 15aude: Improve resource path registration... [21:17:11] You had to patch 5 different components? That does sound like something is going wrong [21:17:49] indeed [21:19:46] [travis-ci] wmde/DataTypes#15 (0.1.1-mw1.23wmf11 - 4b97e96 : aude): The build passed. [21:19:46] [travis-ci] Change view : https://github.com/wmde/DataTypes/commit/4b97e96ed682 [21:19:46] [travis-ci] Build details : http://travis-ci.org/wmde/DataTypes/builds/17725460 [21:20:12] JeroenDeDauw: how do i get a list of open things to review on github? [21:24:06] 01[13DataValuesJavascript01] 15addshore created 060.1.1.1-mw1.23wmf11 (+2 new commits): 02http://git.io/VgDejw [21:24:06] 13DataValuesJavascript/060.1.1.1-mw1.23wmf11 145e9596b 15aude: Improve resource path registration... [21:24:06] 13DataValuesJavascript/060.1.1.1-mw1.23wmf11 147d8016e 15addshore: Use data-types dev-0.1.1-mw1.23wmf11 [21:27:01] 01[13ValueView01] 15addshore created 060.1.1-mw1.23wmf11 (+2 new commits): 02http://git.io/0i03qw [21:27:01] 13ValueView/060.1.1-mw1.23wmf11 14bc3556c 15addshore: improve the way we get remoteExtPath for resources [21:27:01] 13ValueView/060.1.1-mw1.23wmf11 1446dfc72 15addshore: Use data-values/javascript dev-0.1.1.1-mw1.23wmf11 [21:27:35] is that all? [21:28:56] think so [21:29:14] - The requested package data-values/data-types dev-0.1.1-mw1.23-wmf11 could not be found. [21:29:14] - The requested package data-values/javascript dev-0.1.1.1-mw1.23-wmf11 could not be found. [21:29:14] - The requested package data-values/value-view dev-0.1.1-mw1.23-wmf11 could not be found. [21:29:50] they appear.... https://packagist.org/packages/data-values/data-types [21:29:56] takes a minute [21:29:57] perhaps [21:31:05] i would have thought if packagist knows about them it should work [21:31:32] but composer update doesnt want to agree! [21:32:14] my (limited) experience, it takes a minute or two [21:32:27] * addshore continues to hit up and enter :P [21:32:43] :) [21:32:51] ahh, i tpyes it wrong [21:33:00] i added an extra hyphen in my local compoer file! [21:33:05] ah [21:33:35] i guess we have a branch for deployment of wikibase on gerrit? [21:33:37] or not? [21:33:43] mw1.23-wmf11 [21:33:49] gimmie 2 ticks :P [21:33:52] k [21:34:27] hehe, thats why I added the extra dash in xD [21:34:32] cause that how we usually name them! [21:36:33] (03PS1) 10Addshore: Use patched branches for deployment [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109755 [21:36:44] bingo [21:36:51] that all works fine :) [21:36:51] yay! [21:37:10] even wikidata jenkins should pass it [21:37:41] (03CR) 10Aude: [C: 032 V: 032] "works good" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109755 (owner: 10Addshore) [21:37:47] thanks! :) [21:37:57] maybe I should have named the branches 0.1.1-mw1.23-wmf11 and such rather than 0.1.1-mw1.23wmf11 [21:37:58] oh well :P [21:38:01] enjoy! [21:38:35] now making new build and then see if beta is happy [21:38:39] :> [21:39:06] and once the buildscript makes a suable build for you all of this will be much easier as the build would be made automatically :D [21:40:13] (03PS1) 10Aude: update build, fix resource path registration [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109756 [21:40:22] 01[13DataValuesJavascript01] 15addshore 04deleted 06cleanupComments at 14a3c70e6: 02http://git.io/5rJYWw [21:40:26] that's for master, which is using same build now [21:40:32] 01[13ValueView01] 15addshore 04deleted 06firefoxtest at 149e212d7: 02http://git.io/NPgJTQ [21:41:32] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109755 (owner: 10Addshore) [21:41:55] (03CR) 10Addshore: [C: 032 V: 032] update build, fix resource path registration [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109756 (owner: 10Aude) [21:42:12] lovely [21:42:18] and then to deploy it on beta :P [21:42:47] 01[13DataTypes01] 15addshore 04deleted 06cleanupComments at 149651c4c: 02http://git.io/ciZISw [21:43:46] once we deploy, we can have beta use master [21:43:58] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.23-wmf11/6cedda3 : addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17726860 [21:44:42] (03PS1) 10Aude: update build, fix resource path registration [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109758 [21:44:46] same thing [21:44:58] * aude back in ~20 min [21:45:24] 01[13WikibaseDataModelSerialization01] 15addshore 04deleted 06SnakSerializer at 14229bd5c: 02http://git.io/m_-9DA [21:45:32] (03CR) 10Addshore: [C: 032 V: 032] update build, fix resource path registration [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109758 (owner: 10Aude) [21:47:18] 01[13DataTypes01] 15addshore 04deleted 06resourcepath at 14d67e0fa: 02http://git.io/QLw57A [21:55:11] im off, tara [22:20:14] addshore: are you sure I have to do the stupid work of removing @since tags? [22:21:13] benestar: what, you'd like addshore to do it later instead? :p [22:21:31] benestar: Addshore, getting you to do work @since 0.1.2! [22:21:54] lazowik: does it harm to have them? [22:22:05] idk [22:31:37] (03PS1) 10Aude: improve the way we get remoteExtPath in Resources.php [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109771 [22:31:50] (03CR) 10Aude: [C: 032 V: 032] improve the way we get remoteExtPath in Resources.php [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109771 (owner: 10Aude) [22:34:58] (03PS1) 10Aude: update build, fix resource module registration in Wikibase [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109773 [22:35:49] (03CR) 10Aude: [C: 032 V: 032] update build, fix resource module registration in Wikibase [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109773 (owner: 10Aude) [22:36:08] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109771 (owner: 10Aude) [22:36:52] (03PS1) 10Aude: update build, fix resource module registration in Wikibase [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109774 [22:37:08] (03CR) 10Aude: [C: 032 V: 032] update build, fix resource module registration in Wikibase [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109774 (owner: 10Aude) [22:39:01] (03PS20) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [22:39:09] addshore: --^ [22:43:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene)